| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-10-26 | |||
| 13:22:59 | openstackgerrit | Alex Xu proposed openstack/nova master: placement: rewrite AllocationCandidates.get_by_filters https://review.openstack.org/479766 | |
| 13:23:53 | alex_xu | efried: jaypipes, all the functional tests passed ^ in the last patch, but it still is WIP, more unittests, and better commit message, and so on... | |
| 13:24:31 | efried | alex_xu Ack. Anything in particular in there that I could/should work on today? | |
| 13:25:11 | alex_xu | efried: I added todo note in the commit message https://review.openstack.org/#/c/514197/ | |
| 13:25:19 | alex_xu | I want to separate that single unittest to multiple one | |
| 13:25:29 | cdent | I like this todo in commit message handoff idea | |
| 13:25:48 | efried | alex_xu Okay, I'll see if I can tackle that today. | |
| 13:26:01 | jaypipes | alex_xu: yup, I'm getting to those reviews this morning. thanks for your patience. | |
| 13:26:35 | alex_xu | efried: and for other patch, few of them just missing the unittest, I didn't write the todo | |
| 13:26:43 | alex_xu | but you can find them easily | |
| 13:26:45 | alex_xu | jaypipes: thanks | |
| 13:27:09 | efried | alex_xu I think I mentioned this in a comment, but eventually I'd like to extend _get_providers_with_any_resource to be able to do either 'any' or 'all'. | |
| 13:27:21 | efried | alex_xu Because numbered groups are going to want *all*. | |
| 13:27:29 | efried | which is a much easier thing to write SQL for. | |
| 13:27:50 | efried | In fact, perhaps I can just write a separate method that does all resources *and* traits at the same time. | |
| 13:28:27 | alex_xu | efried: that what we doing currently, finally that will be huge sql, that is hard to maintain I think | |
| 13:29:08 | efried | alex_xu I think the "any" thing is what makes it really tricky. But I'll play with it and see if it winds up looking too heinous to do in one shot. | |
| 13:30:28 | alex_xu | efried: yea, it will be good you can take a look at the overall first, let us see which direction better | |
| 13:31:03 | efried | alex_xu Sure thing. I'll go over the updates today in any case. | |
| 13:35:23 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Fix the ocata config-reference URLs https://review.openstack.org/515410 | |
| 13:35:41 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Import the config drive docs from openstack-manuals https://review.openstack.org/515053 | |
| 13:35:51 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Import user-data page from openstack-manuals https://review.openstack.org/515054 | |
| 13:36:00 | lbragstad | gmann_afk: as far as i know, the policy deprecation work in oslo policy is just waiting on reviews | |
| 13:42:48 | mriedem | stvnoyes: did you ever get a chance to test the new cinder attach patches and try to attach the same volume to the same instance multiple times even if the volume wasn't multiattach=true? | |
| 13:43:53 | stvnoyes | no, I've been off on something else for the past week. I'll give it a try today | |
| 13:43:57 | edleafe | alex_xu: I think adding a TODO in a commit message for a WIP patch is very smart | |
| 13:44:27 | mriedem | stvnoyes: ok, alternatively i can just add something to a tempest test, push that up and make it depend on the nova api change | |
| 13:44:45 | stvnoyes | having it in tempest would be good to have | |
| 13:44:57 | mriedem | ok i'll put something up this morning | |
| 13:46:05 | openstackgerrit | Eric Fried proposed openstack/nova master: Parse granular resources/traits from extra_specs https://review.openstack.org/515151 | |
| 13:46:06 | cdent | edleafe, efried, alex_xu: are you familiar with the “park on a slope” concept, when experiencing task interruptions? | |
| 13:46:06 | openstackgerrit | Eric Fried proposed openstack/nova master: Granularize resources_from_{flavor|request_spec} https://review.openstack.org/515223 | |
| 13:46:07 | efried | cdent I went ahead and made those couple of changes since I was editing the base patch anyway ^ | |
| 13:46:26 | efried | cdent Not by that name. Googling... | |
| 13:46:44 | edleafe | cdent: sorry, you just interrupted my task | |
| 13:46:45 | cdent | efried: cool, given other commitments today it is unlikely I would have got back to it and/or there’s not enough coffee in the world to make my brain work | |
| 13:46:52 | edleafe | cdent: no, not familiar | |
| 13:47:31 | efried | Turns out that's kind of a tough thing to google. | |
| 13:48:28 | cdent | it’s aligned with this idea of leaving a TODO in the wip commit. park your car in a way that if the battery is flat when you get back to it, you can still rolling start it | |
| 13:48:44 | cdent | or in general: make it easy, by leaving info, to rolling start | |
| 13:48:48 | cdent | stigmergy | |
| 13:48:50 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Implement query param schema for flavor index https://review.openstack.org/515413 | |
| 13:49:14 | cdent | efried: google stigmergy if you want something detailed to google | |
| 13:50:23 | efried | cdent Neat - the ants-following-scent-trails thing was a great way to crystallize the concept in my head. | |
| 13:50:53 | edleafe | efried: that's what we are, after all :) | |
| 13:51:15 | efried | cdent edleafe Not sure I would go so far as to say we "lack any memory, intelligence or even individual awareness of each other" though. | |
| 13:51:44 | edleafe | efried: so effin' literal! | |
| 13:52:09 | cdent | efried: that somehow reminded me of an old blog post: https://www.burningchrome.com/~cdent/mt/archives/000187.html | |
| 13:52:45 | cdent | efried: if we want to be an inclusive community that accepts all comers we should behave in a way that assumes there is no shared memory, that only external things can operate as memory | |
| 13:53:25 | efried | *mind blown* | |
| 13:55:41 | edleafe | efried: that's cdent's fancy way of saying "write it down!" | |
| 13:57:23 | bauzas | sahid: as you pointed out, there is a bug that prevents mediated devices to be shown by libvirt https://bugzilla.redhat.com/show_bug.cgi?id=1463285#c6 | |
| 13:57:24 | openstack | bugzilla.redhat.com bug 1463285 in libvirt "mediated devices are not shown in nodedev-list --cap mdev output" [High,Post] - Assigned to eskultet | |
| 13:57:50 | bauzas | sahid: now, the problem is about which specific operator impact we should provide | |
| 13:58:11 | stephenfin | dansmith: Wanna direct your nova-network wrath on this? https://review.openstack.org/#/c/499168/ | |
| 13:58:13 | bauzas | sahid: if we ask operators to pre-create the mdevs, it can work for the next instances to be created | |
| 13:58:54 | dansmith | stephenfin: I don't really have n-net wrath, but sure :) | |
| 13:58:58 | bauzas | sahid: but for existing instances, it can be an operator painpoint because you need to exactly recreate the mdev with the same existing UUID | |
| 13:59:05 | dansmith | anything to avoid working on this slide deck sitting in front of me | |
| 13:59:11 | bauzas | as reboots wipe out mediated devices | |
| 13:59:33 | bauzas | sahid: that's why I feel we should leave nova drive the creation, and not the operator | |
| 13:59:45 | bauzas | sahid: unless mediated devices become persistent upon reboot :) | |
| 14:00:08 | sahid | bauzas: what i could say is that, for SR-IOV we ask operator to allocate the VFs | |
| 14:00:16 | openstackgerrit | Alex Xu proposed openstack/nova master: Add _get_traits_by_rp_ids method https://review.openstack.org/511184 | |
| 14:00:16 | openstackgerrit | Alex Xu proposed openstack/nova master: Enable _get_usages_by_provider_and_rc not filter on the resource class id https://review.openstack.org/514649 | |
| 14:00:17 | openstackgerrit | Alex Xu proposed openstack/nova master: Add more caches for the ProviderSummary and ProviderSummaryList https://review.openstack.org/514199 | |
| 14:00:17 | openstackgerrit | Alex Xu proposed openstack/nova master: Add ProviderSummaryList object https://review.openstack.org/514198 | |
| 14:00:18 | openstackgerrit | Alex Xu proposed openstack/nova master: Add has_resources method to the AggregatedProviderSummary object https://review.openstack.org/514650 | |
| 14:00:18 | openstackgerrit | Alex Xu proposed openstack/nova master: Add AggregatedProviderSummary and AggregatedProviderSummaryList objects https://review.openstack.org/514200 | |
| 14:00:19 | openstackgerrit | Alex Xu proposed openstack/nova master: placement: rewrite AllocationCandidates.get_by_filters https://review.openstack.org/479766 | |
| 14:00:19 | openstackgerrit | Alex Xu proposed openstack/nova master: Add as_allocation_request_obj method to AggregatedProvierSummary obj https://review.openstack.org/514651 | |
| 14:00:20 | openstackgerrit | Eric Fried proposed openstack/nova master: Reformat _get_all_with_shared https://review.openstack.org/512799 | |
| 14:00:25 | sahid | if host is rebooting the operator can have the module to pre-allocate VFs anyway | |
| 14:00:37 | sahid | but without the insurance that the PCI addresses will be the same as previously | |
| 14:00:47 | bauzas | sahid: but the domain XML will be incorrect then, right? | |
| 14:00:51 | dansmith | stephenfin: can you fix that typo in the commit message and then I'll fast approve? | |
| 14:00:52 | sahid | right | |
| 14:01:00 | bauzas | sahid: if the VF is on the wrong PCI device | |
| 14:01:01 | sahid | so operator have to deal with that | |
| 14:01:09 | bauzas | sahid: how can they deal with that ? | |
| 14:01:09 | alex_xu | efried: ^ more todo, some of them is more interest than unittest, | |
| 14:01:21 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Move additional nova-net opts to 'network' https://review.openstack.org/499168 | |
| 14:01:22 | sahid | reboot --force | |
| 14:01:22 | dansmith | stephenfin: or I can just do it in the ui I guess | |
| 14:01:29 | stephenfin | dansmith: Done | |
| 14:01:30 | bauzas | sahid: they dump all the instances XML before starting nova-compute? | |
| 14:01:32 | stephenfin | ...from the UI :) | |
| 14:01:52 | efried | alex_xu Ack | |
| 14:01:54 | dansmith | stephenfin: done | |
| 14:01:59 | bauzas | sahid: but a reboot breaks existing instances using VFs, right? | |
| 14:02:29 | bauzas | since as you said, there is no guarantee that the newly created VF will match the one descibed in the domain XML | |
| 14:02:44 | sahid | bauzas: there are some limitations, it's clear... what i'm trying to say is, if you can make them clear for your implementation so operator could deal with them | |
| 14:03:55 | sahid | the libvirt design merged upstream for pci devices does not manage the devices | |
| 14:04:13 | bauzas | sahid: I'm thinking about the fact that if I'm implementing something like nova creating the mdevs directly, we could just ask the operator to restart their libvirt deamon right after they start nova-computez | |
| 14:04:14 | sahid | you could try to do it in nova | |
| 14:04:19 | sahid | but that seems to be complicated | |
| 14:04:48 | sahid | bauzas: what about to ask operator to do a force reboot? | |
| 14:05:01 | dansmith | bauzas: restarting libvirt after nova-compute isn't reasonable, IMHO | |
| 14:05:09 | dansmith | or starting | |
| 14:05:27 | sahid | we have to double check but with a force-reboot we recreating the domainXML from scratch | |