Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-10-25
23:11:39 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035
23:15:25 mriedem gmann_afk: alex_xu: done https://review.openstack.org/#/c/508101/ - i ran into that today when implementing PUT /flavors/{flavor_id} - agree it'd be good to get rid of all of the api extension policy gorp
23:23:50 openstackgerrit Merged openstack/nova-specs master: Spec for API extensions policy removal https://review.openstack.org/508101
23:24:36 melwitt mriedem: I've been working on tests for the libvirt regression today. just gotta write up the upstream bug report and link it
23:26:33 mriedem ok, gate is a bit fubar today anyway so newton eol not happening right now
23:27:11 melwitt okay, was just a FYI
23:27:52 gmann mriedem: thanks for that.
23:28:55 mriedem gmann: so maybe start with the flavor_access and flavor_rxtx api extension policies - i'd like to see what the change looks like,
23:29:10 mriedem because for this new microversion with PUT /flavors/{flavor_id} i wouldn't want to build into those policies
23:29:53 gmann mriedem: sure but we have to keep those till 1 cycle as we can only deprecate those in queens
23:30:05 mriedem sure
23:30:54 gmann mriedem: you want to see extension code merge at least?
23:31:26 mriedem ?
23:31:40 mriedem gmann: there are 2 bps right?
23:31:47 gmann mriedem: yea
23:31:53 mriedem merge the flavor_access and flavor_rxtx extensions into the main flavors extension
23:31:59 mriedem and then the api extension policy deprecation
23:32:10 mriedem do those have to go in order?
23:32:16 mriedem i wouldn't think they would
23:32:29 gmann mriedem: no, they can be done in any order
23:33:27 gmann policy deprecation things depends on oslo policy deprecation BP, whihc i will check with lbragstad otherwise we can with our old way (deprecating it via help msg)
23:34:10 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add microversion to allow setting flavor description https://review.openstack.org/515213
23:34:28 gmann mriedem: let me push both patches and you can if those helpful for your patch ^^
23:36:29 gmann mriedem: i see your patch just quick glance and got it. you do not want to add policy things for PUT in those extensions.
23:37:20 mriedem right, although for rxtx and flavor_access they are'nt granular policy rules
23:37:22 mriedem so it's just docs
23:37:53 mriedem https://review.openstack.org/#/c/515213/2/nova/policies/flavor_manage.py is the only new rule
23:38:15 gmann yea
23:39:09 gmann 1 question, why you want to add rxtx_factor in PUT- https://review.openstack.org/#/c/515213/2/nova/api/openstack/compute/flavor_rxtx.py
23:39:18 mriedem it's the response
23:39:28 mriedem PUT returns a full flavor response
23:39:30 mriedem like create
23:39:34 mriedem and GET /flavors/{flavor_id}
23:39:47 gmann ohk.
23:39:58 mriedem yeah that's how i found i had to add that code
23:40:02 mriedem api samples were failng
23:41:53 gmann i think we need to trick the sample file may be, because it should pass without adding that too. but i have not gone through the complete changes.
23:42:22 gmann let me push extensions/policy merge today and then we can do more cleanly
23:42:42 mriedem we should just be able to move the rxtx_factor and is_public stuff into the flavor view builder
23:42:52 gmann yea
23:42:53 mriedem those keys would have to be controlled via the policy rule today
23:43:03 mriedem but that's pretty simple and then we drop the extension code and deprecate the policy rule
23:43:06 mriedem and it's all in the view builder class
23:43:30 mriedem just make sure we don't check policy for doing index or detail :)
23:43:33 mriedem for each flavor i mean
23:43:53 mriedem checking policy for each item in a large list gets to be pretty bad
23:43:53 gmann yea
23:44:17 mriedem ok i have to call it a day
23:44:18 mriedem ttyl
23:44:23 gmann sure
23:45:01 gmann mriedem_away: last thing, i want you to look into this (quick doc one) - https://review.openstack.org/#/c/514499/
23:45:17 gmann but whenever you have time
#openstack-nova - 2017-10-26
00:26:46 openstackgerrit melanie witt proposed openstack/nova master: libvirt: Don't disregard cache mode for instance boot disks https://review.openstack.org/514339
00:35:27 openstackgerrit melanie witt proposed openstack/nova master: libvirt: Don't disregard cache mode for instance boot disks https://review.openstack.org/514339
01:04:46 openstackgerrit Merged openstack/nova master: Import the config drive docs from openstack-manuals https://review.openstack.org/514723
01:04:52 openstackgerrit Merged openstack/nova master: Import user-data page from openstack-manuals https://review.openstack.org/514738
01:25:42 openstackgerrit Merged openstack/nova master: Handle exception on adding secgroup https://review.openstack.org/465173
01:37:57 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data https://review.openstack.org/407514
01:38:16 openstackgerrit Takashi NATSUME proposed openstack/nova-specs master: Create specs directory for Rocky https://review.openstack.org/514101
01:38:31 openstackgerrit Takashi NATSUME proposed openstack/nova stable/pike: Add 'delete_host' command in 'nova-manage cell_v2' https://review.openstack.org/513717
01:38:55 openstackgerrit Takashi NATSUME proposed openstack/nova stable/ocata: Add 'delete_host' command in 'nova-manage cell_v2' https://review.openstack.org/513721
01:39:09 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Fix an example in "Delete Assisted Volume Snapshot" https://review.openstack.org/514128
01:39:42 openstackgerrit Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955
01:40:33 openstackgerrit Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964
02:41:05 openstackgerrit Merged openstack/nova master: VGPU: Define vgpu resource class https://review.openstack.org/511180
02:41:10 openstackgerrit Merged openstack/nova stable/newton: Remove unused placement_database config options https://review.openstack.org/514685
02:41:19 openstackgerrit Merged openstack/nova master: Fix AttributeError in BlockDeviceMapping.obj_load_attr https://review.openstack.org/514825
02:42:01 openstackgerrit Merged openstack/nova master: Move blkid calls to privsep. https://review.openstack.org/500398
03:07:35 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035
03:09:35 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035
03:35:55 openstackgerrit Yikun Jiang proposed openstack/nova master: [WIP] Add migration db and object pagination support. https://review.openstack.org/514904
04:37:32 Dinesh_Bhor cfriesen: Hi, you there?
05:39:42 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035
06:10:25 openstackgerrit Naichuan Sun proposed openstack/nova master: VGPU_support: add enabled white list https://review.openstack.org/512580
07:03:48 openstackgerrit Takashi NATSUME proposed openstack/nova master: Update document related to host aggregate https://review.openstack.org/514499
07:10:18 openstackgerrit Chen Hanxiao proposed openstack/nova master: libvirt: properly decode error message from qemu guest agent https://review.openstack.org/511459
07:34:55 openstackgerrit jichenjc proposed openstack/nova master: Downgrade log for keystone verify client fail https://review.openstack.org/513243
07:36:16 openstackgerrit jichenjc proposed openstack/nova master: [Placement] Add create inventories doc for placement https://review.openstack.org/512215
07:47:29 openstackgerrit jichenjc proposed openstack/nova master: add regression test for 1546396 https://review.openstack.org/293709
07:47:54 openstackgerrit jichenjc proposed openstack/nova master: fix race condition of instance host https://review.openstack.org/494458
07:52:15 openstackgerrit jichenjc proposed openstack/nova master: Fix warning on {'cell_id': 1} is an invalid UUID https://review.openstack.org/505471
07:56:44 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Remove incorrect comment about instance.locked https://review.openstack.org/515306
08:02:17 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Remove incorrect comment about instance.locked https://review.openstack.org/515306
08:16:09 openstackgerrit jichenjc proposed openstack/nova master: Add description for resource class creation https://review.openstack.org/508083
08:20:45 openstackgerrit Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486
08:22:18 openstackgerrit Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486
08:24:13 openstackgerrit Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486
08:24:59 bauzas naichuans: jianghuaw: could you please upload new revisions in a series by rebasing on the existing changes?
08:25:55 bauzas naichuans: jianghuaw: https://review.openstack.org/#/c/512580/ is no longer dependent on https://review.openstack.org/#/c/514942/
08:26:28 bauzas naichuans: jianghuaw: I'll rebase those
08:28:31 bauzas jianghuaw: thanks for your comment https://review.openstack.org/#/c/514763/ you're right
08:29:40 jianghuaw bauzas, u r welcome. Have you rebased the patch set. Otherwise Naichuan can do it now.
08:33:41 kashyap bauzas: stephenfin: Hi there, what is the way to restore a specification?
08:35:26 stephenfin kashyap: In Gerrit? If it's not your spec, you need a core to do it I think? bauzas can
08:35:37 kashyap stephenfin: Yeah, it's not my specc.
08:35:59 bauzas stephenfin: kashyap: which spec?
08:36:04 kashyap Context is, I was talking to KVM / QEMU developers at KVM Forum here. Incidentally Markus Zoeller was also here
08:36:12 kashyap And I'd like to work on this spec -- https://review.openstack.org/#/c/230968/
08:36:15 kashyap bauzas: ^
08:36:23 kashyap "libvirt: iothreads for disk devices"

Earlier   Later