Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-10-25
14:48:05 dansmith mriedem: that comment was added recently by you right? maybe just rebase noise
14:48:11 mriedem yes
14:48:17 mriedem when cleaning out the system_metadata stuff
14:48:33 mriedem i'm not -1 for that, that could be added back on top later
14:48:38 dansmith gonna pull it out of the gate? I'm still reading
14:48:46 mriedem -1 is for the lack of testing with limits, unless i'm missing something
14:48:52 mriedem *build_requests + limits in the sortmaster
14:52:09 dansmith mriedem: you think it's broken or just want more coverage?
14:52:25 dansmith since it's all the same logic (no special limit decrementing) it's not much of a gap
14:52:44 mriedem there was a test for build requests + limits which was removed,
14:52:48 mriedem so i think we want that coverage yeah
14:53:10 mriedem you could replay it on top of this change if you want (not the series, just this change)
14:54:56 dansmith I would rather not keep that test the way it was, since it tests the instance_list module from above the compute api, but I'm happy to slap a limit base test into instance_list
14:55:25 dansmith mriedem: it's fairly deep into the gate (spot 15 out of 42) but if you want to pull it out, I'll add it to that patch, else I can pile the coverage on top
14:55:43 mriedem just put it on top
14:55:44 mriedem that's fine
15:04:23 dansmith did they just restart zuul or something?
15:07:49 jaypipes gibi: please see my explanation on https://review.openstack.org/#/c/377215/53/nova/tests/functional/db/test_resource_provider.py
15:08:05 dansmith mriedem: so, actually, I think we should pull that from the gate, since everything just restarted
15:08:20 dansmith mriedem: I think there might be a bug that this test will uncover
15:08:25 openstackgerrit Chris Dent proposed openstack/nova master: Move project_id and user_id to Allocation object https://review.openstack.org/500410
15:08:26 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Limit number of attempts to delete allocations https://review.openstack.org/507224
15:08:26 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Allow _set_allocations to delete allocations https://review.openstack.org/501051
15:08:27 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Include project_id and user_id in GET /allocations https://review.openstack.org/512421
15:08:27 openstackgerrit Chris Dent proposed openstack/nova master: Include project_id and user_id in AllocationList.get_all_by_consumer_id https://review.openstack.org/512420
15:08:28 jaypipes gibi: it's a weird one, for sure, but the mock there isn't actually to make the test work properly. it's to exercise one part of the WHERE clause that exists in that get_all_by_filters() method
15:08:28 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Document the changes to PUT and GET /allocations/{consumer_uuid} https://review.openstack.org/510626
15:08:28 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Enable PUT dict to /allocations/{consumer_uuid} https://review.openstack.org/510625
15:08:29 bauzas dansmith: yup, looks like
15:08:29 openstackgerrit Chris Dent proposed openstack/nova master: [placement] POST /allocations to set allocations for >1 consumers https://review.openstack.org/500073
15:08:46 bauzas dansmith: zuulv3 website was timing out
15:08:56 bauzas now the jobs are just restarting
15:09:41 openstackgerrit Dan Smith proposed openstack/nova master: Add CellMapping.get_by_project_id() query method https://review.openstack.org/509002
15:09:41 openstackgerrit Dan Smith proposed openstack/nova master: Merge build requests into the sortmaster 9000 https://review.openstack.org/508595
15:09:42 openstackgerrit Dan Smith proposed openstack/nova master: Make get_instance_objects_sorted() be smart about cells https://review.openstack.org/509003
15:10:08 dansmith mriedem: ^ just to kick ito ut
15:10:35 openstackgerrit Sylvain Bauza proposed openstack/nova master: Accept all standard resource classes in flavor extra specs https://review.openstack.org/514942
15:10:36 openstackgerrit Sylvain Bauza proposed openstack/nova master: WIP: libvirt: Provide VGPU inventory for a single GPU type https://review.openstack.org/514763
15:10:36 openstackgerrit Sylvain Bauza proposed openstack/nova master: VGPU_support: add enabled white list https://review.openstack.org/512580
15:14:05 mriedem dansmith: ack
15:20:22 melwitt stephenfin: I addressed your comments on https://review.openstack.org/#/c/498983 by refactoring the tests if you could please re-look at it when you can
15:20:36 stephenfin melwitt: Will do (y)
15:21:04 melwitt thanks
15:45:24 efried Procedural question: is it legit to link a blueprint in a docstring?
15:49:24 edleafe efried: I don't know that it is prohibited, but I generally prefer docstrings to stand alone, so I would tend to quote the relevant part of the bp.
15:49:25 mriedem efried: we don't build docstrings
15:49:27 mriedem so doesn't matter
15:50:32 openstackgerrit Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766
15:50:43 efried Was thinking more for the sake of future developers wanting to figure out what's going on. If there's a reason not to do so, like the spec might move or change or disappear. But it's easy enough to avoid it. Thanks.
15:51:17 liuyulong sdague, mriedem, hello there, what about this now https://review.openstack.org/#/c/379128/, the patch of bp/rebuild-keypair-reset.
15:52:13 cdent efried: are you talking about a spec.o.o link or launchpad link? if the former, I’d say go for it
15:52:20 cdent if the latter, no
15:52:27 dansmith mriedem: I'm just going to drop this patch
15:52:32 efried cdent Yeah, the former.
15:52:58 dansmith mriedem: there'll be an issue with pagination with it (limits alone work fine), and that test I removed wouldn't have caught it
15:53:25 efried cdent Sigh, except for the whole line width thing.
15:53:27 dansmith mriedem: I've paged out a lot of context on this, and it's going to require re-tooling, which isn't going to happen until after summit
15:53:33 dansmith just fyi
15:53:35 cdent miagra
15:54:25 mriedem liuyulong: i have to get back to reviewing it, but busy with something else right now
15:55:04 mriedem dansmith: ack, shitty but understandable
15:55:41 mriedem dansmith: is the paging issue because we handle build requests separately from the scatter / gather sorted instances in cells thing?
15:55:47 dansmith mriedem: yeah, I wish I had written a test for this when I wrote the rest, I dunno why I didn't
15:56:44 dansmith mriedem: it's because the marker could be in build requests which we look up differently from other things, and because we need to be able to do that special value-based marker resume thing in there too
15:56:52 stephenfin Am I able to get access to these fixture properties in a test? https://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L191-L197
15:56:58 stephenfin (stdout and stderr)
15:57:13 stephenfin sdague, perhaps? ^
15:57:54 mriedem stephenfin: you'd have to store the fixture object in the base nova TestCase class
15:58:00 mriedem stephenfin: like we do here: self.stdlog = nova_fixtures.StandardLogging()
15:58:12 mriedem then you can access the attributes in the fixture from a test
15:58:13 liuyulong mriedem, great, thank you.
15:59:32 sdague stephenfin: yeh, what mriedem said
16:01:18 stephenfin mriedem, sdague: Spot on. I'll do that so
16:08:23 mriedem sdague: something i didn't think about in the flavor description spec, but i didn't say i'd return the description in GET /flavors - which is the limited response - only id, name and links
16:08:33 mriedem not sure if i should include the description or not
16:09:12 mriedem i never use GET /flavors because i want to see how much ram/cpu/disk i'm getting
16:10:25 openstackgerrit sahid proposed openstack/nova master: libvirt: disconnect volume from host during detach https://review.openstack.org/515008
16:17:09 cdent anyone have today’s count on number of different in progress changes racing for placement microversion 1.11?
16:30:33 stephenfin melwitt: Quick one - how come we don't need 'dump_inactive' for the additional call here? https://review.openstack.org/#/c/498983/4/nova/virt/libvirt/driver.py
16:32:20 melwitt stephenfin: that controls whether we pull the active (live) or inactive (persistent) config from the domain. we want to pull the live config after the volume was updated to write it back to the persistent config. does that make sense?
16:32:41 openstackgerrit Chris Dent proposed openstack/nova master: [placement] manage cache headers for inventories https://review.openstack.org/510954
16:32:41 openstackgerrit Chris Dent proposed openstack/nova master: [placement] manage cache headers for /resource_providers https://review.openstack.org/495380
16:32:42 openstackgerrit Chris Dent proposed openstack/nova master: [placement] manage cache headers for usages https://review.openstack.org/513174
16:32:42 openstackgerrit Chris Dent proposed openstack/nova master: [placement] manage cache headers for resource classes https://review.openstack.org/513161
16:32:43 openstackgerrit Chris Dent proposed openstack/nova master: [placement] manage cache headers for aggregates https://review.openstack.org/515128
16:33:02 stephenfin melwitt: Ah, that wasn't immediately obvious to me. Yup, makes sense. +2d
16:33:44 melwitt stephenfin: it could stand to have a code comment, tbh. at the time, I thought I was explaining it with the comment I added but it doesn't call out dump_inactive specifically
16:34:12 stephenfin Yeah, I added a comment to leave that in there. However, it's nit so only address if you can
16:35:17 cfriesen is there a novaclient/openstackclient command that does a GET on /os-hypervisors/detail ?
16:35:33 mriedem nova hypervisor-list?
16:35:41 cfriesen that doesn't have the detail
16:35:45 melwitt stephenfin: k, lemme do an edit on it
16:37:35 mriedem cfriesen: doesn't look like it on the CLI, the python API binding has a detailed kwarg though
16:37:41 mriedem so it could be easily added to the CLI
16:38:13 cfriesen mriedem: good, I'm not going blind.
16:38:41 mriedem although, the amount of stuff you'd get out of /detalis
16:38:42 mriedem *details
16:38:42 openstackgerrit melanie witt proposed openstack/nova master: Save updated libvirt domain XML after swapping volume https://review.openstack.org/498983
16:38:46 mriedem is a lot
16:39:28 mriedem which is why cli users would probably do hypervisor-list and then hypervisor-show on specific ones

Earlier   Later