Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-10-24
20:57:36 melwitt just trying to understand that bit
20:58:09 mriedem melwitt: not sure honestly, because i found a similar problem in the instance object yesterday
20:58:48 mriedem this https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L563
20:59:06 mriedem after you create an instance object, ec2_ids is still marked as changd
20:59:09 mriedem *changed
20:59:26 mriedem however, a later call to instance.save() won't care https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L650
21:00:23 melwitt yeah, I'm guessing the "what_changed" logic recurses, checking
21:00:24 mriedem melwitt: in my bdm patch, if you remove recursive=True and replace https://review.openstack.org/#/c/514825/2/nova/tests/unit/objects/test_block_device.py@391 with bdm.save(), you'll see the failure
21:00:30 mriedem it does
21:01:07 melwitt okay, that's why then. I was just thinking (and you already saw) I bet we have other cases of this around in the code
21:09:09 openstackgerrit Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949
21:11:32 mriedem dansmith: do you want me to address the stuff in https://review.openstack.org/#/c/506420/ ?
21:13:46 dansmith mriedem: no
21:14:25 dansmith melwitt: we should call recursive=True if we've caused all the downstream objects to be saved (or ignored if they have nothing to save)
21:14:46 dansmith it's a detail that came out kinda late in the objectification work so we didn't have a specific pattern from the beginning
21:14:58 tonyb mriedem: the EOL is held up on tooling so it you -W the releases request we can get that last change in
21:15:15 mriedem tonyb: already done, just need the newton change +W
21:15:21 mriedem been waiting for you to wake up
21:15:32 mriedem https://review.openstack.org/#/c/514685/
21:15:44 melwitt dansmith: okay. so in a lazy-load situation we would always want recursive=True if we've freshly loaded an ObjectField
21:15:45 tonyb mriedem: :)
21:16:25 dansmith melwitt: well, if we've done that, the nested object should have no pending changes and thus it wouldn't matter
21:17:04 melwitt dansmith: mriedem saw that if he didn't use recursive=True it's flagging the bdm.instance field as changed?
21:17:25 melwitt I wonder if there's a different bug in Instance then?
21:17:55 dansmith mriedem: what in the scheduler client init do you think is so heavy that we shouldn't be doing it again in that utility method?
21:18:17 tonyb mriedem: I'll need more coffee before I vote on that.
21:18:32 mriedem dansmith: it's not real heavy, it's just loading up two other objects, just seems unnecessary
21:19:07 mriedem tonyb: just keep in mind you +Wed the same change in stable/ocata
21:19:15 dansmith mriedem: I just hate all our methods that take 27 arguments and then do a ton of inefficient shit anyway, but alright
21:19:31 dansmith melwitt: yeah, I dunno about that fix tbh, but haven't looked closely
21:20:53 mriedem dansmith: oh well maybe it's not as inefficient as i thought, now that i look at LazyLoader
21:21:04 mriedem i guess the queryclient thing in there won't even be loaded unless it's called
21:21:12 mriedem anyway, that's not what my -1 was for
21:21:19 tonyb mriedem: s/+W/+2/ but I take your point. I'm trying to workout how doing this last minute helps. I'm on the fence ATM
21:21:50 mriedem tonyb: belmiro from cern was asking this morning if he should be configuring placement_database when planning the upgrade from newton to ocata
21:21:55 mriedem because it's in the newton code and says to use it
21:22:24 mriedem tonyb: so for those that are <newton and going to get here eventually, we want to avoid the confusion before those newton deployments start thinking about going to >=ocata
21:22:50 tonyb mriedem: okay
21:39:08 tonyb mriedem: Just to be certain (and I shoudl have asked this for the ocata backport) ... if someone is running newton and set those options and we remove themi, they upgrade to $last_release ... the config file still loads right?
21:40:21 mriedem tonyb: i think you can put whatever junk you want in the config file
21:40:36 mriedem i haven't tested that scenario though
21:40:59 mriedem don't have a devstack handy either, but would think you could put [DEFAULT]foo=bar in nova.conf and restart n-cpu and it'd be fine
21:41:20 dansmith mriedem: correct
21:41:30 dansmith mriedem: our support people LOVE it
21:41:32 dansmith (not)
21:41:46 dansmith I've closed bugs before with "you typo'd that thing, which is why it's not working"
21:41:50 mriedem i remember there being an option to fail startup if you're using deprecated options
21:41:54 openstackgerrit Dan Smith proposed openstack/nova master: Make migration uuid hold allocations for migrating instances https://review.openstack.org/506420
21:41:55 openstackgerrit Dan Smith proposed openstack/nova master: Make live migration hold resources with a migration allocation https://review.openstack.org/507638
21:42:09 dansmith mriedem: only while they're deprecated, once we remove them you can go back to having whatever you want in there :)
21:42:14 mriedem yeah
21:42:41 mriedem like, [workarounds]make_reschedules_fix_all_my_problems=True
21:42:46 mriedem and then report a bug when it doesn't
21:43:45 openstackgerrit Hongbin Lu proposed openstack/nova master: Fix wrapping of neutron forbidden error https://review.openstack.org/508802
21:44:53 dansmith more like [important_things]/cache_mode = "don't lose my data" -> why are my filesystems getting corrupted
21:48:41 dansmith gah
21:49:14 openstackgerrit Dan Smith proposed openstack/nova master: Make migration uuid hold allocations for migrating instances https://review.openstack.org/506420
21:49:15 openstackgerrit Dan Smith proposed openstack/nova master: Make live migration hold resources with a migration allocation https://review.openstack.org/507638
21:49:58 melwitt speaking of cache_mode ... we had a regression in newton https://review.openstack.org/#/c/514339
21:49:59 tonyb mriedem, dansmith: thanks. That feels like somethign I shoudl have already known :(
21:50:16 dansmith tonyb: yeah, I was just calling your manager to report you.......
21:50:53 tonyb dansmith: ok.
21:51:30 tonyb at least I got my Red Hat
21:51:31 dansmith ;p;
21:51:32 dansmith lol
21:58:25 openstackgerrit melanie witt proposed openstack/nova master: Add console_auth_token_get() method to DB API https://review.openstack.org/481700
21:58:25 openstackgerrit melanie witt proposed openstack/nova master: Add access_url_base to console_auth_tokens table https://review.openstack.org/334614
21:58:26 openstackgerrit melanie witt proposed openstack/nova master: Add periodic task to clean expired console tokens https://review.openstack.org/325381
21:58:26 openstackgerrit melanie witt proposed openstack/nova master: Add console connection object https://review.openstack.org/320063
21:58:27 openstackgerrit melanie witt proposed openstack/nova master: Convert websocketproxy to use db for token validation https://review.openstack.org/333990
21:58:27 openstackgerrit melanie witt proposed openstack/nova master: Use ConsoleConnection object to generate authorizations https://review.openstack.org/325414
22:43:28 melwitt I dunno if yall have seen these bugs opened recently https://bugs.launchpad.net/nova/+bug/1726301 https://bugs.launchpad.net/bugs/1726310
22:43:30 openstack Launchpad bug 1726301 in OpenStack Compute (nova) "Nova should list instances even if it can't connect to a cell DB" [Undecided,New] - Assigned to Surya Seetharaman (tssurya)
22:43:31 openstack Launchpad bug 1726310 in OpenStack Compute (nova) "nova doesn't list services if it can't connect to a cell DB" [Undecided,New] - Assigned to Belmiro Moreira (moreira-belmiro-email-lists)
22:44:08 melwitt re-opens my concern about quotas going wonky when cells are down too
22:45:00 dansmith I have a todo in my list stuff to address this yeah
22:45:06 dansmith but it's not even all merged yet
22:47:03 melwitt k, that's good to hear that there's already a plan
22:47:24 mriedem melwitt: ffs that cache mode patch,
22:47:28 mriedem and that was backported to newton,
22:47:32 mriedem and newton is due for eol
22:47:58 melwitt mriedem: yeah, it's a crap situation
22:48:43 mriedem tonyb: ^
22:48:51 mriedem we'll likely need https://review.openstack.org/#/c/514339/ in newton's final release / eol now too
22:49:49 mriedem melwitt: is kashyap testing that fix out?
22:50:21 tonyb mriedem: okay I'll look at it
22:54:29 melwitt mriedem: I need to check with kashyap, I'm not sure whether he's confirmed the fix locally or with the customer yet
22:55:07 melwitt he's away at kvm forum this week
22:55:59 mriedem sigh
22:56:37 mriedem ok, it would be nice if someone else from the red hat team could recreate and verify the fix before we actually eol newton, because while red hat customers will get the fix in newton, people consuming from upstream stable wouldn't, and that sucks
22:57:20 clarkb mriedem: you should ping tony as the eol is happening right now I think
22:57:26 clarkb tonyb: ^ you have been pinged
22:57:42 mriedem clarkb: see sbove
22:57:45 mriedem *above
22:57:52 clarkb oh perfect
22:59:33 tonyb clarkb: It is but nova has been excluded as it has a pending release request ... it wasn't strictly needed but allows thise these shenanigans ;P
23:00:02 tonyb mriedem: I'll look at it after I've done the EOL thing as I don't want to mess that up
23:00:28 melwitt mriedem: yes, understood. I'll see what I can do
23:04:14 openstackgerrit Matt Riedemann proposed openstack/nova master: Add FlavorPayload.description for versioned notifications https://review.openstack.org/514782
23:04:14 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Flavor.description attribute https://review.openstack.org/514371

Earlier   Later