| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-10-18 | |||
| 21:09:30 | dansmith | efried: haven't I approved enough stuff for you lately? | |
| 21:09:33 | mriedem | tssurya_: yeah, nova-manage db archive_deleted_rows | |
| 21:09:36 | dansmith | tssurya_: yes, that's the work item :) | |
| 21:09:38 | dansmith | mriedem: DUDE | |
| 21:09:42 | dansmith | mriedem: let me tell the stoy | |
| 21:09:44 | dansmith | *story | |
| 21:09:46 | tssurya_ | just like we now have a way to remove the hosts https://review.openstack.org/#/c/510324/ | |
| 21:09:49 | mriedem | oh, oops | |
| 21:09:49 | efried | dansmith "for me"? It's all "for nova"! | |
| 21:09:57 | efried | There is no efried. Only zuulv3 | |
| 21:10:16 | mriedem | well gather round children, | |
| 21:10:19 | mriedem | it's uncle dan's story time | |
| 21:10:34 | mriedem | long ago in a land called north carolina lived a boy named dan | |
| 21:10:34 | dansmith | tssurya_: so we remove instances once they're marked as deleted by "archiving" them with the command that mriedem mentioned | |
| 21:11:04 | dansmith | tssurya_: that moves them from the instances table to shadow_instances, where there are no constraints and then they can be deleted or dumped out to an archive log or something | |
| 21:11:18 | dansmith | tssurya_: right now, if you do this, you leave instance mappings for those instances which are no longer there forever, which is bad | |
| 21:11:20 | tssurya_ | mriedem, dansmith : I have seen the review of this nova-manage db archive_deleted_rows | |
| 21:11:38 | dansmith | tssurya_: while they're deleted=yes, they need their mapping, but once they get archived, the mapping should go away | |
| 21:11:57 | dansmith | tssurya_: so that archive command needs to follow up after the archival by deleting instance mappings from the api database | |
| 21:12:08 | dansmith | tssurya_: if you want to fix that since you're familiar with nova-manage now, that would be super awesome | |
| 21:12:21 | dansmith | generations of DBAs will thank you for years to come | |
| 21:12:25 | tssurya_ | dansmith : yes please would love to do it | |
| 21:12:33 | dansmith | woot ;) | |
| 21:12:50 | mriedem | uh, deleted=id | |
| 21:12:51 | mriedem | derp | |
| 21:12:56 | mriedem | c'mon | |
| 21:13:08 | dansmith | mriedem: in the object, it's boolean, c'mon | |
| 21:13:14 | mriedem | oh sheesh | |
| 21:13:34 | dansmith | tssurya_: you could re-use your bug for this, just maybe add a comment or change the title slightly to s/deleted/archived/ | |
| 21:13:42 | mriedem | once you've mastered removing instance mappings for super gone instances, | |
| 21:13:45 | mriedem | you can do the same for request specs | |
| 21:13:58 | dansmith | oh yeah, tssurya_ you should delete the reqspec at the same time | |
| 21:14:01 | dansmith | good call | |
| 21:14:10 | tssurya_ | dansmith, mriedem : yes shall do ; its this one ? https://bugs.launchpad.net/nova/+bug/1678056 | |
| 21:14:12 | openstack | Launchpad bug 1678056 in OpenStack Compute (nova) "RequestSpec records are never deleted when destroying an instance" [High,In progress] - Assigned to Sylvain Bauza (sylvain-bauza) | |
| 21:14:23 | dansmith | tssurya_: yep | |
| 21:14:41 | mriedem | yeah | |
| 21:15:01 | dansmith | tssurya_: you'll also have bauzas' gratitude for finishing his unfinished work :P | |
| 21:15:04 | tssurya_ | dansmith , mriedem : will get them done then :D | |
| 21:15:08 | dansmith | \o/ | |
| 21:15:09 | mriedem | thanks | |
| 21:15:24 | mriedem | also, my porch is suddenly full of wasps and spiders and i need someone to take care of that for me | |
| 21:15:31 | mriedem | although it is kind of spooky just in time for halloween | |
| 21:25:27 | mlavalle | mriedem: I responded to your comment in the spec | |
| 21:26:00 | mlavalle | I don't recall either that conversation during the PTG, but your feedback in the spec makes sense | |
| 21:30:59 | openstackgerrit | Eric Fried proposed openstack/nova master: Service user token requested with no auth https://review.openstack.org/512329 | |
| 21:33:29 | mriedem | mlavalle: looks like the spec was based on the notes in https://etherpad.openstack.org/p/placement-nova-neutron-queens-ptg | |
| 21:33:33 | mriedem | and i asked in there about the proxy thing too | |
| 21:35:30 | openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Clean up TODOs in allocations.yaml gabbit https://review.openstack.org/513057 | |
| 21:41:07 | efried | Thanks dansmith. edmondsw FYI, https://review.openstack.org/#/c/510957/ is in the gate. | |
| 21:41:14 | openstackgerrit | Merged openstack/nova master: Send Allocations to spawn https://review.openstack.org/511879 | |
| 21:41:15 | efried | Thanks johnthetubaguy too ^ | |
| 21:41:20 | openstackgerrit | Merged openstack/nova master: docs: Explain the flow of the "serial console" feature https://review.openstack.org/476188 | |
| 21:41:38 | edmondsw | efried saw... tx everyone | |
| 21:42:41 | tonyb | Will writing an external app to listen to the notifications bus 'void my warrantee?' or otherwise make y'all sad? | |
| 21:42:58 | mriedem | ? | |
| 21:43:06 | tonyb | I need to clean up an external system when an instance is deleted and I think that's the least gross way to do it | |
| 21:43:18 | mriedem | there are lots of things that do that already | |
| 21:43:20 | mriedem | mistral | |
| 21:43:27 | mriedem | telemetry, searchlight | |
| 21:43:32 | mriedem | designate sink i think | |
| 21:43:41 | mriedem | tonyb: use the versioned notifications | |
| 21:44:01 | tonyb | okay cool. That's knoda what I thought, but they're OpenStack and this things would be far from it | |
| 21:44:18 | mriedem | oh well if it's not openstack it's not allowed | |
| 21:44:35 | tonyb | mriedem: Yup no point writing to the old thing | |
| 21:44:39 | tonyb | mriedem: okay | |
| 21:44:47 | mriedem | i'm joking | |
| 21:44:53 | tonyb | ;p | |
| 21:44:54 | mriedem | about the not openstack thing | |
| 21:45:12 | mriedem | cross polination is the name of the game nowadays | |
| 21:46:19 | tonyb | mriedem: of course I'll push for it but the decision isn't really mine to make | |
| 21:53:00 | openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: Abort Cold Migration https://review.openstack.org/334732 | |
| 21:53:22 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add 'delete_host' command in 'nova-manage cell_v2' https://review.openstack.org/510324 | |
| 21:54:29 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608 | |
| 21:55:10 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483 | |
| 21:55:26 | openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.54 - List/Show all server migration types https://review.openstack.org/430839 | |
| 21:56:13 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955 | |
| 21:56:31 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | |
| 21:59:12 | openstackgerrit | Ed Leafe proposed openstack/nova master: Return Selection objects from the scheduler driver https://review.openstack.org/495854 | |
| 21:59:13 | openstackgerrit | Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357 | |
| 21:59:13 | openstackgerrit | Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/510159 | |
| 21:59:14 | openstackgerrit | Ed Leafe proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358 | |
| 22:05:31 | edleafe | dansmith: ^^ tests passed now, so I removed the 'or {}' | |
| 22:07:53 | openstackgerrit | Merged openstack/nova master: Move restart_compute_service to a common place https://review.openstack.org/512551 | |
| 22:09:53 | openstackgerrit | Merged openstack/nova stable/pike: Regenerate context during targeting https://review.openstack.org/512456 | |
| 22:09:58 | openstackgerrit | Merged openstack/nova stable/ocata: libvirt: add check for VIR_DOMAIN_BLOCK_REBASE_COPY_DEV https://review.openstack.org/512406 | |
| 22:10:12 | openstackgerrit | Merged openstack/nova stable/pike: Reproduce bug 1721652 in the functional test env https://review.openstack.org/511759 | |
| 22:10:13 | openstack | bug 1721652 in OpenStack Compute (nova) pike "Evacuate cleanup fails at _delete_allocation_for_moved_instance" [High,In progress] https://launchpad.net/bugs/1721652 - Assigned to Matt Riedemann (mriedem) | |
| 22:17:25 | mriedem | mlavalle: johnthetubaguy: sean-k-mooney: ok more comments in the port binding spec, specifically https://review.openstack.org/#/c/375580/13/specs/queens/approved/neutron-new-port-binding-api.rst@136 | |
| 22:17:47 | mlavalle | mriedem: thanks I saw them | |
| 22:17:53 | mriedem | i think there is a cleaner way to orchestrate some of the old/new flow stuff, which would also allow you to turn on the new flow if the source/dest during live migration are both running queens code | |
| 22:18:18 | mriedem | make conductor create the dest host binding, shove that into the migrate_data object, and have the computes key off that for doing stuff with the new dest host binding | |
| 22:18:38 | mriedem | also, don't have the virt driver call the neutron api to activate the dest host port binding, that needs to happen via compute manager in a generic way | |
| 22:19:14 | mriedem | i think the dest host port binding contains the details that are required to be put into the domain xml that goes on the dest host, but the spec isn't real clear about that | |
| 22:19:33 | mriedem | but that's probably the stuff that goes in the migrate_data and the compute keys off if it's doing new or old style stuff | |
| 22:21:05 | mlavalle | mriedem: cool, thanks. I'll probably shoot this in an email to sean-k-mooney later in an email to make sure he sees it firt thing in the morning | |
| 22:21:33 | mriedem | mlavalle: ok we might need a hangout in the morning | |
| 22:21:37 | mriedem | including johnthetubaguy | |
| 22:21:47 | mriedem | i feel like the spec goes 2 steps forward and 1 back each time i review it | |
| 22:21:53 | mlavalle | mriedem: do you have a time in mind? | |