Posted	Nick	Remark
#openstack-nova - 2017-10-17
21:16:08	mriedem	we do, however, have GET /servers/{server_id}/migrations/{migration_id} :)
21:16:12	mriedem	which is the int id
21:16:18	dansmith	yeah
21:16:20	mriedem	and DELETE /servers/{server_id}/migrations/{migration_id}
21:16:38	dansmith	but presumably you're doing /servers/id/migrations/ to get that id
21:16:38	mriedem	so i'd be fine with adding a new uuid key to the response for os-migrations like we did in 2.41
21:16:52	mriedem	yeah, presumably
21:16:54	mriedem	but...
21:16:56	dansmith	well, I already +Wd but lodged by discontent
21:17:03	dansmith	*my
21:17:59	mriedem	like i said, i'd be fine with just returning a new uuid key if yo'ure worried about breaking people, or making it confusing
21:18:40	dansmith	it's just unnecessary breakage which I think we should try to avoid unless we need to
21:19:15	openstackgerrit	Eric Fried proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215
21:19:15	openstackgerrit	Eric Fried proposed openstack/nova master: placement: add nested resource providers https://review.openstack.org/377138
21:19:16	openstackgerrit	Eric Fried proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693
21:19:16	dansmith	but it's +Wd
21:19:16	openstackgerrit	Eric Fried proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807
21:19:17	openstackgerrit	Eric Fried proposed openstack/nova master: Reformat _get_all_with_shared https://review.openstack.org/512799
21:20:08	mriedem	dansmith: we can amend
21:20:40	dansmith	I leave it to you, your highness
21:20:45	mriedem	gdi
21:21:00	openstackgerrit	Matt Riedemann proposed openstack/nova-specs master: Add pagination and timestamp filtering support for os-migrations API https://review.openstack.org/506030
21:22:08	dansmith	mriedem: I meant leave the decision to you
21:22:51	mriedem	yeah i agree with your point,
21:23:02	mriedem	i hadn't thought about the lack of GET /os-migratoins/{migration_id} or PUT etc
21:23:24	mriedem	i will say, the api-ref docs changes for communicating the id->uuid thing in 2.53 sucked
21:23:27	mriedem	so i'd like to avoid that again
21:23:43	dansmith	so, another way to decide would be:
21:23:52	dansmith	assuming we update the instance-scoped one to be the same,
21:24:02	dansmith	would you prefer that one to just be id:$uuid because of the GET/ ?
21:24:22	dansmith	if so, then maybe they should both be the same and just put the uuid in the id
21:24:27	mriedem	we don't need to return the uuid out of the instance-scoped one, because when we lookup the instance we know which cell the migration record is in
21:24:29	dansmith	I don't know tbh
21:24:44	mriedem	^ is why i didn't have to handle returning a uuid for the instance-scoped migrations in 2.53
21:24:47	dansmith	the least amount of total breakage would be just a new uuid field on the global one
21:26:47	dansmith	mriedem: well, I have to run off and do something else in a few
21:26:58	dansmith	mriedem: so you choose and either proxy my +2 on there or I'll hit it later on when I'm back
21:27:11	mriedem	i -1ed, yikun can update tonight, we'll +W tomorrow
21:27:15	mriedem	i have to see ms engle soon
21:27:18	dansmith	okay
21:27:21	dansmith	haha
21:27:37	mriedem	laura will dress up of course and i'll look the slob
21:27:55	dansmith	same old story every time I leave the house
21:31:08	mriedem	mtreinish: can you hit these 3 newton changes that have a +2 in them? https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/newton trying to flush these out before eol
21:39:08	mtreinish	mriedem: sure, I'll look in a sec
21:40:57	melwitt	mriedem: tempest.scenario.test_encrypted_cinder_volumes.TestEncryptedCinderVolumes.test_encrypted_cinder_volumes_luks [234.382405s] ... FAILED on the newton DNM patch
21:41:10	melwitt	will dig in once logs are available
21:44:04	mriedem	melwitt: aha
21:44:57	melwitt	I guess the question will still be something like, did os-brick fix the problem as a side effect and we should still do the nova change or did os-brick legit fix something
21:45:44	mriedem	idk, would have to figure out what the actual root failure was and what was changed in os-brick that makes it no longer a problem
21:45:52	mriedem	in that case the fix might be backporting something in os-brick
21:46:21	melwitt	yeah. if os-brick did something to legit fix it, we would backport that instead
21:46:43	melwitt	but if it's a side effect, we may still want the nova change to not rely on a side effect, if that makes sense
21:46:59	mriedem	sean-k-mooney: mlavalle: comments inline https://review.openstack.org/#/c/375580/
21:47:00	mriedem	gotta run
21:47:19	mlavalle	mriedem: thanks
21:49:43	openstackgerrit	melanie witt proposed openstack/nova master: Remove old-style quotas code https://review.openstack.org/511689
22:36:29	openstackgerrit	Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357
22:36:29	openstackgerrit	Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/510159
22:36:30	openstackgerrit	Ed Leafe proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358
22:42:53	openstackgerrit	melanie witt proposed openstack/nova stable/newton: DNM: libvirt: Fully destroy instances during a hard reboot https://review.openstack.org/512896
23:57:17	openstackgerrit	Merged openstack/nova stable/pike: Enable custom certificates for keystone communication https://review.openstack.org/505546
23:57:54	openstackgerrit	Merged openstack/nova stable/newton: Add live.migration.force.complete to the legacy notification whitelist https://review.openstack.org/508902
23:58:04	openstackgerrit	Merged openstack/nova stable/newton: Account for compute.metrics.update in legacy notification whitelist https://review.openstack.org/509441
23:58:11	openstackgerrit	Merged openstack/nova stable/newton: Catch InstanceNotFound exception https://review.openstack.org/467321
#openstack-nova - 2017-10-18
00:35:57	mriedem	yikun_jiang: did you see the updates to https://review.openstack.org/#/c/506030/ ?
01:04:56	openstackgerrit	Yikun Jiang proposed openstack/nova-specs master: Add pagination and changes since filter support for os-instance-action API https://review.openstack.org/507762
01:09:59	Kevin_Zheng	mriedem hi, for https://review.openstack.org/#/c/509326/
01:11:23	Kevin_Zheng	I was thinking adding a config option will let the operator to choose from 1. improved performance and 2. regex matching
01:11:32	Kevin_Zheng	if the neutron is old
01:11:40	mriedem	Kevin_Zheng: we don't really want config-driven API behavior
01:12:02	mriedem	if neutron has the new regex filtering support, we use it, else we fallback to what we do today
01:12:11	Kevin_Zheng	OK, that's also good, I was just adding it for discussion
01:12:30	mriedem	if someone really really needed to both filter by IPs and list deleted instances, they could still do that client side if necessary
01:13:46	Kevin_Zheng	understood
02:01:22	openstackgerrit	jichenjc proposed openstack/nova master: Refactor placement version check https://review.openstack.org/512497
02:01:42	openstackgerrit	jichenjc proposed openstack/nova master: mv generate_glance_url to get_image_endpoint_url https://review.openstack.org/511400
02:02:01	openstackgerrit	jichenjc proposed openstack/nova master: Remove duplicate error info https://review.openstack.org/510719
02:14:02	openstackgerrit	jichenjc proposed openstack/nova master: Add description for reousrce class creation https://review.openstack.org/508083
02:28:28	openstackgerrit	Huan Xie proposed openstack/nova master: VGPU: Define vgpu resource class https://review.openstack.org/511180
02:32:32	openstackgerrit	Hironori Shiina proposed openstack/nova-specs master: Ironic: Resize and cold migration support https://review.openstack.org/449155
02:44:38	openstackgerrit	Huan Xie proposed openstack/nova master: VGPU: Define vgpu resource class https://review.openstack.org/511180
02:47:47	openstackgerrit	jichenjc proposed openstack/nova master: fix race condition of instance host https://review.openstack.org/494458
02:51:11	openstackgerrit	Yikun Jiang proposed openstack/nova-specs master: Add pagination and timestamp filtering support for os-migrations API https://review.openstack.org/506030
02:55:24	openstackgerrit	jichenjc proposed openstack/nova master: Add create inventories doc for placement https://review.openstack.org/512215
02:56:14	openstackgerrit	jichenjc proposed openstack/nova master: check query param for server groups function https://review.openstack.org/500347
04:54:04	openstackgerrit	Ian Wienand proposed openstack/nova master: [DNM] testing nova changes https://review.openstack.org/512929
05:12:01	openstackgerrit	Naichuan Sun proposed openstack/nova master: VGPU_support: add enabled white list https://review.openstack.org/512580
05:17:43	openstackgerrit	Naichuan Sun proposed openstack/nova master: VGPU_support: add enabled white list https://review.openstack.org/512580
05:56:40	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data https://review.openstack.org/407514
06:42:12	openstackgerrit	jichenjc proposed openstack/nova master: Refactor placement version check https://review.openstack.org/512497
06:43:43	openstackgerrit	Yikun Jiang proposed openstack/nova-specs master: Add pagination and changes since filter support for os-instance-action API https://review.openstack.org/507762
06:59:12	openstackgerrit	Naichuan Sun proposed openstack/nova master: VGPU_support: add enabled white list https://review.openstack.org/512580
08:06:36	gibi	efried: I left one comment in https://review.openstack.org/#/c/511879
08:25:50	gibi	a pretty trivial patch for already awake cores: https://review.openstack.org/#/c/510635/
08:26:34	openstackgerrit	Jianghua Wang proposed openstack/nova master: vGPU: XenAPI: get vgpu stats from hypervisor https://review.openstack.org/512965
08:45:01	openstackgerrit	jichenjc proposed openstack/nova master: Refactor placement version check https://review.openstack.org/512497
08:49:23	openstackgerrit	Naichuan Sun proposed openstack/nova master: VGPU_support: add enabled white list https://review.openstack.org/512580
08:57:43	openstackgerrit	Naichuan Sun proposed openstack/nova master: VGPU_support: add enabled white list https://review.openstack.org/512580
09:32:10	stephenfin	sean-k-mooney, ralonsoh: Sean brought this up at the PTG, but what bus do the on-die FPGAs on recent Xeon chips hook into? QPI?

Earlier   Later