Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-10-11
16:49:02 openstackgerrit melanie witt proposed openstack/nova stable/pike: Target context for build notification in conductor https://review.openstack.org/511292
16:49:04 mriedem if the instance mapping doesn't have the cell mapping in it, we get the instance from the build request - and if that's gone by the time we look, we check the instance mapping again
16:49:27 dansmith mriedem: aye
16:49:43 mriedem gdi this is like 2 days i've spent all day chasing weird bugs
17:21:15 mriedem melwitt: does https://review.openstack.org/#/c/511292/ also need to go to ocata?
17:22:43 melwitt hm, lemme check. I had thought not but maybe this code was from ocata
17:22:44 mriedem looks like yes https://github.com/openstack/nova/blob/stable/ocata/nova/conductor/manager.py#L921
17:23:11 mriedem it also looks like ocata is not targeting the instance action in the cell, so that's getting created in cell0
17:23:22 melwitt yeah, was about to say that too
17:23:54 openstackgerrit Dan Smith proposed openstack/nova master: Revert allocations by migration uuid https://review.openstack.org/498949
17:23:55 openstackgerrit Dan Smith proposed openstack/nova master: Make migration uuid hold allocations for migrating instances https://review.openstack.org/506420
17:23:55 openstackgerrit Dan Smith proposed openstack/nova master: Refactor resource tracker to account for migration allocations https://review.openstack.org/506419
17:23:56 openstackgerrit Dan Smith proposed openstack/nova master: Split get_allocations_for_instance() into useful bits https://review.openstack.org/511306
17:23:56 openstackgerrit Dan Smith proposed openstack/nova master: Make live migration hold resources with a migration allocation https://review.openstack.org/507638
17:24:10 mriedem https://github.com/openstack/nova/commit/ca51db7e2db72cb774c94fb039509f2b4e6c94ca
17:24:19 dansmith mriedem: ^ updated to determine the source compute from allocations instead of trying to look it up
17:24:37 mriedem melwitt: https://github.com/openstack/nova/commit/ca51db7e2db72cb774c94fb039509f2b4e6c94ca fixed the instance action thing in pike, we'll want to backport that as well...
17:24:41 mriedem didn't have a bug o nit
17:24:51 melwitt ah, crap
17:25:17 openstackgerrit Matt Riedemann proposed openstack/nova stable/ocata: Make conductor create InstanceAction in the proper cell https://review.openstack.org/511307
17:25:20 mriedem thar she blar
17:25:27 melwitt k, cool
17:25:50 melwitt I should stack the other backport on that I think
17:26:01 mriedem yup
17:26:15 mriedem dansmith: ok
17:26:18 melwitt to increase the chance of clean backport. k
17:26:22 mriedem dansmith: +2 on mel's pike backport https://review.openstack.org/#/c/511292/
17:26:52 mriedem i need food in my belly
17:32:12 jaypipes dansmith: I think zuul might be lying about the merge failure messages.
17:32:29 dansmith jaypipes: I don't think they've actually started the cutover yet
17:32:31 dansmith which means, yes
17:34:12 melwitt it's expected to emit false merge conflicts prior to cutover? I guess I am missing something obvious
17:34:29 dansmith it's been doing that all week
17:34:38 melwitt I know
17:35:48 dansmith I'm just saying, it's been doing it all week, and the changes they have planned today haven't started yet AFAIK, so I think we'd expect the same behavior
17:36:20 dansmith I would assume that whatever has been giving zuul merge conflict heartburn over the last week is factored into the switchover
17:36:35 melwitt I had been thinking they were fixing zuul v3 before the cutover so maybe those would get fixed prior to the cutover
17:37:10 melwitt yeah. I guess I should ask
17:37:40 dansmith unless the failure is because they're not having it do the post-merge conflict checks because of resources or something
17:37:49 dansmith since it's highly constrained at the moment, and not doing the actual merges
17:37:55 openstackgerrit Jay Pipes proposed openstack/nova master: placement: add nested resource providers https://review.openstack.org/377138
17:37:56 openstackgerrit Jay Pipes proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807
17:37:56 openstackgerrit Jay Pipes proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215
17:37:57 openstackgerrit Jay Pipes proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693
17:38:11 dansmith I'm not sure what jaypipes' point was I guess
17:38:15 jaypipes efried: k, updated the n-r-p spec to address your comments ^^
17:38:28 efried Thanks jaypipes
17:38:41 jaypipes dansmith: generally, you can assume I am pointless.
17:38:51 efried dansmith jaypipes They figured out why the bogus merge conflicts were happening.
17:38:55 efried But no, they haven't cut over yet.
17:39:17 efried http://eavesdrop.openstack.org/irclogs/%23openstack-infra-incident/%23openstack-infra-incident.2017-10-11.log in case you're interested.
17:39:54 melwitt indeed they know about it in #infra and they're working on it
17:40:12 dansmith so yeah, like I said, it's getting old data because it's not doing the actual merges
17:40:46 melwitt okay. I didn't know how it worked
17:41:27 jaypipes efried, dansmith: k, thx for the info.
17:41:58 openstackgerrit Dan Smith proposed openstack/nova master: Revert allocations by migration uuid https://review.openstack.org/498949
17:41:59 openstackgerrit Dan Smith proposed openstack/nova master: Make migration uuid hold allocations for migrating instances https://review.openstack.org/506420
17:41:59 openstackgerrit Dan Smith proposed openstack/nova master: Refactor resource tracker to account for migration allocations https://review.openstack.org/506419
17:42:00 openstackgerrit Dan Smith proposed openstack/nova master: Make live migration hold resources with a migration allocation https://review.openstack.org/507638
17:45:54 abhishek Hi all.. can someone please review https://review.openstack.org/#/c/505546/
17:52:43 efried jaypipes https://review.openstack.org/#/c/377138/ not sure if I'm off base there...
18:10:54 openstackgerrit Jay Pipes proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215
18:10:54 openstackgerrit Jay Pipes proposed openstack/nova master: placement: add nested resource providers https://review.openstack.org/377138
18:10:55 openstackgerrit Jay Pipes proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693
18:10:55 openstackgerrit Jay Pipes proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807
18:10:59 jaypipes efried: good feedback, thanks. fixed ^^
18:11:04 efried jaypipes rgr
18:11:06 efried sdague https://review.openstack.org/#/c/490031/ succeeded, so that ought to mean https://review.openstack.org/#/c/490057/ is good to go. (To be extra sure, I'm still waiting for jenkins to vote on https://review.openstack.org/#/c/511006/, which runs the Nova CI with everything in place.)
18:12:38 efried jaypipes Cool man, I think I'm +1 on the whole stack. Let me know if I missed any.
18:12:59 jaypipes efried: thanks for the great reviews. appreciated.
18:13:05 efried yahyoubetcha :)
18:16:09 openstackgerrit Peter Hamilton proposed openstack/nova-specs master: Add support for certificate validation https://review.openstack.org/488541
18:28:40 openstackgerrit Dan Smith proposed openstack/nova master: Merge build requests into the sortmaster 9000 https://review.openstack.org/508595
18:28:41 openstackgerrit Dan Smith proposed openstack/nova master: Make get_instance_objects_sorted() be smart about cells https://review.openstack.org/509003
18:28:41 openstackgerrit Dan Smith proposed openstack/nova master: Add CellMapping.get_by_project_id() query method https://review.openstack.org/509002
18:32:16 mriedem dansmith: if you're going to fix the indent issue in the bottom change in the series, you could add a todo i pointed out in here https://review.openstack.org/#/c/498949/
18:32:21 mriedem that would be great mmmkay?
18:32:58 melwitt thaaaaanks
18:33:38 dansmith mriedem: wonkified? honestly matt...
18:34:47 dansmith mriedem: so, on the shared storage thing,
18:35:00 dansmith mriedem: I think that when we do that we'll have the instance hold its shared storage allocation on the new host,
18:35:10 dansmith not duplicate it for the migration one
18:35:37 dansmith the only case would be if we're root-on-shared-ephemeral I guess
18:36:08 dansmith so, I dunno, I'll put a NOTE as I don't really know what the TODO is until later
18:37:43 openstackgerrit Dan Smith proposed openstack/nova master: Revert allocations by migration uuid https://review.openstack.org/498949
18:37:43 openstackgerrit Dan Smith proposed openstack/nova master: Split get_allocations_for_instance() into useful bits https://review.openstack.org/511306
18:37:44 openstackgerrit Dan Smith proposed openstack/nova master: Make migration uuid hold allocations for migrating instances https://review.openstack.org/506420
18:37:44 openstackgerrit Dan Smith proposed openstack/nova master: Refactor resource tracker to account for migration allocations https://review.openstack.org/506419
18:37:45 openstackgerrit Dan Smith proposed openstack/nova master: Make live migration hold resources with a migration allocation https://review.openstack.org/507638
18:39:02 mriedem ok
18:39:20 mriedem wonkification of the SchedulerReportClient 2.0
18:40:59 dansmith heh
18:55:07 openstackgerrit Matt Riedemann proposed openstack/nova-specs master: Spec for flavor description https://review.openstack.org/501017
18:55:11 mriedem sdague: made those changes on restricting the id and name fields ^
18:55:49 sdague mriedem: will look
19:07:00 openstackgerrit Merged openstack/nova master: Update cinder in RequestContext service catalog https://review.openstack.org/510947
19:12:51 sdague mriedem: that looks completely sane to me
19:13:32 mriedem not only sane, but completely sane?
19:13:33 mriedem nice
19:17:41 mriedem huh https://developer.openstack.org/api-ref/placement/#resource-provider-inventories

Earlier   Later