Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-10-09
21:09:27 melwitt mriedem: lol. that one is not about a bug
21:10:19 melwitt dansmith: true, bugs in cells is unpossible
21:10:48 dansmith melwitt: I feel like we should be able to test that bottom one somehow
21:10:58 dansmith er,
21:11:03 dansmith I mean the scatter gather one
21:12:17 melwitt dansmith: yeah, I'm pondering on it
21:13:10 melwitt at first I was thinking there's not a good way to test it but there's probably a way
21:14:30 openstackgerrit Matt Riedemann proposed openstack/nova master: Update "SHUTOFF" description in API guide https://review.openstack.org/510697
21:15:16 melwitt just ... want ... to ... save ... comment ... in .... gerrit ...
21:15:24 melwitt nnnnggghh
21:15:35 mriedem it is pretty slow right now
21:15:55 melwitt yeah, some ppl are talking about it in #infra
21:16:10 melwitt probably gonna have to restart it again
21:16:37 dansmith yeah, super slow
21:16:46 dansmith melwitt: a couple questions in the other patch
21:18:40 openstackgerrit Merged openstack/nova master: use already loaded BDM in instance. https://review.openstack.org/483324
21:21:33 melwitt dansmith: in the test I was trying to assert that the context for the notify was targeted to the same cell the instance was created in. though I'm not sure how we know it's cell1 (there's already an assertion in that test that knows instance is created in cell1)
21:22:55 dansmith I really wish we had something in the context that identified the cell, because several tests go through obscure hoops to try to verify the cell
21:24:23 dansmith if you're going to leave it that way I think you need a bunch more comments explaining all the assumptions, how the fixture works, etc
21:24:38 openstackgerrit Merged openstack/nova master: use already loaded BDM in instance. (2) https://review.openstack.org/483955
21:25:05 dansmith personally I think it'd be better to just (re-)mock target_cell so you can get a stable __enter__ result and ensure that its yielded context is used for the instance
21:25:39 melwitt dansmith: it's not relying on the fixture giving the same context for subsequent targets (I removed all of that in the top patch and this is me working backward fixing the bugs I found)
21:26:04 dansmith I mean the same oslo_db context
21:26:07 dansmith or whatever it's called
21:26:09 melwitt I just wanted to verify it's targeted to the right thing
21:26:20 dansmith the thing we yield from our global db facade hacky thing
21:26:24 melwitt yeah, I took out that stuff in the last patch
21:26:58 melwitt I left only default_ctxt_mgr. unless that's what you're talking about
21:27:10 dansmith is that how this works then?
21:27:25 dansmith because you're asserting that something from a freshly created context is the same as an earlier-created one
21:28:39 melwitt oh, I think I understand what you're saying. you're talking about how in the fixture we only create a new context manager once per cell
21:29:21 dansmith right
21:29:35 dansmith yeah, it's oslo_db context_mgr that I'm trying to say with my words, right?
21:29:56 melwitt okay. yes, oslo.db TransactionContextManager
21:30:30 melwitt well, so we have one for cell0 and one for cell1 in the test env, and I wanted to assert that the notify one is targeted to cell1 and not cell0
21:30:38 melwitt that's what my thinking was
21:30:52 melwitt to make sure we're targeted to the right cell
21:31:08 dansmith which you're still doing in the new patch, L426 of fixtures.py
21:31:30 melwitt yeah, sorry I misunderstood you. I thought you were talking about the last_ctxt_mgr thing that I took out
21:31:41 dansmith yeah, I understand what you're doing, I just think it's obscure and an artifact of the fixture that is awkward to test for
21:31:43 melwitt I noticed that wasn't actually doing anything anymore so I removed it
21:32:04 melwitt but yeah I think asserting it's not None accomplishes the same thing
21:32:05 dansmith since we fixed a bunch of stuff, I think we don't need that now, yeah
21:32:55 dansmith my instance list stuff could avoid another db hit if I could tell what cell a context was targeted for, so .. we might want to consider doing something other than hackery for detecting that at some point
21:34:20 melwitt yeah. eons ago I suggested putting cell_uuid in the context for something else. so maybe we could do that?
21:34:58 melwitt when I brought it up it was back when we had the mq client cache thing in compute/rpcapi and we could have done cache lookups with the cell_uuid
21:35:27 dansmith yeah, that's what I meant
21:37:15 melwitt yeah, I'm +1 on that
21:43:56 dansmith gdi gerrit, come on
21:44:27 efried Is there chatter on -infra about it?
21:44:32 efried (I just rejoined)
21:44:40 dansmith yeah
21:46:06 efried cause yeah
21:46:30 efried Didn't realize how completely I rely on gerrit to do basically anything (and how much I took it for granted).
21:47:22 openstackgerrit Eric Fried proposed openstack/nova master: Use ksa adapter for placement conf & requests https://review.openstack.org/492247
21:48:03 dansmith melwitt: I'm going to run off for a bit but I'll hit those when I'm back if you get them updated
21:48:19 melwitt dansmith: cool, thanks
21:49:02 efried Rebase successful, but still complaining of a merge conflict. That's odd, isn't it?
21:49:26 melwitt if it's Zuul, I think it's posting not-really-merge-conflicts
21:49:50 efried ah
21:49:54 melwitt right now things are back to being gated on Jenkins, so I'd only pay attention to that as far as passing/not
21:50:06 openstackgerrit Kaustubh Phatak proposed openstack/nova master: Fixing: Bug #1722409 vmware network matches wrong substring from vSphere https://review.openstack.org/510702
21:50:07 openstack bug 1722409 in OpenStack Compute (nova) "nova wrongly attaches different network with similar name" [Undecided,New] https://launchpad.net/bugs/1722409 - Assigned to Kaustubh Phatak (kphatak-pf9)
21:51:36 openstackgerrit Kaustubh Phatak proposed openstack/nova master: Fixing: Bug #1722409 vmware network matches https://review.openstack.org/510703
21:51:37 openstack bug 1722409 in OpenStack Compute (nova) "nova wrongly attaches different network with similar name" [Undecided,New] https://launchpad.net/bugs/1722409 - Assigned to Kaustubh Phatak (kphatak-pf9)
22:02:36 openstackgerrit Matt Riedemann proposed openstack/nova-specs master: Deprecate file injection https://review.openstack.org/509013
22:02:37 mriedem sdague: for your morrow ^
22:11:59 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add 'delete_host' command in 'nova-manage cell_v2' https://review.openstack.org/510324
22:33:30 openstackgerrit Matt Riedemann proposed openstack/nova master: Move user_data max length check to schema https://review.openstack.org/510704
22:47:49 openstackgerrit Ed Leafe proposed openstack/nova master: Add Selection objects https://review.openstack.org/499239
22:47:49 openstackgerrit Ed Leafe proposed openstack/nova master: Add alternate hosts https://review.openstack.org/486215
22:47:50 openstackgerrit Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/510159
22:47:50 openstackgerrit Ed Leafe proposed openstack/nova master: Return Selection objects from the scheduler driver https://review.openstack.org/495854
22:59:13 melwitt grr, I thought I came up with a good way to test the scatter gather thing, but SpawnIsSynchronous messes that up. or rather, what I assert is still true without the fix bc it's synchronous
23:12:08 melwitt hm, it works when I remove SpawnIsSynchronous. I dunno if that makes it susceptible to timing bugs
23:12:42 melwitt probably.
23:22:44 openstackgerrit melanie witt proposed openstack/nova master: Fix target_cell usage for scatter_gather_cells https://review.openstack.org/510691
23:22:44 openstackgerrit melanie witt proposed openstack/nova master: Target context for build notification in conductor https://review.openstack.org/509967
23:22:45 openstackgerrit melanie witt proposed openstack/nova master: WIP Improve the CellDatabases test fixture and usage https://review.openstack.org/508432
23:22:45 openstackgerrit melanie witt proposed openstack/nova master: Elevate existing RequestContext to get bandwidth usage https://review.openstack.org/509968
23:29:28 openstackgerrit melanie witt proposed openstack/nova master: Fix target_cell usage for scatter_gather_cells https://review.openstack.org/510691
23:29:28 openstackgerrit melanie witt proposed openstack/nova master: Target context for build notification in conductor https://review.openstack.org/509967
23:29:29 openstackgerrit melanie witt proposed openstack/nova master: WIP Improve the CellDatabases test fixture and usage https://review.openstack.org/508432
23:29:29 openstackgerrit melanie witt proposed openstack/nova master: Elevate existing RequestContext to get bandwidth usage https://review.openstack.org/509968
#openstack-nova - 2017-10-10
01:20:09 openstackgerrit Yikun Jiang proposed openstack/nova-specs master: Add pagination and changes since filter support for os-instance-action API https://review.openstack.org/507762
01:36:21 openstackgerrit jichenjc proposed openstack/nova master: Remove duplicate error info https://review.openstack.org/510719
02:43:10 openstackgerrit Merged openstack/nova master: rp: de-ORM ResourceProvider.get_by_uuid() https://review.openstack.org/509025
03:02:49 openstackgerrit Michael Still proposed openstack/nova master: Cleanup mount / umount and associated rmdir calls https://review.openstack.org/494423
03:02:50 openstackgerrit Michael Still proposed openstack/nova master: Move shred to privsep. https://review.openstack.org/495537
03:02:50 openstackgerrit Michael Still proposed openstack/nova master: Move lvm handling to privsep. https://review.openstack.org/495516
03:02:51 openstackgerrit Michael Still proposed openstack/nova master: Move the idmapshift binary into privsep. https://review.openstack.org/495541
03:02:51 openstackgerrit Michael Still proposed openstack/nova master: Move xend existence probes to privsep. https://review.openstack.org/495538
03:02:52 openstackgerrit Michael Still proposed openstack/nova master: Move nbd commands to privsep. https://review.openstack.org/500351
03:02:52 openstackgerrit Michael Still proposed openstack/nova master: Move loopback setup and removal to privsep. https://review.openstack.org/495664
03:02:53 openstackgerrit Michael Still proposed openstack/nova master: Move blkid calls to privsep. https://review.openstack.org/500398
03:02:53 openstackgerrit Michael Still proposed openstack/nova master: Move kpartx calls to privsep. https://review.openstack.org/500354
03:09:41 openstackgerrit Merged openstack/nova master: nova.utils.get_ksa_adapter() https://review.openstack.org/488137
04:31:59 openstackgerrit jichenjc proposed openstack/nova master: Add description for reousrce class creation https://review.openstack.org/508083
04:50:20 openstackgerrit Wonil Choi proposed openstack/nova master: libvirt: add a condition to check the same host https://review.openstack.org/510737
06:27:53 openstackgerrit Merged openstack/nova master: rp: Move RP._get|set_aggregates() to module scope https://review.openstack.org/509026

Earlier   Later