| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-10-09 | |||
| 18:56:08 | sdague | I think I've got +2 on the ceph plugin repo too, so let me know when that's posted and I can help get it in | |
| 18:57:26 | melwitt | awesomesauce | |
| 19:04:34 | openstackgerrit | sean mooney proposed openstack/nova master: WIP reorder destination host setup https://review.openstack.org/510658 | |
| 19:11:01 | melwitt | sdague: posted here https://review.openstack.org/#/c/510660 will need to await test results to be 100% sure it's gonna owrk | |
| 19:11:03 | melwitt | *work | |
| 19:11:38 | sdague | melwitt: cool, I starred it, will come back around when the tests are in | |
| 19:11:50 | melwitt | thx | |
| 19:17:22 | mriedem | so uh https://review.openstack.org/#/c/394808/ | |
| 19:17:32 | mriedem | as far as i can tell, | |
| 19:17:44 | mriedem | that was added in ocata but the libvirt live migration flag it's setting is only available starting in libvirt 2.3.0 | |
| 19:17:52 | mriedem | http://libvirt.org/git/?p=libvirt.git;a=blob;f=docs/news-2016.html.in#l437 | |
| 19:18:03 | mriedem | our minimum is 1.2.9 | |
| 19:18:56 | sean-k-mooney | we can override this from the config no? | |
| 19:19:01 | mriedem | no | |
| 19:20:02 | sdague | mriedem: probably just put a conditional around that? | |
| 19:20:04 | sean-k-mooney | oh so the live_migration_flag option in the libvirt section of the nova-cpu.conf is jsut the default set ? | |
| 19:20:29 | mriedem | oh this might just be some other libvirt backend | |
| 19:21:15 | mriedem | yeah nvm, super old http://libvirt.org/git/?p=libvirt.git;a=commit;h=632be336898c9efef258e1f2d1c3df199a98a4aa | |
| 19:26:57 | sean-k-mooney | so live_migration_flag was apparently removed in kilo ... i should probably update our internal wiki to not tell you to use those when livemigrating | |
| 20:11:44 | openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: remove old code in post_live_migration_at_destination https://review.openstack.org/510680 | |
| 20:12:45 | openstackgerrit | Merged openstack/nova master: Remove dead code of api.fault notification sending https://review.openstack.org/505164 | |
| 20:12:58 | mriedem | sean-k-mooney: having to re-learn live migration to review this port binding spec again of course | |
| 20:45:18 | claudiub | mriedem: hellou. just an fyi, and I'm going to send a mail to the MLs and a patch for it, we're deprecating the support for Windows / Hyper-V Server 2012; the acceptable versions will be 2012 r2 and 2016. | |
| 20:45:22 | mriedem | man we do not do a good job of documenting the valid values for filtering instances by status | |
| 20:45:31 | mriedem | claudiub: ok | |
| 20:55:05 | openstackgerrit | melanie witt proposed openstack/nova master: Target context for build notification in conductor https://review.openstack.org/509967 | |
| 20:55:06 | openstackgerrit | melanie witt proposed openstack/nova master: WIP Improve the CellDatabases test fixture and usage https://review.openstack.org/508432 | |
| 20:55:06 | openstackgerrit | melanie witt proposed openstack/nova master: Elevate existing RequestContext to get bandwidth usage https://review.openstack.org/509968 | |
| 20:55:07 | openstackgerrit | melanie witt proposed openstack/nova master: Fix target_cell usage for scatter_gather_cells https://review.openstack.org/510691 | |
| 20:57:25 | efried | mriedem sdague Sorry, I'm back now. Little lunchtime injury to deal with. Anything I need to know right now or will me email/dashboard tell all? | |
| 20:58:17 | melwitt | mriedem, dansmith: found a couple of cells bugs while working on CellDatabases. bottom two in the stack ^ | |
| 20:59:36 | openstackgerrit | Merged openstack/nova master: Always put 'uuid' into sort_keys for stable instance lists https://review.openstack.org/510140 | |
| 21:00:29 | mriedem | efried: the latter | |
| 21:00:41 | efried | mriedem Cool, thanks. | |
| 21:01:29 | efried | mriedem And to answer your question, the distance between those two patches was significant and we didn't want to collapse them together, though we could have. But you're absolutely correct that the second one just undoes what the first one adds wrt those auth options. | |
| 21:07:37 | mriedem | melwitt: don't tell me you can't get bandwidth usage with multiple cells?! | |
| 21:07:40 | openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: fix server status values in GET /servers docs https://review.openstack.org/510696 | |
| 21:09:21 | dansmith | melwitt: not possible. | |
| 21:09:27 | melwitt | mriedem: lol. that one is not about a bug | |
| 21:10:19 | melwitt | dansmith: true, bugs in cells is unpossible | |
| 21:10:48 | dansmith | melwitt: I feel like we should be able to test that bottom one somehow | |
| 21:10:58 | dansmith | er, | |
| 21:11:03 | dansmith | I mean the scatter gather one | |
| 21:12:17 | melwitt | dansmith: yeah, I'm pondering on it | |
| 21:13:10 | melwitt | at first I was thinking there's not a good way to test it but there's probably a way | |
| 21:14:30 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Update "SHUTOFF" description in API guide https://review.openstack.org/510697 | |
| 21:15:16 | melwitt | just ... want ... to ... save ... comment ... in .... gerrit ... | |
| 21:15:24 | melwitt | nnnnggghh | |
| 21:15:35 | mriedem | it is pretty slow right now | |
| 21:15:55 | melwitt | yeah, some ppl are talking about it in #infra | |
| 21:16:10 | melwitt | probably gonna have to restart it again | |
| 21:16:37 | dansmith | yeah, super slow | |
| 21:16:46 | dansmith | melwitt: a couple questions in the other patch | |
| 21:18:40 | openstackgerrit | Merged openstack/nova master: use already loaded BDM in instance. |
|
| 21:21:33 | melwitt | dansmith: in the test I was trying to assert that the context for the notify was targeted to the same cell the instance was created in. though I'm not sure how we know it's cell1 (there's already an assertion in that test that knows instance is created in cell1) | |
| 21:22:55 | dansmith | I really wish we had something in the context that identified the cell, because several tests go through obscure hoops to try to verify the cell | |
| 21:24:23 | dansmith | if you're going to leave it that way I think you need a bunch more comments explaining all the assumptions, how the fixture works, etc | |
| 21:24:38 | openstackgerrit | Merged openstack/nova master: use already loaded BDM in instance. |
|
| 21:25:05 | dansmith | personally I think it'd be better to just (re-)mock target_cell so you can get a stable __enter__ result and ensure that its yielded context is used for the instance | |
| 21:25:39 | melwitt | dansmith: it's not relying on the fixture giving the same context for subsequent targets (I removed all of that in the top patch and this is me working backward fixing the bugs I found) | |
| 21:26:04 | dansmith | I mean the same oslo_db context | |
| 21:26:07 | dansmith | or whatever it's called | |
| 21:26:09 | melwitt | I just wanted to verify it's targeted to the right thing | |
| 21:26:20 | dansmith | the thing we yield from our global db facade hacky thing | |
| 21:26:24 | melwitt | yeah, I took out that stuff in the last patch | |
| 21:26:58 | melwitt | I left only default_ctxt_mgr. unless that's what you're talking about | |
| 21:27:10 | dansmith | is that how this works then? | |
| 21:27:25 | dansmith | because you're asserting that something from a freshly created context is the same as an earlier-created one | |
| 21:28:39 | melwitt | oh, I think I understand what you're saying. you're talking about how in the fixture we only create a new context manager once per cell | |
| 21:29:21 | dansmith | right | |
| 21:29:35 | dansmith | yeah, it's oslo_db context_mgr that I'm trying to say with my words, right? | |
| 21:29:56 | melwitt | okay. yes, oslo.db TransactionContextManager | |
| 21:30:30 | melwitt | well, so we have one for cell0 and one for cell1 in the test env, and I wanted to assert that the notify one is targeted to cell1 and not cell0 | |
| 21:30:38 | melwitt | that's what my thinking was | |
| 21:30:52 | melwitt | to make sure we're targeted to the right cell | |
| 21:31:08 | dansmith | which you're still doing in the new patch, L426 of fixtures.py | |
| 21:31:30 | melwitt | yeah, sorry I misunderstood you. I thought you were talking about the last_ctxt_mgr thing that I took out | |
| 21:31:41 | dansmith | yeah, I understand what you're doing, I just think it's obscure and an artifact of the fixture that is awkward to test for | |
| 21:31:43 | melwitt | I noticed that wasn't actually doing anything anymore so I removed it | |
| 21:32:04 | melwitt | but yeah I think asserting it's not None accomplishes the same thing | |
| 21:32:05 | dansmith | since we fixed a bunch of stuff, I think we don't need that now, yeah | |
| 21:32:55 | dansmith | my instance list stuff could avoid another db hit if I could tell what cell a context was targeted for, so .. we might want to consider doing something other than hackery for detecting that at some point | |
| 21:34:20 | melwitt | yeah. eons ago I suggested putting cell_uuid in the context for something else. so maybe we could do that? | |
| 21:34:58 | melwitt | when I brought it up it was back when we had the mq client cache thing in compute/rpcapi and we could have done cache lookups with the cell_uuid | |
| 21:35:27 | dansmith | yeah, that's what I meant | |
| 21:37:15 | melwitt | yeah, I'm +1 on that | |
| 21:43:56 | dansmith | gdi gerrit, come on | |
| 21:44:27 | efried | Is there chatter on -infra about it? | |
| 21:44:32 | efried | (I just rejoined) | |
| 21:44:40 | dansmith | yeah | |
| 21:46:06 | efried | cause yeah | |
| 21:46:30 | efried | Didn't realize how completely I rely on gerrit to do basically anything (and how much I took it for granted). | |
| 21:47:22 | openstackgerrit | Eric Fried proposed openstack/nova master: Use ksa adapter for placement conf & requests https://review.openstack.org/492247 | |
| 21:48:03 | dansmith | melwitt: I'm going to run off for a bit but I'll hit those when I'm back if you get them updated | |
| 21:48:19 | melwitt | dansmith: cool, thanks | |
| 21:49:02 | efried | Rebase successful, but still complaining of a merge conflict. That's odd, isn't it? | |
| 21:49:26 | melwitt | if it's Zuul, I think it's posting not-really-merge-conflicts | |
| 21:49:50 | efried | ah | |
| 21:49:54 | melwitt | right now things are back to being gated on Jenkins, so I'd only pay attention to that as far as passing/not | |
| 21:50:06 | openstackgerrit | Kaustubh Phatak proposed openstack/nova master: Fixing: Bug #1722409 vmware network matches wrong substring from vSphere https://review.openstack.org/510702 | |