| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-10-09 | |||
| 13:37:03 | sdague | dansmith: also, ug multiple sort queries | |
| 13:37:21 | dansmith | sdague: yeah, :/ | |
| 13:37:27 | sdague | that's mostly a good way to use no indexes | |
| 13:37:44 | dansmith | that | |
| 13:37:50 | dansmith | is another ibm special feature | |
| 13:37:57 | dansmith | but, the ship has sailed | |
| 13:39:22 | stephenfin | gibi: Single comment on https://review.openstack.org/#/c/483324/ | |
| 13:40:36 | gibi | stephenfin: thanks. | |
| 13:41:16 | gibi | stephenfin: I think that part of the code makes sure that the bdm is marked deleted in db | |
| 13:41:36 | stephenfin | gibi: But we still have the object reference that we can show? | |
| 13:41:38 | gibi | stephenfin: as we are at a last step of instance deletion | |
| 13:42:02 | gibi | stephenfin: yes we have the in memory version of that bdm | |
| 13:42:16 | gibi | stephenfin: or somebody could query it out form the db with read_deleted=True | |
| 13:42:58 | gibi | stephenfin: I can move the bdm.destroy() after the delete.end notification if that looks more logical to you | |
| 13:45:29 | mnaser | i'm trying to figure out from the commits if the placement database connection is something that is no longer being used? | |
| 13:46:05 | mnaser | it looks like it was reverted a while back.. but there's an open patch to add it again (that's pretty old): https://review.openstack.org/#/c/362766/ ? | |
| 13:49:23 | dansmith | mnaser: it is used by placement | |
| 13:49:27 | dansmith | er, wait | |
| 13:50:04 | mnaser | dansmith: https://review.openstack.org/#/q/39fb302fd9c8fc57d3e4bea1c60a02ad5067163f not sure if that helps you cobble things up together but it's not helping me much | |
| 13:50:06 | mnaser | (im reviewing the puppet change and seeing if we should deprecate that option or not) | |
| 13:50:29 | dansmith | mnaser: so we introduced some things a little too early and backed up a few steps, | |
| 13:50:46 | dansmith | but it's forward-looking not something that is going to go away | |
| 13:51:15 | dansmith | mnaser: we put something back in after that revert I think, just a sec | |
| 13:52:52 | dansmith | or maybe we never put it back | |
| 13:53:44 | dansmith | mnaser: well, anyway, "Deprecate" is probably the wrong word for the puppet patch, but it's confusing | |
| 13:54:25 | krypto | hello all any idea why windows vm created with 4 vcpu flavor shows only 2 vcpu inside it? I can see that in vm configuration its 4 cpu but inside the guest its just 2 | |
| 13:55:47 | mriedem | dansmith: looks like unit test failures in https://review.openstack.org/#/c/506416/ are real | |
| 13:55:59 | dansmith | mriedem: yep I know | |
| 13:56:25 | mnaser | dansmith: i think we'll add a warning to mention that it's currently un-used (not deprecated) till https://review.openstack.org/#/c/362766/ is merged | |
| 13:56:37 | mriedem | we never put the placement api stuff back in | |
| 13:56:39 | mriedem | after the revert | |
| 13:56:44 | mriedem | s/api/db/ | |
| 13:57:02 | edleafe | Scheduler subteam meeting in 3 minutes in #openstack-meeting-alt | |
| 13:57:24 | mnaser | mriedem so should we deprecate that option in puppet-nova or just warn that it's not used until it gets added again? | |
| 13:57:41 | dansmith | mriedem: I thought we had put an alternate connection url conf option in, that let you separate if not, but apparently we didn't | |
| 13:57:47 | mriedem | mnaser: i'd probably just say it's not used | |
| 13:58:12 | mriedem | otherwise we have to coordinate deprecations | |
| 13:58:24 | mriedem | and once puppet drops it, we might add it back in :) | |
| 13:58:37 | mnaser | alright cool, i'll leave a note mentioning to drop the warning once https://review.openstack.org/#/c/362766/ merges (if it ever does that is)? | |
| 13:58:58 | mriedem | we haven't put serious thought into what the migration / split out is going to look like | |
| 13:59:53 | mnaser | mriedem: gotcha. in that case we'll just leave it a warning and then keep up with nova's changes :> | |
| 14:00:05 | mnaser | thanks mriedem and dansmith :) | |
| 14:04:10 | stephenfin | gibi: Yeah, if you wouldn't mind | |
| 14:04:25 | gibi | stephenfin: sure, I can do that | |
| 14:04:27 | stephenfin | I get that it's safe there, but it seems...weird | |
| 14:04:30 | stephenfin | gibi: Ta :) | |
| 14:09:25 | gibi | mriedem: do you know if somebody is working on the spec discussed as a per requisite for the rx/tx queue size support? https://etherpad.openstack.org/p/nova-ptg-queens L239 | |
| 14:09:54 | gibi | mriedem: I reached out to nic but he said no | |
| 14:10:08 | mriedem | gibi: stephenfin: not sure that change needs to be made | |
| 14:10:12 | mriedem | at least not in the notifications patch | |
| 14:11:03 | mriedem | gibi: i thought cburgess and nic were working on that one | |
| 14:11:07 | gibi | mriedem: the notification patch started using the destroyed bdm and therefore introduced the confusion | |
| 14:11:15 | stephenfin | mriedem: It's not unrelated though - we weren't previously referencing bdm later in the function and now we are | |
| 14:11:16 | mriedem | i didn't follow the outcome of the conversation though | |
| 14:11:21 | stephenfin | Yeah, what gibi said | |
| 14:11:57 | gibi | mriedem: I pinged cburgess but no answer yet | |
| 14:12:02 | stephenfin | fwiw, I'm fine with it being done in a follow up, but I think it's confusing that we're "ensur(ing) block device mappings are not leaked", then "leaking" them via notifications | |
| 14:12:07 | gibi | cburgess: ^^ ping me please | |
| 14:12:32 | mriedem | stephenfin: well it means leaked as in not deleted from the db | |
| 14:12:50 | mriedem | thta's probably dead code now anyway | |
| 14:12:57 | mriedem | we delete the bdms when we delete the instance | |
| 14:13:25 | mriedem | https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L1891 | |
| 14:14:16 | mriedem | so given that, how about just removing that part in a follow up | |
| 14:14:21 | mriedem | rather than move it in this one | |
| 14:14:50 | stephenfin | Yup, let's do that so | |
| 14:15:16 | gibi | OK, I can push a followup | |
| 14:19:39 | mriedem | also just fyi https://github.com/openstack/nova/commit/5674e7646d106751b27d191e3334d9e6ebe9ab1b was newton, | |
| 14:19:47 | mriedem | so it should be safe to make that assumption from the queens compute | |
| 14:19:51 | mriedem | that the db api is doing what we want | |
| 14:20:12 | gibi | mriedem: ack | |
| 14:21:59 | mriedem | stephenfin: cool, thanks for hitting those | |
| 14:29:40 | openstackgerrit | Dan Smith proposed openstack/nova master: Fix minor input items from previous patches https://review.openstack.org/506416 | |
| 14:29:41 | openstackgerrit | Dan Smith proposed openstack/nova master: Add CellMapping.get_by_project_id() query method https://review.openstack.org/509002 | |
| 14:29:41 | openstackgerrit | Dan Smith proposed openstack/nova master: Merge build requests into the sortmaster 9000 https://review.openstack.org/508595 | |
| 14:29:42 | openstackgerrit | Dan Smith proposed openstack/nova master: Make get_instance_objects_sorted() be smart about cells https://review.openstack.org/509003 | |
| 14:30:43 | openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: PCI NUMA Policies https://review.openstack.org/361140 | |
| 14:31:00 | stephenfin | jaypipes: Fancy taking another shot at the PCI NUMA policies spec? ^ | |
| 14:31:39 | jaypipes | stephenfin: I'll take a look in a bit, sure | |
| 14:33:34 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix typo in test_prep_resize_errors_migration https://review.openstack.org/510591 | |
| 14:33:45 | mriedem | gibi: ^ :) | |
| 14:39:04 | gibi | mriedem: looking... | |
| 14:39:58 | dansmith | that was all gibi's fault anyway | |
| 14:40:26 | gibi | but now it is fixed and everybody is happy :) | |
| 14:40:31 | mriedem | heh | |
| 14:40:32 | dansmith | heh | |
| 14:41:10 | mriedem | melwitt: btw, i plan on starting draft slides for the pike update this week | |
| 14:45:26 | dansmith | I've seen several volume related issues causing gate resets this morning | |
| 14:48:45 | openstackgerrit | Stephen Finucane proposed openstack/nova master: placement: add ProviderTree.is_inventory_empty https://review.openstack.org/480957 | |
| 14:58:14 | openstackgerrit | sean mooney proposed openstack/nova-specs master: Use neutron's new port binding API https://review.openstack.org/375580 | |
| 14:59:42 | openstackgerrit | Merged openstack/nova master: Fix instance_get_by_sort_filters() for multiple sort keys https://review.openstack.org/510203 | |
| 14:59:54 | mriedem | dansmith: https://review.openstack.org/#/c/509899/ | |
| 15:00:02 | mriedem | but that's not showing up in http://status.openstack.org/elastic-recheck/index.html | |
| 15:00:07 | mriedem | b/c the page is busted for some reason | |
| 15:00:09 | mriedem | probably new gerrit | |
| 15:00:16 | dansmith | mriedem: ah okay I had looked | |
| 15:00:36 | mriedem | they don't send you 10 emails for a month before that happens? | |
| 15:00:50 | mriedem | most of my email now is school spam | |
| 15:00:53 | efried | dansmith To be clear, by "hamstringing" you mean settling on the param being an allocations object versus some other thing we would have more time to think about and design? | |
| 15:01:19 | dansmith | efried: no, passing allocations into the virt driver is not a huge deal, | |
| 15:01:22 | bauzas | mriedem: just one name : strike | |