| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-10-04 | |||
| 16:46:36 | mriedem | dansmith: still going through this if you want to hold up | |
| 16:46:41 | mriedem | into the conductor stuff now | |
| 16:46:46 | cfriesen | bauzas: will comment on the review | |
| 16:46:50 | dansmith | mriedem: sure | |
| 16:48:33 | cfriesen | bauzas: it occurs to me that combining flavor extra-specs and image properties is tricky...some of that logic is way down in the virt code. | |
| 16:53:36 | mriedem | dansmith: ok done :) | |
| 16:54:09 | dansmith | mriedem: I can't wait to see what gifts you have left for me | |
| 16:54:16 | mriedem | they are bountiful | |
| 16:54:27 | mriedem | i'm going to go pat myself on the back with lunch | |
| 16:56:32 | mriedem | jaypipes: cdent: fyi https://review.openstack.org/#/c/498950/ | |
| 16:57:25 | cdent | mriedem: mlph | |
| 16:57:37 | cdent | this shit is too confusing | |
| 17:10:08 | mriedem | cdent: yeah, there are like 10 things that happen outside the scenes of everything... | |
| 17:18:37 | efried | jaypipes ( cdent ) I finished reviewing the series starting at https://review.openstack.org/#/c/470575/ -- is there anything else to look at for NRP or related at the moment? | |
| 17:18:46 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova-specs master: Network bandwitdh resource provider https://review.openstack.org/502306 | |
| 17:19:06 | cdent | efried: have you seen jay’s orm removal stack? | |
| 17:19:12 | cdent | it’s tangentially related | |
| 17:19:16 | efried | What's an orm/ | |
| 17:19:17 | efried | ? | |
| 17:19:23 | efried | (But I guess not) | |
| 17:19:44 | cdent | https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:no-orm-resource-providers | |
| 17:21:16 | efried | cdent rgr | |
| 17:22:30 | cdent | efried: you’re already aware of alex’s traits work I think? | |
| 17:22:48 | efried | cdent Ah, sort of, but need to plug into it. Got a starter patch? | |
| 17:23:36 | cdent | it’s currently merge conflict, but: https://review.openstack.org/#/c/489206/7 | |
| 17:23:59 | efried | beaut | |
| 17:24:49 | efried | Amago eat, will dig in after. | |
| 17:28:30 | cfriesen | question for someone with more sqlalchemy-foo than I....will the soft_delete() call at https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L5932 affect both the "aggregate" table and the "aggregate_hosts" table? Or just the "aggregate" table? | |
| 17:35:52 | openstackgerrit | priyaduggirala proposed openstack/nova master: Rename parameters in call() of nova/image/glance.py https://review.openstack.org/508533 | |
| 17:40:02 | openstackgerrit | Merged openstack/nova master: Read from console ptys using privsep. https://review.openstack.org/489486 | |
| 17:40:47 | openstackgerrit | Merged openstack/nova stable/ocata: Fix 500 if list servers called with empty regex pattern https://review.openstack.org/506760 | |
| 17:42:11 | openstackgerrit | Dan Smith proposed openstack/nova master: Pre-create migration object https://review.openstack.org/498950 | |
| 17:42:11 | openstackgerrit | Dan Smith proposed openstack/nova master: Make allocation cleanup honor new by-migration rules https://review.openstack.org/498948 | |
| 17:42:12 | openstackgerrit | Dan Smith proposed openstack/nova master: Refactor resource tracker to account for migration allocations https://review.openstack.org/506419 | |
| 17:42:12 | openstackgerrit | Dan Smith proposed openstack/nova master: Revert allocations by migration uuid https://review.openstack.org/498949 | |
| 17:42:13 | openstackgerrit | Dan Smith proposed openstack/nova master: Make live migration hold resources with a migration allocation https://review.openstack.org/507638 | |
| 17:42:13 | openstackgerrit | Dan Smith proposed openstack/nova master: Make migration uuid hold allocations for migrating instances https://review.openstack.org/506420 | |
| 17:45:40 | mriedem | cfriesen: the latter | |
| 17:45:48 | mriedem | there is no such thing as cascading soft deletes | |
| 17:46:00 | mriedem | cfriesen: you could write a simple db api unit test to recreate that | |
| 17:52:08 | cfriesen | mriedem: I think that our online_data_migration will end up leaving a bunch of entries in the "aggregate_hosts" table after a migration....though properly written code shouldn't care. | |
| 17:52:31 | cfriesen | /s/migration/upgrade | |
| 17:53:35 | mriedem | write a test to show that | |
| 17:57:46 | dansmith | mriedem: are you sure that dest_host is the ip in the case of cold migration? https://review.openstack.org/#/c/508603/1/nova/objects/migration.py | |
| 17:58:03 | dansmith | I was surprised to find this was true for live migration a couple weeks ago when debugging a real thing, | |
| 17:58:14 | dansmith | but I'm not sure it's the same for cold migration | |
| 17:58:35 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Only query BDMs once in API during rebuild https://review.openstack.org/509574 | |
| 17:58:42 | mriedem | dansmith: yeah, that's what the RT sets it to | |
| 17:59:04 | mriedem | https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L368 | |
| 17:59:15 | mriedem | https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L393 | |
| 17:59:32 | mriedem | does live migration even set the migration.dest_host anywhere? | |
| 17:59:52 | melwitt | mriedem: it looks like the ceph package from the pike uca pulls in python-pastedeploy which gets install in parallel with a pip installed PasteDeploy package and keystone can't start because it has trouble referencing when there are multiple? (see last comment on https://ask.openstack.org/en/question/11458/keystone-all-importerror-cannot-import-name-deploy/) | |
| 17:59:57 | dansmith | actually we don't use moveclaim for live migration right? | |
| 18:00:04 | mriedem | dansmith: correct | |
| 18:00:05 | dansmith | maybe I had that reversed | |
| 18:00:11 | mriedem | that's why live migration creates the migratoin in conductor | |
| 18:00:16 | dansmith | ack | |
| 18:00:32 | dansmith | I think it's wrong for us to be setting the ip in that host field | |
| 18:00:42 | dansmith | in a "it's wrong but I'm not going to fix it any time soon" sort of way | |
| 18:00:57 | mriedem | dansmith: heh agree that it's surely confusing as hell | |
| 18:01:06 | mriedem | hence my putting a patch to comment on those damn fields | |
| 18:01:11 | mriedem | b/c i have to re-look it up every time | |
| 18:01:13 | dansmith | yeah | |
| 18:02:37 | clarkb | melwitt: on ubuntu (where uca is a thing) the deb packages should install to /usr and pip installed things to /usr/local. So if you get the order sorted out I expect it would just work | |
| 18:03:30 | mriedem | melwitt: weird, is there an ubuntu bug report? | |
| 18:03:36 | mriedem | we could ask jamespage about a fix | |
| 18:03:56 | mriedem | melwitt: alternatively we could workaround that maybe in the devstack-plugin-ceph repo by monkeying with the packages | |
| 18:08:34 | mriedem | heh, wtf, the compute rpcapi method for reboot_instance has a 'block_device_info' parameter that is always None from the API | |
| 18:13:36 | openstackgerrit | Jay Pipes proposed openstack/nova master: rp: remove CRUD operations on Inventory class https://review.openstack.org/509029 | |
| 18:13:36 | openstackgerrit | Jay Pipes proposed openstack/nova master: rp: move RP._set_traits() to module scope https://review.openstack.org/509028 | |
| 18:13:37 | openstackgerrit | Jay Pipes proposed openstack/nova master: rp: remove dead code in Allocation._create_in_db() https://review.openstack.org/509031 | |
| 18:13:37 | openstackgerrit | Jay Pipes proposed openstack/nova master: rp: streamline InventoryList.get_all_by_rp_uuid() https://review.openstack.org/509030 | |
| 18:13:38 | openstackgerrit | Jay Pipes proposed openstack/nova master: rp: fix up AllocList.get_by_resource_provider_uuid https://review.openstack.org/509033 | |
| 18:13:38 | openstackgerrit | Jay Pipes proposed openstack/nova master: rp: remove ability to delete 1 allocation record https://review.openstack.org/509032 | |
| 18:13:39 | openstackgerrit | Jay Pipes proposed openstack/nova master: rp: remove _HasAResourceProvider mixin https://review.openstack.org/509036 | |
| 18:13:39 | openstackgerrit | Jay Pipes proposed openstack/nova master: rp: rework AllocList.get_all_by_consumer_id() https://review.openstack.org/509035 | |
| 18:19:39 | cdent | jaypipes: is that orm-removal stuff basically ready for review, or are you still working through the kinks? i’m out of juice to review it now, but tomorrow morning might be good | |
| 18:20:49 | jaypipes | cdent: ready for review, thanks. | |
| 18:20:58 | cdent | coolio | |
| 18:21:06 | jaypipes | cdent: even doing three or four of the bottom ones would be useful. | |
| 18:21:13 | jaypipes | they're pretty smallish patches. | |
| 18:22:07 | jaypipes | cdent: fwiw, the HEAD of that series gets the resource_provider.py file to the point where I can do the root_provider_id/parent_provider_id fields (instead of the root_provider_uuid/parent_provider_uuid fields) that dansmith has asked for on the nested series. | |
| 18:22:33 | jaypipes | that dansmith has requested and that I agree with, btw | |
| 18:23:35 | mriedem | that reminds me, | |
| 18:23:47 | mriedem | andreykurilin: is there a devstack plugin for rally to make it easy to get an env setup? | |
| 18:24:01 | mriedem | oooo there is https://github.com/openstack/rally/tree/master/devstack | |
| 18:24:04 | mriedem | does it work? | |
| 18:24:05 | andreykurilin | mriedem: sure | |
| 18:24:43 | mriedem | what is the default backend when doing that? like do i need to also have ceilometer enabled? | |
| 18:24:44 | andreykurilin | mriedem: yes. it is used in all our gates | |
| 18:25:29 | andreykurilin | hm... ceilometer? rally has nothing related to ceilometer except test plugins for it. the default database backend is sqllite | |
| 18:25:57 | mriedem | ok yeah i was wondering about a db, i don't know much about rally, and i thought there was something to do with configuring it to send metrics collection to ceilometer | |
| 18:26:35 | mriedem | i'm looking for something simple to setup so i can compare test runs before and after some nova patch is applied | |
| 18:26:48 | mriedem | or, comparing scheduling times between ocata and pike | |
| 18:26:49 | mriedem | for example | |
| 18:28:19 | mriedem | i guess i should shut up and just read https://rally.readthedocs.io/en/latest/quick_start/tutorial.html | |
| 18:29:12 | andreykurilin | mriedem: so rally is quite simple and doesn't require any additional services to be installed. All the results are stored in the sql-dabase. One rally installation can check different clusters. The latest clients work perfectly with older releases of openstack. For example we have regular job which launch the scenarios at mitaka release | |
| 18:29:39 | mriedem | ok, i'm mostly interested in scheduling performance between ocata and pike, | |
| 18:30:01 | mriedem | i only have a single node devstack, so i'd have to get creative with mocking out computes | |
| 18:31:08 | mriedem | i know devstack has some flags for mocking out fake compute services when using the fake virt driver, but not sure if that works anymore with the tiered conductor stuff in devstack | |