| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-09-28 | |||
| 13:59:33 | mdbooth | Because it makes it messier upstream, and it's like a 1 line diff. | |
| 13:59:38 | mdbooth | In a unit test. | |
| 13:59:54 | mriedem | mdbooth: so when you say backport, you only mean internal backports? | |
| 14:00:09 | mdbooth | I'll be doing both. | |
| 14:00:38 | mriedem | ok. so as a stable reviewer, why do i need to sort out this diff? just isolate the py3 thing into the fix patch for migrateToURI and do the more general thing on top | |
| 14:01:16 | mdbooth | You should read my backport commit messages :) They're immaculate. | |
| 14:02:07 | dansmith | -1 | |
| 14:03:37 | openstackgerrit | Chris Dent proposed openstack/nova-specs master: Add spec for symmetric GET and PUT of allocations https://review.openstack.org/508164 | |
| 14:04:20 | mdbooth | mriedem: Incidentally, ever seen this bash-hackery: https://github.com/mdbooth/openstack-dev-hacks/blob/master/openstack.bash#L1-L4 | |
| 14:05:00 | mriedem | bauzas: do you think you'll be able to get to https://review.openstack.org/#/c/507488/ today? if not, i can help clean it up | |
| 14:06:15 | bauzas | dans | |
| 14:06:19 | bauzas | dansmith: done | |
| 14:06:39 | bauzas | mriedem: not sure I understand you, you mean me reviewing https://review.openstack.org/#/c/507488/ ? | |
| 14:06:50 | dansmith | bauzas: thanks | |
| 14:06:51 | mriedem | bauzas: oops, wrong patch | |
| 14:07:02 | mriedem | bauzas: this one https://review.openstack.org/#/c/506093/ | |
| 14:07:12 | bauzas | mriedem: FWIW, I'll have to bail out in 20 mins because I have to attend a Lyon OpenStack meetup (and btw. I'll miss today's nova meeting) | |
| 14:07:23 | openstackgerrit | Alex Xu proposed openstack/nova-specs master: Request traits in Nova https://review.openstack.org/468797 | |
| 14:07:31 | bauzas | mriedem: yeah I can fix that | |
| 14:07:37 | bauzas | 20 mins is enough | |
| 14:10:57 | mriedem | dansmith: what would be the best way to go about renaming the 'recreate' parameter in the rebuild_instance method in the compute manager, given rpc | |
| 14:11:14 | mriedem | add an 'evacuate' kwarg? so we could eventually drop the recreate parameter in a major rpc versoin bump? | |
| 14:11:34 | dansmith | mriedem: check the min version and send it the right way depending on what we're pinned to, | |
| 14:11:47 | dansmith | but you have to do the "if recreate or evacuate" logic in the top of the manager function, | |
| 14:11:55 | dansmith | which will probably not improve confusion | |
| 14:12:00 | dansmith | or, reduce | |
| 14:12:07 | dansmith | you could just do this at the top of the manager: | |
| 14:12:10 | mriedem | ok, alternatively i was just going to do: | |
| 14:12:12 | mriedem | evacuate = recreate | |
| 14:12:14 | dansmith | evacuate = recreate | |
| 14:12:15 | dansmith | yeah | |
| 14:12:17 | mriedem | ok | |
| 14:12:17 | mriedem | and replace all usage of the variable | |
| 14:12:23 | openstackgerrit | Ed Leafe proposed openstack/nova-specs master: Return Alternate Hosts https://review.openstack.org/504275 | |
| 14:12:34 | edleafe | johnthetubaguy: ^^ hope this addresses your comments | |
| 14:15:00 | bauzas | mriedem: not sure I get your comment on https://review.openstack.org/#/c/506093/4/nova/tests/functional/regressions/test_bug_1718455.py@135 | |
| 14:15:21 | bauzas | mriedem: if the migration isn't done yet, we should fail the test right? | |
| 14:16:02 | mriedem | bauzas: that code is waiting for the migration status to be 'running' | |
| 14:16:05 | mriedem | which is not waiting for it to be done | |
| 14:16:19 | bauzas | mriedem: so, s/running/done ? | |
| 14:16:37 | mriedem | you'd have to see whatever status we set the migration to when it's done | |
| 14:17:20 | mriedem | completed | |
| 14:17:29 | mriedem | is what is in _post_live_migrate in the compute manager | |
| 14:17:39 | mriedem | *_post_live_migration | |
| 14:17:41 | bauzas | ah, I understand | |
| 14:17:57 | bauzas | so, when it's running, that means the migration is in progress | |
| 14:17:58 | bauzas | my bad | |
| 14:18:07 | mriedem | correcto | |
| 14:18:09 | mriedem | hence the race | |
| 14:18:47 | bauzas | okay, uploading | |
| 14:19:52 | alex_xu_ | mriedem: gmann, jaypipes , next week is holiday in china, I will begin the vacation from tomorrow, so I won't active next week, probably just update spec when online since those two traits spec are very close. | |
| 14:20:06 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Ensure instance can migrate when launched concurrently https://review.openstack.org/506093 | |
| 14:20:12 | openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Update the placement deployment instructions https://review.openstack.org/469048 | |
| 14:20:18 | mriedem | alex_xu_: ok | |
| 14:20:50 | bauzas | alex_xu_: I was planning a spec review week, I could help you by providing new updates if you agree | |
| 14:20:55 | cdent | stephenfin: good comments, but I decided to deny you the “that” because why not | |
| 14:21:16 | alex_xu_ | bauzas: yea, sure, please free to update, appreciate the help! | |
| 14:22:22 | bauzas | k | |
| 14:25:51 | jaypipes | alex_xu_: cool. you ok with me or bauzas updating? | |
| 14:26:04 | jaypipes | alex_xu_: enjoy your vacation! :) | |
| 14:26:25 | alex_xu_ | jaypipes: yes, sure, thanks! | |
| 14:27:02 | mdbooth | lyarwood: Just reviewing stable rescue spec for resubmission. Given that it seems we need to touch the api anyway, if you did it again would you make 'stable' an argument to the rescue rest api? | |
| 14:27:59 | lyarwood | mdbooth: no, iirc the only api changes were a new microversion for the new behaviour right? | |
| 14:29:04 | mdbooth | The different image parameters would still be required if you wanted to change the bus though, I guess... | |
| 14:29:34 | lyarwood | mdbooth: yeah I was about to say that they provide more than just turning it on and off, I'd keep that as the interface tbh and just add in the microversion | |
| 14:29:55 | mdbooth | But in the main, I'd expect that 'add this regular root disk at the end and boot from it' would work, so the only user change would be --stable | |
| 14:30:38 | mdbooth | And in fact, given that by default we use the original boot image as the rescue image... | |
| 14:30:50 | mdbooth | We would enable the use case of no additional changes, just rescue --stable | |
| 14:32:40 | lyarwood | mdbooth: yeah, I still wouldn't but it's your baby now ;) | |
| 14:33:20 | mdbooth | Hehe. It would be slightly simpler to leave it alone, of course. I just wonder if it wouldn't be easier for users. | |
| 14:35:49 | johnthetubaguy | edleafe: great updates for the alternate hosts spec, just have a question on the follow up to gibi around things other than build | |
| 14:36:13 | johnthetubaguy | edleafe: there are quite a few users of select_destinations, its worth having at least a note about the approach there | |
| 14:36:42 | openstackgerrit | sahid proposed openstack/nova master: pci: update PciDevice object field 'address' to accept NULL https://review.openstack.org/508175 | |
| 14:36:43 | openstackgerrit | sahid proposed openstack/nova master: pci: generalize object unit-tests for different framework https://review.openstack.org/508177 | |
| 14:36:43 | openstackgerrit | sahid proposed openstack/nova master: pci: add for PciDevice object new field mdev https://review.openstack.org/508176 | |
| 14:36:44 | openstackgerrit | sahid proposed openstack/nova master: pci: generalize stats unit-tests for different framework https://review.openstack.org/508179 | |
| 14:36:44 | openstackgerrit | sahid proposed openstack/nova master: pci: add support for mdev device type request https://review.openstack.org/508178 | |
| 14:36:45 | openstackgerrit | sahid proposed openstack/nova master: pci: add support for resource pool stats of mdev devices https://review.openstack.org/508181 | |
| 14:36:45 | openstackgerrit | sahid proposed openstack/nova master: pci: add support for mdev devices type devspec https://review.openstack.org/508180 | |
| 14:36:46 | openstackgerrit | sahid proposed openstack/nova master: libvirt: update PCI node device to report mdev devices https://review.openstack.org/508183 | |
| 14:36:46 | openstackgerrit | sahid proposed openstack/nova master: pci: make manager to accept handling mdev devices https://review.openstack.org/508182 | |
| 14:36:47 | openstackgerrit | sahid proposed openstack/nova master: libvirt: add support to start vm with using mdev (vGPU) https://review.openstack.org/508185 | |
| 14:36:47 | openstackgerrit | sahid proposed openstack/nova master: libvirt: report mdev resources https://review.openstack.org/508184 | |
| 14:36:48 | openstackgerrit | sahid proposed openstack/nova master: libvirt: resuse SRIOV funtional tests for MDEV devices https://review.openstack.org/508187 | |
| 14:36:48 | openstackgerrit | sahid proposed openstack/nova master: functional: rework fakelibvirt host pci devices https://review.openstack.org/508186 | |
| 14:38:40 | openstackgerrit | Matt Riedemann proposed openstack/nova master: What is the meaning of....recreate? https://review.openstack.org/508190 | |
| 14:39:01 | mriedem | johnthetubaguy: edleafe: good point - note that the only other place we do reschedules is cold migrate/resize | |
| 14:39:17 | mriedem | evacuate, unshelve, live migration don't do the reschedule dance between compute and conductor, | |
| 14:39:25 | mriedem | live migration does a reschedule dance of it's own, but that happens in super conductor | |
| 14:39:35 | edleafe | johnthetubaguy: ok, but I'm not sure as to the depth you would like, beyond stating that the return from select_destinations will change | |
| 14:40:02 | mriedem | edleafe: it's probably worth calling out (1) where we rely on reschedules and (2) that those paths will need to be aware of this change | |
| 14:40:10 | mriedem | so build, resize/migrate, live migrate | |
| 14:40:32 | mriedem | and we should probably be sure to have functional tests for hitting those reschedule flows | |
| 14:40:59 | edleafe | mriedem: yeah - they'll need to adapt to handle the different return value, but they don't need to change what they do with it | |
| 14:41:09 | mriedem | the good news is i think we already do have functional tests for reschedules with those 3 flows now | |
| 14:41:37 | edleafe | they *can* change, but that's out of scope for this | |
| 14:41:40 | mriedem | cdent: i thought you might like the philosophical tone of https://review.openstack.org/#/c/508190/ | |
| 14:41:55 | cdent | heh | |
| 14:42:46 | cdent | “The meaning is, don't ask.” is my new bumper sticker, t-shirt, tattoo | |
| 14:43:06 | cdent | this ^ is very exciting | |