Posted	Nick	Remark
#openstack-nova - 2017-09-22
19:41:38	mriedem	that would be jianghua wang
19:42:12	mriedem	heh, actually, they said in july:
19:42:13	mriedem	"The connection_info from bdm works well for XenAPI both in v2 and v3.27. It'd be good if someone can help us to understand why libvirt needs initialize_connection."
19:42:20	mriedem	:)
19:42:51	mriedem	ah that's why this works
19:42:53	mriedem	"Per the commit message from the following commit, the connection_info from DBM is for destination. So if the connection info for source side is different from destination, it will have problem. That's why libvirt changed to use initialize_connection. https://github.com/openstack/nova/commit/8b649aa86fb26e998d66e75e5cebfd19c396942d"
19:43:12	mriedem	so apparently the bdm.connection_info is already getting updated with the dest host connection_info
19:44:04	mriedem	nvm, that doesn't explain why your change isn't failing when we disconnect on the source host
19:44:50	mriedem	let's just be safe and pull that thing out of cinder if we're new flow, we know it's there, and we have the attachment_id to get it via the migrate_data object
19:47:28	stvnoyes	kk
20:00:09	openstackgerrit	Jackie Truong proposed openstack/nova master: Add trusted_certs to Instance object https://review.openstack.org/489408
20:00:59	openstackgerrit	Jackie Truong proposed openstack/nova master: Add trusted_certificates to REST API https://review.openstack.org/486204
20:09:52	openstackgerrit	Merged openstack/nova master: Add tests to validate instance_list handles faults correctly https://review.openstack.org/505392
20:30:55	mriedem	sdague: one sort of weird thing in the live snapshot patch https://review.openstack.org/#/c/454323/
20:31:05	mriedem	the config option help talks about libvirt 1.2.2,
20:31:13	mriedem	but we've required at least 1.2.9 since pike
20:31:22	sdague	mriedem: right, which is under our minimum
20:31:35	sdague	yeh, honestly, I don't know if other libvirt versions will experience the same issue
20:31:50	mriedem	right we test against 2.5.0 right now
20:31:56	sdague	yeh
20:32:25	sdague	so we could also deprecate the option, I would honestly do that as a follow on from the default change under the assumption that we don't see the issue show up again
20:32:39	sdague	it would be nice to have a month of burn in data on that
20:32:58	mriedem	we'll be using 3.6.0 if/when we switch to pike uca
20:33:00	cburgess	Or a release.
20:33:05	mriedem	ok so that was my question, if we also deprecate
20:33:08	mriedem	i'm ok with doing it in a separate change
20:39:22	openstackgerrit	Matt Riedemann proposed openstack/nova master: fix nova accepting invalid availability zone name with ':' https://review.openstack.org/490722
20:42:37	sdague	yeh, that would make me more comfortable to know that all this was going to work for reals for a while
20:42:49	sdague	it took us a while to see the fail pattern before
20:42:59	sdague	and while the 10 rechecks seem fine, stuff emerges
20:48:08	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add functional migrate force_complete test https://review.openstack.org/496202
20:52:51	mriedem	anyone noticed an annoying quirk with new gerrit where commenting lower in a file jumps you back up to a previous comment or something higher up?
20:53:08	mriedem	i swear i had to fix this somehow 2 years ago with the last major upgrade
20:56:49	openstackgerrit	Dan Smith proposed openstack/nova master: Add get_instance_objects_sorted() https://review.openstack.org/505417
20:56:50	openstackgerrit	Dan Smith proposed openstack/nova master: Fix a pagination logic bug in test_bug_1689692 https://review.openstack.org/505661
20:56:50	openstackgerrit	Dan Smith proposed openstack/nova master: Copy some tests to a cellsv1 mixin https://review.openstack.org/505442
20:56:51	openstackgerrit	Dan Smith proposed openstack/nova master: Remove legacy fault-loading routines https://review.openstack.org/505456
20:56:51	openstackgerrit	Dan Smith proposed openstack/nova master: Use improved instance_list module in compute API https://review.openstack.org/505418
20:56:52	openstackgerrit	Dan Smith proposed openstack/nova master: Fix minor input items from previous patches https://review.openstack.org/506416
20:56:52	openstackgerrit	Dan Smith proposed openstack/nova master: Fix CellDatabases fixture swallowing exceptions https://review.openstack.org/506312
20:56:53	openstackgerrit	Dan Smith proposed openstack/nova master: Make 'fault' a valid joined query field for Instance https://review.openstack.org/506774
21:00:31	openstackgerrit	Ed Leafe proposed openstack/nova master: Add alternate hosts https://review.openstack.org/486215
21:00:32	openstackgerrit	Ed Leafe proposed openstack/nova master: Add Selection objects https://review.openstack.org/499239
21:21:34	mriedem	huh, placement randomly crashed in my devstack at some point in the last week
21:52:10	mriedem	ooo yeah, bursting 20 instances at once with no quota and the fake virt driver
21:52:22	mriedem	now i understand why this nfv thing is so fun!
21:54:21	cburgess	lol
21:55:37	mriedem	oh yeah, port quota
21:55:40	mriedem	need to keep that in mind
21:57:22	mriedem	superdan: i was going to create like 100 instances using the fake driver in devstack env and just compare listing instances before and after your changes, have you tried something like that yet?
21:59:04	mriedem	i only have 1 cell though so it's not as fun
22:00:43	superdan	mriedem: I've been scheming on some tests :)
22:00:53	superdan	but I don't have any real numbers or anything no
22:27:00	mikal	I'd appreciate a quick review of https://review.openstack.org/#/c/504429/ if anyone is bored, its a fix for a privsep snafu with ploop stuff
22:27:16	mikal	Not superdan though, he's already given it a +2
22:27:44	superdan	\o/
22:28:44	mikal	Yeah, that guy is an overachiever
22:28:57	melwitt	I'll review it cause it's named "ploop"
22:33:58	mikal	LOL
22:34:16	mikal	melwitt: thanks, I appreciate it
22:44:43	cburgess	OMG speaking of overachiver.. mikal from the airport on a Saturday.
23:00:52	mikal	cburgess: sorry, I'm just bored waiting four hours for my flight
23:33:05	openstackgerrit	Steve Noyes proposed openstack/nova master: Add attachment_get call to volume/cinder_api https://review.openstack.org/506805
23:35:06	cburgess	mikal Lame. Didn't catch the earlier flight?
23:47:35	openstackgerrit	Steve Noyes proposed openstack/nova master: Add attachment_get call to volume/cinder_api https://review.openstack.org/506805
#openstack-nova - 2017-09-23
00:02:50	mikal	cburgess: bags took ages to come out, so I missed the earlier one.
01:00:30	mriedem	melwitt: https://github.com/openstack/nova/blob/master/nova/scheduler/manager.py#L84
01:00:41	mriedem	we're running a periodic task in the scheduler manager to expire reservations, which no longer exist :)
01:02:14	melwitt	a-ha. they might technically exist but are definitely not being used
01:02:21	mriedem	https://bugs.launchpad.net/nova/+bug/1719048
01:02:22	openstack	Launchpad bug 1719048 in OpenStack Compute (nova) "The scheduler runs a useless periodic task to expire quota reservations" [Medium,Triaged]
01:04:03	melwitt	the thing to think about is if old computes might be writing reservations. so ocata computes could write reservations, but in queens nothing will be writing them, so that would be the appropriate time to remove things that do anything with them
01:07:25	mriedem	true
01:40:59	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Remove useless periodic task that expires quota reservations https://review.openstack.org/506822
01:48:31	openstackgerrit	Merged openstack/nova master: Cleanup unused get_iscsi_initiator. https://review.openstack.org/501944
01:48:37	Kevin_Zheng	mriedem I guess I should also add a release note then, it looks like we have a configure option [quota]reservation_expire
01:50:26	mriedem	yeah
01:51:35	liuyulong	hi there, morning
01:56:26	liuyulong	mriedem, Kevin_Zheng , I'll add the patch https://review.openstack.org/#/c/379128/ to the REF of spec of bp/rebuild-keypair-reset. By the way its on the same topic https://review.openstack.org/#/q/topic:bp/rebuild-keypair-reset.
02:08:37	Kevin_Zheng	mriedem, I might delete all the reservation commit/rollback code as well?
02:13:04	mriedem	um, not sure, probably need to leave that for melwitt
02:13:20	mriedem	she should get dibs on removing a bunch of that stuff since she went through the pain of getting us to not use it
02:51:05	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Remove useless periodic task that expires quota reservations https://review.openstack.org/506822
04:15:00	openstackgerrit	Michael Still proposed openstack/nova master: Move ploop commands to privsep. https://review.openstack.org/492325
04:15:01	openstackgerrit	Michael Still proposed openstack/nova master: Cleanup mount / umount and associated rmdir calls https://review.openstack.org/494423
04:15:01	openstackgerrit	Michael Still proposed openstack/nova master: Don't shell out to mkdir, use ensure_tree() https://review.openstack.org/492326
04:15:02	openstackgerrit	Michael Still proposed openstack/nova master: Move shred to privsep. https://review.openstack.org/495537
04:15:02	openstackgerrit	Michael Still proposed openstack/nova master: Move lvm handling to privsep. https://review.openstack.org/495516
04:15:03	openstackgerrit	Michael Still proposed openstack/nova master: Move the idmapshift binary into privsep. https://review.openstack.org/495541
04:15:03	openstackgerrit	Michael Still proposed openstack/nova master: Move xend existence probes to privsep. https://review.openstack.org/495538
04:15:04	openstackgerrit	Michael Still proposed openstack/nova master: Move nbd commands to privsep. https://review.openstack.org/500351
04:15:04	openstackgerrit	Michael Still proposed openstack/nova master: Move loopback setup and removal to privsep. https://review.openstack.org/495664
04:15:05	openstackgerrit	Michael Still proposed openstack/nova master: Move blkid calls to privsep. https://review.openstack.org/500398
04:15:05	openstackgerrit	Michael Still proposed openstack/nova master: Move kpartx calls to privsep. https://review.openstack.org/500354
04:15:06	openstackgerrit	Michael Still proposed openstack/nova master: WIP / Aspirational: we don't need rootwrap any more. https://review.openstack.org/495542
06:40:29	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Remove useless periodic task that expires quota reservations https://review.openstack.org/506822
08:13:57	openstackgerrit	Zhenyu Zheng proposed openstack/nova-specs master: Allow update keypair for instance https://review.openstack.org/506552
08:33:55	openstackgerrit	Zhenyu Zheng proposed openstack/nova-specs master: Allow update keypair for instance https://review.openstack.org/506552
09:34:11	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: block_device_mapping_v2.bus_type is missing from api-ref https://review.openstack.org/499488
12:20:59	openstackgerrit	zhangyangyang proposed openstack/nova stable/pike: Remove the method get_iscsi_initiator in volumeutils.py https://review.openstack.org/506846

Earlier   Later