| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-09-22 | |||
| 00:26:10 | openstackgerrit | Dan Smith proposed openstack/nova master: Make allocation cleanup honor new by-migration rules https://review.openstack.org/498948 | |
| 00:26:11 | openstackgerrit | Dan Smith proposed openstack/nova master: Refactor resource tracker to account for migration allocations https://review.openstack.org/506419 | |
| 00:26:11 | openstackgerrit | Dan Smith proposed openstack/nova master: Pre-create migration object https://review.openstack.org/498950 | |
| 00:26:12 | openstackgerrit | Dan Smith proposed openstack/nova master: Make migration uuid hold allocations for migrating instances https://review.openstack.org/506420 | |
| 00:26:25 | dansmith | this is still super WIP except for the first patch ^ | |
| 00:26:30 | dansmith | and a giant mess to boot | |
| 00:26:41 | dansmith | but, it's getting there | |
| 00:31:36 | dansmith | melwitt: replied to your [0] question, and I can slap a comment into the fixes patch at the end if you want | |
| 00:31:44 | dansmith | if you are otherwise likely to be okay with the rest | |
| 00:31:48 | dansmith | same for your docstring mriedem | |
| 00:34:07 | melwitt | okay, yeah a comment would be nice for the fixes patch. the rest looked fine to me | |
| 00:37:03 | openstackgerrit | Dan Smith proposed openstack/nova master: Fix minor input items from previous patches https://review.openstack.org/506416 | |
| 00:37:06 | dansmith | voilla ^ | |
| 00:38:13 | openstackgerrit | Merged openstack/nova master: Make instance_list honor global query limit https://review.openstack.org/504984 | |
| 00:39:15 | dansmith | aww yeah | |
| 00:39:39 | dansmith | melwitt: mriedem: the gate phoned and said it was lonely. just sayin'. | |
| 00:42:53 | melwitt | the gate calls you on the phone? I'm jell | |
| 00:43:56 | dansmith | don't be, it's rarely good news | |
| 00:44:10 | melwitt | heh | |
| 00:44:56 | mriedem | what the f are you two talking about | |
| 00:45:29 | melwitt | cool cat stuff | |
| 00:47:05 | mriedem | dansmith: this is kind of a "add an assertion check here?" question https://review.openstack.org/#/c/504985/8/nova/tests/unit/db/test_db_api.py@10793 | |
| 00:47:35 | dansmith | mriedem: assert what? | |
| 00:47:58 | dansmith | oh, I see | |
| 00:48:02 | mriedem | yeah | |
| 00:48:03 | dansmith | make sure the first one did the thing I want? | |
| 00:48:03 | mriedem | that | |
| 00:48:17 | mriedem | yes | |
| 00:48:23 | dansmith | but at the end we know we've gotten them all ... | |
| 00:49:06 | mriedem | yeah ok | |
| 00:49:09 | mriedem | fair enough | |
| 00:49:50 | dansmith | I can slap more checking into the fixes patch if you want | |
| 00:50:18 | melwitt | slap chop | |
| 00:50:55 | mriedem | it's just kind of hard to grok what this is doing | |
| 00:51:05 | dansmith | the first call is using the existing db method, | |
| 00:51:15 | mriedem | it starts with the 256 memory_mb instance | |
| 00:51:31 | dansmith | so if it wasn't sorting properly, we'd have a big problem and other tests would fail (hopefully?) | |
| 00:51:46 | mriedem | and then i guess it pages through each time, and should hit those other instances in order | |
| 00:51:53 | mriedem | so next after 256+1 would be the 512 instance | |
| 00:51:57 | dansmith | mriedem: it does, and I just put things in the db in a weird order to make sure we don't rely on the ordering in the db but the sorting | |
| 00:52:08 | mriedem | yeah noted that | |
| 00:52:11 | mriedem | which is nice | |
| 00:52:45 | mriedem | and the key_name in the values is just there for? | |
| 00:53:11 | mriedem | just to show we aren't sorting on key_name? | |
| 00:53:49 | dansmith | I think I was copying my other unit test examples from the other patches, but yeah I can remove that if you think it's confusing | |
| 00:55:06 | mriedem | ok left some comments inline, you can add docs to it in the end if you want | |
| 00:55:57 | openstackgerrit | Dan Smith proposed openstack/nova master: Fix minor input items from previous patches https://review.openstack.org/506416 | |
| 00:55:59 | dansmith | mriedem: ^ | |
| 00:57:04 | dansmith | mriedem: does that help at all? or is it still too obscure because I'm not comparing against a static obvious list? | |
| 00:58:42 | mriedem | you only updated the commit message | |
| 00:59:07 | dansmith | gah | |
| 00:59:27 | openstackgerrit | Dan Smith proposed openstack/nova master: Fix minor input items from previous patches https://review.openstack.org/506416 | |
| 00:59:31 | dansmith | sorry | |
| 01:01:08 | mriedem | ok, left a comment about the key_name thing in the last change | |
| 01:02:39 | openstackgerrit | Dan Smith proposed openstack/nova master: Fix minor input items from previous patches https://review.openstack.org/506416 | |
| 01:02:54 | dansmith | got it | |
| 01:03:30 | mriedem | i think i'm getting the global marker patch now | |
| 01:03:37 | mriedem | understanding the patch before it is key | |
| 01:10:30 | mriedem | so for the ip filtering we do in python in the compute api, does the end of this result in us returning a sorted/filtered list to the code that then processes the ip filter regex? | |
| 01:15:03 | dansmith | mriedem: I'm not sure I understand.. that filtering code is in the api, right? we shouldn't be changing what it sees | |
| 01:15:14 | mriedem | yeah i just haven't gotten there yet | |
| 01:15:22 | dansmith | okay | |
| 01:15:27 | mriedem | this is all basically a shim in between the db api and that code that processes the result and filters by ip regex | |
| 01:15:28 | mriedem | ok | |
| 01:15:36 | dansmith | right | |
| 01:15:49 | dansmith | a multiplexing layer that doesn't eff up the sort order like what we had before | |
| 01:20:04 | mriedem | ok just some nits in the mega marker paging patch, which can go at the end, otherwise +2 | |
| 01:20:07 | mriedem | my work here is done | |
| 01:20:20 | dansmith | cool thanks I'll take a look in a sec | |
| 01:33:19 | openstackgerrit | Dan Smith proposed openstack/nova master: Fix minor input items from previous patches https://review.openstack.org/506416 | |
| 01:49:22 | dansmith | melwitt: they work with desc too, will push a test variant at the end | |
| 01:49:41 | mriedem | hey, don't forget to read the ML before bed | |
| 01:49:48 | mriedem | there is a surprise | |
| 01:50:20 | openstackgerrit | Dan Smith proposed openstack/nova master: Fix minor input items from previous patches https://review.openstack.org/506416 | |
| 01:50:28 | dansmith | mriedem: the mogan stuff? | |
| 01:50:32 | dansmith | melwitt: ^ | |
| 01:50:42 | mriedem | no | |
| 01:50:44 | mriedem | better | |
| 01:50:50 | mriedem | an old set of friends | |
| 01:50:54 | mriedem | coming together at last | |
| 01:51:09 | melwitt | dansmith: cool, thanks | |
| 01:52:31 | melwitt | I was thinking between the tests earlier in the series to now, everything stitches together, but wasn't totally sure | |
| 01:52:59 | dansmith | melwitt: yeah, I think it's all the same enough that it wouldn't matter, but good to have them in there | |
| 01:54:37 | melwitt | lol mriedem | |
| 01:55:22 | dansmith | oh, the shelve and file injection thing? | |
| 01:55:28 | mriedem | yeah | |
| 01:55:42 | mriedem | oh come on | |
| 01:55:53 | melwitt | I chuckled | |
| 01:55:56 | mriedem | shelve is one of my most favorite things to shit on in the ML on a semi-monthly basis | |
| 01:56:05 | mriedem | melwitt: you said you "lol"ed | |
| 01:56:14 | melwitt | I chuckled out loud | |
| 01:56:28 | mriedem | ok | |
| 01:56:29 | melwitt | a chuckle is a laugh right? | |
| 01:56:32 | dansmith | issubclass('chuckle', 'laugh') == True | |
| 01:56:36 | mriedem | ok | |
| 01:56:41 | melwitt | haha yeeeah | |
| 01:56:41 | mriedem | didn't know the rules | |
| 01:56:48 | dansmith | rules ^ | |
| 01:56:58 | mriedem | you know, | |
| 01:57:09 | mriedem | if we allowed you to just specify personality files on unshelve... | |