Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-09-13
20:48:20 melwitt yeah, I was thinking the same. the functional env is a direct ostestr call tho
20:48:22 mtreinish with quotes it treats posargs as a single arg which breaks for something like --regex foo
20:48:34 mtreinish which needs to be 2 args for argparse to understand it
20:49:07 mtreinish hmm, I'm not sure if that fixes the capture fixtures though. I saw things outside the capture in a local run
20:49:30 melwitt it worked for what I'm working on (wherein I added a couple of print statements)
20:49:53 mtreinish melwitt: ah ok, maybe it was just something else then
20:49:54 melwitt gonna try running -efunctional with a regex to see if that is okay
20:49:59 mtreinish ok
20:50:09 dansmith mikal: this might be a good set for your special list: https://review.openstack.org/#/c/502152
20:50:24 dansmith mikal: the unregister.* ones
20:52:53 mikal dansmith: I live to obey
20:54:00 openstackgerrit Merged openstack/nova master: Move execs of tee to privsep. https://review.openstack.org/489438
20:57:26 mriedem dtantsur|afk: TheJulia: are we going nova/ironic in our room? (Ballroom A)
20:57:31 mriedem s/going/doing/
20:59:19 dansmith cdent: why do you need to move the custom namespace thing in this patch? https://review.openstack.org/#/c/502155/3
20:59:30 dansmith oh sorry, I can read
20:59:34 cdent import loop
20:59:51 cdent i hadn’t done it, and then the tests blew up and trying to fix it uncovered that
21:00:52 melwitt mtreinish: I commented on the review
21:01:38 mtreinish melwitt: yeah, I saw that I'm pushing a new rev to answer mikal's complaints and fix the quotes on functional tests
21:02:15 melwitt mtreinish: oh cool. also on api-samples I would think
21:03:03 mtreinish yep
21:03:32 openstackgerrit Matthew Treinish proposed openstack/nova master: Fix test runner config issues with os-testr 1.0.0 https://review.openstack.org/503811
21:03:49 mtreinish melwitt: ^^^ I think that should work, I accidently did tox -r so the tests are still waiting
21:03:53 mtreinish for me locally
21:04:08 mtreinish mikal: ^^^ test that and see if you still want to stab me
21:05:58 melwitt stestr: error: invalid choice: 'nova.tests.unit.test_profiler' (choose from 'run', 'list', 'slowest', 'failing', 'last', 'init', 'load')
21:10:21 openstackgerrit Eric Fried proposed openstack/nova master: WIP: dac_admin.openfile context manager https://review.openstack.org/503823
21:11:27 mtreinish melwitt: yeah I forgot to add run after stestr
21:11:30 mtreinish one sec
21:12:01 openstackgerrit Lee Yarwood proposed openstack/nova stable/pike: Move hash ring initialization to init_host() for ironic https://review.openstack.org/502082
21:12:21 openstackgerrit Matthew Treinish proposed openstack/nova master: Fix test runner config issues with os-testr 1.0.0 https://review.openstack.org/503811
21:12:27 mtreinish melwitt: ^^^
21:15:59 mtreinish melwitt: it works for me locally
21:16:14 melwitt yeah, working for me too. thanks
21:17:50 mtreinish melwitt: and a bonus with that patch is if you do tox -epy27 -- --no-discover nova.tests.unit.test_utils it will save some time because it will skip discovery
21:18:31 mtreinish well, at least for the second run. the osprofiler thing will still do discovery
21:18:41 mtreinish oh, actually I can add that flag and make that a bit faster
21:18:56 mtreinish I'll do that in a follow up though to land the fix faster
21:19:09 melwitt yeah, it's a bummer to have osprofiler run first for me, bc I usually just ctrl-c that part
21:19:50 bauzas long known rant about osprofiler :)
21:19:58 bauzas I'd love to just skip it
21:20:12 bauzas so I just modify tox.ini when it bummers me
21:20:19 melwitt yeah. I dunno why it's in there. does the gate do anything with it?
21:20:21 mtreinish melwitt: let me push a patch on top I can make it a bit better now that tox.ini uses stestr directly
21:20:22 bauzas but I haven't yet had the guts to kill it
21:21:15 bauzas melwitt: good question, honestly it's about making sure we don't regress performance-wise, so I'd say worth having it a separate target and job
21:21:26 med_ dansmith, you have to pass this flag in ceph to delete a pool... so it's not just nova... "ceph osd pool delete {pool-name} [{pool-name} --yes-i-really-really-mean-it]"
21:21:50 bauzas for some unknown reason, we added it to the py27 target (probably for a good reason tho )
21:22:22 melwitt mtreinish: --no-discover is cool, thanks for the hint
21:22:39 bauzas mtreinish: +2d as well, but I'm tempted to wait for the jobs to finish before +Wing it, thoughts?
21:23:28 melwitt yeah, I think waiting for the jenkins vote is fine
21:23:40 mtreinish bauzas: yeah it's find to wait
21:23:57 openstackgerrit Matthew Treinish proposed openstack/nova master: Cleanup running of osprofiler tests https://review.openstack.org/503831
21:24:18 mtreinish melwitt, bauzas: ^^^ see if that makes osprofiler a bit less annoying for you
21:24:35 mtreinish although I'd be totally down with deleting it, not sure what value it actually brings
21:24:53 melwitt yeah, I don't know the history on that either
21:26:12 cdent melwitt, mtreinish: the performance group out of mirantis wanted to run in every project, to show that osprofiler was a thing that could be used
21:26:22 cdent that’s lost traction, I think it may be only nova where the test runs
21:26:48 mtreinish cdent: yeah I didn't see it in any other projects when I went looking
21:28:32 bauzas cdent: do you know the reason why it wasn't a separate tox target and a job ?
21:28:58 melwitt hm, there's still a quite long startup time when running with --no-discover. is it always reinstalling deps in the venv or something?
21:29:13 melwitt (not related to any of these patches)
21:29:48 mtreinish melwitt: hmm, with the second patch?
21:29:49 cdent melwitt: the process of confirming the requirements is pretty big and kind of happens twice
21:30:08 cdent once for the tox env, and then again for installing nova into the env
21:30:16 cdent i think that second one can skip
21:30:26 melwitt mtreinish: yeah. nothing to do with your patches
21:30:38 melwitt cdent: I see
21:30:58 cdent there’s room for improvement but I haven’t had a chance to look closely
21:34:33 mtreinish melwitt: fwiw, I spun up a quick test and the second patch saves ~10secs
21:34:39 mtreinish so a huge win :p
21:34:49 melwitt yeah, I just tried it too. sweet. thanks for doing that
21:42:04 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Target context when setting instance to ERROR when over quota https://review.openstack.org/503839
21:49:05 mriedem melwitt: figured out why that quota test wasn't catching the bug
21:49:10 mriedem it is the fixture
21:50:21 melwitt mriedem: yeah, I was just getting to the bottom of it too just now. the compute service defaults to cell1 and non-targeted DB access also defaults to cell1
21:51:30 melwitt in general when I've wanted to make sure multi cell works, I've written a functional test with two cells and made each instance land per cell and then assert things after that. I should have done it in this case too
21:52:02 melwitt because the default thing in the unit tests makes it act like single cell I guess
21:52:35 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Target context when setting instance to ERROR when over quota https://review.openstack.org/503839
21:52:41 mriedem yeah ^
21:52:47 mriedem if you remove the fix, that shows the failure
21:52:59 mriedem melwitt: this isn't even multi-cell
21:53:13 mriedem this is just our cell db fixture lying for us
21:53:31 melwitt yeah, okay
21:56:30 mtreinish dansmith: if you were curious (which I know you aren't): http://stestr.readthedocs.io/en/latest/MANUAL.html#combining-test-results and http://stestr.readthedocs.io/en/latest/MANUAL.html#running-tests describe those options I was using
22:06:17 dansmith mtreinish: cool
22:08:17 melwitt mriedem: I wonder if we should just make sure default compute cell != default cell when untargeted in nova/test.py
22:08:38 melwitt because that also makes the test fail with InstanceNotFound. if I make default=True for cell2 instead of cell1
22:10:17 openstackgerrit Merged openstack/nova master: Fix missed chown call https://review.openstack.org/503079
22:10:36 openstackgerrit Chris Dent proposed openstack/nova master: WIP: [placement] POST /allocations to set allocations for >1 consumers https://review.openstack.org/500073
22:10:42 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Removing versioning from resource_provider objects https://review.openstack.org/502164
22:10:43 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Unregister the ResourceProviderList object https://review.openstack.org/502162
22:10:43 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Unregister the ResourceProvider object https://review.openstack.org/502163
22:10:44 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Unregister the Inventory object https://review.openstack.org/502161
22:10:45 openstackgerrit Chris Dent proposed openstack/nova master: Move project_id and user_id to Allocation object https://review.openstack.org/500410
22:10:45 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Unregister the InventoryList object https://review.openstack.org/502160
22:10:46 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Unregister the AllocationList object https://review.openstack.org/502158
22:10:47 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Unregister the UsageList object https://review.openstack.org/502156
22:10:47 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Unregister the Allocation object https://review.openstack.org/502159

Earlier   Later