| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-09-08 | |||
| 08:59:53 | bauwser | jsheeren: you can't do that directly, you'll require an API microversion | |
| 09:00:22 | jsheeren | ah | |
| 09:00:50 | bauwser | jsheeren: I'll provide some comments to that, but the fix will require a Nova spec that will desribe the API change as we need to keep a consistent behaviour for our API | |
| 09:01:01 | jsheeren | ok, thanks | |
| 09:35:35 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix the ocata config-reference URLs https://review.openstack.org/502017 | |
| 10:43:40 | stephenfin | bauwser, gibi: Could you folks look at https://review.openstack.org/#/c/501342/, please? | |
| 10:54:41 | gibi | stephenfin: looking... | |
| 11:06:00 | openstackgerrit | Chenghui Yu proposed openstack/nova-specs master: Fix usage of method isotime https://review.openstack.org/502043 | |
| 11:37:12 | gibi | stephenfin: I left some comments in https://review.openstack.org/#/c/501342/ | |
| 11:43:32 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/pike: reno: note that custom resources are not supported https://review.openstack.org/500521 | |
| 12:15:46 | openstackgerrit | Elod Illes proposed openstack/nova master: Transform aggregate.add_host notification https://review.openstack.org/396210 | |
| 12:23:38 | openstackgerrit | Lajos Katona proposed openstack/nova master: Extend ServerMovingTests with custom resources https://review.openstack.org/497399 | |
| 12:58:35 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform servergroup.delete notification https://review.openstack.org/483902 | |
| 13:01:21 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform servergroup.delete notification https://review.openstack.org/483902 | |
| 13:09:08 | mriedem | sdague: you want to take a gander at this osc-placement plugin post_test_hook change to run functional dsvm tests? https://review.openstack.org/#/c/452122/ - it's modeled after the one in novaclient, with a couple of odd differences for env vars which i don't quite follow, but don't seem to be a problem either | |
| 13:09:57 | sdague | mriedem: +A | |
| 13:10:06 | mriedem | are you core on project-config? | |
| 13:10:08 | sdague | yes | |
| 13:10:15 | mriedem | well do i have a deal for you | |
| 13:10:22 | sdague | :) | |
| 13:10:24 | mriedem | https://review.openstack.org/#/c/501884/ | |
| 13:10:31 | mriedem | moves that functional job from experimental to non-voting check | |
| 13:10:51 | sdague | cool | |
| 13:10:59 | sdague | now, we just need zuul to come back online | |
| 13:11:15 | openstackgerrit | Matthew Booth proposed openstack/nova master: fake_notifier: Refactor wait_for_versioned_notification https://review.openstack.org/489637 | |
| 13:16:58 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Transform instance.resize.error notifications https://review.openstack.org/417882 | |
| 13:20:01 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Split flavors docs into admin and user guides https://review.openstack.org/501342 | |
| 13:20:01 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Add documentation for emulator_thread_policy https://review.openstack.org/501721 | |
| 13:20:02 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Add documentation for cpu_realtime, cpu_realtime_mask https://review.openstack.org/502056 | |
| 13:21:23 | stephenfin | gibi: All good point. Addressed above ^ | |
| 13:22:00 | stephenfin | tbh, that whole section needs a thorough looking over. I'll do it after the PTG but this is a good start | |
| 13:27:59 | gibi | stephenfin: totally agree. this is a good start so I'm +2 | |
| 13:29:00 | stephenfin | Excellent, thanks gibi :) | |
| 13:37:09 | mriedem | johnthetubaguy: policy question on scope checking, | |
| 13:37:24 | mriedem | this is something that continues to confuse me about whether or not non-admins can see extra specs for a flavor | |
| 13:37:46 | mriedem | "os_compute_api:os-flavor-extra-specs:index": "rule:admin_or_owner" | |
| 13:37:46 | mriedem | default policy is admin or owner | |
| 13:38:09 | mriedem | but when we check the scope, we don't pass the flavor in, and the flavor doesn't have a user_id/project_id (owner) anyway | |
| 13:38:38 | mriedem | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/flavors_extraspecs.py#L53 | |
| 13:38:57 | mriedem | so it's unclear to me if a non-admin can by default view flavor extra specs | |
| 13:43:01 | johnthetubaguy | mriedem: just reading back your note | |
| 13:44:24 | johnthetubaguy | mriedem: we have a default target of {project_id: context.project_id, user_id:context.user_id}, basically making the scope check a no op | |
| 13:45:15 | johnthetubaguy | mriedem: well my no-op I mean always returns true | |
| 13:45:21 | johnthetubaguy | s/my/by/ | |
| 13:45:41 | mriedem | ok so basically anyone can view flavor extra specs by default | |
| 13:47:21 | johnthetubaguy | mriedem: it seems that way, I am just checking the DB code | |
| 13:48:42 | johnthetubaguy | mriedem: it looks like we join extra_specs for everyone here: https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L5017 | |
| 13:49:15 | mriedem | yup | |
| 13:49:26 | mriedem | well, if the flavor is in a cell still, but yeah | |
| 13:49:44 | mriedem | https://github.com/openstack/nova/blob/master/nova/objects/flavor.py#L295 is the new hotness | |
| 13:50:23 | johnthetubaguy | mriedem: oh right, we only hit the other for the unmigrated (probably no one) case | |
| 13:50:52 | mriedem | yeah we can remove that old compat now https://review.openstack.org/#/c/460377/ | |
| 13:50:58 | mriedem | but anyway, that answers my question | |
| 13:51:08 | johnthetubaguy | I see what you did there | |
| 13:51:12 | mriedem | :) | |
| 13:51:18 | mriedem | it was not subtle | |
| 13:51:27 | johnthetubaguy | effective though | |
| 13:51:38 | mriedem | i'm getting some questions about extra specs vs scheduler hints and thinking about things like what is discoverable etc | |
| 13:52:12 | mriedem | and now that i think about it, we really have no discoverable way for an end user to know what scheduler hints are available in a nova installation do we | |
| 13:52:22 | johnthetubaguy | I know sfinucan once expressed and interest doing an image meta like thing for extra specs | |
| 13:52:28 | mriedem | i assume we have just always relied on clouds to document what they support for scheduler hints | |
| 13:52:29 | openstackgerrit | Merged openstack/osc-placement master: tests: add a hook for functional testing in the gate https://review.openstack.org/452122 | |
| 13:53:12 | johnthetubaguy | yeah, we did talk about getting alaski to look at a way to discover available scheduler hints, so we could do API validation on them | |
| 13:53:27 | mriedem | we == rackspace? | |
| 13:53:28 | johnthetubaguy | like have filters and weights register what they support, etc | |
| 13:53:41 | johnthetubaguy | we as in upstream years ago | |
| 13:53:49 | johnthetubaguy | in some summit session | |
| 13:53:50 | mriedem | ok | |
| 13:53:52 | mriedem | we have https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/scheduler_hints.py | |
| 13:54:03 | mriedem | but the hints in there might not be enabled in the filters, | |
| 13:54:04 | mikal | Do I really have to get up? Or can I just go back to bed? | |
| 13:54:06 | mriedem | and you can load your own | |
| 13:54:17 | johnthetubaguy | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/scheduler_hints.py#L67 | |
| 13:54:17 | mriedem | mikal: just work from bed | |
| 13:54:19 | johnthetubaguy | yeah | |
| 13:54:20 | mriedem | like a monarch | |
| 13:54:31 | mriedem | king mikal | |
| 13:55:20 | mikal | mriedem: I can't. I have to go to a big room in the urine district and call people liars | |
| 13:55:39 | mikal | mriedem: its a community service that I offer | |
| 13:56:01 | mriedem | so you're going to go yell at people in a public bathroom? | |
| 13:56:10 | mriedem | i'm unclear on what australians refer to as "the urine district" | |
| 13:56:23 | mikal | mriedem: the urine district is a region of San Francisco | |
| 13:56:29 | mriedem | oh i see | |
| 13:56:29 | mikal | mriedem: most of the city as best as I can tell | |
| 13:56:44 | mriedem | that's less interesting | |
| 13:57:02 | johnthetubaguy | I remember a smell there, but I just hoped it was chlorine in the water with lots of water sprinkler or something | |
| 13:58:15 | mikal | johnthetubaguy: ummm, no | |
| 13:58:29 | mikal | johnthetubaguy: also, don't ask why the BART escalators don't work, and definitely don't touch them | |
| 13:58:42 | johnthetubaguy | mikal: ...true | |
| 13:58:45 | stephenfin | Yay, johnthetubaguy is back | |
| 13:58:59 | mikal | johnthetubaguy: http://www.sfgate.com/bayarea/article/Human-waste-shuts-down-BART-escalators-3735981.php | |
| 13:59:04 | johnthetubaguy | yeah, I am around, now an then :) | |
| 14:01:06 | gibi | bauwser: you were +2 on this patch before, do you still like it? https://review.openstack.org/#/c/498596 | |
| 14:01:12 | sdague | johnthetubaguy: the discoverable bit there was kicked around | |
| 14:01:22 | sdague | but it was all a concept conversation | |
| 14:01:54 | bauwser | gibi: sure, I just have a shit of paperwork coming in litterally by the day before I'm traveling to the PTG, yay \o/ | |
| 14:02:21 | johnthetubaguy | sdague: that sounds right | |
| 14:03:03 | gibi | bauwser: sorry to hear that. Don't worry about that patch now. I can ping you during the PTG | |
| 14:03:18 | bauwser | gibi: no, I just briefly reviewed it, +Wd | |
| 14:03:32 | bauwser | the modifications weren't that huge | |