Posted	Nick	Remark
#openstack-nova - 2017-09-07
20:02:38	mtreinish	mriedem: +2
20:03:04	mtreinish	although I wonder how much the tls-proxy is used now. As things move to use uwsgi the standalone proxy isn't used anymore
20:12:14	openstackgerrit	Matt Riedemann proposed openstack/nova-specs master: Add spec to use cinder's new attachment API https://review.openstack.org/497552
20:16:22	ildikov	mriedem: thanks ^^
20:16:57	mriedem	ildikov: johnthetubaguy found the same thing i did in https://review.openstack.org/#/c/493323/
20:18:45	ildikov	mriedem: I bumped the version for all the calls to 3.44 in the attach patch
20:19:50	mriedem	that's not clear here, it wasn't called out in the commit message, and it would probably just be cleaner if we did it in this change
20:20:12	ildikov	mriedem: I got lost on the newer version note in the review though
20:20:30	mriedem	mine?
20:20:31	ildikov	I was debating where to do it and thought to try to keep the patches clean
20:20:47	mriedem	i noticed the skip_version_check=True thing,
20:20:55	mriedem	which is wrong here, as i noted
20:21:20	ildikov	because I haven't bumped all versions?
20:21:41	mriedem	i'd just bump the version for attachment_create to be 3.44 as john pointed out, update whatever unit tests and make a comment about it in the commit message that we need the minimum microversion for creating the attachment to equal the microversoin needed for complete
20:21:57	mnaser	abaranov https://review.openstack.org/#/c/501820/1 looks lik ethis failed somewhere along the line
20:22:05	mnaser	it doesnt seem unrelated but does anyone know the bug # offhand
20:22:12	ildikov	mriedem: that's what I planned to do
20:23:21	mriedem	mnaser: unrelated, just recheck it
20:23:26	ildikov	mriedem: as I said, I had two choices on where to bump and I chose what seemed cleaner to me, but agree with this variation too so will change when I get there later today
20:23:31	mnaser	done, ty
20:23:53	mriedem	mnaser: btw, wanted to ask, how do you pick up changes from stable branches? do you wait for a release or just pull from the branch?
20:24:03	mnaser	mriedem rdo trunk stable builds
20:24:14	mriedem	ok so don't wait for release
20:24:20	mnaser	in cases like this, no
20:24:32	mriedem	do you patch rpms until the changes are merged upstream then?
20:24:51	mnaser	in very urgent scenarios yes, with puppet after the rpm is installed (not pretty)
20:25:00	mnaser	but for the most we try to get it into stable branch asap and then deploy those packages
20:25:11	mriedem	yeah
20:25:52	mriedem	dansmith: these stable backports are up when you've got the time https://review.openstack.org/#/q/topic:bug/1715462+branch:stable/pike
20:26:05	mriedem	mtreinish: could you also go through these ^ ?
20:26:11	mriedem	nasty regressions for pike
20:26:21	mriedem	and we're short on stable cores atm
20:26:29	mriedem	that aren't in europe anyway
20:29:46	openstackgerrit	Merged openstack/nova-specs master: Add spec to use cinder's new attachment API https://review.openstack.org/497552
20:41:13	mtreinish	mriedem: sure, I'll take a look
21:00:50	openstackgerrit	Merged openstack/nova master: Make eventlet hub use a monotonic clock https://review.openstack.org/434327
21:14:42	openstackgerrit	Matt Riedemann proposed openstack/nova master: Drop support for the Cinder v2 API https://review.openstack.org/501874
21:15:10	smcginnis	Woot! ^
22:05:01	openstackgerrit	Eric Fried proposed openstack/nova master: Use ksa adapter for placement conf & requests https://review.openstack.org/492247
22:05:02	openstackgerrit	Eric Fried proposed openstack/nova master: nova.utils.get_ksa_adapter() https://review.openstack.org/488137
22:09:09	openstackgerrit	Ildiko Vancsa proposed openstack/nova master: Add attachment_complete call to volume/cinder.py https://review.openstack.org/493323
22:09:10	openstackgerrit	Ildiko Vancsa proposed openstack/nova master: Tweak connection_info translation for the new Cinder attach/detach API https://review.openstack.org/493324
22:09:11	openstackgerrit	Ildiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285
22:19:04	openstackgerrit	Merged openstack/nova master: Transform keypair.delete notification https://review.openstack.org/463946
22:26:04	openstackgerrit	Eric Fried proposed openstack/nova master: Use ksa adapter for placement conf & requests https://review.openstack.org/492247
22:27:59	cdent	efried: I don’t think you are being sufficiently critical of yourself in your comments
22:28:32	efried	cdent I know what I mean, and I'm VICIOUS.
22:28:42	cdent	:)
22:38:28	openstackgerrit	Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766
22:39:35	openstackgerrit	Eric Fried proposed openstack/nova master: Get auth from context for glance endpoint https://review.openstack.org/490057
22:51:09	openstackgerrit	Ildiko Vancsa proposed openstack/nova master: Add attachment_complete call to volume/cinder.py https://review.openstack.org/493323
22:51:10	openstackgerrit	Ildiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285
22:51:10	openstackgerrit	Ildiko Vancsa proposed openstack/nova master: Tweak connection_info translation for the new Cinder attach/detach API https://review.openstack.org/493324
#openstack-nova - 2017-09-08
00:46:09	openstackgerrit	Merged openstack/nova stable/pike: Allow setting up multiple cells in the base TestCase https://review.openstack.org/501818
00:48:57	openstackgerrit	Merged openstack/nova stable/pike: Make ConductorTaskTestCase run with 2 cells https://review.openstack.org/501819
00:50:05	openstackgerrit	Takashi NATSUME proposed openstack/nova-specs master: Enable cold migration with target host https://review.openstack.org/489031
00:52:19	openstackgerrit	Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483
00:52:52	openstackgerrit	Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.54 - List/Show all server migration types https://review.openstack.org/430839
01:53:21	openstackgerrit	liusheng proposed openstack/nova master: Correct the out-of-date flavor doc reference https://review.openstack.org/501921
02:17:19	openstackgerrit	Merged openstack/nova master: Fix broken URLs https://review.openstack.org/501402
02:35:39	openstackgerrit	Shunli Zhou proposed openstack/nova master: Transform servergroup.create notification https://review.openstack.org/454023
02:52:20	openstackgerrit	Philip Choi proposed openstack/nova master: Add warning message for cache_utils connection failure https://review.openstack.org/501928
02:56:56	openstackgerrit	Philip Choi proposed openstack/nova master: Add warning message for cache_utils connection failure https://review.openstack.org/501928
03:04:17	openstackgerrit	kangyufei proposed openstack/nova master: Typo error about help resource_classes.inc https://review.openstack.org/501930
03:25:49	mnaser	https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/pike+topic:bug/1715462 -- everything is finally passing, appreciate a review from anyone on the stable team to get this pike bug fixed :>
03:54:17	openstackgerrit	Michael Still proposed openstack/nova master: Remove two testing stubs which aren't really needed. https://review.openstack.org/501939
03:57:18	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955
04:31:27	openstackgerrit	Michael Still proposed openstack/nova master: Cleanup unused get_iscsi_initiator. https://review.openstack.org/501944
05:34:12	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964
05:59:46	openstackgerrit	Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.54 - Enable cold migration with target host https://review.openstack.org/406707
06:33:06	openstackgerrit	Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042
06:49:34	openstackgerrit	Takashi NATSUME proposed openstack/nova-specs master: Abort Cold Migration https://review.openstack.org/334732
08:19:06	jsheeren	hi all, i'm curious as to why no special characaters like a dot (.) are allowed for the ssh keypair names
08:19:24	jsheeren	if i check the code: safe_chars = "_- " + string.digits + string.ascii_letters
08:19:46	jsheeren	does anyone have an idea as to why?
08:29:37	openstackgerrit	Hironori Shiina proposed openstack/nova master: virt/ironic: Implement rescue and unrescue https://review.openstack.org/416487
08:34:33	bauwser	jsheeren: here, I'm just guessing, but if you look at https://github.com/openstack/nova/commit/ec0a65d81fd11d26be77b45827a4dd7c77711675 it seems that's because AWS was only accepting that
08:35:11	bauwser	since we did cut the EC2 API previously, I don't think it's still a problem
08:49:43	ygl	hi all
08:49:51	ygl	i need some help
08:49:53	openstackgerrit	Rick van de Loo proposed openstack/nova master: Allow dots in keypair filenames https://review.openstack.org/502000
08:59:24	jsheeren	bauwser: thanks, Rick proposed a patch that fixes our issue. :-)
08:59:53	bauwser	jsheeren: you can't do that directly, you'll require an API microversion
09:00:22	jsheeren	ah
09:00:50	bauwser	jsheeren: I'll provide some comments to that, but the fix will require a Nova spec that will desribe the API change as we need to keep a consistent behaviour for our API
09:01:01	jsheeren	ok, thanks
09:35:35	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Fix the ocata config-reference URLs https://review.openstack.org/502017
10:43:40	stephenfin	bauwser, gibi: Could you folks look at https://review.openstack.org/#/c/501342/, please?
10:54:41	gibi	stephenfin: looking...
11:06:00	openstackgerrit	Chenghui Yu proposed openstack/nova-specs master: Fix usage of method isotime https://review.openstack.org/502043
11:37:12	gibi	stephenfin: I left some comments in https://review.openstack.org/#/c/501342/
11:43:32	openstackgerrit	Balazs Gibizer proposed openstack/nova stable/pike: reno: note that custom resources are not supported https://review.openstack.org/500521
12:15:46	openstackgerrit	Elod Illes proposed openstack/nova master: Transform aggregate.add_host notification https://review.openstack.org/396210
12:23:38	openstackgerrit	Lajos Katona proposed openstack/nova master: Extend ServerMovingTests with custom resources https://review.openstack.org/497399
12:58:35	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Transform servergroup.delete notification https://review.openstack.org/483902
13:01:21	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Transform servergroup.delete notification https://review.openstack.org/483902
13:09:08	mriedem	sdague: you want to take a gander at this osc-placement plugin post_test_hook change to run functional dsvm tests? https://review.openstack.org/#/c/452122/ - it's modeled after the one in novaclient, with a couple of odd differences for env vars which i don't quite follow, but don't seem to be a problem either
13:09:57	sdague	mriedem: +A
13:10:06	mriedem	are you core on project-config?
13:10:08	sdague	yes

Earlier   Later