| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-09-07 | |||
| 13:10:11 | mriedem | needs another +2 | |
| 13:12:06 | stephenfin | mriedem: Yup, looks grand to me | |
| 13:12:17 | efried | 'cept for the typos | |
| 13:13:46 | stephenfin | efried: If you're brave enough to -1 it for that, I'll give you a cookie :P | |
| 13:13:59 | stephenfin | efried: mriedem might give you something else though | |
| 13:14:09 | efried | I only -1 for typos in docs | |
| 13:14:20 | efried | ("typo's in doc's"?) | |
| 13:14:35 | stephenfin | Yup, likewise. I kid :) | |
| 13:18:58 | mikal | stephenfin: yeah, I think we could take another pass at that now | |
| 13:18:59 | sahid | stephenfin: https://review.openstack.org/#/c/501721/2 the explnation does not make a lot of sense | |
| 13:20:24 | stephenfin | sahid: Yup, good call. I'll rework shortly | |
| 13:20:32 | bauzas | sahid: I tend to fast-approve doc changes but it helps, but feel free to open a follow-up and I'll review it | |
| 13:20:49 | bauzas | s/but/because | |
| 13:20:50 | stephenfin | bauzas, sahid: It's actually blocked by a base patch so it won't merge :/ | |
| 13:21:04 | bauzas | stephenfin: ack, then push another rev and I'll +2 | |
| 13:21:12 | stephenfin | +2 to fast-approving docs too. Fast iteration is really helpful | |
| 13:21:28 | bauzas | I mean, doc bugs don't hurt | |
| 13:21:45 | bauzas | while doc amendments really help | |
| 13:21:48 | stephenfin | Well, not as much as no docs does | |
| 13:21:57 | bauzas | yup that | |
| 13:22:21 | bauzas | unless of course if you state in the doc something like "rm -rf /" | |
| 13:22:59 | sdague | mikal: ok, looking | |
| 13:23:31 | stephenfin | mikal: Sweet. I'll revive that shortly so | |
| 13:24:40 | bauzas | mriedem: new school year, new constraints. I'll need to bail out from the nova meeting around 1420UTC (ie. 20 mins after you start= | |
| 13:24:56 | bauzas | but I should be back 20 mins after | |
| 13:25:26 | bauzas | hopefully the daylight shift will solve the problem in a couple of weeks :) | |
| 13:25:42 | mriedem | ok | |
| 13:33:25 | openstackgerrit | Andreas Jaeger proposed openstack/nova master: Fix broken URLs https://review.openstack.org/501402 | |
| 13:33:54 | sdague | mikal: https://review.openstack.org/#/c/489486 ... that needs some more explaining, the the cryptsetup add isn't clear to me | |
| 13:37:54 | dansmith | mriedem: you going to fix the typo in that second one or just steam on? | |
| 13:38:04 | mriedem | doing it now | |
| 13:38:14 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Make ConductorTaskTestCase run with 2 cells https://review.openstack.org/501514 | |
| 13:38:14 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Track which cell each instance is created in and use it consistently https://review.openstack.org/501452 | |
| 13:38:15 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Ensure instance mapping is updated in case of quota recheck fails https://review.openstack.org/501408 | |
| 13:39:31 | mriedem | alex raised a good question here https://review.openstack.org/#/c/501408/8/nova/conductor/manager.py@1049 | |
| 13:40:06 | mriedem | in that if the build request is already deleted after we create the instance in the cell but before we actually send the instance to the host to build, we cleanup the instance (local delete) but don't cleanup dest node allocations | |
| 13:40:34 | mriedem | separate bug, but a bug nonetheless | |
| 13:41:01 | mikal | sdague: so I need a reno when I remove a command from rootwrap's filters? Or only when I add one? | |
| 13:41:04 | openstackgerrit | Merged openstack/nova master: Fix test_rpc_consumer_isolation for oslo.messaging 5.31.0 https://review.openstack.org/501400 | |
| 13:42:20 | sdague | the adds are the critical bit. That's a config file which won't work if you don't add those lines | |
| 13:42:29 | sdague | if people left old things around, meh | |
| 13:43:07 | openstackgerrit | Andreas Jaeger proposed openstack/nova master: Fix broken URLs https://review.openstack.org/501402 | |
| 13:43:38 | mriedem | who wants to look at https://review.openstack.org/#/c/501514/ and up? regression in pike that needs to be backported | |
| 13:43:42 | mriedem | vexxhost hit it yesterday | |
| 13:44:08 | jaypipes | mriedem: just FYI, we're evacuating this evening so I'll be OOO tomorrow and part of this afternoon. | |
| 13:44:23 | mriedem | jaypipes: ok, good luck | |
| 13:44:25 | jaypipes | mriedem: and I do mean evacuate, not rebuild. | |
| 13:44:29 | sdague | mikal: the general rule of thumb, assume someone is upgrading with pip install -U on the commit. Do they need to do something besides that to have usable environment | |
| 13:44:39 | mriedem | jaypipes: i hear ohio still has room for you | |
| 13:44:44 | mriedem | if you'll take it back | |
| 13:44:47 | jaypipes | mriedem: that's where we're headed. | |
| 13:45:04 | mriedem | nice | |
| 13:45:15 | mriedem | just in time for your beloved browns season to begin | |
| 13:45:22 | sdague | jaypipes: well, that means jeni's icecream when you arrive | |
| 13:45:24 | dansmith | jaypipes: good luck | |
| 13:45:30 | jaypipes | sdague: heh :) | |
| 13:45:43 | jaypipes | dansmith: thx. still smoldering where you are? | |
| 13:45:56 | dansmith | jaypipes: yeah | |
| 13:45:58 | sdague | jaypipes: we stopped in columbus north market on our drive to TN for the eclipse. Could not leave without some jeni's | |
| 13:46:14 | sdague | jaypipes: safe travels | |
| 13:46:21 | jaypipes | sdague: indeed. Jeni's is awesome. Graeters is also very good :) | |
| 13:46:26 | jaypipes | sdague: thx | |
| 13:46:36 | jaypipes | dansmith: how close to you are the fires? | |
| 13:46:54 | sdague | jaypipes: we going to see you in CO still? | |
| 13:47:08 | dansmith | jaypipes: the fires are at portland's watershed, if that tells you, but that's like 15 miles by the crow I think | |
| 13:49:03 | kashyap | dansmith: "by the crow" == shortest path I presume? | |
| 13:49:25 | dansmith | kashyap: yes, as in "as the crow flies" | |
| 13:49:30 | dansmith | apparently crows fly in straight lines | |
| 13:49:32 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Provide hints when nova-manage db sync fails to sync cell0 https://review.openstack.org/501745 | |
| 13:49:36 | kashyap | Yeah, I recall hearing that, just wanted to double-check :-) | |
| 13:49:47 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Provide hints when nova-manage db sync fails to sync cell0 https://review.openstack.org/501746 | |
| 13:49:48 | kashyap | Oh dear, the wildfire looks insane | |
| 13:50:44 | gibi | mriedem: hi! Is it OK for you If I rebase your patch https://review.openstack.org/#/c/498596 as mine top of it need to be adapted to a test case from master ? | |
| 13:56:33 | mriedem | gibi: sure | |
| 13:57:13 | mriedem | gibi: you were +1 on https://review.openstack.org/#/c/499718/ are you OK with it? sylvain is +2 and i'd like to move that series along as it's a regression that needs to be backported | |
| 13:57:37 | gibi | mriedem: looking... | |
| 13:57:53 | mriedem | looks like we need to talk about the other comments higher up the stack at some point too | |
| 13:58:00 | mriedem | after the meeting | |
| 13:58:16 | gibi | mriedem: yes, let's agree on the way forward with that series | |
| 14:00:08 | jaypipes | sdague: on line with Delta right now trying to redo flights | |
| 14:00:39 | bauzas | jaypipes: crossing fingers, mate | |
| 14:02:26 | mikal | sdague: yeah in that case I think a few of the renos need tweaking | |
| 14:02:38 | mikal | sdague: I will do that during the TWO HOURS OF KEYNOTES THIS ORNING | |
| 14:10:13 | sdague | mikal: but, you could miss some critical detail about synergizing! | |
| 14:19:54 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test resource allocation during soft delete https://review.openstack.org/495159 | |
| 14:19:54 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Moving more utils to ServerResourceAllocationTestBase https://review.openstack.org/499539 | |
| 14:19:55 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor ServerMovingTests for non-move tests https://review.openstack.org/498596 | |
| 14:26:07 | mriedem | gibi: i think you can remove your -1 on https://review.openstack.org/#/c/499237/ | |
| 14:26:45 | mriedem | gibi: i also replied to https://review.openstack.org/#/c/499874/4/nova/tests/functional/test_servers.py@1817 | |
| 14:27:12 | gibi | mriedem: reading... | |
| 14:28:31 | gibi | mriedem: what can we do with your dislike about rebuild after failed evac? | |
| 14:29:34 | mriedem | not sure i understand the question | |
| 14:30:01 | mriedem | gibi: i tend to agree with your point that we should handle a failure in the conductor (NoValidHost) the same as it's being handled in the compute when a claim fails or the spawn fails on the dest node, | |
| 14:30:03 | gibi | mriedem: I agree that rebuild after failed evac is not a major use case but I know about users depending on it. So I don't really want to prevent it | |
| 14:30:11 | mriedem | which is set the migration status to a state such that _destroy_evacuated_instances on the source node doesn't process it, | |
| 14:30:15 | mriedem | and delete the dest node allocation | |
| 14:31:02 | gibi | mriedem: OK. then I think we can set the migration to failed, and then nova will not try to delete source allocation either after the source compute is brought up | |
| 14:31:04 | mriedem | gibi: given that rebuild does not allocate resources or make a claim, i think in that case it's actually preferrable to *not* attempt to delete the source node allocations if the evacuate failed, | |
| 14:31:16 | gibi | mriedem: totally agree | |
| 14:31:17 | mriedem | because if the evac fails and you want to rebuild the instance on the source node after it comes back up, then the allocations are still there | |