Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-09-06
00:43:22 openstackgerrit Matt Riedemann proposed openstack/nova stable/pike: WIP spelling error availiable change to available https://review.openstack.org/501043
00:47:27 openstackgerrit wanghongtaozz proposed openstack/nova stable/pike: spelling mistake intergration change to integration https://review.openstack.org/501047
00:47:54 alex_xu mriedem: gmann it needn't microversion, I think just just add query params validation for the exist API and keep it same behavour for the API
00:49:02 gmann alex_xu, but we are doing non negative integer for limit - https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/keypairs.py#L109
00:49:21 gmann https://github.com/openstack/nova/blob/dbfde14978d4e4374c1fc1085c7f061b2a22d2c6/nova/api/validation/parameter_types.py#L438
00:50:00 gmann alex_xu, this is only case change the behavior for 'int' 200 -> 400
00:50:01 alex_xu gmann: that isn't backward-compatible?
00:50:26 alex_xu gmann: I remember there are some validation in the python code for the limits, that should check the non-negative value also
00:51:06 gmann alex_xu, humm
00:51:15 gmann alex_xu, i found the flow like this
00:51:16 gmann 1. https://github.com/openstack/nova/blob/dbfde14978d4e4374c1fc1085c7f061b2a22d2c6/nova/api/openstack/common.py#L189
00:51:30 gmann 2. https://github.com/openstack/nova/blob/dbfde14978d4e4374c1fc1085c7f061b2a22d2c6/nova/api/openstack/common.py#L202
00:52:10 gmann 3. https://github.com/openstack/nova/blob/dbfde14978d4e4374c1fc1085c7f061b2a22d2c6/nova/utils.py#L883
00:52:26 gmann 3rd one convert the '1' to 1
00:54:23 alex_xu gmann: there is parameter 'min_value', that is limited to non-negative?
01:02:00 openstackgerrit Merged openstack/nova master: tests: Remove useless test https://review.openstack.org/483031
01:02:53 openstackgerrit Jackie Truong proposed openstack/nova master: Add trusted_certificates to REST API https://review.openstack.org/486204
01:06:47 openstackgerrit Merged openstack/nova master: Cleanup allocations on invalid dest node during live migration https://review.openstack.org/498861
01:08:21 alex_xu gmann: I may not clear the question
01:08:34 alex_xu the value of '1' will get 400?
01:09:12 openstackgerrit Merged openstack/nova master: iso8601.is8601.Utc No Longer Exists https://review.openstack.org/498287
01:14:59 openstackgerrit Chris Dent proposed openstack/nova master: WIP: [placement] POST /allocations to set allocations for >1 consumers https://review.openstack.org/500073
01:15:00 openstackgerrit Chris Dent proposed openstack/nova master: WIP: [placement] Allow _set_allocations to delete allocations https://review.openstack.org/501051
01:15:28 cdent dansmith: some of the jiggery pokery in that ^ is starting to get a bit wack
01:15:32 openstackgerrit Jackie Truong proposed openstack/python-novaclient master: Microversion 2.54 - Add trusted_certificates param https://review.openstack.org/500396
01:38:20 openstackgerrit jichenjc proposed openstack/nova master: conf: remove deprecated 'project_id_regex' opt https://review.openstack.org/501057
02:05:09 openstackgerrit jichenjc proposed openstack/nova master: conf: Remove quota_networks options https://review.openstack.org/501068
02:21:10 openstackgerrit Chenghui Yu proposed openstack/nova master: Remove usage of kwarg retry_on_request in API https://review.openstack.org/501073
04:43:58 openstackgerrit Pooja Jadhav proposed openstack/nova master: Fix ValueError if invalid max_rows passed to db purge https://review.openstack.org/500771
05:03:05 itlinux there are 4 compute nodes.. and those images are cirros..
05:11:03 itlinux hello team..
05:11:29 itlinux looks like the scheduler gets stuck when I try to spin up few machines at one time..
05:11:33 itlinux like 4 or 5
05:11:44 itlinux I have 4 compute nodes and the images are cirros
05:11:54 itlinux I checked the hypervisors are up
05:47:02 openstackgerrit jichenjc proposed openstack/nova master: Update doc to indicate nova-network deprecated https://review.openstack.org/500654
05:49:03 openstackgerrit jichenjc proposed openstack/nova master: conf: Remove quota_networks options https://review.openstack.org/501068
05:49:31 gmann alex_xu, i mean, if we pass any int as string in limit like '1' not 1, it will be 400 in current case of keypair. because of schema
05:49:44 itlinux hello nova team.. anyone has a tweak since when I spin up some vms the compute that gets like two vms takes forever..
05:49:53 itlinux like 100sec for a cirros image..
05:50:00 itlinux sounds a little too much!
05:55:30 gmann alex_xu, but when i ran it without schema it is also same(400). cannot this convert '1' -? 1 - https://github.com/openstack/nova/blob/dbfde14978d4e4374c1fc1085c7f061b2a22d2c6/nova/utils.py#L883
06:04:53 openstackgerrit jichenjc proposed openstack/nova master: conf: remove deprecated 'project_id_regex' opt https://review.openstack.org/501057
06:09:08 openstackgerrit jichenjc proposed openstack/nova master: Enhance doc for nova services https://review.openstack.org/499536
06:09:30 openstackgerrit jichenjc proposed openstack/nova master: propagate OSError to MigrationPreCheckError https://review.openstack.org/469779
06:11:30 alex_xu gmann: that schema should work with '1', not sure I missed something
06:13:43 gmann alex_xu, oh, 1 sec
06:19:22 openstackgerrit Merged openstack/nova master: Add uuid to migration object and migrate-on-load https://review.openstack.org/496934
06:40:15 openstackgerrit Merged openstack/nova master: Add uuid online migration for migrations https://review.openstack.org/498589
06:57:30 openstackgerrit Gao Zexu proposed openstack/os-traits master: Update the documentation urls https://review.openstack.org/501122
07:02:50 openstackgerrit jichenjc proposed openstack/nova master: WIP:check query param for used_limits function https://review.openstack.org/499091
07:09:59 openstackgerrit jichenjc proposed openstack/nova master: WIP:Remove quota_networks and enable_network_quota https://review.openstack.org/501068
07:11:11 jichen gmann: hi, in https://review.openstack.org/#/c/501057/2/nova/tests/unit/api/openstack/compute/test_config_drive.py, you mentioned :i like to have some uuid as project id here instead of removing.
07:11:49 jichen I think in v2.18, we have:
07:12:04 jichen 2.18 Establishes a set of routes that makes project_id an optional construct in v2.1.
07:12:20 jichen why we still need add project id in the test ?
07:21:40 gmann jichen, yea, but we do have tests to test both
07:22:28 gmann jichen, i do not have string opinion on this but i we can discuss whether it is ok to remove the project_id from tests
07:23:03 gmann jichen, its unit test only right? does it matter anywhere. i mean url is really dummy things in unit tests right
07:28:42 openstackgerrit Lajos Katona proposed openstack/nova master: Add functional migrate force_complete test https://review.openstack.org/496202
07:34:55 jichen gmann: yeah, we should have test for both..I will see whether it's possible to at least include some project id into test
07:35:34 jichen gmann: and yes, it's in unit test , but PS#1 shows a lot of error if I use /v2.1/fake/xxx, so I tried to move to /v2.1/xxx and it works locally
07:35:47 jichen so I think at least in some cases it matters :)
07:37:14 gmann jichen, can we use some dummy UUID in this change and later we decide whether to remove project-id in unit tests or not as whole
07:37:30 openstackgerrit sahid proposed openstack/os-vif master: ovs-hybrid: should permanently keep MAC entries https://review.openstack.org/501132
07:38:15 jichen ok, that's doable, I think you are saying is /v2.1/0000-0000-00000-00000/xxx (a uuid format) instead /v2.1/fake/xxx ,right?
07:38:33 gmann something like '11111111-1111- '
07:38:38 gmann jichen, yea
07:39:08 jichen gmann: ok, let me try it, thanks for comments
07:39:12 gmann jichen, thanks
07:43:59 openstackgerrit sahid proposed openstack/nova master: libvirt: add method to configure migration speed https://review.openstack.org/497456
07:43:59 openstackgerrit sahid proposed openstack/nova master: libvirt: slowly live-migration to ensure network is ready https://review.openstack.org/497457
07:44:00 openstackgerrit sahid proposed openstack/nova master: libvirt: bandwidth param should be set in guest migrate https://review.openstack.org/497455
07:50:41 openstackgerrit Merged openstack/nova master: Refactor LiveMigrationTask._find_destination https://review.openstack.org/498874
07:54:19 openstackgerrit Merged openstack/nova master: Add missing unit tests for FilterScheduler._get_all_host_states https://review.openstack.org/496803
08:08:54 openstackgerrit Lajos Katona proposed openstack/nova master: Add functional for live migrate delete https://review.openstack.org/499583
08:37:28 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: disable numa feature when virt_type is not kvm https://review.openstack.org/465160
09:41:45 stephenfin bauzas: Is my point about not using 'prelude' in reno notes correct here? https://review.openstack.org/#/c/459166/
09:42:37 bauzas stephenfin: looking
09:43:03 bauzas stephenfin: that's correct
09:43:22 bauzas stephenfin: I did a bit of writing in the doc about that
09:43:27 bauzas sec, finding it
09:43:57 bauzas (that new docs rearrangement is making me finding my kids :) )
09:44:33 bauzas stephenfin: https://docs.openstack.org/nova/latest/contributor/releasenotes.html
09:47:36 stephenfin bauzas: Perfect. I'll leave a note for mikal saying as much. Ta :)
09:47:42 bauzas stephenfin: just did
09:48:07 bauzas honestly, that privsep effort is important, so I'll see how I can help with reviews
09:49:09 stephenfin Yup, I started on that yesterday. It's getting pretty big and has been there for a while now
09:53:04 bauzas good opportunity then for understanding how privsep works :)
09:53:24 bauzas I barely understand it, but those changes will help
10:08:05 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add VersionedObjectPrintable mixin https://review.openstack.org/493082
10:17:51 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add VersionedObjectPrintable mixin https://review.openstack.org/493082
10:17:52 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add ``HostPortProfileInfo`` class https://review.openstack.org/441590
10:23:02 openstackgerrit Ghanshyam Mann proposed openstack/nova master: [WIP] Add tests for 'limit' filter as string for GET keypair API https://review.openstack.org/501202
10:31:22 openstackgerrit sahid proposed openstack/nova master: objects: add cpu_emulator_threads_mask field https://review.openstack.org/501206
10:31:22 openstackgerrit sahid proposed openstack/nova master: objects: add new field MASK for emulator threads policy https://review.openstack.org/501205
10:31:23 openstackgerrit sahid proposed openstack/nova master: hardware: handle/check emulator threads mask constraints https://review.openstack.org/501208
10:31:23 openstackgerrit sahid proposed openstack/nova master: hardware: add method to get emulator threads mask https://review.openstack.org/501207
10:31:24 openstackgerrit sahid proposed openstack/nova master: libvirt: configure emulator threads of a guest based on mask https://review.openstack.org/501210
10:31:24 openstackgerrit sahid proposed openstack/nova master: hardware: add method to compute emulator threads placement https://review.openstack.org/501209

Earlier   Later