| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-09-01 | |||
| 13:42:55 | fried_rice | Cause I think they have some of the same issues as claudiub and I do. | |
| 13:43:09 | fried_rice | that we want to make sure the new solution solves. | |
| 13:43:31 | cdent | fried_rice: yup | |
| 13:43:57 | mriedem | kashyap: http://lists.openstack.org/pipermail/openstack-dev/2017-June/117987.html | |
| 13:44:46 | kashyap | mriedem: BTW, thanks for kickstarting the cleanup of the spaghetti that is LM doc - 9c2518c2 ("Cleanup the plethora of libvirt live migration options") | |
| 13:45:47 | mriedem | yeah it's impossible | |
| 13:46:48 | kashyap | Heh, "landmine of terrible" | |
| 13:47:12 | openstackgerrit | Elod Illes proposed openstack/nova master: Functional test for regression bug #1713783 https://review.openstack.org/500057 | |
| 13:47:13 | openstack | bug 1713783 in OpenStack Compute (nova) pike "After failed evacuation the recovered source compute tries to delete the instance" [High,Triaged] https://launchpad.net/bugs/1713783 | |
| 13:50:00 | kashyap | mriedem: Darn, I missed your e-mail as it got filtered to the 'operators' mail dir. | |
| 13:55:25 | mriedem | elod: thanks for https://review.openstack.org/#/c/500057/ - just a few small things inline | |
| 13:57:55 | elod | mriedem: thanks too, checking | |
| 13:59:03 | kashyap | Although you could figure out for context, but the URL will be useless in future | |
| 13:59:08 | kashyap | s/for/from/ | |
| 14:01:42 | gibi | kashyap: you can have a github link that points to place via a specfic commit hash. That is futureproof | |
| 14:07:07 | mriedem | e.g. https://github.com/openstack/nova/blob/7815108d4892525b0047c787cbd2fe2f26c204c2/nova/virt/libvirt/driver.py#L652 | |
| 14:07:10 | mriedem | like in my email | |
| 14:07:53 | stephenfin | Any chance of a +W on this? Been sitting around for a while https://review.openstack.org/#/c/407055/ | |
| 14:08:19 | kashyap | gibi: Ah, noted | |
| 14:08:35 | mriedem | stephenfin: the change under it has a -1 on it | |
| 14:08:39 | mriedem | so what's the rush | |
| 14:08:42 | mriedem | unless you re-order | |
| 14:08:49 | kashyap | Just reading this one (oh dear, yet more live migration options) - https://review.openstack.org/#/c/456571/ | |
| 14:08:50 | stephenfin | Aha, correct. nvm me | |
| 14:09:08 | stephenfin | My list of open patches has grown rather large/unmanageable :/ | |
| 14:09:19 | kashyap | I know it intends to solve the said valid bug where one can't specify one of the URI variants | |
| 14:09:24 | mriedem | kashyap: the point of that is to remove the URI option and make it specific | |
| 14:09:29 | mriedem | so you can configure the parts of the URI | |
| 14:09:32 | mriedem | right | |
| 14:09:51 | mriedem | live_migration_query_parameters :) | |
| 14:09:58 | kashyap | mriedem: :-) I see the point | |
| 14:10:02 | mriedem | oh i guess that's extra_params | |
| 14:10:06 | mriedem | i was just joking about that one | |
| 14:10:46 | kashyap | Yeah, I've read your comment where you lament about the proliferation of the options | |
| 14:11:16 | mriedem | you know, it makes me think, if we merged that and removed live_migration_uri, in 2 years time someone will say, "why do i have to configure separately the 4 parts of this URI? why can't i just specify the single live migration URI as a config option?" | |
| 14:11:28 | mriedem | that someone will likely be me | |
| 14:12:32 | mriedem | oh i guess it's because only nova knows the host | |
| 14:12:38 | mriedem | so we have to sub in the host/ip in the URI | |
| 14:12:47 | kashyap | On a call, /me is a bit slow to read the scroll here | |
| 14:13:00 | kashyap | mriedem: Exactly! About the future complainer | |
| 14:13:24 | kashyap | But yeah, it's a bit hair-splitty | |
| 14:17:22 | openstackgerrit | Elod Illes proposed openstack/nova master: Functional test for regression bug #1713783 https://review.openstack.org/500057 | |
| 14:17:23 | openstack | bug 1713783 in OpenStack Compute (nova) pike "After failed evacuation the recovered source compute tries to delete the instance" [High,Triaged] https://launchpad.net/bugs/1713783 | |
| 14:17:53 | mriedem | gibi: we might want to think about how to highlight http://docs-draft.openstack.org/63/499963/1/check/gate-nova-docs-ubuntu-xenial/2c3bf74//doc/build/html/reference/notifications.html#existing-versioned-notifications at a higher level in the docs, | |
| 14:18:08 | mriedem | gibi: because right now you have to go main index > technical reference deep dives > notifications > samples | |
| 14:18:43 | mriedem | if i'm a consumer of the versioned notifications and want samples, like we have for the compute api reference, it would be nice to get to those from a higher level since i dont think i'd expect to find it in 'technical reference deep dives' | |
| 14:19:13 | gibi | mriedem: sure, I have to scan the new structure to see where a link can fit | |
| 14:19:24 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove dest node allocation if evacuate MoveClaim fails https://review.openstack.org/499878 | |
| 14:19:25 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add recreate test for evacuate claim failure https://review.openstack.org/499874 | |
| 14:19:25 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add a test to make sure failed evacuate cleans up dest allocation https://review.openstack.org/499877 | |
| 14:20:08 | mriedem | gibi: maybe a new section in https://docs.openstack.org/nova/latest/#for-end-users ? | |
| 14:20:23 | mriedem | because the tech reference deep dive is under 'For Contributors' | |
| 14:20:33 | mriedem | but if i'm a notification consumer i'm not necessarily a contributor | |
| 14:20:47 | mriedem | i'll hack something up quick to fight over | |
| 14:21:15 | gibi | mriedem: I think similar to what is in https://docs.openstack.org/nova/latest/#writing-to-the-api | |
| 14:21:20 | openstackgerrit | Eric Fried proposed openstack/nova master: Include /resource_providers/uuid/allocations link https://review.openstack.org/499826 | |
| 14:21:31 | mriedem | yeah | |
| 14:21:32 | gibi | mriedem: or maybe even inside it as a sub section | |
| 14:21:39 | gibi | mriedem: as notification is also an API | |
| 14:22:32 | mriedem | ok i can stack that on top of this https://review.openstack.org/#/c/498977/ | |
| 14:23:07 | gibi | mriedem: cool. but if you have more important things then I can do that doc change | |
| 14:23:28 | mriedem | this is the most important thing in my life right this second | |
| 14:23:39 | gibi | mriedem: thank go for it :) | |
| 14:24:42 | gibi | I mean thanks, then go for it | |
| 14:27:18 | openstackgerrit | Eric Fried proposed openstack/nova master: Glance download: only fsync files https://review.openstack.org/451094 | |
| 14:27:49 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Remove '[conductor] topic' opt https://review.openstack.org/499179 | |
| 14:28:46 | mriedem | elod: can you rebase https://review.openstack.org/#/c/499237/ on top of https://review.openstack.org/#/c/500057/ now? | |
| 14:29:30 | mriedem | bauwser: i've got all of the patches up for the various evacuate failure scenarios where we need to cleanup allocations https://review.openstack.org/#/q/topic:bug/1713786 | |
| 14:29:40 | mriedem | i plan on getting those backported to pike | |
| 14:29:54 | bauwser | mriedem: in a meeting but I'll look asap | |
| 14:30:09 | mriedem | they are really in two separate series for failures in conductor and failures in compute, i could stack them though (and probably should to avoid conflicts in the functional test) | |
| 14:30:28 | mriedem | so, maybe i'll do that quick | |
| 14:30:50 | openstackgerrit | Chris Dent proposed openstack/nova master: WIP: [placement] POST /allocations to set allocations for >1 consumers https://review.openstack.org/500073 | |
| 14:30:56 | bauwser | mmm, your call | |
| 14:31:25 | bauwser | mriedem: I'm not fully onboard yet about all the problems you folks found during my offline, so I'll trust you | |
| 14:31:38 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP! conf: Remove deprecated 'multi_instance_display_name_template' opt https://review.openstack.org/499612 | |
| 14:31:38 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Remove deprecated 'null_kernel' opt https://review.openstack.org/499611 | |
| 14:31:39 | mriedem | these are pretty straightforward | |
| 14:31:45 | mriedem | something fails, cleanup the dest allocation | |
| 14:31:46 | bauwser | yeah I can see | |
| 14:31:47 | cdent | mriedem, dansmith ^ that post allocations wip is very wippy, but wanted to get some early commentary | |
| 14:32:36 | sean-k-mooney | o/ i dont see jay pipes online. is he traveling today. i think he was in europe this week? | |
| 14:32:48 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Rename two VNC options https://review.openstack.org/498387 | |
| 14:32:50 | mriedem | sean-k-mooney: he's on vacation today | |
| 14:32:54 | mriedem | so out until tuesday | |
| 14:32:57 | mriedem | since monday is a US holiday | |
| 14:33:27 | sean-k-mooney | ah ok noting urgent. | |
| 14:34:37 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Deprecate 'keymap' options https://review.openstack.org/483994 | |
| 14:38:28 | rabel | i think https://review.openstack.org/#/c/494169/ is ready for a final review (again). it even passed VMware NSX CI this time. ;) | |
| 14:40:53 | mriedem | rabel: question inline | |
| 14:44:33 | openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: link to placement api-ref and history docs from main index https://review.openstack.org/498977 | |
| 14:44:34 | openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: link to versioned notification samples from main index https://review.openstack.org/500081 | |
| 14:44:37 | mriedem | gibi: ^ | |
| 14:44:38 | mriedem | see how that looks | |
| 14:45:39 | openstackgerrit | Elod Illes proposed openstack/nova master: Set error state after failed evacuation https://review.openstack.org/499237 | |
| 14:46:34 | gibi | mriedem: looking | |
| 14:48:58 | elod | mriedem: bug-fix rebased | |
| 14:49:11 | mriedem | yup, just looked it over | |
| 14:49:14 | mriedem | waiting on tests but lgtm | |
| 14:51:40 | elod | ok, thx | |