| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-08-31 | |||
| 13:06:02 | ratailor | with flavor matching metadata as host-aggregate metadata comes, this | |
| 13:06:02 | ratailor | as "COMPUTE0.example.com". And after that if instance creation request | |
| 13:06:02 | ratailor | HostNotFound error, that host is successfully added to host-aggregate | |
| 13:06:02 | ratailor | "COMPUTE0.example.com" (in capital case), then instead of throwing | |
| 13:06:02 | ratailor | and user tries to add this host to host-aggregate but by-mistake types | |
| 13:06:02 | ratailor | bauzas, As of now, if hostname is set as "compute0.example.com" (in lower case) | |
| 13:06:04 | ratailor | host is not filtered by scheduler, since there is no host with hostname | |
| 13:06:06 | ratailor | COMPUTE0.example.com, as added in host-aggregate | |
| 13:09:11 | bauzas | ratailor: I got the problem | |
| 13:09:43 | ratailor | bauzas, cool, | |
| 13:09:46 | bauzas | ratailor: what I feel is that we somehow should still accept COMPUTE0 as a possible value for the host to be added in the aggregate | |
| 13:09:57 | bauzas | from an API perspective | |
| 13:10:08 | bauzas | if we want to follow the DNS RFC | |
| 13:10:51 | bauzas | ratailor: what we could do tho is to lowercase that string before amending the aggregate | |
| 13:11:39 | bauzas | and that wouldn't trample https://specs.openstack.org/openstack/nova-specs/specs/newton/approved/lowercase-metadata-keys.html | |
| 13:11:52 | ratailor | bauzas, But that can happen other way round as well, hostname can be COMPUTE0 and user tries to add compute0 which should fail, as there is no hostname with compute0. | |
| 13:12:56 | bauzas | then the filter has to be fixed too | |
| 13:13:19 | bauzas | because it fails due to the filtter, right? | |
| 13:13:26 | ratailor | bauzas, I think, that's separate bug, which is only concerned about metadata keys. Is it somehow related to hostname. | |
| 13:14:29 | ratailor | bauzas, I think, the issue is with mysql only, | |
| 13:14:31 | ratailor | bauzas, https://github.com/openstack/nova/commit/402b3abf990d08d2af8331079d36a92d84d84b80 | |
| 13:15:27 | ratailor | bauzas, similar problem was there, and he has changed collation type for mysql backend. | |
| 13:18:59 | ratailor | bauzas, you want to discuss anything else, it EOD here. Can we continue tomorrow, if anything is left ? | |
| 13:20:13 | bauzas | ratailor: for sure | |
| 13:20:30 | bauzas | ratailor: have a good evening | |
| 13:20:40 | ratailor | bauzas, same to you! | |
| 13:23:50 | gibi | mriedem: I reverted https://review.openstack.org/#/c/491808 top of https://review.openstack.org/#/c/498482 and I still see that the recovered source compute tries to delete the instance | |
| 13:25:18 | gibi | mriedem: so I think setting the migration to failed is the solution we need. Do you suggest to add an extra check to the destroy_evacuated_instances about that instance.host != CONF.host as well? | |
| 13:26:49 | gibi | hm, the bug disappeared from launchpad https://bugs.launchpad.net/nova/+bug/1713783 | |
| 13:26:51 | openstack | gibi: Error: malone bug 1713783 not found | |
| 13:29:49 | openstackgerrit | Bob Ball proposed openstack/nova master: XenAPI: Unit tests must mock os_xenapi calls https://review.openstack.org/499573 | |
| 13:30:02 | gibi | mriedem: but you were able to just update that bug. that is weird | |
| 13:31:02 | hrw | morning | |
| 13:31:56 | hrw | can someone tell me where nova defines default VM scheme? As 'hi libvirt, here I have some VM definition for you' way | |
| 13:35:48 | gibi | hrw: hi, I think this is the place https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L5170 | |
| 13:35:58 | hrw | gibi: thanks | |
| 13:56:22 | mriedem | gibi: one thing on the fix for that evacuate issue is, i'd like to backport that further than just pike, | |
| 13:56:30 | mriedem | but we don't have the ServerMovingTests stuff before pike | |
| 13:56:40 | mriedem | so backporting to ocata and newton will be difficult if we don't decouple those | |
| 13:56:50 | mriedem | it would be nice if the code fix patch is self-contained | |
| 14:01:49 | gibi | mriedem: would you like to have an independent regression test for that bug under tests/functional/regressions ? | |
| 14:01:59 | gibi | mriedem: that could be backportable | |
| 14:02:37 | mriedem | it's not really a regression | |
| 14:02:46 | mriedem | but yes a separate standalone test would be nice | |
| 14:02:59 | mriedem | it's just a latent bug from what i can tell | |
| 14:03:19 | mriedem | well, it was maybe regressed when the migration record stuff was changed to track evacuations, but that's pretty old now (liberty or mitaka i think) | |
| 14:03:46 | mriedem | so you could put it in tests/functional/regressions if you wanted, that's fine | |
| 14:03:50 | mriedem | just decouple from ServerMovingTests | |
| 14:06:33 | gibi | mriedem: OK, cool | |
| 14:08:03 | mriedem | i also need to look at splitting https://review.openstack.org/#/c/499399/ up a bit later today | |
| 14:08:08 | mriedem | since it's a pretty large change atm | |
| 14:10:50 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Remove deprecated 'null_kernel' opt https://review.openstack.org/499611 | |
| 14:10:51 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP! conf: Remove deprecated 'multi_instance_display_name_template' opt https://review.openstack.org/499612 | |
| 14:17:14 | efried | where da source for the placement API reference doc? https://developer.openstack.org/api-ref/placement/ | |
| 14:17:24 | efried | found typo, wanna fix. | |
| 14:17:54 | sdague | new ironic issue - https://bugs.launchpad.net/nova/+bug/1714248 ? | |
| 14:17:55 | openstack | Launchpad bug 1714248 in OpenStack Compute (nova) "Compute node HA for ironic doesn't work due to the name duplication of Resource Provider " [Undecided,New] | |
| 14:18:59 | efried | nova project, placement-api-ref/source/parameters.yaml? | |
| 14:19:09 | sdague | efried: yep | |
| 14:19:14 | efried | thx | |
| 14:19:25 | efried | starts_with => startswith, according to my playing around. | |
| 14:19:50 | efried | ...for GET /traits | |
| 14:21:24 | sdague | efried: cool | |
| 14:21:45 | sdague | the names of parameters is in the rst, so depending you might only need to change that side, not that parameters.yaml | |
| 14:22:23 | efried | sdague rgrep showed starts_with only in that yaml file, so... | |
| 14:23:00 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: [placement] Add test for empty resources in allocation https://review.openstack.org/499615 | |
| 14:23:01 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: [placement] Require at least one resource class in allocation https://review.openstack.org/499616 | |
| 14:23:21 | bauzas | mriedem: I'm still not at full steam, but how can I help by reviewing changes ? | |
| 14:23:38 | bauzas | mriedem_away: the above gibi's changes ? | |
| 14:24:23 | gibi | bauzas: that change need some work based on the above discussion to make it backportable | |
| 14:24:32 | bauzas | k | |
| 14:26:12 | efried | The list of links returned by GET /resource_providers doesn't have one for .../allocations. I think it should (because that URI responds). LP bug? | |
| 14:30:30 | gibi | bauzas: mriedem_away has a refactor here https://review.openstack.org/#/c/498596/ that needs a +2 | |
| 14:31:04 | gibi | bauzas: and some more test coverage here https://review.openstack.org/#/c/496202 that also needs some core love | |
| 14:31:30 | bauzas | gibi: I need to look at what you added during my 2.5wks PTO :) | |
| 14:32:01 | gibi | bauzas: I had my one week PTO during that time so not that much but others were busy | |
| 14:37:52 | edleafe | efried: that sounds reasonable, but I would wait for cdent to chime in. It may be an oversight, or there might be a good reason. | |
| 14:38:03 | edleafe | efried: my money's on an oversight | |
| 14:38:05 | edleafe | :) | |
| 14:38:49 | efried | edleafe Rgr. Found the spot in the code where it would be added. I think the per-microversion link splitup was done before the allocations microversion. | |
| 14:39:12 | edleafe | efried: that would make sense | |
| 14:39:26 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Remove deprecated 'allow_instance_snapshots' opt https://review.openstack.org/499621 | |
| 14:39:29 | efried | Will confirm, open bug, and if it's intentional, cdent can just close the sucker. | |
| 14:43:53 | efried | nope, https://review.openstack.org/#/c/366789/ merged 20160909; https://review.openstack.org/#/c/468923/ merged 20170606. Both authored by cdent. So... maybe intentional. | |
| 14:45:34 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Move additional nova-net opts to 'network' https://review.openstack.org/499168 | |
| 14:47:47 | efried | edleafe FYI: https://bugs.launchpad.net/nova/+bug/1714275 | |
| 14:47:49 | openstack | Launchpad bug 1714275 in OpenStack Compute (nova) "GET /resource_providers: "links" doesn't include "allocations"" [Undecided,New] | |
| 14:49:54 | edleafe | efried: cool. I'm sure cdent will contribute his 2 cents when he is back on the ground | |
| 14:51:12 | dansmith | edleafe: are you going to be in denver? know about cdent? | |
| 14:51:53 | edleafe | dansmith: we both are | |
| 14:51:59 | dansmith | okay cool | |
| 14:55:03 | gibi | mriedem_away: I added my subteam update to the nova meeting agenda as I cannot joint today | |
| 15:02:21 | kashyap | melwitt: Following up from yesterday, and as your test proved, re-defining from live domain is expected to work - Eric, the author of the API confirms | |
| 15:10:35 | mriedem | gibi: ok | |
| 15:11:58 | openstackgerrit | Eric Fried proposed openstack/nova master: Update placement docs: api-ref link, startswith https://review.openstack.org/499635 | |
| 15:12:07 | efried | sdague FYI ^ | |
| 15:12:37 | efried | mriedem backport potential? ^ | |
| 15:12:46 | efried | (test out that gerritbot update :) | |
| 15:13:39 | openstackgerrit | Bob Ball proposed openstack/nova master: XenAPI: Unit tests must mock os_xenapi calls https://review.openstack.org/499573 | |
| 15:13:59 | sdague | efried: api-ref doesn't need backporting | |