| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-08-29 | |||
| 13:09:41 | jaypipes | bhagyashri_s: until we rewrite those REST API pieces to use placement, we can't get rid of them. | |
| 13:10:01 | jaypipes | bhagyashri_s: lemme grab some links for you... one sec | |
| 13:11:37 | claudiub|2 | artom: hello. around? | |
| 13:11:39 | jaypipes | bhagyashri_s: tada: https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/hypervisors.py#L54 | |
| 13:12:00 | jaypipes | bhagyashri_s: that compute REST API endpoint (/os-hypervisors) need to just go away... :) | |
| 13:12:20 | jaypipes | bhagyashri_s: and essentially deprecated in favor of the placement API. | |
| 13:12:32 | bhagyashri_s | jaypipes: ohh ok. | |
| 13:12:36 | jaypipes | bhagyashri_s: which has the /usages endpoint | |
| 13:12:40 | jaypipes | bhagyashri_s: make sense? | |
| 13:12:52 | bhagyashri_s | jaypipes: yes | |
| 13:13:00 | jaypipes | bhagyashri_s: note that the compute API's GET /os-hypervisors endpoint is an admin-only hting | |
| 13:13:02 | jaypipes | thing | |
| 13:13:12 | jaypipes | as is the placement API. | |
| 13:16:07 | bhagyashri_s | jaypipes: so is there any plan in future to deprecate that | |
| 13:19:50 | bhagyashri_s | jaypipes: and as you mentioned for compute rest api endpoint like /os-hypervisors we will get info from placement API. | |
| 13:19:56 | artom | claudiub|2, yeah - give me, like, 30 minutes to drive kids to daycare | |
| 13:21:48 | jaypipes | bhagyashri_s: it's not been thoroughly discussed, no... probably a good thing to bring up on the mailing list and discuss in Denver PTG | |
| 13:22:10 | bhagyashri_s | jaypipes: so that resource usages related columns in the compute_node table will not be needed any more | |
| 13:22:11 | mriedem | gibi: i don't see much advantage in mocking out the FakeDriver here rather than just stubbing out the manager method https://review.openstack.org/#/c/498627/1/nova/tests/functional/test_servers.py | |
| 13:23:56 | bhagyashri_s | jaypipes: ok. Thank you for info and sure will discussed in Denver PTG. | |
| 13:24:04 | bhagyashri_s | jaypipes: :) | |
| 13:33:07 | lpetrut | Hi, we have an issue with nova assisted volume snapshots when a separate DB is being used for each cell. The API only accepts a volume id, fetching the instance id from the BDM. The issue is that the BDM object cannot be retrieved as the nova api service is looking in the wrong DB (not knowing which cell to use). | |
| 13:34:26 | lpetrut | I thought you guys may provide some input :) relevant nova api code snippet: https://github.com/openstack/nova/blob/5d3a11b9c9a6a5aecd46ad7ecc635215184d930e/nova/compute/api.py#L4076-L4078 | |
| 13:35:24 | gibi | mriedem: mocking the manager method changes that part of nova we try to verify. While mocking the FakeDriver would only change the behavior of the test env. I also OK with way you did in your refactor patch by adding FakeDriver variants with a good class doc | |
| 13:35:26 | mriedem | lpetrut: ah very possible. this doesn't grab the instance first, but if it did, the _get_instance method in the compute API would set the cell mapping in the context | |
| 13:36:13 | mriedem | lpetrut: can you report a bug? | |
| 13:36:37 | gibi | mriedem: ahh I see why you didn't added a FakeDriver variant. | |
| 13:36:40 | lpetrut | mriedem: sure. the issue is that at this point, the instance id is unknown as it's not passed in the api call. | |
| 13:36:59 | mriedem | lpetrut: yeah, which sucks, so we'll likely have to iterate the cells looking for the bdm | |
| 13:37:12 | mriedem | and once found, target the context for the rest of the calls | |
| 13:37:31 | mriedem | we wouldn't have hit this in CI because only certain drivers, like NFS, test this API | |
| 13:37:42 | mriedem | there is an NFS job, but it's non-voting and in the experimental queue i think | |
| 13:38:09 | mriedem | gibi: right i'd have to create a new test class to use a new virt driver | |
| 13:38:16 | openstackgerrit | Viktor Varga proposed openstack/nova master: Ensure image metadata when unshelving BFV instance https://review.openstack.org/498729 | |
| 13:38:18 | mriedem | gibi: i can see what mocking out the driver method instead looks like | |
| 13:38:38 | lpetrut | mriedem: yep, that one's failing because of this: http://logs.openstack.org/21/498321/5/check/gate-tempest-dsvm-full-devstack-plugin-nfs-nv/b8bca96/logs/screen-c-vol.txt.gz?level=TRACE | |
| 13:39:21 | mriedem | yeah - open a bug and we'll get a fix and backport for pike | |
| 13:39:35 | mriedem | probably not the pike GA at this point though, RC2 was last week | |
| 13:39:48 | lpetrut | mriedem: sure. thanks | |
| 13:40:20 | mriedem | lpetrut: btw, does hyperv have a backend that supports this API? or just got this from a customer? | |
| 13:40:46 | lpetrut | yeah, we have the Cinder SMB driver which uses it | |
| 13:41:00 | gibi | mriedem: if you mock.patch.object the FakeDriver object in only in the compute manager that you need to behave differently then you can even drop the if from your fake method. But these are just small gains I agree | |
| 13:41:18 | mriedem | lpetrut: ok, should get the docs updated then https://developer.openstack.org/api-ref/compute/#assisted-volume-snapshots-os-assisted-volume-snapshots | |
| 13:41:26 | mriedem | because that says only the libvirt driver supports this | |
| 13:41:44 | lpetrut | good point, thanks for mentioning it | |
| 13:42:10 | mriedem | lpetrut: actually i only see the libvirt driver implementing the "volume_snapshot_create" method in tree | |
| 13:42:20 | mriedem | are you sure you don't have something in the compute hyperv repo that's not in nova? | |
| 13:43:19 | lpetrut | mriedem: actually, you're right. that didn't make it upstream | |
| 13:43:31 | mriedem | the bdm not found bug is still valid | |
| 13:43:39 | mriedem | for libvirt + nfs | |
| 13:43:58 | lpetrut | yep, I'll point to the NFS CI results | |
| 13:49:42 | gibi | mriedem: OK. I'm convinced. The manager method your patch mocks just basically calls the driver methdon I suggested to mock, so we are not loosing real coverage with your mock | |
| 13:50:27 | gibi | mriedem: so I'm +1 | |
| 13:51:40 | mriedem | heh, and i just changed the test to mock the driver | |
| 13:52:29 | mriedem | and it's passing, so i'll just leave it | |
| 13:53:28 | gibi | mriedem: ohh, OK | |
| 13:53:36 | gibi | mriedem: I like it both ways now | |
| 13:54:20 | mriedem | jaypipes: is the derek carr on that k8s rescheduler email the same as the quarterback for the raiders? | |
| 13:54:25 | mriedem | because if so, that would be impressive | |
| 13:54:35 | mriedem | oh also a red hat employee | |
| 14:01:36 | openstackgerrit | Dan Smith proposed openstack/nova-specs master: WIP: Add migration-allocations spec https://review.openstack.org/498510 | |
| 14:07:14 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Add user index page https://review.openstack.org/498817 | |
| 14:07:15 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Cleanup of existing index pages https://review.openstack.org/498819 | |
| 14:07:15 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Add configuration index page https://review.openstack.org/498818 | |
| 14:07:16 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rename cellsv2_layout -> cellsv2-layout https://review.openstack.org/498821 | |
| 14:07:16 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Add contents pages https://review.openstack.org/498820 | |
| 14:08:19 | sean-k-mooney | beagles: hi o/ did you get an answer to your os-vif question? | |
| 14:09:37 | openstack | Launchpad bug 1713590 in os-vif "Plugging VFs no longer works without a readable phys_switch_id" [Undecided,New] | |
| 14:09:37 | beagles | sean-k-mooney, no I ended up filing a bug to avoid falling through cracks https://bugs.launchpad.net/os-vif/+bug/1713590 | |
| 14:10:37 | beagles | sean-k-mooney, I'm not 100% on the code path so there might be something else going on or the configuration of the test system might be missing something. From the information I had, this seemed a valid issue | |
| 14:11:30 | artom | claudiub|2, hey, back, took longer than planned, sorry | |
| 14:11:47 | claudiub|2 | artom: no problem. :) | |
| 14:12:51 | claudiub|2 | artom: i have a question regarding the test_device_tagging tempest test | |
| 14:12:56 | artom | claudiub|2, sure | |
| 14:13:02 | claudiub|2 | artom: what kind of image are you using when testing it? | |
| 14:13:10 | claudiub|2 | artom: i assume cirros, right? | |
| 14:13:43 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Remove deprecated call to sphinx.util.compat https://review.openstack.org/498824 | |
| 14:15:57 | sean-k-mooney | beagles: os vif does not handel pluging vf normally | |
| 14:16:17 | sean-k-mooney | beagles: its should only do this if you have ovs with hardware offlod support. | |
| 14:16:36 | artom | claudiub|2, it uses a boot volume, created from whatever's image defined in the configuration | |
| 14:17:00 | artom | claudiub|2, https://github.com/openstack/tempest/blob/master/tempest/api/compute/servers/test_device_tagging.py#L102 | |
| 14:17:01 | sean-k-mooney | beagles: in you ml2_conf.ini i would guess you have the openvswitch mech driver listeted before the sriovnic agent correct? | |
| 14:17:02 | claudiub|2 | artom: i know. :) | |
| 14:17:12 | claudiub|2 | artom: but what do *you* use to test it with? :D | |
| 14:17:23 | artom | claudiub|2, doh, hah! Yeah, I used cirros | |
| 14:17:34 | andreaf | zul: around? I have a change in Tempest that if merged would break some nova-lxd integration tests from the in-tree tempest plugin | |
| 14:17:34 | claudiub|2 | hm interesting | |
| 14:17:47 | artom | claudiub|2, what's up? | |
| 14:17:51 | beagles | sean-k-mooney, interesting ... tbh I don't know, the test system is likely gone at the moment. Where there was a patch that introduced this change to tripleo a short while ago, I think that's a safe bet | |
| 14:18:21 | andreaf | zul: but I don't see those tests running anywhere in nova-lxd gate, so I was wondering if I can just change tempest and propose a patch to fix nova-lxd afterward? | |
| 14:18:31 | sean-k-mooney | beagles: basically is you want sriov and ovs in the same deployment and all your sriov host dont supprot hardware offload you have to list sriov first. | |
| 14:19:07 | claudiub|2 | artom: i'm also using a cirros, but only eth0 is configured in it, even if all the interfaces are attached. the problem is that the interface which gets to be eth0 is random, and making the VM un-ssh-able | |
| 14:19:35 | claudiub|2 | artom: as the floating IP is associated with just one of the many private IPs the VM has. | |
| 14:20:08 | beagles | sean-k-mooney,k. I'll check on that | |
| 14:20:16 | sean-k-mooney | beagles: that said we can probaly harden that could a more and retrun a specific exction rather then causing an io error by reading a file that does not exist | |
| 14:20:22 | claudiub|2 | artom: was wondering if you had an issue like this | |
| 14:20:43 | artom | claudiub|2, I haven't run it manually in a long time | |
| 14:20:53 | artom | claudiub|2, how long has this been going on? | |
| 14:21:18 | claudiub|2 | artom: i've started testing the pike release, so i've only seen it nowadays | |
| 14:21:56 | artom | claudiub|2, interesting. https://review.openstack.org/#/c/463837/ merged recently, and it changes which floating ip client gets used | |