Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-08-21
19:58:17 dansmith mriedem: that test for the bug you're working on has the post assertion for the destination's allocations commented out,
19:58:30 dansmith so fixing 1712045 will be required for that one too I think
20:06:02 openstackgerrit Merged openstack/nova master: doc: Address review comments for contributor index https://review.openstack.org/491517
20:07:10 mriedem wtf, is local docs build blowing up a known issue?
20:07:25 mriedem https://gist.github.com/mriedem/4a6dcb52ed867af14f16989d7b83739a
20:18:40 openstackgerrit Matt Riedemann proposed openstack/nova master: doc: Address review comments for main index https://review.openstack.org/492645
20:19:31 mriedem dansmith: i think we should probably get ^ to rc2 to fix the "OpenSack" thing in the first section you read in nova's docs
20:19:53 dansmith lol
20:26:45 openstackgerrit Ilya Popov proposed openstack/nova master: Tests: Add cleanup of 'instances' directory https://review.openstack.org/491589
20:32:50 mriedem as for that live migration test, yeah it's a mix of both bugs, and the comments are wrong for some of the existing test
20:32:55 mriedem i'll update that test also
20:32:58 dansmith mriedem: well, I have the change made for the post-migration update I think, but I can't really use it until I have your patch to create the doubled allocation in the scheduler
20:33:11 mriedem cleaning up the test atm
20:33:12 dansmith otherwise I'm trying to push empty allocations to placement
20:33:16 dansmith no problem, just FYI
20:38:56 openstackgerrit Matt Riedemann proposed openstack/nova master: Add functional live migrate test https://review.openstack.org/495811
20:38:57 openstackgerrit Matt Riedemann proposed openstack/nova master: Add functional force live migrate test https://review.openstack.org/495170
20:45:25 mriedem ok +2 on both of the live migration functional tests
21:14:16 mriedem i was thinking that with setting RequestSpec.requested_destination we might end up bypassing the filtering for MEMORY_MB in placement, but looks like we do that first regardless of the requested/forced host
21:14:37 mriedem so we always call to placement to get the candidates, and then wittle that down based on forced hosts, and then further filter that using the filters
21:14:59 mriedem so we should be ok with removing that ram check in the live migration task in conductor
21:23:52 cfriesen_ mriedem: looking at your comments for https://bugs.launchpad.net/nova/+bug/1712008 I guess that actually calling the scheduler will end up filtering for cells as well?
21:23:53 openstack Launchpad bug 1712008 in OpenStack Compute (nova) pike "Force live migrate doesn't claim resources on the target host" [Critical,Triaged]
21:24:09 mriedem nope
21:24:20 mriedem because conductor doesn't set request_spec.requested_destination.cell
21:24:25 mriedem in the LiveMigrateTask
21:38:35 cfriesen_ mriedem: that bug is in the context of forcing a host...how is it even valid to claim resources when forcing a host? It could end up consuming resources that aren't available.
21:39:10 cfriesen_ mriedem: (when factoring in overcommit etc)
21:39:50 mriedem cfriesen_: pre-placement you'd end up claiming resources in the compute anyway
21:39:52 mriedem via the resource tracker
21:39:55 mriedem yo'ud just fail much later
21:40:38 mriedem but let me verify that first
21:42:57 mriedem hmm, yeah we don't call the resource tracker to make a claim during live migration...
21:43:33 cfriesen_ mriedem: that's part of the patch series that's been under review forever
21:44:00 mriedem so, we don't want to build more on claims in the computes, yes?
21:44:09 mriedem because the RT is a mess
21:44:41 mriedem and we are moving things to the scheduler so we can make more accurate decisions when building instances up front, rather than rely on reschedules
21:44:42 mriedem yes?
21:45:15 cfriesen_ As I understand it we want to do the claims from the scheduler. I'm not sure what meaning "force" has when it comes to things like cpu pinning, hugepages, PCI devices, etc.
21:48:38 mriedem force from the api just meant use this host i'm giving you
21:48:51 mriedem rather than leave it up to the scheduler to pick one randomly
21:49:35 mriedem now reading https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id27 this could be considered an API change
21:49:37 cfriesen_ mriedem: you can specify which host you want without using "force"...."force" just means "not verifying the provided destination host by the scheduler".
21:49:40 mriedem "Also changes the live-migrate action behaviour when providing a host string field by calling the nova scheduler to verify the provided host unless the force attribute is set."
21:49:49 mriedem yeah point taken
21:50:19 mriedem so if the point of the force flag is to not call the scheduler, because you don't care about filters or anything,
21:50:22 cfriesen_ so if we passed the force option to the scheduler, and if set we skip all the filters/weighters but still do the claim
21:50:42 mriedem but we want to call the scheduler to do the allocation on the dest host, then we have a conflict
21:51:18 mriedem and we don't want to do the allocation on the dest host from conductor, since that triplicates that behavior between nova-compute, nova-scheduler and nova-conductor
21:51:21 cfriesen_ I think we could get the spirit of the "force" option by still calling the scheduler but skipping the filters/weighers
21:52:01 cfriesen_ that would allow us to avoid additional duplication
21:52:06 mriedem that probably involves passing yet another ignore/force type thing to the scheduler
21:52:09 cfriesen_ yea
21:52:19 mriedem request spec already has ignore_hosts and force_hosts
21:52:23 mriedem and requested_destination
21:52:40 mriedem this would be, ignore source host, force dest host, but seriously, really ignore and force everything wink wink
21:52:47 cfriesen_ hmm...what's the difference between force_hosts and requested_destination?
21:52:56 mriedem cfriesen_: see the email i just send to the ML :)
21:53:13 cfriesen_ lol
21:54:12 cfriesen_ right. maybe we can reuse force_hosts to tell it to skip the filters/weighers but still do claims
21:54:35 mriedem no that gets really confusing
21:54:47 mriedem adds more confusion to an already really confusing thing i mean
21:54:55 cfriesen_ I think "ignore_hosts" is more than just ignore source...it's also used to keep track of hosts we've already tried (when doing a reschedule)
21:55:03 mriedem like, i think force_hosts is used today in the scheduler hint for picking a specific host using scheduler hints
21:55:08 mriedem and that goes through the filters/weighers
21:55:13 mriedem yes it is
21:55:31 cfriesen_ the joys of an organically grown API. :)
21:55:32 mriedem so if we pass something to the scheduler, i'd say it's an explicit new flag, called skip_filters or something
21:55:44 cfriesen_ yeah, that's probably cleanest
21:56:50 cfriesen_ I can probably take on the limit-live-mig-dest-to-same-cell thing if you haven't already started it.
21:57:28 mriedem i'm sort of doing that as part of this other fix for the allocations thing, but it's going to require a separate bug and patch for the non-force case
21:57:31 mriedem i'm opening that bug now
22:02:00 mikal .
22:02:17 mriedem cfriesen_: https://bugs.launchpad.net/nova/+bug/1712210
22:02:18 openstack Launchpad bug 1712210 in OpenStack Compute (nova) "Live migration does not restrict to the original cell" [Medium,New]
22:03:19 mriedem dansmith: you're working on https://bugs.launchpad.net/nova/+bug/1712045 right? if so, i'll assign it to you
22:03:20 openstack Launchpad bug 1712045 in OpenStack Compute (nova) pike "nova doesn't clean up the resources after live migrate" [Critical,Triaged]
22:11:57 dansmith mriedem: I have some code for it yeah, waiting for your change to the conductor task
22:12:20 mriedem i'm code is a turd at this point - likely need to pass a flag to select_destinations as was just talking about with cfriesen_ ^
22:12:38 mriedem but, i've got something, running the functional test to update it, and then will push up the wip for discussion
22:13:47 openstackgerrit Merged openstack/nova master: doc: Address review comments for main index https://review.openstack.org/492645
22:17:59 mriedem here is that docs backport https://review.openstack.org/#/c/495977/
22:21:02 dansmith mriedem: +2+W I assume?
22:21:44 mriedem of course
22:22:00 mriedem unless we put mikal back on the nova-release team for 1 week only :)
22:22:19 mriedem throwback week
22:39:28 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Allocate resources on forced dest host during live migration https://review.openstack.org/496031
22:40:26 mriedem dansmith: cfriesen_: ok here is my wip for the bug where we don't create allocations for the dest node during forced live migration ^ lots of TODOs for things i need to consider still, plus as cfriesen_ pointed out it's probably wrong anyway since it's breaking the api contracton how that force flag is supposed to work
22:45:44 mriedem these force flags are a bad idea
22:50:30 openstackgerrit Dan Smith proposed openstack/nova master: Remove source node allocation after live migration completes https://review.openstack.org/496032
22:50:33 dansmith mriedem: ^
22:54:02 mriedem hawt
22:54:10 mriedem with that, i'm going to gymnastics!
22:56:07 cburgess lol
#openstack-nova - 2017-08-22
01:46:30 openstackgerrit Michael Still proposed openstack/nova master: Move xend existence probes to privsep. https://review.openstack.org/495538
01:46:30 openstackgerrit Michael Still proposed openstack/nova master: Move lvm handling to privsep. https://review.openstack.org/495516
01:46:31 openstackgerrit Michael Still proposed openstack/nova master: Cleanup mount / umount and associated rmdir calls https://review.openstack.org/494423
01:46:31 openstackgerrit Michael Still proposed openstack/nova master: Move shred to privsep. https://review.openstack.org/495537
01:46:32 openstackgerrit Michael Still proposed openstack/nova master: Move loopback setup and removal to privsep. https://review.openstack.org/495664
01:46:32 openstackgerrit Michael Still proposed openstack/nova master: WIP / Aspirational: we don't need rootwrap any more. https://review.openstack.org/495542

Earlier   Later