| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-08-17 | |||
| 15:16:17 | gibi | I have two health kindeys but maybe we can freeze them for later use :) | |
| 15:16:55 | dansmith | gibi: now, but later you may need one unexpectedly | |
| 15:17:15 | dansmith | gibi: or did you mean freeze the one jaypipes owes you? | |
| 15:17:30 | dansmith | because yeah, another ten years of crunchy bars and his'll be useless | |
| 15:17:34 | dansmith | so good idea to freeze now | |
| 15:17:43 | gibi | dansmith: yeah, exaxtly | |
| 15:17:59 | dansmith | good call | |
| 15:19:19 | gibi | English is hard | |
| 15:19:48 | jaypipes | dansmith, gibi: k, +2 from me on that one. | |
| 15:19:59 | dansmith | heh | |
| 15:20:09 | jaypipes | the patch, not the freezing part :) | |
| 15:20:15 | dansmith | jaypipes: got one more for you in just a sec | |
| 15:20:32 | jaypipes | k | |
| 15:20:46 | dansmith | jaypipes: https://review.openstack.org/#/c/491808 | |
| 15:20:58 | dansmith | jaypipes: you were +2, I just had some comments on test coverage, but looks good to me now | |
| 15:21:13 | dansmith | maciejjozefczyk: I'm assuming we should put that into pike as well | |
| 15:21:33 | jaypipes | ah, maciejjozefczyk and dpawlik's patch | |
| 15:21:54 | cdent | I’m in a quandry: If I want to keep jay’s kidneys healthy, for the sake of gibi, then I shouldn’t deliver crunchie bars. | |
| 15:22:15 | dansmith | heh | |
| 15:22:23 | gibi | cdent: or, we have to freeze that kindey before you deliver | |
| 15:22:32 | jaypipes | dansmith: k, +Wallaby'd maciejjozefczyk's patch. | |
| 15:22:54 | dansmith | thanks | |
| 15:23:09 | dansmith | gibi: +W on the shelve patch, so please propose that for pike too | |
| 15:23:24 | gibi | dansmith: thank. I will do it | |
| 15:23:28 | maciejjozefczyk | jaypipes: dansmith thx | |
| 15:24:21 | dansmith | maciejjozefczyk: you too for pike | |
| 15:24:48 | gibi | dansmith: what is the policy? Only propose the bugfix on stable or both the functional test and the bugfix in two separate patches or maybe squash them? | |
| 15:25:14 | dansmith | gibi: never squash unless you have to, | |
| 15:25:25 | dansmith | gibi: but are you talking about your "replace chance" patch? | |
| 15:26:09 | gibi | dansmith: nope. both the evac and the offload fix consist of two patches one for the functional test and one for the bugfix | |
| 15:26:31 | dansmith | gibi: oh and the functional test are already in tree, right? | |
| 15:26:49 | gibi | dansmith: for the shelve it is still on review https://review.openstack.org/#/c/493062/ | |
| 15:27:02 | gibi | dansmith: the evac test is in the master but not on stable pike | |
| 15:27:04 | dansmith | oh heh, I see now, I was confusing | |
| 15:27:21 | dansmith | gibi: for both just backport all the patches as they are | |
| 15:27:36 | gibi | dansmith: OK | |
| 15:28:00 | dansmith | gibi: I was looking at that shelve test in the shelve fix and thinking "oh I didn't see this go in, but this is nice" | |
| 15:28:01 | dansmith | didn't realize there was another below it | |
| 15:28:28 | gibi | dansmith: yeah, too many patches | |
| 15:28:37 | dansmith | jaypipes: you on that one? | |
| 15:30:55 | jaypipes | dansmith: looking... | |
| 15:33:29 | gibi | just a note, previously I mentioned a possible bug in soft_delete + periodic reclaim. It turned out that it was a missing _run_periodics() in the test case. | |
| 15:36:51 | jaypipes | dansmith: k, done. | |
| 15:37:06 | jaypipes | I'm heading out now... | |
| 15:38:17 | cdent | gibi: no kidney for you! | |
| 15:39:12 | gibi | cdent: but then jaypipes-afk can eat more crunchies :) | |
| 15:55:08 | efried | cdent Thanks for https://review.openstack.org/489537 | |
| 15:55:33 | cdent | seemed it would save some trouble | |
| 15:56:06 | efried | cdent Depends how urgent their bug is. I'm not sure mine is gonna move until I've got the q bp approved. | |
| 15:56:53 | cdent | true. but also: I’ve got mixed feelings about interface types... | |
| 15:57:38 | efried | cdent Feel free to comment in my review. Though I may just wind up refereeing while you & mordred slog it out. | |
| 15:58:22 | cdent | efried: I don’t think the fight is warranted or necessary: This is another one of those cases where reality is up to no good and I’m on the idealism side. | |
| 15:58:35 | cdent | it keeps happening | |
| 15:59:06 | efried | tbh, I really don't have any of the history wrt interfaces, so I'm just doing what I'm told there. | |
| 15:59:25 | mordred | efried, cdent : oh - so ... my only fight is that this isn't quite friendly enough | |
| 15:59:51 | mordred | we added interface as a list for a reason -so that the default could be ['internal', 'public'] meaning that almost nobody would ever have to change the value | |
| 15:59:53 | mordred | BUT | |
| 16:00:07 | mordred | if we can't get that plumbed in all the way for now - I'm totally on board with teh default for ironic eing internal | |
| 16:00:38 | mordred | end-goal should be to be able to sanely use the list so that most operators never have to touch the setting at all | |
| 16:01:26 | mordred | oh. hah. that's what cdent was saying already isn't it? | |
| 16:01:56 | efried | I actually don't know what cdent was referring to by "mixed feelings about interface types" :) | |
| 16:02:30 | cdent | mordred: no, my position is more idealistic than that: there shouldn’t be any such thing in the service catalog as an interface type. there should be one and only one service url per service | |
| 16:02:35 | cdent | but that’s not this world | |
| 16:02:41 | mordred | cdent: I totally agree with you | |
| 16:03:21 | mordred | cdent: but - one step back from that is that we should be able to set a default ordered list that should work for most deployers | |
| 16:03:46 | mordred | and that, other service-user auth info, most deployers should NEVER have to tell nova ANYTHING about how to find a particular service | |
| 16:03:57 | cdent | yes | |
| 16:04:06 | mordred | "I made 20 service users, please use this one to talk to ironic" is, I think, fair | |
| 16:04:24 | mordred | s/ironic/baremetal/ | |
| 16:04:43 | efried | mordred Cool, I *think* I've accomplished that with the bp/use-service-catalog-for-endpoints series. | |
| 16:04:56 | efried | ...with much guidance from the likes of you & sdague | |
| 16:05:00 | mordred | efried: I think you have too | |
| 16:12:29 | gibi | dansmith: I proposed the evac fix series to stable/pike. The series starts here https://review.openstack.org/#/c/494623/ | |
| 16:13:14 | gibi | hm, is the gerrit bot on vacation? or is it get hit by the kline like me? | |
| 16:13:26 | dansmith | gibi: no reports from non-master I think | |
| 16:13:44 | gibi | dansmith: ahh ok | |
| 16:15:51 | edmondsw | mordred we're actually in the process of adding another place deployers have to tell nova how to talk to something: https://review.openstack.org/#/c/485121/ | |
| 16:20:49 | gibi | dansmith: the shelve backport starts here https://review.openstack.org/#/c/494631/ | |
| 16:21:15 | gibi | dansmith: I had to make the shelve dependent on the evac to avoid merge conflict in the test_server file | |
| 16:27:13 | dansmith | gibi: cool thanks | |
| 16:27:34 | dansmith | gibi: you didn't have to do anything to make that fit other than the dep though right? | |
| 16:27:53 | gibi | dansmith: right. It was a clear cherry-pick after I ordered the patches | |
| 16:28:01 | dansmith | they should ideally be merged to stable in the same order as master so that they don't need any modification | |
| 16:28:15 | dansmith | okay cool | |
| 16:28:51 | gibi | now I have to leave for today, but I will check the patches tomorrow if needed | |
| 16:29:07 | gibi | dansmith: thanks for the help | |
| 16:50:23 | openstackgerrit | Merged openstack/nova master: delete allocation of evacuated instance https://review.openstack.org/493037 | |
| 16:54:23 | openstackgerrit | Merged openstack/os-vif master: Read datapath_type from VIF object https://review.openstack.org/474914 | |
| 17:11:52 | openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285 | |
| 17:21:35 | openstackgerrit | Merged openstack/nova master: test shelve and shelve offload with placement https://review.openstack.org/493062 | |
| 17:23:49 | mordred | edmondsw: oh - sure- I mean, we need the config options to exist - but the best result would be that they're options 99% of deployers never have to use | |
| 17:39:21 | mordred | edmondsw: thanks for the headsup- I left some reviews - efried they mention you | |
| 17:39:49 | openstackgerrit | Merged openstack/nova master: Clean up resources at shelve offload https://review.openstack.org/493834 | |
| 17:44:47 | dansmith | gibi: okay everything is on its way | |
| 17:57:34 | dansmith | is there a designee for running the meeting today? | |
| 17:58:27 | dansmith | if not, I'll do it, but I figure mriedem may have already arranged for someone to do it | |
| 18:38:43 | openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova master: update comment for dropping support https://review.openstack.org/494061 | |
| 19:58:48 | melwitt | dansmith: I assumed the meeting would be run by you | |
| 20:00:07 | dansmith | okay | |
| 20:55:45 | dansmith | ten minute nova meeting in five minutes | |