Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-08-08
16:04:59 sdague honestly, uml is kind of docker before docker
16:06:20 cfriesen sdague: wouldn't that be lxc?
16:06:22 sean-k-mooney sdague: so its like lxc/openvz container. e.g a sandboxed system level container/chroot?
16:06:55 sdague sean-k-mooney: yeh, except pre namespaces
16:07:18 cfriesen sean-k-mooney: sdague: I think it's actually linux implemented using POSIX as the architecture.
16:08:01 sdague anyway, the crux of it, I'd remove all the references to it in the nova space. I expect someone got somethign working in cactus, but never bothered again after
16:08:06 sdague and the reference lasted until now
16:08:42 cfriesen sdague: yeah, agreed. don't see why anyone would actually use it with nova
16:08:52 stephenfin Yup, they're gone
16:09:02 stephenfin There was only one (that I've found so far)
16:09:14 sdague oh, this is why - https://blueprints.launchpad.net/nova/+spec/austin-user-mode-linux
16:09:27 sdague they were attempting to use it for testing instead of 2nd level qemu
16:09:44 sean-k-mooney sdague: looking at https://wiki.openstack.org/wiki/Nova/UML it looks like its pluged in under livbivrt
16:09:54 stephenfin sdague: Importing this config guide is proving slower than I thought (alll the cross-references). I may need to have you take over it if I don't get much further in the next hour or so
16:10:02 stephenfin (I'm gone tomorrow on)
16:10:04 sdague stephenfin: no prob
16:10:08 mriedem melwitt: i've rebased and cleaned up the conflict in the stable branches for https://review.openstack.org/#/q/I8cd056fa17184a98c31547add0e9fb2d363d0908,n,z
16:10:17 mriedem melwitt: now just need to get the series of changes below that one merged
16:10:58 sdague stephenfin: before you leave, if you can send me an email with the patch url, and what the major reference fixing looks like
16:11:10 sdague just to get me running on it quicker
16:11:21 sdague as I'm about to go out for a bike ride while the getting is good
16:11:40 stephenfin Will do
16:20:59 openstackgerrit Jay Pipes proposed openstack/nova master: remove provider allocs in confirm/revert resize https://review.openstack.org/488510
16:21:00 openstackgerrit Jay Pipes proposed openstack/nova master: placement: refactor healing of allocations in RT https://review.openstack.org/491850
16:21:00 openstackgerrit Jay Pipes proposed openstack/nova master: Resource tracker compatibility with Ocata and Pike https://review.openstack.org/491012
16:21:26 jaypipes dansmith: ok, I did my best on the above but it's icky and may have made a mistake or two.
16:21:34 dansmith okay
16:21:37 jaypipes dansmith: really need your eyeballs on it.
16:22:07 dansmith I guess I didn't think there was that much change needed...
16:24:01 dansmith jaypipes: this replaces the delete with "heal" which doesn't make sense to me
16:24:03 dansmith since we're also still healing in the non-delete path
16:24:50 jaypipes dansmith: the heal will need to recreate allocations for ocata-deleted allocations, which is why I renamed it heal. I know, it's bad
16:25:04 dansmith and it doesn't heal right? it deletes.
16:25:35 jaypipes dansmith: well, this method will need to re-create allocations that an ocata compute node deleted incorrectly.
16:26:20 jaypipes dansmith: if an ocata compute node was the source for a migrate to a pike compute host.
16:26:31 dansmith but that's already done in update_usage_for_instance right?
16:26:46 dansmith in the top patch, conditional on the presence of ocata computes
16:28:14 jaypipes dansmith: ack, sorry, yes, you're right.
16:28:22 jaypipes dansmith: I can rename it back to delete...
16:28:32 dansmith jaypipes: I'm not sure what the point of this patch is though.. just some extra conditions for not calling delete?
16:29:51 jaypipes dansmith: the point of this patch was two things: 1) to only delete allocations when the instance is DELETED or SHELEVED_OFFLOADED and 2) add a bunch of log statements so we can see what state instances are in during this _remove_deleted_instances_allocations() method
16:30:44 dansmith jaypipes: okay I thought we were doing this filtering earlier such that by the time we got here we didn't have anything other than the ones we needed to delete..
16:30:55 jaypipes dansmith: I added the debug log statements when trying to fix the issue alex_xu brought up about evacuate code paths not being correct.
16:31:09 dansmith we've been round and round about this particular conditional, so maybe I missed something
16:31:33 jaypipes dansmith: the evacuate code paths were not being affected by the update_usage_for_instance() path for some reason.
16:31:45 jaypipes dansmith: on the source host at least.
16:32:34 jaypipes dansmith: so when trying to verify the evacuate code path for scenario when source host is restarted, I was trying to get log messages about the instances in this method. sorry, it got really confusing :(
16:32:55 dansmith jaypipes: so vm_states.ALLOW_RESOURCE_REMOVAL excludes things that aren't deleted or shelved_offloaded, so doesn't that cover us?
16:33:07 dansmith oh, not for deleting allocations I guess
16:33:17 jaypipes right, that actually results in InstanceNotFound.
16:33:27 dansmith what does?
16:33:32 jaypipes when an instance is deleted.
16:33:41 jaypipes the Instance.get_by_uuid() returns InstanceNotFound
16:34:47 openstackgerrit Stephen Finucane proposed openstack/nova master: doc: Import configuration reference https://review.openstack.org/491853
16:35:04 mriedem https://docs.openstack.org/releasenotes/nova/unreleased.html#id15
16:35:04 mriedem stephenfin: in case you haven't left yet, there are two duplicate upgrade notes for similar things in the libvirt driver about port filtering capability
16:35:05 jaypipes dansmith: sorry about all of this :( in trying to address alex_xu's review comments about evacuate I ended up going down the rabbithole.
16:35:21 jaypipes dansmith: and it's likely I've f'd it all up now :(
16:35:25 dansmith jaypipes: okay, yeah, I'm confused I guess
16:35:32 stephenfin mriedem: I assume we can just delete one/
16:35:34 dansmith jaypipes: I'm throwing some comments in here though
16:35:34 stephenfin *?
16:35:40 jaypipes k
16:35:45 mriedem stephenfin: they are slightly different
16:36:34 mriedem https://github.com/openstack/nova/blob/501a0fe65afabb7e6a8b1e2d1ca0fbcea941d2d1/releasenotes/notes/libvirt-ignore-allow_same_net_traffic-fd88bb2801b81561.yaml
16:36:38 mriedem https://github.com/openstack/nova/blob/5c0cb33d75acb284a3b6299c851ab70f10f69dfc/releasenotes/notes/libvirt-firewall-ignore-use_ipv6-c555f95799f991fd.yaml
16:37:31 openstackgerrit Chris Friesen proposed openstack/nova master: Remove ram/disk sched filters from default list https://review.openstack.org/491854
16:40:24 mriedem stephenfin: maybe i'll just make sure the boilerplate text is the same between the two
16:40:27 mriedem and leave the rest
16:41:06 stephenfin mriedem: As in keep both but make the shared part look similar?
16:41:14 cfriesen mriedem: dansmith: how much validation of images should nova do? I'm getting a report that with RDB instance storage launching an instance from qcow2 format image doesn't boot but launching instance from raw format image works. Booting from volume with either image works.
16:41:18 stephenfin or something else?
16:41:22 mriedem stephenfin: yes
16:41:38 stephenfin mriedem: Cool. You or me doing that?
16:42:06 mriedem i'm doing it
16:42:49 stephenfin (y)
16:43:12 cfriesen mriedem: dansmith: similarly, should we believe glance when it tells us the image type? In Newton at least glance doesn't appear to be validating the specified image type.
16:44:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Cleanup release note about ignoring allow_same_net_traffic https://review.openstack.org/491855
16:44:45 bauzas folks, bailing out, see you Thursday \o
16:50:52 stephenfin bauzas: o/
16:52:01 stephenfin mriedem: +2d
16:52:12 stephenfin sdague: email sent
16:52:17 stephenfin (I hope - Evolution sux)
16:55:07 openstackgerrit Stephen Finucane proposed openstack/nova master: doc: Import configuration reference https://review.openstack.org/491853
16:57:08 stephenfin See you all next week o/
17:04:09 cdent jaypipes, bauzas, dansmith, mriedem : I made a new patch to publish the placement-api-ref. https://review.openstack.org/#/c/491860/ it depends on the top patch in https://review.openstack.org/#/q/topic:cd/placement-api-ref+status:open so it would be nice if we could get those in and have happy little docs
17:04:27 jaypipes cdent: kk
17:17:51 melwitt dansmith, mriedem: my bfv functional test queries hypervisor stats to verify correct handling of bfv. it seems like that's independent of the RT, right?
17:18:08 dansmith no, that's where hv stats come from
17:19:10 melwitt so currently the scheduler, claims, and reporting will be different than hv stats?
17:19:44 melwitt that is, they'll show different resource amounts?
17:19:45 openstackgerrit Doug Hellmann proposed openstack/nova master: use intersphinx to link to horizon https://review.openstack.org/491866
17:20:42 dansmith melwitt: we do account for things a little differently in placement, which is what scheduler is using for the basis of choosing a host, and claiming against
17:21:01 dansmith hv stats has never been particularly correct either, mind you
17:21:36 melwitt okay
17:22:17 melwitt I think I could update the test to query placement for how much disk the compute node is reporting
17:22:43 melwitt because that's all I was doing is verifying it's reporting 0 local_gb_used
17:23:32 dansmith so the compute node's allocation will account for it, but we don't heal if we're on pike only,
17:23:40 melwitt it would be interested to see if the test passes with those lines commented out too, because if bfv isn't handled correctly yet, it won't even be able to boot instances
17:23:50 melwitt *interesting

Earlier   Later