| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-08-04 | |||
| 14:52:08 | sdague | sfinucan: also, just for you, I changed my word wrap for rst mode to 79 columns :) | |
| 14:52:16 | stephenfin | Yay! :D | |
| 14:58:10 | stephenfin | sdague: Yeah, I personally prefer that bullet point style. It's used in both the OVS and Django docs, and gives way more context | |
| 15:00:13 | superdan | mriedem: not sure how that bdms.update() is doing the right thing | |
| 15:03:26 | mriedem | superdan: if no bdms are found in a cell for the list of instance uuids it should just return {} | |
| 15:03:35 | leakypipes | superdan: k, just finished up with meetings. heading to code now. | |
| 15:03:40 | leakypipes | sorry for delay | |
| 15:04:09 | mriedem | leakypipes: before heading back into the RT fun, mind looking at this regression fix? https://review.openstack.org/#/c/489763/ | |
| 15:04:37 | leakypipes | mriedem: yup, will do. | |
| 15:04:41 | superdan | mriedem: the object method returns a List object though, not a dict | |
| 15:04:50 | mriedem | superdan: which one? | |
| 15:05:00 | mriedem | did you see my reply in the patch? | |
| 15:05:01 | superdan | BlockDeviceMappingList.get_by_instance_uuids | |
| 15:05:21 | superdan | mriedem: mine is the latest | |
| 15:05:22 | mriedem | superdan: that's not the method used | |
| 15:05:23 | mriedem | bdms_by_instance_uuid | |
| 15:05:40 | mriedem | which returns a dict of bdm lists keyed by instance uuid | |
| 15:05:49 | superdan | oh, indeed | |
| 15:05:55 | mriedem | right, it's confusing as hell | |
| 15:06:01 | mriedem | i had to look at it a few times this morning | |
| 15:07:29 | superdan | and it's not even plural | |
| 15:08:05 | leakypipes | what!? not plural? /me changes clothes into SuperGrammarCorrector | |
| 15:08:59 | superdan | someone on a ML I'm on yesterday was making fun of someone who couldn't spell, saying "watch your grammer" | |
| 15:09:01 | superdan | I was tickled | |
| 15:09:50 | leakypipes | lol | |
| 15:12:57 | leakypipes | superdan: k, I'm +2 on mriedem | |
| 15:12:59 | leakypipes | https://review.openstack.org/#/c/489763/1 | |
| 15:13:25 | openstackgerrit | Merged openstack/python-novaclient master: Replace six.itervalues() with dict.values() in python-novaclient https://review.openstack.org/490784 | |
| 15:14:52 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add Port Profile info to VIF objects OVS plugin https://review.openstack.org/490819 | |
| 15:15:13 | superdan | mriedem: leakypipes is +2 on you | |
| 15:16:30 | leakypipes | kinky. | |
| 15:17:26 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add Port Profile info to VIF objects Linux Bridge plugin https://review.openstack.org/490829 | |
| 15:17:36 | superdan | I said +2 not #2 | |
| 15:19:14 | leakypipes | superdan: rofl | |
| 15:19:37 | leakypipes | superdan: FYI, I'm fixing up mriedem' | |
| 15:19:41 | leakypipes | s review comments on https://review.openstack.org/#/c/490514/ | |
| 15:19:55 | superdan | okay thanks | |
| 15:21:23 | mriedem | i'll start digging back into my shared storage resize functional test patch to see what weirdness is going on there | |
| 15:35:01 | ftersin | mriedem: thanks for the review | |
| 15:37:18 | openstackgerrit | Eric Fried proposed openstack/nova master: nova.utils.get_ksa_adapter() https://review.openstack.org/488137 | |
| 15:46:42 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Add additional content to admin guide https://review.openstack.org/490952 | |
| 16:08:07 | leakypipes | superdan, mriedem: relatively painless reviews on placement-api-ref series starting here: https://review.openstack.org/#/c/450550/ | |
| 16:10:40 | mriedem | yeah i've got the series starred, was coming in handy last night writing this functional test for shared storage + resize | |
| 16:10:56 | mriedem | i've also figured out part of what is going weird in this test, which is also the bug we need to fix | |
| 16:10:57 | leakypipes | ya | |
| 16:11:06 | mriedem | for the report client stomping the disk allocations for the shared storage provider | |
| 16:11:10 | openstackgerrit | Jay Pipes proposed openstack/nova master: Add resource utilities to scheduler utils https://review.openstack.org/490514 | |
| 16:11:10 | openstackgerrit | Jay Pipes proposed openstack/nova master: remove provider allocs in confirm/revert resize https://review.openstack.org/488510 | |
| 16:11:21 | leakypipes | superdan, mriedem: k, good to go. all tests passing. ^^ | |
| 16:14:05 | mriedem | leakypipes: ok one thing in there | |
| 16:14:07 | mriedem | misunderstanding | |
| 16:14:46 | mriedem | the merge of the resources should pick up the new key in the new flavor | |
| 16:16:43 | leakypipes | mriedem: ah, ok, yes I misunderstood you. will have a fix up pronto. | |
| 16:16:47 | mriedem | we should probably drop this from INFO to DEBUG: "Synced traits from os_traits into API DB" | |
| 16:16:51 | mriedem | it dumps out a bunch of traits | |
| 16:17:02 | leakypipes | mriedem: you want me to do that in this patch? | |
| 16:17:09 | mriedem | leakypipes: no, | |
| 16:17:12 | leakypipes | k | |
| 16:17:15 | mriedem | just seeing it in my functional test run that uses traits | |
| 16:18:41 | superdan | leakypipes: I still really want that last patch split between the confirm and service version pieces, but I'm happy to work on that if you want | |
| 16:19:08 | leakypipes | superdan: yeah, that would be cool. just gimme a minute to push a mriedem_lunch request | |
| 16:19:13 | superdan | if we had to revert the confirm bit, for example, we'd not want to revert the service version piece which is harder to undo | |
| 16:19:15 | superdan | okay | |
| 16:19:30 | leakypipes | superdan: yeah, agreed | |
| 16:20:49 | openstackgerrit | Jay Pipes proposed openstack/nova master: Add resource utilities to scheduler utils https://review.openstack.org/490514 | |
| 16:20:49 | openstackgerrit | Jay Pipes proposed openstack/nova master: remove provider allocs in confirm/revert resize https://review.openstack.org/488510 | |
| 16:20:54 | leakypipes | superdan: tag, you're it. :) | |
| 16:31:33 | superdan | ugh, pretty sure I'm going to be talking myself out of this one in a couple hours | |
| 16:40:06 | openstackgerrit | Eric Fried proposed openstack/nova master: nova.utils.get_ksa_adapter() https://review.openstack.org/488137 | |
| 16:46:14 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/490859 | |
| 16:48:03 | superdan | leakypipes: so I'm going to split this up and push for you to look at and make sure I didn't fubar anything and if we decide it's too much work to separate, we can just pull and resubmit this current PS where things are unified okay? | |
| 16:48:27 | superdan | I've got unit tests passing on the confirm part without the service version part, and am running functional tests now | |
| 16:49:36 | fried_rice | mriedem_lunch Pushing use-service-catalog-for-endpoints to Q at this point? | |
| 16:50:01 | leakypipes | superdan: ack | |
| 16:52:09 | openstackgerrit | Merged openstack/nova master: Fix 409 handling in report client when deleting inventory https://review.openstack.org/489763 | |
| 17:00:33 | openstackgerrit | Merged openstack/nova master: [placement] Add api-ref for allocations https://review.openstack.org/470933 | |
| 17:20:20 | openstackgerrit | Sean Dague proposed openstack/nova master: Create reference subpage https://review.openstack.org/490994 | |
| 17:42:51 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Functional regression test for evacuate with a target https://review.openstack.org/490997 | |
| 17:42:51 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Pass requested_destination in filter_properties https://review.openstack.org/481116 | |
| 17:49:30 | bauzas | mriedem_lunch: I'll be off in the next minute but see the above changes for https://bugs.launchpad.net/nova/+bug/1702454 | |
| 17:49:31 | openstack | Launchpad bug 1702454 in OpenStack Compute (nova) "Transforming the RequestSpec object into legacy dicts doesn't support the requested_destination field" [High,In progress] - Assigned to Sylvain Bauza (sylvain-bauza) | |
| 17:49:45 | bauzas | mriedem_lunch: as we discussed the backports are slightly different | |
| 18:13:15 | edmondsw_ | fried_rice you might know how to improve https://review.openstack.org/#/c/485121 | |
| 18:15:14 | superdan | leakypipes: okay get ready to rumble | |
| 18:15:24 | leakypipes | ok dokey | |
| 18:15:32 | superdan | hang on, forgot to run pep8 | |
| 18:15:39 | superdan | stand by rumble | |
| 18:16:03 | leakypipes | hehe | |
| 18:18:00 | mriedem | ERROR [nova.scheduler.client.report] Failed to allocate resources on provider 9f098d35-83b2-46e1-a2c2-b51ee1a33f66 for instance aeb45d5b-4787-4afa-9b19-430da6f33699. Error: | |
| 18:18:00 | mriedem | yes | |
| 18:18:07 | mriedem | Unable to allocate inventory: Inventory for 'DISK_GB' on resource provider '9f098d35-83b2-46e1-a2c2-b51ee1a33f66' invalid. | |
| 18:18:32 | mriedem | what do you mean you can't allocate against a provider with 0 DISK_GB inventory?! | |
| 18:18:48 | superdan | okay here comes | |
| 18:18:56 | openstackgerrit | Dan Smith proposed openstack/nova master: remove provider allocs in confirm/revert resize https://review.openstack.org/488510 | |
| 18:18:57 | openstackgerrit | Dan Smith proposed openstack/nova master: Resource tracker compatibility with Ocata and Pike https://review.openstack.org/491012 | |
| 18:18:57 | openstackgerrit | Dan Smith proposed openstack/nova master: Add resource utilities to scheduler utils https://review.openstack.org/490514 | |
| 18:19:52 | mriedem | +2 on https://review.openstack.org/#/c/490514/ | |
| 18:20:37 | leakypipes | mriedem: I'd +2 that but I added a lot to it... | |
| 18:20:57 | leakypipes | perhaps melwitt or bauzas could look at it? | |
| 18:21:11 | mriedem | bauzas is going to the mediterraneannenaanna coast | |