Earlier  
Posted Nick Remark
#openstack-nova - 2017-08-04
13:54:30 mriedem like evacuate and specify-host
13:54:50 ftersin mriedem: hi. who could merge https://review.openstack.org/#/c/490340/ ? it fixes a regression bug which blocks CI for ec2api
13:55:02 stephenfin mriedem: Yeah, I'm not sure where those are going yet, tbh
13:55:07 leakypipes superdan: yup, will do. just wrapping up meetings.
13:55:47 stephenfin They're going to need some work as they're pretty out of date and don't tie into the 'oslo_config.sphinxext'. I'll take a shot at it shortly
13:56:22 mriedem stephenfin: there is also https://github.com/openstack/openstack-manuals/blob/stable/ocata/doc/admin-guide/source/cli-set-compute-quotas.rst
13:56:27 mriedem so the naming pattern isn't consistent
13:56:40 mriedem https://github.com/openstack/openstack-manuals/blob/stable/ocata/doc/admin-guide/source/cli-os-migrate-cfg-ssh.rst
13:56:45 stephenfin mriedem: Good point. Looks like I'll need to go through them all individually :(
13:57:01 mriedem stephenfin: i'll just open a bug to track it
13:57:07 stephenfin mriedem: In any case, sdague and I figured it was better to just get _something_ in and build upon it
13:57:14 stephenfin Do - you can assign it to me
13:59:15 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/488086
14:00:12 stephenfin mriedem: Can we still merge those req updates if they make sense ^
14:00:15 stephenfin *?
14:00:39 mriedem we can't release them for pike at this point
14:00:43 mriedem or in stable/pike
14:00:54 mriedem i'd just hold off on those until queens
14:00:58 mriedem for the libraries
14:01:39 openstack Launchpad bug 1708666 in OpenStack Compute (nova) "docs: admin guide import is missing several compute-specific docs" [High,Confirmed] - Assigned to Stephen Finucane (stephenfinucane)
14:01:39 mriedem stephenfin: https://bugs.launchpad.net/nova/+bug/1708666
14:04:07 stephenfin mriedem: (y) (for both)
14:15:22 mriedem ftersin: the test needs work if you want to touch it up
14:15:30 mriedem takashin is probably no longer working
14:20:06 ftersin mriedem: thx. we'll ping takashi tomorrow
14:20:53 ftersin uhhm... tomorrow, in monday :/
14:21:08 mriedem heh, ok, or i'll just update it
14:21:12 mriedem it's a 1 line assertion in the test
14:23:38 ftersin our developer's gone home, i'm busy with other things and do not have OS sources with git, etc right now
14:23:50 mriedem that's fine
14:26:59 openstackgerrit Merged openstack/nova master: Update install guide to clearly define between package installs https://review.openstack.org/490844
14:30:28 openstackgerrit Jackie Truong proposed openstack/nova master: Add trusted_certs to instance_extra https://review.openstack.org/457711
14:45:16 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix getting instance bdms in multiple cells https://review.openstack.org/490340
14:47:13 mriedem superdan: you should probably check this out - multi-cell fun https://review.openstack.org/#/c/490340/
14:48:27 superdan cool
14:51:37 openstackgerrit Sean Dague proposed openstack/nova master: Add Contributor Guide section page https://review.openstack.org/490644
14:51:42 sdague sfinucan: ^^^
14:51:58 stephenfin sdague: looking
14:52:08 sdague sfinucan: also, just for you, I changed my word wrap for rst mode to 79 columns :)
14:52:16 stephenfin Yay! :D
14:58:10 stephenfin sdague: Yeah, I personally prefer that bullet point style. It's used in both the OVS and Django docs, and gives way more context
15:00:13 superdan mriedem: not sure how that bdms.update() is doing the right thing
15:03:26 mriedem superdan: if no bdms are found in a cell for the list of instance uuids it should just return {}
15:03:35 leakypipes superdan: k, just finished up with meetings. heading to code now.
15:03:40 leakypipes sorry for delay
15:04:09 mriedem leakypipes: before heading back into the RT fun, mind looking at this regression fix? https://review.openstack.org/#/c/489763/
15:04:37 leakypipes mriedem: yup, will do.
15:04:41 superdan mriedem: the object method returns a List object though, not a dict
15:04:50 mriedem superdan: which one?
15:05:00 mriedem did you see my reply in the patch?
15:05:01 superdan BlockDeviceMappingList.get_by_instance_uuids
15:05:21 superdan mriedem: mine is the latest
15:05:22 mriedem superdan: that's not the method used
15:05:23 mriedem bdms_by_instance_uuid
15:05:40 mriedem which returns a dict of bdm lists keyed by instance uuid
15:05:49 superdan oh, indeed
15:05:55 mriedem right, it's confusing as hell
15:06:01 mriedem i had to look at it a few times this morning
15:07:29 superdan and it's not even plural
15:08:05 leakypipes what!? not plural? /me changes clothes into SuperGrammarCorrector
15:08:59 superdan someone on a ML I'm on yesterday was making fun of someone who couldn't spell, saying "watch your grammer"
15:09:01 superdan I was tickled
15:09:50 leakypipes lol
15:12:57 leakypipes superdan: k, I'm +2 on mriedem
15:12:59 leakypipes https://review.openstack.org/#/c/489763/1
15:13:25 openstackgerrit Merged openstack/python-novaclient master: Replace six.itervalues() with dict.values() in python-novaclient https://review.openstack.org/490784
15:14:52 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add Port Profile info to VIF objects OVS plugin https://review.openstack.org/490819
15:15:13 superdan mriedem: leakypipes is +2 on you
15:16:30 leakypipes kinky.
15:17:26 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add Port Profile info to VIF objects Linux Bridge plugin https://review.openstack.org/490829
15:17:36 superdan I said +2 not #2
15:19:14 leakypipes superdan: rofl
15:19:37 leakypipes superdan: FYI, I'm fixing up mriedem'
15:19:41 leakypipes s review comments on https://review.openstack.org/#/c/490514/
15:19:55 superdan okay thanks
15:21:23 mriedem i'll start digging back into my shared storage resize functional test patch to see what weirdness is going on there
15:35:01 ftersin mriedem: thanks for the review
15:37:18 openstackgerrit Eric Fried proposed openstack/nova master: nova.utils.get_ksa_adapter() https://review.openstack.org/488137
15:46:42 openstackgerrit Stephen Finucane proposed openstack/nova master: doc: Add additional content to admin guide https://review.openstack.org/490952
16:08:07 leakypipes superdan, mriedem: relatively painless reviews on placement-api-ref series starting here: https://review.openstack.org/#/c/450550/
16:10:40 mriedem yeah i've got the series starred, was coming in handy last night writing this functional test for shared storage + resize
16:10:56 mriedem i've also figured out part of what is going weird in this test, which is also the bug we need to fix
16:10:57 leakypipes ya
16:11:06 mriedem for the report client stomping the disk allocations for the shared storage provider
16:11:10 openstackgerrit Jay Pipes proposed openstack/nova master: Add resource utilities to scheduler utils https://review.openstack.org/490514
16:11:10 openstackgerrit Jay Pipes proposed openstack/nova master: remove provider allocs in confirm/revert resize https://review.openstack.org/488510
16:11:21 leakypipes superdan, mriedem: k, good to go. all tests passing. ^^
16:14:05 mriedem leakypipes: ok one thing in there
16:14:07 mriedem misunderstanding
16:14:46 mriedem the merge of the resources should pick up the new key in the new flavor
16:16:43 leakypipes mriedem: ah, ok, yes I misunderstood you. will have a fix up pronto.
16:16:47 mriedem we should probably drop this from INFO to DEBUG: "Synced traits from os_traits into API DB"
16:16:51 mriedem it dumps out a bunch of traits
16:17:02 leakypipes mriedem: you want me to do that in this patch?
16:17:09 mriedem leakypipes: no,
16:17:12 leakypipes k
16:17:15 mriedem just seeing it in my functional test run that uses traits
16:18:41 superdan leakypipes: I still really want that last patch split between the confirm and service version pieces, but I'm happy to work on that if you want
16:19:08 leakypipes superdan: yeah, that would be cool. just gimme a minute to push a mriedem_lunch request
16:19:13 superdan if we had to revert the confirm bit, for example, we'd not want to revert the service version piece which is harder to undo

Earlier   Later