| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-08-04 | |||
| 13:34:31 | dansmith | the unit test is so mocked up the butt I can't really even tell if it's useful | |
| 13:34:46 | dansmith | and the functional one was a gabbit thing and I dunno why it would have changed or what to do about it | |
| 13:35:08 | dansmith | leakypipes: and did you see my comments about the fixes for the ocata-to-pike one? | |
| 13:35:54 | dansmith | hmm, I guess the gabbit one didn't fail in jenkins, that's weird | |
| 13:36:06 | stephenfin | leakypipes: Two easy reviews for you for later https://review.openstack.org/#/c/486536/ https://review.openstack.org/#/c/480092/ | |
| 13:36:18 | stephenfin | (gets os-vif off of https://doughellmann.com/doc-migration/) | |
| 13:45:10 | leakypipes | dansmith: no, sorry superdan, just getting back to things this morning. | |
| 13:45:39 | openstackgerrit | Merged openstack/os-vif master: Update the documentation link for doc migration https://review.openstack.org/486536 | |
| 13:47:25 | dansmith | heh, always with the friday guilt | |
| 13:47:33 | leakypipes | :) | |
| 13:48:31 | superdan | leakypipes: so the remaining unit test fails because the fake resource tracker has no compute nodes, but tries to pull self.compute_nodes[cn].uuid out and fails with keyerror | |
| 13:48:46 | leakypipes | superdan: k. | |
| 13:48:49 | superdan | but the test seriously has like 30 mocks and so it's really hard to tell if it's even useful | |
| 13:48:58 | leakypipes | superdan: I know, it's rough | |
| 13:49:08 | leakypipes | superdan: am I good to take the baton and pull code? | |
| 13:49:10 | superdan | when I tried adding a compute node to it, it failed much earlier, which I found amusing | |
| 13:49:13 | superdan | leakypipes: yes | |
| 13:49:36 | superdan | leakypipes: look at my two latest comments on the review though and make sure my fixes for your ocata to pike test are legit | |
| 13:51:07 | mriedem | o/ | |
| 13:53:04 | mriedem | stephenfin: the admin guide import was missing several things i pointed out https://review.openstack.org/#/c/477497/ | |
| 13:53:29 | mriedem | like https://github.com/openstack/openstack-manuals/blob/stable/ocata/doc/admin-guide/source/compute-flavors.rst | |
| 13:53:32 | stephenfin | mriedem: s/compute-// | |
| 13:53:39 | stephenfin | He just dropped all the prefixes | |
| 13:53:47 | stephenfin | They're there alright :) | |
| 13:54:23 | mriedem | all of the cli-nova-* stuff from https://github.com/openstack/openstack-manuals/tree/stable/ocata/doc/admin-guide/source isn't in there | |
| 13:54:30 | mriedem | like evacuate and specify-host | |
| 13:54:50 | ftersin | mriedem: hi. who could merge https://review.openstack.org/#/c/490340/ ? it fixes a regression bug which blocks CI for ec2api | |
| 13:55:02 | stephenfin | mriedem: Yeah, I'm not sure where those are going yet, tbh | |
| 13:55:07 | leakypipes | superdan: yup, will do. just wrapping up meetings. | |
| 13:55:47 | stephenfin | They're going to need some work as they're pretty out of date and don't tie into the 'oslo_config.sphinxext'. I'll take a shot at it shortly | |
| 13:56:22 | mriedem | stephenfin: there is also https://github.com/openstack/openstack-manuals/blob/stable/ocata/doc/admin-guide/source/cli-set-compute-quotas.rst | |
| 13:56:27 | mriedem | so the naming pattern isn't consistent | |
| 13:56:40 | mriedem | https://github.com/openstack/openstack-manuals/blob/stable/ocata/doc/admin-guide/source/cli-os-migrate-cfg-ssh.rst | |
| 13:56:45 | stephenfin | mriedem: Good point. Looks like I'll need to go through them all individually :( | |
| 13:57:01 | mriedem | stephenfin: i'll just open a bug to track it | |
| 13:57:07 | stephenfin | mriedem: In any case, sdague and I figured it was better to just get _something_ in and build upon it | |
| 13:57:14 | stephenfin | Do - you can assign it to me | |
| 13:59:15 | openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/488086 | |
| 14:00:12 | stephenfin | mriedem: Can we still merge those req updates if they make sense ^ | |
| 14:00:15 | stephenfin | *? | |
| 14:00:39 | mriedem | we can't release them for pike at this point | |
| 14:00:43 | mriedem | or in stable/pike | |
| 14:00:54 | mriedem | i'd just hold off on those until queens | |
| 14:00:58 | mriedem | for the libraries | |
| 14:01:39 | openstack | Launchpad bug 1708666 in OpenStack Compute (nova) "docs: admin guide import is missing several compute-specific docs" [High,Confirmed] - Assigned to Stephen Finucane (stephenfinucane) | |
| 14:01:39 | mriedem | stephenfin: https://bugs.launchpad.net/nova/+bug/1708666 | |
| 14:04:07 | stephenfin | mriedem: (y) (for both) | |
| 14:15:22 | mriedem | ftersin: the test needs work if you want to touch it up | |
| 14:15:30 | mriedem | takashin is probably no longer working | |
| 14:20:06 | ftersin | mriedem: thx. we'll ping takashi tomorrow | |
| 14:20:53 | ftersin | uhhm... tomorrow, in monday :/ | |
| 14:21:08 | mriedem | heh, ok, or i'll just update it | |
| 14:21:12 | mriedem | it's a 1 line assertion in the test | |
| 14:23:38 | ftersin | our developer's gone home, i'm busy with other things and do not have OS sources with git, etc right now | |
| 14:23:50 | mriedem | that's fine | |
| 14:26:59 | openstackgerrit | Merged openstack/nova master: Update install guide to clearly define between package installs https://review.openstack.org/490844 | |
| 14:30:28 | openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_certs to instance_extra https://review.openstack.org/457711 | |
| 14:45:16 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix getting instance bdms in multiple cells https://review.openstack.org/490340 | |
| 14:47:13 | mriedem | superdan: you should probably check this out - multi-cell fun https://review.openstack.org/#/c/490340/ | |
| 14:48:27 | superdan | cool | |
| 14:51:37 | openstackgerrit | Sean Dague proposed openstack/nova master: Add Contributor Guide section page https://review.openstack.org/490644 | |
| 14:51:42 | sdague | sfinucan: ^^^ | |
| 14:51:58 | stephenfin | sdague: looking | |
| 14:52:08 | sdague | sfinucan: also, just for you, I changed my word wrap for rst mode to 79 columns :) | |
| 14:52:16 | stephenfin | Yay! :D | |
| 14:58:10 | stephenfin | sdague: Yeah, I personally prefer that bullet point style. It's used in both the OVS and Django docs, and gives way more context | |
| 15:00:13 | superdan | mriedem: not sure how that bdms.update() is doing the right thing | |
| 15:03:26 | mriedem | superdan: if no bdms are found in a cell for the list of instance uuids it should just return {} | |
| 15:03:35 | leakypipes | superdan: k, just finished up with meetings. heading to code now. | |
| 15:03:40 | leakypipes | sorry for delay | |
| 15:04:09 | mriedem | leakypipes: before heading back into the RT fun, mind looking at this regression fix? https://review.openstack.org/#/c/489763/ | |
| 15:04:37 | leakypipes | mriedem: yup, will do. | |
| 15:04:41 | superdan | mriedem: the object method returns a List object though, not a dict | |
| 15:04:50 | mriedem | superdan: which one? | |
| 15:05:00 | mriedem | did you see my reply in the patch? | |
| 15:05:01 | superdan | BlockDeviceMappingList.get_by_instance_uuids | |
| 15:05:21 | superdan | mriedem: mine is the latest | |
| 15:05:22 | mriedem | superdan: that's not the method used | |
| 15:05:23 | mriedem | bdms_by_instance_uuid | |
| 15:05:40 | mriedem | which returns a dict of bdm lists keyed by instance uuid | |
| 15:05:49 | superdan | oh, indeed | |
| 15:05:55 | mriedem | right, it's confusing as hell | |
| 15:06:01 | mriedem | i had to look at it a few times this morning | |
| 15:07:29 | superdan | and it's not even plural | |
| 15:08:05 | leakypipes | what!? not plural? /me changes clothes into SuperGrammarCorrector | |
| 15:08:59 | superdan | someone on a ML I'm on yesterday was making fun of someone who couldn't spell, saying "watch your grammer" | |
| 15:09:01 | superdan | I was tickled | |
| 15:09:50 | leakypipes | lol | |
| 15:12:57 | leakypipes | superdan: k, I'm +2 on mriedem | |
| 15:12:59 | leakypipes | https://review.openstack.org/#/c/489763/1 | |
| 15:13:25 | openstackgerrit | Merged openstack/python-novaclient master: Replace six.itervalues() with dict.values() in python-novaclient https://review.openstack.org/490784 | |
| 15:14:52 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add Port Profile info to VIF objects OVS plugin https://review.openstack.org/490819 | |
| 15:15:13 | superdan | mriedem: leakypipes is +2 on you | |
| 15:16:30 | leakypipes | kinky. | |
| 15:17:26 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add Port Profile info to VIF objects Linux Bridge plugin https://review.openstack.org/490829 | |
| 15:17:36 | superdan | I said +2 not #2 | |
| 15:19:14 | leakypipes | superdan: rofl | |
| 15:19:37 | leakypipes | superdan: FYI, I'm fixing up mriedem' | |
| 15:19:41 | leakypipes | s review comments on https://review.openstack.org/#/c/490514/ | |
| 15:19:55 | superdan | okay thanks | |