| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-08-03 | |||
| 13:52:03 | dansmith | cdent: I'm handling other morning stuff waiting for mriedem to catch me up.. if you're fixing things, I'd just keep going with that | |
| 13:52:11 | dansmith | and/or push fixes you already have working | |
| 13:52:12 | cdent | roger that | |
| 13:52:20 | cdent | check with me before you dive in | |
| 13:52:25 | cdent | I’ll get what I can make sense of | |
| 13:52:50 | dansmith | ack | |
| 13:53:31 | jaypipes | I could use a catch-up too. | |
| 13:55:58 | openstackgerrit | Merged openstack/nova master: fix list rendering in rpc doc https://review.openstack.org/490442 | |
| 13:56:41 | openstackgerrit | Merged openstack/nova master: Fix list rendering in bdm doc. https://review.openstack.org/490446 | |
| 13:57:23 | openstackgerrit | Merged openstack/nova master: fix list rendering in aggregates https://review.openstack.org/490448 | |
| 13:58:12 | openstackgerrit | Merged openstack/nova master: fix list rendering in cells https://review.openstack.org/490449 | |
| 13:58:59 | openstackgerrit | Merged openstack/nova master: fix list rendering in policy-enforcement https://review.openstack.org/490451 | |
| 14:00:42 | dansmith | jaypipes: I had just said I was waiting to see if mriedem had anything queued locally for that set, I assume that means you do not? | |
| 14:02:17 | dansmith | jaypipes: per my comment a few minutes ago, if we don't address the flavor overrides in that un-doubling, we'll mess up accounting after a move with an overriding flavor | |
| 14:02:28 | dansmith | and edleafe has a flavor-to-resources method we can just use I think | |
| 14:10:42 | mriedem | dansmith: cdent: just got home, | |
| 14:10:48 | mriedem | i'm not currently working on anything | |
| 14:11:15 | dansmith | mriedem: okay | |
| 14:11:36 | dansmith | cdent: so I guess push your changes when you're ready and then I will see about fixing the resource override stuff | |
| 14:12:17 | openstackgerrit | Chris Dent proposed openstack/nova master: remove provider allocs in confirm/revert resize https://review.openstack.org/488510 | |
| 14:12:24 | cdent | good timing ^ | |
| 14:12:45 | cdent | that fixes the pep8 problems, and the calls where flavor was not included in a call to remove_provider_from … | |
| 14:13:12 | cdent | but it does not fix an assertion with AssertionError: Expected 'delete_allocation_for_instance' to be called once. Called 0 times. | |
| 14:13:23 | cdent | nor some mock problems in “unrelated” tests | |
| 14:14:35 | cdent | dansmith, mriedem, jaypipes, I release the lock | |
| 14:15:44 | dansmith | ah, mriedem's patch should already be kosher in this respect actually | |
| 14:15:53 | dansmith | I was thinking with my uncaffeinated brain | |
| 14:16:07 | dansmith | it's just the last one that needs it | |
| 14:16:38 | cdent | just to highlight it, gibi pointed out yet another edge case on ps16: https://review.openstack.org/#/c/490461 | |
| 14:17:32 | mriedem | dansmith: so no resource override in my change? | |
| 14:17:42 | mriedem | b/c if so, you'll have to deal with it b/c resource override is lost on me | |
| 14:17:44 | dansmith | mriedem: right yours should be good because the scheduler has already done that part | |
| 14:17:52 | mriedem | ok | |
| 14:22:50 | jaypipes | dansmith: sorry, having some issues today :( | |
| 14:23:26 | jaypipes | dansmith: last I checked in I was waiting on the bottom patch in that series to test positive and then I was going to appove it (it was the test resize same host patch) | |
| 14:24:03 | jaypipes | dansmith: I think my status currently is I need to pull whatever the latest that mriedem pushed last night and cherry-pick the changes I was working on last night onto that series. | |
| 14:24:19 | dansmith | okay that's what I was just asking, if you had pending changes | |
| 14:24:21 | jaypipes | dansmith: those changes include fixing up the "cheating" section | |
| 14:24:35 | dansmith | anyway, let me finish what I'm doing here, which is fixing the cheating section, but so it accounts for flavor overrides | |
| 14:24:37 | dansmith | almost done with that | |
| 14:24:44 | jaypipes | dansmith: oh, ok | |
| 14:24:47 | jaypipes | dansmith: np | |
| 14:25:03 | jaypipes | dansmith: and sorry, I'm having some medical issues today. trying to get in to see a doctor. | |
| 14:25:16 | dansmith | ack, np | |
| 14:25:21 | jaypipes | so it's not an ideal work day unfortunately :( | |
| 14:26:08 | jaypipes | if cdent would send me a box of Crunchie bars and a new hip and lower back, that would be groovy. | |
| 14:26:30 | jaypipes | thx cdent :) | |
| 14:26:52 | cdent | they are a part of my official travel to openstack events habit, so if you can survive until september: hooked up | |
| 14:27:08 | mriedem | *cortisone | |
| 14:27:09 | mriedem | damn | |
| 14:27:10 | cdent | I’m going home, brb | |
| 14:27:27 | openstackgerrit | Matthew Booth proposed openstack/nova master: imagebackend: cleanup constructor args to Rbd https://review.openstack.org/490499 | |
| 14:27:47 | jaypipes | mriedem: that cortisone come with morphine? | |
| 14:28:04 | mdbooth | ^^^ is the most trivial trivial patch I've ever submitted, btw | |
| 14:28:38 | mdbooth | Actually, I'm sure I've submitted a typo fix in a comment before | |
| 14:28:38 | openstack | Launchpad bug 1708424 in OpenStack Compute (nova) "When a flavor has resource extra_specs disabling all standard fields, nova tries to make a request to the placements API with no resources" [Undecided,New] | |
| 14:28:38 | sdague | https://bugs.launchpad.net/nova/+bug/1708424 ... that's a weird bug | |
| 14:29:01 | edleafe | sdague: IMO that one is operator error | |
| 14:29:08 | sdague | yeh | |
| 14:29:32 | edleafe | sdague: they go to the trouble of zeroing out all the standard resources, but never add the ironic resource class | |
| 14:30:05 | edleafe | sdague: so perhaps we could catch that in Nova, but if they really wanna shoot themselves in the foot... | |
| 14:30:11 | sdague | yeh | |
| 14:30:31 | sdague | so is that a hack to do something ironicy? | |
| 14:31:45 | edleafe | It's part of the switch to ironic custom resource classes | |
| 14:32:29 | jaypipes | mdbooth: +2 from me. | |
| 14:32:36 | edleafe | In Queens, an ironic flavor will have the extra_specs contain the custom resource class, along with zeroes for the "standard" resources | |
| 14:32:50 | openstack | Launchpad bug 1707160 in neutron "test_create_port_in_allowed_allocation_pools test fails on ironic grenade" [Critical,Confirmed] - Assigned to Ihar Hrachyshka (ihar-hrachyshka) | |
| 14:32:50 | sdague | bauzas: why did you mark https://bugs.launchpad.net/nova/+bug/1707160 as critical even though you didn't think it was a nova bug? | |
| 14:32:53 | edleafe | In Pike, it should just have the ironic custom RC | |
| 14:33:29 | bauzas | sdague: just for getting traction | |
| 14:33:38 | bauzas | because it's a gate issue | |
| 14:34:00 | bauzas | but anyway | |
| 14:34:18 | mdbooth | jaypipes: Thanks, also for the attaboy ;) | |
| 14:34:31 | jaypipes | mdbooth: heh :) | |
| 14:34:53 | sdague | bauzas: ok, I thought we save critical for must fix rc bugs | |
| 14:35:14 | bauzas | sdague: np, your modification is good to me | |
| 14:37:06 | mriedem | melwitt: some suggestions in https://review.openstack.org/#/c/470578/ | |
| 14:38:12 | melwitt | mriedem: cool, thanks | |
| 14:39:56 | openstack | Launchpad bug 1708458 in OpenStack Compute (nova) "Expose instance system_metadata in compute API" [Undecided,New] | |
| 14:39:56 | sdague | I'm assuming this would need a spec - https://bugs.launchpad.net/nova/+bug/1708458 ? | |
| 14:42:01 | mriedem | sdague: jesus yes | |
| 14:42:26 | mriedem | we shouldn't flat out expose system metadata | |
| 14:42:43 | mriedem | "if you want to query the point in time properties that where inherited from an image during the launch." | |
| 14:42:53 | mriedem | expose those as some other field then | |
| 14:43:16 | mriedem | we don't need to expose all of the garbage we carry in system metadata | |
| 14:43:20 | mriedem | like old_vm_state during a resize | |
| 14:44:03 | mriedem | bauzas: i backported the placement fix to overwrite allocations https://review.openstack.org/#/c/490231/ | |
| 14:46:24 | sdague | ok, I'm good with Won't Fix | |
| 14:47:27 | openstackgerrit | Ed Leafe proposed openstack/nova master: Handle addition of new nodes/instances in ironic flavor migration https://review.openstack.org/487954 | |
| 14:47:34 | mriedem | well, alternatively the fix is a microversion to expose some specific part of system metadata and what that entails | |
| 14:47:51 | mriedem | sdague: ever thought about indexing qemu instance logs in our ci runs? | |
| 14:48:05 | mriedem | http://logs.openstack.org/10/490110/2/check/gate-tempest-dsvm-multinode-live-migration-ubuntu-xenial/6c1da1c/logs/subnode-2/libvirt/qemu/instance-00000003.txt.gz | |
| 14:48:05 | mriedem | when live migration jobs fail, a lot of the time it's due to | |
| 14:48:11 | mriedem | /build/qemu-orucB6/qemu-2.8+dfsg/nbd/server.c:nbd_co_receive_request():L1135: reading from socket failed | |
| 14:48:17 | mriedem | but ^ isn't exposed in anything we index | |
| 14:48:25 | jaypipes | dansmith: did you see cdent just pushed a revision on the confirm resize patch? | |
| 14:48:59 | dansmith | jaypipes: a bit ago while we were talking, yeah. he said so and that's when I pulled to start working | |
| 14:49:14 | jaypipes | gotcha. just making sure you noticed. carry on. | |
| 14:49:48 | mriedem | what i'd really love is if the libvirt / qemu job had some way to get those details from the guest | |
| 14:50:08 | mriedem | kashyap: mdbooth: you know how during a live migration we're checking the domain job status to see when it completes, or if it fails? | |