Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-08-01
14:35:21 dansmith gibi: tbh I haven't looked at the later ones in detail.. as I said on the review, I think we should revert back to PS14 and roll on, but I'm not sure if there was a reason for the refactor
14:37:10 gibi dansmith: the refactor was only for reduce duplication and increase readability by better naming
14:37:50 gibi dansmith: I think 14 and 17 executes the same scenario but 18 executes a different one (different move direction)
14:38:23 dansmith gibi: well, like I said, the duplication in the test makes it _more_ readable IMHO, even if a bit wasteful
14:38:34 dansmith gibi: agree we could have improved the naming a bit though
14:39:57 jaypipes gibi: yeah, as I walked to get breakfast I realized you are correct
14:42:27 openstackgerrit Jay Pipes proposed openstack/nova master: placement: remove existing allocs when set allocs https://review.openstack.org/489273
14:42:27 openstackgerrit Jay Pipes proposed openstack/nova master: Test resize with placement api https://review.openstack.org/487958
14:42:28 openstackgerrit Jay Pipes proposed openstack/nova master: remove source provider allocs in confirm_resize() https://review.openstack.org/488510
14:42:29 jaypipes dansmith, gibi, mriedem: ok, good to go now ^^
14:42:38 jaypipes for the test resize patch at least
14:43:10 openstack bug 1707071 in OpenStack Compute (nova) "Compute nodes will fight over allocations during migration" [Medium,In progress] https://launchpad.net/bugs/1707071 - Assigned to Jay Pipes (jaypipes)
14:43:10 jaypipes dansmith, gibi, mriedem: now I go back to trying to actually fix the bug 1707071
14:44:11 gibi dansmith, jaypipes: then I guess we are not bringing back the duplications by inlining util functions I introduced
14:46:36 jaypipes gibi: I think what you did made the test easier to read and consume.
14:46:50 jaypipes gibi: I know dansmith disagrees a bit, though
14:47:10 jaypipes but dansmith is a disagreeable man.
14:47:28 jaypipes who requires a constant IV drop of caffeine to agree with anything.
14:47:55 jaypipes is it Friday yet?
14:48:16 cdent soon, jaypipes. soon
14:48:21 jaypipes hehe
14:48:24 mriedem https://images-na.ssl-images-amazon.com/images/I/51S%2BpPtReeL._AC_UL320_SR228,320_.jpg
14:49:22 mriedem or https://s-media-cache-ak0.pinimg.com/originals/49/d7/a0/49d7a0676e7945b3fb7bcf4c4533fd99.jpg
14:49:25 sdague gibi: honestly, on the test front, duplication is not a bad thing. You are trying to understand individual test functions in their own context, and if you have to chase a bunch of common code, it's a lot harder to put the state in your head
14:52:25 gibi sdague: I have no firm oppinion I think for me the usefullness of deduplication depends on how well I can trust the utility function to do what it promise
14:53:55 dansmith sdague: exactly
14:53:57 gibi sdague: to build that trust during review I guess I inline the utils in my head at the first usage but then later I just trust them
14:57:32 openstackgerrit Jay Pipes proposed openstack/nova master: Test resize with placement api https://review.openstack.org/487958
14:57:33 openstackgerrit Jay Pipes proposed openstack/nova master: remove source provider allocs in confirm_resize() https://review.openstack.org/488510
14:57:33 openstackgerrit Jay Pipes proposed openstack/nova master: placement: remove existing allocs when set allocs https://review.openstack.org/489273
14:57:35 jaypipes dansmith: made those changes you pointed out in the review ^^
14:58:44 openstack bug 1454515 in OpenStack Compute (nova) "Property "instance.disable_terminate" is always "False" and never actually used." [Low,In progress] https://launchpad.net/bugs/1454515 - Assigned to Khushbuparakh (khushbuparakh)
14:58:44 openstackgerrit khushbu parakh proposed openstack/nova master: Closes-Bug: #1454515 https://review.openstack.org/488941
14:59:24 sdague gibi: right, but that's because you are familiar with them. People reading tests will not be, so it takes longer to understand what is going on if they also need to digest utils
15:05:59 dfisher ok, i'm still struggling trying to get a compute node talking to a devstack rig. What services need to be running on the compute node? Obviously nova-compute but what else?
15:06:06 dfisher this is all with beta3
15:06:32 dfisher nova service-list sees my compute node, but cell_v2 discover_hosts can't find it
15:07:02 gibi sdague: sure, there is an overhead due to the extra indirection until the reader gets familiar with the utils but after that it is a lot easier to read the deduplicated code (not to mention chaging it)
15:07:19 jaypipes gibi, dansmith, mriedem, cdent: for the record, I was wrong, dansmith and gibi were right. sorry that I jumped the gun.
15:07:30 mriedem dfisher: what does nova-manage cell_v2 list_cells show?
15:07:34 mriedem do you have a cell0 and cell1?
15:07:55 jaypipes gibi, dansmith, mriedem, cdent: and I did not mean to shut anyone down. I just thought I'd figured out the issue
15:07:57 dfisher mriedem: yes. I have both cell0 and cell1
15:08:10 cdent jaypipes: I’ll have a aggregate map WIP up shortly
15:08:20 openstackgerrit Matt Riedemann proposed openstack/nova master: Deprecate cells v1 https://review.openstack.org/489632
15:08:20 jaypipes cdent: cool, thanks.
15:08:23 gibi jaypipes: you made me think for a while, but I like these mental challenges so no worries
15:08:24 sdague dfisher: what versions of devstack code do you have?
15:08:29 dansmith dfisher: and cell1 points to the same transport and db url as the config for the conductor and the compute?
15:08:32 mriedem dfisher: and does the transport_url for cell1 match the transport_url in nova.conf on the compute node?
15:08:48 dfisher sdague: git pull'd as of yesterday
15:08:59 mriedem dfisher: you can see the transport_url for cell1 by using --verbose with the list_cells command
15:09:11 dfisher dansmith/mriedem: hang on, checking...
15:09:22 mriedem dansmith: sdague: here is the cellsv1 deprecation https://review.openstack.org/489632
15:09:34 dansmith dfisher: this is what I asked you yesterday fwiw :)
15:09:48 dfisher I know. I'm thick :(
15:09:50 jaypipes gibi: no, I feel bad because I didn't see dansmith's comment above "oh you're right, so I should just stop looking then eh?". I didn't mean to shut him down.
15:10:20 sdague mriedem: ++
15:11:58 dfisher dansmith: i apologize but I didn't understand you meant the transport_url
15:12:04 dfisher dansmith: you said, "dfisher: make sure your conductor's config is pointed at the cell1 db, matching the cell1 cell_mapping record"
15:12:11 dansmith dfisher: yesterday or now?
15:12:12 dfisher dansmith: and I thought you meant the database connection string :(
15:12:14 dfisher yesterday
15:12:23 dfisher ok, so with the transport_url set right, i'm in business
15:12:26 dansmith dfisher: well, it's a little of both
15:12:29 dfisher thank you all.
15:12:30 dansmith dfisher: cool
15:12:41 mriedem little bit country? little bit rock&roll?
15:13:42 mriedem dfisher: we could put something in https://docs.openstack.org/nova/latest/user/cells.html#faqs for your ase
15:13:43 mriedem *case
15:14:59 mriedem by we i think i mean you
15:18:16 openstackgerrit Chris Dent proposed openstack/nova master: WIP Update RT aggregate map less frequently https://review.openstack.org/489633
15:19:09 sdague dfisher: ok, it would be good to figure out where that went wrong
15:19:25 sdague because devstack should be setting it up correctly on both controller and compute
15:19:37 sdague and if something is falling through, would be good to fix
15:19:40 mriedem sdague: i assume dfisher is doign multinode
15:19:45 mriedem w/o devstack-gate
15:19:47 sdague mriedem: sure
15:20:13 sdague but the only thing in d-g is the discover_hosts
15:20:16 openstackgerrit Jay Pipes proposed openstack/nova master: Test resize with placement api https://review.openstack.org/487958
15:20:17 openstackgerrit Jay Pipes proposed openstack/nova master: remove source provider allocs in confirm_resize() https://review.openstack.org/488510
15:20:17 openstackgerrit Jay Pipes proposed openstack/nova master: placement: remove existing allocs when set allocs https://review.openstack.org/489273
15:20:19 cdent jaypipes: that patch above does what I think we’re after ^ but needs some reactions and tweaks. gonna get lunch and then will check back
15:20:28 mriedem sdague: d-g also sets up the local.conf for the subnodes doesn't it?
15:20:28 jaypipes cdent: cheers
15:20:36 mriedem otherwise you'd have n-api in enabled_services
15:20:37 cdent bbs
15:20:48 sdague mriedem: yeh, but I didn't think we had cells specific logic there
15:21:01 sdague I'd like devstack multinode without d-g to work for folks
15:21:29 mriedem sdague: there is conditional logic in devstack to know if it's a subnode or not based on n-api running
15:21:30 mriedem is my point
15:22:29 sdague mriedem: yeh
15:23:04 sdague dfisher: anyway, if you have suggestions on how to make this more clear and straightforward to setup on the devstack side, let me know
15:23:26 dfisher sdague: just mention that the transport_url on the compute node needs to match the cell1 transport_url
15:23:28 dfisher that's all you need.
15:24:26 dfisher and, again, thank you sdague, mriedem, and dansmith for putting up with dumb questions from the peanut gallery
15:24:43 gibi jaypipes, dansmith: I have one more question at https://review.openstack.org/#/c/487958/21/nova/tests/functional/test_servers.py@1370
15:25:20 sdague dfisher: any idea where that should be mentioned that it would be more obvious?
15:25:54 dfisher 1.Configure and start your compute hosts. Before step 7, make sure you have compute hosts in the database by running nova service-list --binary nova-compute.
15:25:54 dfisher sdague:

Earlier   Later