Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-07-31
20:38:46 dansmith I'm going to remove the resource_tracker.py change so we can get an expedited run on top of jay's stuff,
20:38:55 dansmith and then we can move this to the bottom, change the assertions and build on top
20:39:06 mriedem also
20:39:08 jaypipes ++
20:39:09 mriedem have you noticed? ObjectActionError: Object action get_minimum_version failed because: Invalid binary prefix
20:39:30 dansmith where is that?
20:39:52 jaypipes must be on the latest
20:40:09 dansmith yeah he must not have done nova-compute
20:40:10 jaypipes since I *just* added the get_minimum_version_latest() thing
20:40:30 mriedem get_minimum_version_multi takes a list
20:40:45 jaypipes gah, ok
20:41:00 jaypipes sec... like I said, this was just so dansmith could take a lo9oksie :)
20:41:06 mriedem just use get_minimum_version
20:41:15 jaypipes k
20:41:43 dansmith damn I guess I probably need the virt/fake change too
20:42:13 mriedem the test will also likely need the AllServicesCurrent fixture now too
20:43:08 openstackgerrit Dan Smith proposed openstack/nova master: Test resize with placement api https://review.openstack.org/487958
20:43:18 dansmith that's the minor fix
20:43:26 dansmith I can start working this on top of master
20:48:59 cdent I will try to catch up in the morning. I have no brains left. Good luck. Good night.
20:59:03 dansmith I'm just going to push this up rebased on master so we can move forward
20:59:17 dansmith jaypipes: you'll rebase on top of this and make sure this test keeps working as you make your changes, right?
20:59:45 dansmith and it'd be really good if we had a single-node version of these
21:00:10 mriedem i can help work on the single node one,
21:00:14 mriedem also digging into the revert case
21:00:21 jaypipes dansmith: yes, just ping me when you push.
21:00:34 jaypipes currentl fixing up unit tests for the service min version thing
21:00:48 dansmith mriedem: what revert case?
21:01:00 mriedem the revert resize test that fails
21:01:13 dansmith of gibi's?
21:01:15 mriedem http://logs.openstack.org/58/487958/7/check/gate-nova-tox-functional-ubuntu-xenial/7f7f332/console.html#_2017-07-31_17_04_11_513991
21:01:16 mriedem yeah
21:01:21 dansmith he has self.fail() at the end
21:01:23 dansmith I think that's it
21:01:29 dansmith passes for me without that
21:02:04 mriedem hmm, ok the test was hitting this http://logs.openstack.org/58/487958/7/check/gate-nova-tox-functional-ubuntu-xenial/7f7f332/console.html#_2017-07-31_17_04_11_497592 but on the older patches in the series
21:02:28 dansmith jay hasn't fixed revert yet, AFAIK
21:02:29 dansmith only confirm
21:02:54 mriedem i think i just did locally
21:03:10 dansmith okay well I have it passing on master, so we'll iterate from there
21:03:22 openstackgerrit Jackie Truong proposed openstack/nova master: Add trusted_certs to instance_extra https://review.openstack.org/457711
21:03:32 openstackgerrit Dan Smith proposed openstack/nova master: Test resize with placement api https://review.openstack.org/487958
21:04:09 dansmith mriedem: jaypipes ^
21:04:18 dansmith I can also try to clean up the sleep usage in there by just calling into the manager
21:04:59 mriedem dansmith: jaypipes: this fixed revert for me https://review.openstack.org/#/c/488510/6/nova/compute/resource_tracker.py
21:05:06 mriedem basically the same thing as confirm in the RT
21:07:16 jaypipes mriedem: sure, ok will add that.
21:08:20 mriedem dansmith: i think you just need to do: self.compute.manager.update_available_resource(ctxt)
21:08:30 dansmith mriedem: I know
21:08:43 dansmith mriedem: getting a failure on one of the conditions after doing that though
21:12:45 openstackgerrit Michael Still proposed openstack/nova master: Move execs of touch to privsep. https://review.openstack.org/489190
21:14:02 dansmith yeah, no worky
21:14:05 dansmith it's running the code
21:15:17 dansmith and I'm running it for both of the fake hosts
21:17:34 dansmith heh
21:17:39 dansmith it's deleting the instance allocation
21:17:52 dansmith I wonder if this is just a different orientation of some races
21:20:40 dansmith yeah I think if I reorder the RT runs it fails in a different way
21:22:41 cburgess Anyone know if we have an API call to retrieve the contents of and entry in the block_device_mapping table? I can't find one but wanted to confirm before I went and did bad horrible ugly things.
21:23:24 openstackgerrit Jackie Truong proposed openstack/nova master: Add trusted_certs to Instance object https://review.openstack.org/489408
21:23:26 openstackgerrit Merged openstack/nova master: Updated from global requirements https://review.openstack.org/488865
21:25:29 tonyb Any chance someone that knows SSL can look at: https://review.openstack.org/#/c/489078/ Somethign like that is needed to unblock the glanceclient update in requirements
21:31:20 openstackgerrit Dan Smith proposed openstack/nova master: Test resize with placement api https://review.openstack.org/487958
21:31:32 dansmith mriedem: jaypipes: pretty brutal brokenness when we explicitly run the periodics ^ :(
21:32:02 dansmith almost all of the checks are commented out and replaced with "assert there is no allocation at all"
21:33:14 mikal sdague: I am awake now
21:33:33 mikal sdague: I replied to your reno comment. I think we do them later as we remove things, not in that cleanup patch.
21:33:42 mriedem comments in ps9
21:33:52 mikal sdague: I'd also like to get that series merged really early in Queens in case it destabilizes things in confusing ways.
21:35:32 dansmith mriedem: I had just removed those prints.. do you want them as log.info or is removed okay?
21:35:54 mriedem removed is fine, the should be in the mismatch error anyway
21:35:57 mriedem *they
21:39:43 dansmith mriedem: you wanna go through my latest rev quickly to see if you're okay with those changes and then I'll fix your redundancies?
21:40:19 mriedem i can
21:40:40 mriedem i thought you said the direct update_available_resource made everything go sideways though?
21:41:05 dansmith that was before I realized how fscked it was with them set
21:41:11 mriedem oh
21:41:28 dansmith letting them run in the sleep was causing them to run twice (well 1.5 times) and so the things that worked were hard-coded for that pattern
21:42:14 dansmith so it would update, delete, create in the span of the two seconds
21:42:20 dansmith running them each once leaves it at update, delete
21:42:27 dansmith so no allocation at all, target or source
21:42:36 mriedem ok new things looks fine
21:42:41 dansmith ack
21:44:39 dansmith boom ^
21:44:41 dansmith dang
21:44:41 openstackgerrit Dan Smith proposed openstack/nova master: Test resize with placement api https://review.openstack.org/487958
21:44:44 dansmith boom ^
21:45:36 mriedem oh you sucker
21:45:59 mriedem DOUBLE BOOM!
21:46:03 mriedem SONIC BOOM?!
21:48:17 tonyb mriedem: https://www.youtube.com/watch?v=Fnmh7dF4c2U
21:48:20 dansmith ah, I didn't realize what you were pointing to in that
21:48:57 mriedem tonyb: exactly
21:49:21 openstackgerrit Dan Smith proposed openstack/nova master: Test resize with placement api https://review.openstack.org/487958
21:49:41 dansmith turBOOM
21:51:32 mriedem dansmith: the commit message is a bit old now
21:51:41 dansmith gdi riedeman
21:52:11 mriedem well you could just leave it
21:52:24 mriedem 2 n's btw
21:52:29 mriedem double-n as my dad would say

Earlier   Later