Earlier  
Posted Nick Remark
#openstack-nova - 2017-07-25
06:17:29 openstackgerrit Tony Breeds proposed openstack/nova master: Do not import nova.conf into nova/exception.py https://review.openstack.org/485907
06:17:29 openstackgerrit Tony Breeds proposed openstack/nova master: Move the last_bytes util method to libvirt https://review.openstack.org/472228
06:17:30 openstackgerrit Tony Breeds proposed openstack/nova master: rootwrap.d cleanup mislabeled files https://review.openstack.org/486831
06:17:30 openstackgerrit Tony Breeds proposed openstack/nova master: Move libvirt usages of chown to privsep. https://review.openstack.org/471972
06:20:56 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Wrong href link returned when providing non-existed version in GET version API https://review.openstack.org/486850
06:30:38 trinaths qemu-system-aarch64: /root/qemu/hw/virtio/vhost.c:1186: vhost_virtqueue_mask: Assertion `vdev->use_guest_notifier_mask' failed. Please help me in resolving this issue.
06:30:38 trinaths hi, I'm using nova (mitaka) compute. when I spawn a VM, it will auto shutoff after 10 minutes. and at qemu logs, it was the error: 2017-07-25T00:52:49.334691Z qemu-system-aarch64: Failed initializing vhost-user memory map, consider using -object memory-backend-file share=on
06:33:45 openstackgerrit Tony Breeds proposed openstack/nova master: Avoid chowning console logs in libvirt https://review.openstack.org/472229
06:37:06 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi: cached images should be cleaned up by time https://review.openstack.org/465954
06:54:24 openstackgerrit Tony Breeds proposed openstack/nova master: Avoid chowning console logs in libvirt https://review.openstack.org/472229
06:54:25 openstackgerrit Tony Breeds proposed openstack/nova master: Move the last_bytes util method to libvirt https://review.openstack.org/472228
06:54:25 openstackgerrit Tony Breeds proposed openstack/nova master: First attempt at adding a privsep user to nova itself. https://review.openstack.org/459166
06:54:26 openstackgerrit Tony Breeds proposed openstack/nova master: Move libvirt usages of chown to privsep. https://review.openstack.org/471972
06:54:26 openstackgerrit Tony Breeds proposed openstack/nova master: Do not import nova.conf into nova/exception.py https://review.openstack.org/485907
06:54:27 openstackgerrit Tony Breeds proposed openstack/nova master: rootwrap.d cleanup mislabeled files https://review.openstack.org/486831
07:47:18 openstackgerrit Hironori Shiina proposed openstack/nova master: Ironic: Get IP address for volume connector https://review.openstack.org/468353
08:03:22 openstackgerrit Rawan Herzallah proposed openstack/nova master: Adding NVMEoF for libvirt driver https://review.openstack.org/482640
08:07:42 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Wrong href link returned when providing non-existed version in GET version API https://review.openstack.org/486850
08:15:30 jangutter Hi, there are two patches left for netronome-smartnic-enablement. Would anyone have cycles to leave comments? 50 lines of code, 300 lines of tests, many litres of blood. https://review.openstack.org/#/c/486426/ and https://review.openstack.org/#/c/483459/
08:16:43 jangutter For that matter, Mellanox's got a similar patch: https://review.openstack.org/#/c/398265/
08:42:46 openstackgerrit Artem Tiumentcev proposed openstack/nova-specs master: SPEC: nova disk quota tracking https://review.openstack.org/486947
08:49:08 openstackgerrit Tony Breeds proposed openstack/nova master: Avoid chowning console logs in libvirt https://review.openstack.org/472229
09:01:21 kashyap mdbooth: Thanks for the review here: https://review.openstack.org/#/c/485752/
09:01:32 kashyap mdbooth: Test - I will fix, that's also why I -1ed it myself.
09:01:55 kashyap mdbooth: But the core change itself is working; the downstream bug reporter has tested the fix and confirmed that they don't see the perf regression anymore with this fix
09:18:24 mdbooth kashyap: Yeah, I said it looked good :)
09:18:43 mdbooth Except for the bits which didn't, but you can sort those easily enough.
09:18:57 kashyap mdbooth: Sure, did notice your remark. :-)
09:19:17 kashyap mdbooth: The bits which didn't are - (a) missing tests; (b) adding in the config line that accidentally removed
09:19:21 kashyap Anything else you noticed?
09:19:42 mdbooth Nope.
09:20:05 mdbooth The code structure is kinda ugly, but sahid already noted that
09:20:22 openstackgerrit Alexandru Muresan proposed openstack/nova master: Ensure that vif ports are unplugged during cold migration https://review.openstack.org/486955
09:22:38 kashyap mdbooth: There's a comment from Sahid? I don't even see it, /me refreshes the URL
09:22:49 kashyap Maybe you mean in the code
09:22:49 mdbooth Not a review comment
09:22:53 kashyap Yeah, noted.
09:22:57 mdbooth A code comment from the distant past
09:23:56 kashyap Yep
09:25:33 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Add tags fields for server list detail/show api-ref https://review.openstack.org/465842
09:31:47 openstackgerrit Rikimaru Honjo proposed openstack/nova master: compute: Sweep duplicated bdm records https://review.openstack.org/290793
09:32:31 openstackgerrit Béla Vancsics proposed openstack/nova master: Transform instance.resize_confirm notification https://review.openstack.org/482557
09:36:02 bauzas gabor_antal: gibi: about https://review.openstack.org/#/c/467514/7/nova/compute/api.py@4977 honestly my only concern was that I think "import" is probably not a great RESTful action
09:37:10 bauzas gabor_antal: gibi: cdent reminded me previously that a PUT can create or update with a body so in theory there should only be one notification of creation
09:37:39 bauzas but anyway, seems I'm nitpicking
09:45:44 bauzas gibi: btw. any notifications patches I could help to land before FF ?
10:18:30 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Migration from ``ip`` commands to ``pyroute2`` https://review.openstack.org/484386
10:29:33 gibi bauzas: hi! thanks for the feedback. I don't have direct user feedback so I cannot say for sure that we need import in the notification but it feels useful for me
10:29:43 bauzas cools
10:31:14 gibi bauzas: for patches to help in, I see on patch that needs a second +2 https://review.openstack.org/#/c/480984/
10:31:51 gibi bauzas: besides that we have a list of patches that looks good from subteam perspective (and has +1) here https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/versioned-notification-transformation-pike+label:Code-Review%253E%253D%252B1+label:Verified%253E%253D1+AND+NOT+label:Verified%253C0+AND+NOT+label:Code-Review%253C0
10:34:12 openstackgerrit Gábor Antal proposed openstack/nova master: Transform HostAPI-set_enabled notifications https://review.openstack.org/482622
10:34:15 gibi bauzas: any help is appreciated
10:38:28 bauzas gibi: going out for lunch but will review those afterwards
10:40:50 openstackgerrit Merged openstack/nova master: Remove check_detach https://review.openstack.org/446671
10:43:18 gibi bauzas: enjoy for lunch, I just brought mine in the meantime
10:49:05 gibi s/for/your/
10:50:24 openstackgerrit Alexandra Settle proposed openstack/nova master: doc: Rework index page per new sections https://review.openstack.org/478485
11:03:40 openstackgerrit Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964
11:09:27 openstackgerrit Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964
11:14:50 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042
11:21:53 openstackgerrit Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964
11:25:36 ildikov stephenfin: hi
11:26:57 ildikov stephenfin: I just wanted to ask whether you got a chance to check stvnoyes's answers here: https://review.openstack.org/#/c/463987/ to see whether they address your concerns?
11:28:05 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042
11:38:25 mamandle bauzas: https://review.openstack.org/#/c/483911/ needs a second +2, can you please take a look?
11:43:15 openstackgerrit Ildiko Vancsa proposed openstack/nova master: WIP: Allow multi-attach in compute api https://review.openstack.org/271047
11:43:17 openstackgerrit Ildiko Vancsa proposed openstack/nova master: libvirt: Allow multiple volume attachments https://review.openstack.org/267587
12:12:51 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/477091
12:14:06 mamandle stephenfin: can you please check https://review.openstack.org/#/c/483911/ , its waiting on another +2.
12:19:13 openstackgerrit Merged openstack/nova master: [placement] Flush RC_CACHE after each gabbit sequence https://review.openstack.org/486805
12:25:51 mriedem ildikov: stephenfin is on vacation all week
12:30:08 s-dean Hi, im a at a loss trying to get this working, this is a RPC problem right ? <class 'oslo_messaging.exceptions.MessagingTimeout'>
12:30:26 sdague cdent: so it looks like you got to the bottom of the fixture issue?
12:30:36 sdague though we seem to be bouncing off a keystone issue
12:30:44 cdent sdague: I _think_ so
12:32:24 openstackgerrit Rawan Herzallah proposed openstack/nova master: Adding NVMEoF for libvirt driver https://review.openstack.org/482640
12:32:26 cdent I started working on the OSAPIFixture too, but something has introduced some painful slowness. not clear if it is just wsgi intercept itself, or some other weirdness
12:35:43 mriedem jaypipes: i think i'm going to mark this done for pike https://blueprints.launchpad.net/nova/+spec/placement-allocation-requests
12:39:11 jaypipes mriedem: ack
12:39:39 jaypipes mriedem: I'll update the spec
12:41:38 mriedem thank
12:41:39 mriedem s
12:51:59 openstackgerrit Gábor Antal proposed openstack/nova master: use context mgr in instance.delete https://review.openstack.org/443764
12:55:00 s-dean Hi, could someone take a look at this log this is really weird. compute01 connects to rabbit, but throws this error. https://pastebin.com/ZbpJtBq8
12:55:19 bauzas jaypipes: I just thought about a possible problem with https://review.openstack.org/#/c/483566/10
12:55:39 bauzas jaypipes: tl;dr how can we be sure that the first allocation request node is accepted by the filters ?
12:56:19 openstackgerrit Alexandra Settle proposed openstack/nova master: doc: Rework index page per new sections https://review.openstack.org/478485
12:56:25 bauzas jaypipes: when we're getting a list of hosts after we run filters, we should possibly subset the alloc_reqs list to be only for accepted nodes, nope ?
12:56:43 bauzas jaypipes: unless you're changing it somewhere and I'm blind
13:02:03 mriedem TheJulia: looks like CI for https://review.openstack.org/#/c/215385/ has passed using https://review.openstack.org/#/c/485812/ yes?
13:02:13 mriedem although maybe not on the latest change?
13:03:43 cdent sdague: is this nutbar or crazy pants or hmmm? https://review.openstack.org/#/c/486829/
13:03:53 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Use wsgi_intercept in PlacementFixture https://review.openstack.org/486237
13:03:53 openstackgerrit Chris Dent proposed openstack/nova master: Use wsgi-intercept in OSAPIFixture https://review.openstack.org/486825
13:04:18 mriedem TheJulia: or are you testing here now? https://review.openstack.org/#/c/485349/
13:04:34 bauzas cdent: I'd be okay with wsgi-intercept but my concern goes with how many people are working for it
13:05:15 cdent bauzas: the crazy pants question was about modify MiniDNS not wsgi-intercept.
13:05:31 cdent on wsgi-intercept: we are already committed to using it because we are committed to using gabbi
13:05:40 bauzas cdent: I'm looking at its github page, and it means nova would have a dependency for a small package

Earlier   Later