| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-07-21 | |||
| 13:26:31 | vdrok | stephenfin: it's about comments in code and relnote update I think, so should not affect the doc-migration | |
| 13:28:10 | stephenfin | vdrok: Yeah, it's just the support-matrix changes that would cause the issue | |
| 13:28:45 | stephenfin | vdrok: Unless mriedem disagrees, could I ask you to split that little bit out into a separate patch, and we'll merge it in after? | |
| 13:28:56 | vdrok | stephenfin: oh, ok, I'll check the doc-migration patches then, can rebase on top of the relevant one | |
| 13:29:27 | stephenfin | maybe not, because I can't be sure they'll get in before feature freeze, and I'm sure you want it in then | |
| 13:29:45 | stephenfin | two separate patches would be better, because we can merge docs after feature freeze | |
| 13:30:02 | stephenfin | vdrok: just the support-matrix doc. Release note is fine | |
| 13:30:25 | vdrok | okie | |
| 13:31:16 | stephenfin | ta :) | |
| 13:37:19 | jangutter | Would anyone have the time to give https://review.openstack.org/#/c/483459 (Netronome VIF type) a quick once-over? 62 lines of code, 290 lines of tests and 42 litres of tears. | |
| 13:46:35 | openstackgerrit | Vladyslav Drok proposed openstack/nova master: Implement interface attach/detach in ironic virt driver https://review.openstack.org/419975 | |
| 13:46:58 | openstackgerrit | Vladyslav Drok proposed openstack/nova master: Update ironic feature matrix https://review.openstack.org/486148 | |
| 13:58:43 | stephenfin | Dinesh_Bhor: done and done | |
| 14:00:15 | stephenfin | vdrok: docs patch +2'd | |
| 14:00:24 | stephenfin | I'll leave the code one to mriedem for now | |
| 14:00:28 | vdrok | stephenfin: thanks :) | |
| 14:02:10 | Dinesh_Bhor | stephenfin: thank you so much | |
| 14:03:07 | openstackgerrit | Alexandra Settle proposed openstack/nova master: doc: Rework index page per new sections https://review.openstack.org/478485 | |
| 14:05:47 | jaypipes | figleaf: yes it is. please do work on alternates, that would be great | |
| 14:05:50 | jaypipes | and thank you! | |
| 14:06:22 | jaypipes | will give me time to add func tests around failures on compute nodes | |
| 14:07:06 | openstackgerrit | Sean Dague proposed openstack/nova master: request_log addition for running under uwsgi https://review.openstack.org/485602 | |
| 14:07:15 | sdague | mriedem: that should be ready to go... I hope ^^^ | |
| 14:09:28 | openstackgerrit | Felipe Monteiro proposed openstack/nova master: Update policy description for 'instance_actions' https://review.openstack.org/484609 | |
| 14:09:32 | figleaf | jaypipes: on it | |
| 14:25:27 | leakypipes | mriedem, superdan, melwitt: super important bug fix: https://review.openstack.org/#/c/485088/6 | |
| 14:25:45 | leakypipes | it addresses the transient NoValidHosts issue we've been seeing. | |
| 14:25:52 | leakypipes | in some of the functional test failures. | |
| 14:26:27 | melwitt | noice | |
| 14:35:04 | leakypipes | mriedem: btw, did you see cdent's ? to you on https://review.openstack.org/#/c/483566/? | |
| 14:35:25 | mriedem | just sat down with coffee for the first time today, so i haven't seen anything | |
| 14:35:40 | mriedem | just a lot of pings | |
| 14:38:30 | mriedem | leakypipes: it's a comment on that change | |
| 14:38:35 | mriedem | leakypipes: looking at the grenade failure | |
| 14:38:42 | mriedem | http://logs.openstack.org/66/483566/6/check/gate-grenade-dsvm-neutron-ubuntu-xenial/b0077c3/logs/new/screen-n-sch.txt.gz?level=TRACE#_2017-07-20_23_58_04_589 | |
| 14:38:46 | mriedem | we have 1 node in this job | |
| 14:39:04 | mriedem | the scheduler goes to submit an allocation and it fails because something else slipped in and changed the inventory at the same time | |
| 14:39:28 | mriedem | with concurrently running tests in a single node job, if we merge this, i think it's going to kill the gate | |
| 14:39:50 | leakypipes | gotcha | |
| 14:40:10 | mriedem | so i think that means if we have exhausted the list of filtered hosts in the filter scheduler, | |
| 14:40:23 | mriedem | we have to go back up to the scheduler manager and retry by getting a fresh set of allocation candidates | |
| 14:40:38 | mriedem | until CONF.num_retries or whatever | |
| 14:40:52 | leakypipes | mriedem: well, we could also retry the same host if we get that specific error. | |
| 14:41:51 | leakypipes | mriedem: the issue is we'd need to put somehting into the claim_resources() report client method to distinguish between 409 Conflict for concurrent update and 409 Conflict for InvalidInventory (which is returned when the capacity was exceeded by another thread and thus the same claim request would fail) | |
| 14:41:54 | mriedem | i'm happy with that, | |
| 14:42:02 | mriedem | i just wasn't sure if we could do it | |
| 14:43:04 | leakypipes | mriedem: yup. gimme about an hour. I'll add a dependent patch before that one that adds the error condition distinguishing thing | |
| 14:43:14 | leakypipes | mriedem: and then mod the patch to retry same host on concurrent update | |
| 14:43:58 | mriedem | ack | |
| 14:46:41 | figleaf | leakypipes: I have a small but significant bug in https://review.openstack.org/#/c/483566/ as long as you're fixing the 409 claim conflict | |
| 14:47:36 | figleaf | leakypipes: Also, did we agree that the number of alternates would be based on CONF.scheduler.max_attempts? | |
| 14:47:49 | leakypipes | figleaf: yeah | |
| 14:47:54 | figleaf | ok | |
| 14:51:22 | mriedem | vdrok: https://review.openstack.org/#/c/419975/18..19/doc/source/support-matrix.ini ? | |
| 14:51:35 | mriedem | you dropped that in PS19 | |
| 14:51:42 | mriedem | otherwise i'd +2 | |
| 14:53:19 | vdrok | mriedem: stephenfin asked to move it to a separate change to avoid conflict with doc migration | |
| 14:54:04 | vdrok | mriedem https://review.openstack.org/486148 | |
| 14:55:23 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement interface attach/detach in ironic virt driver https://review.openstack.org/419975 | |
| 14:55:42 | mriedem | vdrok: ack, + | |
| 14:55:43 | mriedem | +2 | |
| 14:56:11 | mriedem | very simple +W for someone https://review.openstack.org/#/c/419975/ | |
| 14:56:19 | vdrok | Thanks! | |
| 14:56:41 | mriedem | yw | |
| 14:58:16 | melwitt | mriedem: does that one imply we also need to update the hypervisor matrix? | |
| 14:58:40 | mriedem | melwitt: see ^ | |
| 14:58:41 | mriedem | :) | |
| 14:58:47 | mriedem | https://review.openstack.org/486148 | |
| 14:59:08 | melwitt | oh, heh | |
| 14:59:12 | mriedem | stephenfin, the kaiser of docs, asked to move it | |
| 14:59:31 | melwitt | brought down the hammer | |
| 14:59:59 | stephenfin | All Hail Stephen | |
| 15:00:13 | stephenfin | *too | |
| 15:00:42 | mriedem | only if markus_z is around | |
| 15:03:16 | melwitt | mriedem: I didn't notice this till now, but do you think "other" is the right place for this type of release note? or should it be under "upgrade"? https://review.openstack.org/#/c/386008/10/releasenotes/notes/quota-show-detail-access-d6f37282d288fa33.yaml | |
| 15:03:56 | mriedem | melwitt: sdague asked me about this exact same one earlier in the week :) | |
| 15:04:17 | melwitt | give me the scoop | |
| 15:04:21 | mriedem | if it were a new rule, other would be fine i think, | |
| 15:04:32 | mriedem | since it's changing the default for an existing rule, upgrade seems more appropriate | |
| 15:04:43 | mriedem | i think of it like config options | |
| 15:05:01 | melwitt | that's what I thought, I hadn't noticed it was "other" when I +2ed it. guess I'll change it and re +2 | |
| 15:10:01 | openstackgerrit | melanie witt proposed openstack/nova master: Change default policy to view quota details https://review.openstack.org/386008 | |
| 15:12:59 | openstackgerrit | Merged openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/485950 | |
| 15:46:24 | mriedem | ildikov: at some point we'll have to talk about the connection_info stuff going on in https://review.openstack.org/#/c/330285/ because i don't get it | |
| 15:46:31 | mriedem | did cinder regress that in the api | |
| 15:46:32 | mriedem | ? | |
| 15:46:53 | mriedem | i'm not sure why nova needs to stitch things back together | |
| 15:47:19 | ildikov | mriedem: the information that's coming back from Cinder in the new calls is everything in one dict | |
| 15:47:27 | ildikov | mriedem: so there's no nested dict anymore | |
| 15:47:42 | ildikov | mriedem: whatever was under the 'data' key is in connection_info | |
| 15:47:47 | mriedem | oh | |
| 15:47:54 | ildikov | mriedem: so we put back the 'data' key for now | |
| 15:47:56 | mriedem | ok we need to separate that out into a different change then | |
| 15:48:03 | ildikov | mriedem: too much effort to remove it... | |
| 15:48:11 | ildikov | mriedem: it's already separated out | |
| 15:48:29 | mriedem | where? | |
| 15:48:32 | ildikov | mriedem: I just try to fix the old flow tests in the attach patch before upload the extended chain | |
| 15:48:37 | mriedem | ah ok | |
| 15:48:49 | mriedem | ok yeah the amount of test change in that patch really scared me | |
| 15:48:53 | ildikov | mriedem: but I can upload where I am now if you want to take a look | |