| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-07-21 | |||
| 09:29:27 | openstackgerrit | Gábor Antal proposed openstack/nova master: Transform instance.rebuild_scheduled notification https://review.openstack.org/473929 | |
| 09:29:28 | alex_xu | stephenfin: ok :) why change a new name | |
| 09:29:33 | openstackgerrit | Gábor Antal proposed openstack/nova master: Transform instance.resize_prep notification https://review.openstack.org/465081 | |
| 09:29:36 | openstackgerrit | Gábor Antal proposed openstack/nova master: Transform aggregate.update_prop notification https://review.openstack.org/462576 | |
| 09:30:33 | stephenfin | alex_xu: So people stop dropping the 'e' from my last name (Finucane) :) Also, so I can use the same name _everywhere_ (GitHub, Twitter, etc.) | |
| 09:32:13 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add tags to instance.create Notification https://review.openstack.org/459493 | |
| 09:32:19 | alex_xu | stephenfin: haha | |
| 09:47:04 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add abstract OVSDB API https://review.openstack.org/476612 | |
| 09:51:12 | smcginnis | I'm a little confused on a Nova unit test failure we are getting on the version bump of the cinderclient. | |
| 09:51:15 | smcginnis | http://logs.openstack.org/03/485903/2/check/gate-cross-nova-python27-ubuntu-xenial/bd55208/console.html#_2017-07-21_05_00_42_049094 | |
| 09:51:35 | smcginnis | The Nova test code passes skip_version_check=True | |
| 09:51:38 | smcginnis | https://github.com/openstack/nova/blob/master/nova/tests/unit/volume/test_cinder.py#L851 | |
| 09:52:02 | smcginnis | But then it blows up on checking the microversion here: | |
| 09:52:03 | smcginnis | https://github.com/openstack/nova/blob/master/nova/volume/cinder.py#L141 | |
| 09:53:39 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add native implementation OVSDB API https://review.openstack.org/482226 | |
| 10:09:25 | frickler | smcginnis: you are looking at the wrong test is seems, this one is failing: https://github.com/openstack/nova/blame/master/nova/tests/unit/volume/test_cinder.py#L826 . does the new python-cinderclient provide a different 3.x range only? | |
| 10:11:01 | smcginnis | frickler: Shoot, you're right. Don't know how I messed that up when the line number is right in the traceback. | |
| 10:11:09 | frickler | smcginnis: ah, this is probably the default version changed here: https://github.com/openstack/nova/blame/master/nova/tests/unit/volume/test_cinder.py#L823 | |
| 10:12:40 | smcginnis | frickler: MAX_VERSION is now 3.40. Hmm. | |
| 10:13:09 | frickler | smcginnis: seems wrong from nova to make assuptions about that being 3.27 permanently | |
| 10:14:20 | smcginnis | frickler: Well, if I understand this correctly, unless we remove that microversion it should always be there. | |
| 10:14:36 | smcginnis | frickler: Looking at the check code to see what it's doing now. | |
| 10:19:00 | smcginnis | Looks like we may still have a bug in python-cinderclient. | |
| 10:19:17 | smcginnis | It was supposed to have been fixed here it was treating version as a float. | |
| 10:19:48 | smcginnis | So 3.40 becomes 3.4, which makes the range checking off. | |
| 10:21:04 | frickler | smcginnis: the test mocks the answer in L823 by using the constant from python-cinderclient, so it will be 3.4. but it compares that result to the fixed string "3.27". so IMO either the mock or the comparison should be fixed | |
| 10:22:06 | smcginnis | frickler: Ah, you're right. Line 823 calls float() on that. | |
| 10:22:17 | smcginnis | frickler: I think the test needs to be fixed then. | |
| 10:22:31 | smcginnis | frickler: Thanks, I can fix that quick. | |
| 10:22:59 | smcginnis | frickler: Although I obviously need more coffee based on the number of obvious things you've had to point out to me. :) | |
| 10:28:55 | openstackgerrit | Stephen Finucane proposed openstack/nova master: console: introduce framework for RFB authentication https://review.openstack.org/345397 | |
| 10:28:55 | openstackgerrit | Stephen Finucane proposed openstack/nova master: console: introduce basic framework for security proxying https://review.openstack.org/345396 | |
| 10:28:56 | openstackgerrit | Stephen Finucane proposed openstack/nova master: console: introduce the VeNCrypt RFB authentication scheme https://review.openstack.org/345398 | |
| 10:28:57 | openstackgerrit | Stephen Finucane proposed openstack/nova master: console: provide an RFB security proxy implementation https://review.openstack.org/345399 | |
| 10:32:47 | openstackgerrit | Sean McGinnis proposed openstack/nova master: Don't case cinderclient microversions to float https://review.openstack.org/486096 | |
| 10:33:54 | openstackgerrit | Sean McGinnis proposed openstack/nova master: Don't cast cinderclient microversions to float https://review.openstack.org/486096 | |
| 10:36:10 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Switch to openstackdocstheme https://review.openstack.org/477751 | |
| 10:36:10 | sdague | hey alex_xu, you still around today? If so, I'd like to get your take on - https://review.openstack.org/#/c/485602/ | |
| 10:49:17 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add memoize function using oslo.cache https://review.openstack.org/472773 | |
| 11:01:19 | cdent | bauzas: is this still alive: https://review.openstack.org/#/c/427200/ | |
| 11:23:56 | jangutter | Would someone be able to trigger +W on https://review.openstack.org/#/c/485634/ <--- updated from global requirements | |
| 11:42:52 | sdague | jangutter: done | |
| 11:44:09 | jangutter | sdague: thanks! as a bit of a newbie I am both in awe and scared snotless of the automation here. | |
| 11:46:12 | jangutter | just one or two more levels of indirection and you can trigger a job to write the code from specs. | |
| 12:03:10 | openstackgerrit | Gábor Antal proposed openstack/nova master: Transform instance.live_migration_rollback_dest notification https://review.openstack.org/480214 | |
| 12:11:35 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/477091 | |
| 12:19:05 | bauzas | cdent: sorry was afk | |
| 12:19:26 | cdent | no problem | |
| 12:19:33 | bauzas | cdent: we could yeah, totally | |
| 12:19:40 | bauzas | cdent: I just need to resurrect this one | |
| 12:20:37 | cdent | I was going through the links on the prevous rp update and wanted to make sure that anything there was still relevant before creating the new one | |
| 12:28:28 | bauzas | np | |
| 12:28:45 | openstackgerrit | Sean Dague proposed openstack/nova master: request_log addition for running under uwsgi https://review.openstack.org/485602 | |
| 12:32:31 | openstackgerrit | Alexandra Settle proposed openstack/nova master: doc: Rework index page per new sections https://review.openstack.org/478485 | |
| 12:44:13 | openstackgerrit | Vladyslav Drok proposed openstack/nova master: Implement interface attach/detach in ironic virt driver https://review.openstack.org/419975 | |
| 12:46:05 | openstackgerrit | Ed Leafe proposed openstack/nova master: Migrate Ironic Flavors https://review.openstack.org/484949 | |
| 12:52:57 | figleaf | leakypipes: Is https://review.openstack.org/#/c/483566/ the last one in your series? | |
| 12:53:12 | figleaf | leakypipes: if so, I can start working on adding alternates | |
| 13:13:49 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/485634 | |
| 13:13:59 | Dinesh_Bhor | stephenfin, mriedem: Hi, wanted to discuss this blueprint: https://blueprints.launchpad.net/nova/+spec/specify-keymap-on-server-boot | |
| 13:14:47 | stephenfin | Dinesh_Bhor: Are you referring to the bug I have opened to deprecate those options? | |
| 13:14:52 | Dinesh_Bhor | stephenfin, mriedem: We started work on this But it seems to contradict with this bug: https://bugs.launchpad.net/nova/+bug/1682020/ | |
| 13:14:54 | openstack | Launchpad bug 1682020 in OpenStack Compute (nova) "Remove nova default keymap option for qemu-kvm (deprecated)" [Undecided,In progress] - Assigned to Stephen Finucane (stephenfinucane) | |
| 13:15:03 | Dinesh_Bhor | stephenfin: yes | |
| 13:15:04 | stephenfin | Indeed you are :) | |
| 13:15:11 | stephenfin | Right, so what do you want to know? | |
| 13:15:45 | Dinesh_Bhor | stephenfin: Whether should we proceed work of that blueprint | |
| 13:15:48 | Dinesh_Bhor | ? | |
| 13:17:36 | stephenfin | Dinesh_Bhor: Personally, I wouldn't | |
| 13:17:48 | stephenfin | You've seen the comment from danpb on that bug | |
| 13:18:16 | stephenfin | We shouldn't be doing that, and it's breaking stuff for us. The blueprint sounds like it would be putting lipstick on a pig, so to speak :) | |
| 13:19:11 | openstackgerrit | Steve Noyes proposed openstack/nova master: update live migration to use v3 cinder api https://review.openstack.org/463987 | |
| 13:21:16 | Dinesh_Bhor | stephenfin: ohh, ohk. Understood. Could you please comment on those patches about your opinion? | |
| 13:21:52 | Dinesh_Bhor | stephenfin: patches submitted against that blueprint | |
| 13:22:26 | mriedem | keymapping huh, huawei has interest in something similar for vnc consoles i think | |
| 13:22:31 | mriedem | but i'd have to dig up the details | |
| 13:23:30 | mriedem | vdrok: a couple of small things in https://review.openstack.org/#/c/419975/ just for docs | |
| 13:24:03 | vdrok | mriedem: thx, updating | |
| 13:25:40 | stephenfin | mriedem, vdrok: Docs, you say? That's going to bring merge conflicts for doc-migration | |
| 13:25:53 | stephenfin | I assume it's too important to -2 until doc-migration is, as I've been doing of late? | |
| 13:26:31 | vdrok | stephenfin: it's about comments in code and relnote update I think, so should not affect the doc-migration | |
| 13:28:10 | stephenfin | vdrok: Yeah, it's just the support-matrix changes that would cause the issue | |
| 13:28:45 | stephenfin | vdrok: Unless mriedem disagrees, could I ask you to split that little bit out into a separate patch, and we'll merge it in after? | |
| 13:28:56 | vdrok | stephenfin: oh, ok, I'll check the doc-migration patches then, can rebase on top of the relevant one | |
| 13:29:27 | stephenfin | maybe not, because I can't be sure they'll get in before feature freeze, and I'm sure you want it in then | |
| 13:29:45 | stephenfin | two separate patches would be better, because we can merge docs after feature freeze | |
| 13:30:02 | stephenfin | vdrok: just the support-matrix doc. Release note is fine | |
| 13:30:25 | vdrok | okie | |
| 13:31:16 | stephenfin | ta :) | |
| 13:37:19 | jangutter | Would anyone have the time to give https://review.openstack.org/#/c/483459 (Netronome VIF type) a quick once-over? 62 lines of code, 290 lines of tests and 42 litres of tears. | |
| 13:46:35 | openstackgerrit | Vladyslav Drok proposed openstack/nova master: Implement interface attach/detach in ironic virt driver https://review.openstack.org/419975 | |
| 13:46:58 | openstackgerrit | Vladyslav Drok proposed openstack/nova master: Update ironic feature matrix https://review.openstack.org/486148 | |
| 13:58:43 | stephenfin | Dinesh_Bhor: done and done | |
| 14:00:15 | stephenfin | vdrok: docs patch +2'd | |
| 14:00:24 | stephenfin | I'll leave the code one to mriedem for now | |
| 14:00:28 | vdrok | stephenfin: thanks :) | |
| 14:02:10 | Dinesh_Bhor | stephenfin: thank you so much | |
| 14:03:07 | openstackgerrit | Alexandra Settle proposed openstack/nova master: doc: Rework index page per new sections https://review.openstack.org/478485 | |
| 14:05:47 | jaypipes | figleaf: yes it is. please do work on alternates, that would be great | |
| 14:05:50 | jaypipes | and thank you! | |