Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-07-17
22:32:49 dansmith idk, I just think more magic object conversions hide where this is happening
22:33:37 mriedem true
22:33:45 mriedem i don't like any of it really so i don't care too much :)
22:35:24 dansmith they're reverting the jsonutils change, but they plan to put it back in I guess?
22:35:58 mriedem they plan to put it back in with a UserWarning that the thing passed in can't be turned into a primitive
22:36:15 mriedem and then drop that at some point with a major version bump i guess
22:36:17 dansmith okay
22:36:25 mriedem since it's an api change in the library
22:36:45 mriedem but 6 months from now who knows if anyone will remember any of this
22:36:52 dansmith well, I dunno, we shouldn't really be doing this in the first place for an unversioned return value of an rpc call, IMHO
22:37:07 dansmith but IMHO, it's best to be very explicit and targeted if we're going to convert it
22:37:28 dansmith i.e. "if there is a numa limit, it is a NumaWhateverObject and we shall always convert it to primitive"
22:38:04 mriedem ok making that change
22:48:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Convert HostState.limits['numa_topology'] to primitive https://review.openstack.org/484439
23:11:09 mriedem efried: is https://review.openstack.org/#/c/458257/ the last thing for that bp?
23:11:14 mriedem i see the dependent change is in ksa 2.20
23:12:10 efried mriedem No, that one had a couple of the clienty changes; plan was to follow up with others.
23:12:15 efried mriedem Did ksa 2.20 happen??
23:12:54 efried mriedem Or maybe 2.20 isn't the one I thought I was trying to squeeze stuff into right now.
23:13:57 mriedem https://review.openstack.org/#/c/482742/ ?
23:14:02 mriedem which change in ksa specifically do we need?
23:14:12 mriedem or all over https://review.openstack.org/#/q/topic:version-discovery ?
23:14:15 mriedem *all ov
23:14:16 mriedem *of
23:15:06 efried mriedem That was the hope. Specifically I wanted to fix the APIs in discover.py - https://review.openstack.org/#/c/483604/
23:15:38 efried ...so we didn't release them with unnecessary params and have to support those (and their [really complicated] implications) forever.
23:17:17 mriedem ok so realizing that ksa boat of changes isn't going to land by thursday probably,
23:17:34 mriedem do we have something pragmatic to land in nova to complete this for pike and then improve it later?
23:18:51 mriedem sfinucan: you took over as author on this https://review.openstack.org/#/c/428241/
23:19:06 mriedem i think that git review / rebase bug where it changes author is hitting more than just me
23:19:09 efried mriedem If you're assuming the boat won't land... I would have to work something up that's better than https://review.openstack.org/#/c/458257/ but not the whole ksa hog.
23:19:30 mriedem efried: i'm assuming it won't land by thursday, no
23:19:31 efried But I've been operating under the hope that it's not too late. mordred Pipe dream?
23:19:36 mriedem and if it's rushed, it'll likely be buggy
23:21:15 mordred I don't think it's a pipe-dream
23:21:39 mordred the stuff we're working on getting in are mostly cleanups, better docs and better tests - the hard logic is in
23:22:16 mordred mriedem: I'm currently still pushing towards getting it out this week - I don't think it's unachievable
23:22:50 efried mordred You and I should probably take a hard look at whether https://review.openstack.org/#/c/483604/ (or some variant thereof) is within that achievable umbrella.
23:23:01 efried Cause that's hard logic.
23:23:50 efried Good news is, the test cases are robust to a point where, if we can get 'em passing, I'll have confidence in the code.
23:25:05 mriedem mordred: ok the release freeze is thursday
23:25:08 mordred efried: yes. I agree with that
23:25:11 mordred mriedem: yup
23:25:29 mriedem </project management status update check>
23:25:35 mordred efried: (I agree we need to take a hard look at it - and I agree that the tests are robust and trustable)
23:33:00 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.52 - List/Show all server migration types https://review.openstack.org/430839
23:33:20 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.52 - Enable cold migration with target host https://review.openstack.org/406707
23:48:05 mriedem TheJulia: question in https://review.openstack.org/#/c/419975/
23:48:13 mriedem not sure who on the ironic team has the setup to test this,
23:48:35 mriedem but when plugging the vif, neutron should eventually recognize a state change in the port and send an event back to nova to refresh the cache
23:48:50 mriedem then we wouldn't need all that gorpy refresh cache code within the driver
#openstack-nova - 2017-07-18
00:13:16 openstackgerrit melanie witt proposed openstack/nova master: Request zero root disk for boot-from-volume instances https://review.openstack.org/428481
00:13:17 openstackgerrit melanie witt proposed openstack/nova master: Claim and report zero root disk for boot-from-volume instances https://review.openstack.org/428505
00:30:55 mriedem alex_xu: good morning. the server tags during create API change is ready now I think https://review.openstack.org/#/c/469800/ - the tags filters are supported in the build requests now too
00:31:08 mriedem Kevin_Zheng: ^ you should probably get started on the novaclient support for that microversion too
00:38:14 openstackgerrit Takashi NATSUME proposed openstack/nova-specs master: Amend the "list-show-all-server-migration-types" spec https://review.openstack.org/460847
00:38:26 openstackgerrit Takashi NATSUME proposed openstack/nova master: Use URIOpt https://review.openstack.org/479215
00:38:40 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Verify parameters in os-migrations.inc https://review.openstack.org/474879
00:39:02 openstackgerrit Takashi NATSUME proposed openstack/nova master: Stop using mox stubs in test_remote_consoles.py https://review.openstack.org/478423
00:39:40 openstackgerrit Takashi NATSUME proposed openstack/nova master: Stop using mox stubs in test_console_auth_tokens.py https://review.openstack.org/477374
00:41:19 openstackgerrit Takashi NATSUME proposed openstack/nova master: Stop using mox stubs in cast_as_call.py https://review.openstack.org/477730
01:02:15 openstackgerrit Tuan Luong-Anh proposed openstack/python-novaclient master: Replace uuid.uuid4().hex with uuidutils.generate_uuid() https://review.openstack.org/484244
01:13:02 Kevin_Zheng mriedem: Thank you very very much on this
01:17:50 mriedem sure yw, thanks for being prompt about responding to review comments
01:20:04 Kevin_Zheng btw, could you tell me why did the test I wrote fail? it doesn't seems alot of difference to your patch?
01:20:53 Kevin_Zheng oh, I got it
01:25:42 alex_xu mriedem: got it, I will go through the patch today
01:25:46 sbezverk any knows an equivalent to nova service-list in openstack cli ?
01:26:59 openstackgerrit Merged openstack/nova master: fix test_volume_swap_server instability https://review.openstack.org/484288
01:38:20 mriedem Kevin_Zheng: to pay me back, you can take a look at this and see if there is something obvious that I'm doing wrong to cause this http://logs.openstack.org/70/484170/4/check/gate-nova-python27-ubuntu-xenial/3bafcd1/testr_results.html.gz
01:38:25 mriedem it's totally random
02:02:15 mriedem melwitt: replied to your replies in https://review.openstack.org/#/c/416521/
02:02:22 mriedem melwitt: you saw my -1 over the thing in conductor right?
02:33:18 melwitt mriedem: yeah, then I forgot to reply to it. will reply
02:57:13 openstackgerrit Felipe Monteiro proposed openstack/nova master: Update policy description for 'instance_actions' https://review.openstack.org/484609
02:58:49 openstackgerrit Felipe Monteiro proposed openstack/nova master: Update policy description for 'instance_actions' https://review.openstack.org/484609
03:09:14 TheJulia mriedem: good question, I'll inquire tomorroe. I do seem to remember some discussion of the callback in austin, but at that time it wasn't functional. Of course, I may be crossing threads in my brain at the same time.
03:09:45 TheJulia Tomorrow! :)
03:17:53 openstackgerrit Merged openstack/nova master: Consistent policies https://review.openstack.org/479774
03:25:53 openstackgerrit Merged openstack/nova master: Set wsgi.keep_alive=False globally for tests https://review.openstack.org/483972
03:26:20 openstackgerrit Merged openstack/nova master: Update policy descriptions for base. https://review.openstack.org/472622
03:26:48 openstackgerrit Merged openstack/nova master: scheduler: isolate _get_sorted_hosts() https://review.openstack.org/483564
03:27:23 openstackgerrit Merged openstack/nova master: Use plain routes list for os-networks instead of stevedore https://review.openstack.org/474463
03:48:20 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add 'updated_at' field to InstancePayload in notifications https://review.openstack.org/475276
03:56:38 openstackgerrit Zhenyu Zheng proposed openstack/python-novaclient master: Microversion 2.52 - Support tag when boot https://review.openstack.org/484617
04:27:11 openstackgerrit Mike Perez proposed openstack/nova master: conf: remove *_topic config opts https://review.openstack.org/433924
05:05:30 mamandle alex_xu: Can you please take a look at https://review.openstack.org/#/c/483911/, updated changes are out for review.
06:19:31 openstackgerrit jichenjc proposed openstack/nova master: Adjust error msg for ImageNUMATopologyAsymmetric https://review.openstack.org/484634
06:24:47 openstackgerrit jichenjc proposed openstack/nova master: Adjust error msg for ImageNUMATopologyAsymmetric https://review.openstack.org/484634
06:38:14 openstackgerrit Zhenyu Zheng proposed openstack/python-novaclient master: Microversion 2.52 - Support tag when boot https://review.openstack.org/484617
06:46:36 openstackgerrit Zhenyu Zheng proposed openstack/python-novaclient master: DNM: Regression test for confusing error log in test https://review.openstack.org/484639
06:49:02 openstackgerrit Zhenyu Zheng proposed openstack/python-novaclient master: Fix misleading error log when test fails https://review.openstack.org/484641
06:53:40 openstackgerrit Zhenyu Zheng proposed openstack/python-novaclient master: DNM: Regression test for confusing error log in test - 2 https://review.openstack.org/484645
07:15:52 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Fix indentation in policy doc https://review.openstack.org/484646
08:08:50 openstackgerrit jichenjc proposed openstack/nova master: Check root disk size when doing resize in API https://review.openstack.org/484664
08:15:05 openstackgerrit jichenjc proposed openstack/nova master: Remove CannotResizeToSameFlavor exception https://review.openstack.org/484666
08:21:33 openstackgerrit Hironori Shiina proposed openstack/nova master: Ironic: Support boot from Cinder volume https://review.openstack.org/215385
08:21:54 openstackgerrit Gábor Antal proposed openstack/nova master: Add json style checking for sample notifications https://review.openstack.org/443677
08:23:50 openstackgerrit Radoslav Gerganov proposed openstack/nova master: VMware: Handle concurrent registrations of the VC extension https://review.openstack.org/484667
08:37:45 openstackgerrit Radoslav Gerganov proposed openstack/nova master: VMware: Handle missing volume vmdk during detach https://review.openstack.org/484675

Earlier   Later