Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-07-17
20:32:40 mriedem that's the default impl
20:32:59 mriedem the options are registered here https://github.com/openstack/nova/blob/stable/newton/nova/conf/key_manager.py
20:33:20 mriedem and then there is some backward compat magic in https://github.com/openstack/nova/blob/stable/newton/nova/keymgr/__init__.py
20:37:16 Ctesias yeah commenting out the lines in __init__.py fixes it
20:38:36 Ctesias Is this behavior fixed upstream from Newton anywhere yet?
20:41:19 mriedem i think that stuff in init was all removed in ocata
20:41:33 mriedem oh i guess not ocata https://github.com/openstack/nova/blob/stable/ocata/nova/keymgr/__init__.py
20:41:44 mriedem damn
20:41:44 mriedem or master https://github.com/openstack/nova/blob/master/nova/keymgr/__init__.py
20:42:14 mriedem so the fact it's setting that b/c of devstack is a total hack
20:42:21 mriedem let me see if that's at least set in devstack
20:43:27 mriedem Ctesias: https://review.openstack.org/#/c/439855/
20:44:42 Ctesias cool. Thanks
20:45:03 mriedem Ctesias: so did you just remove this line? https://github.com/openstack/nova/blob/stable/newton/nova/keymgr/__init__.py#L29 ?
20:45:08 mriedem or all of the stuff in there
20:46:58 Ctesias I only commented out the lines that re-set the api_class value
20:47:18 Ctesias but if you're curious I can try to get rid of all of it and see what happens
20:47:34 mriedem i'm curious if just commenting out https://github.com/openstack/nova/blob/stable/newton/nova/keymgr/__init__.py#L29 resolves your issue
20:47:41 mriedem because that would be easy for me to change on master and backport through to newton
20:47:55 Ctesias Yes.
20:47:59 mriedem ok
20:48:28 Ctesias If you would be so kind as to post that change once it comes in so I can follow it back and get upgraded to it that would be excellent.
20:48:29 mriedem i can mess around with pushing that change later then - i can't say i totally understand *why* it would cause an issue since it should just set a default, not override your value
20:48:35 mriedem unless it thinks that your value was the default or something?
20:48:42 Ctesias beats the hell out of me
20:49:09 mriedem i'll just remove it on the grounds that we have the value set in devstack so removing the hack is good enough
20:50:40 mriedem Ctesias: reporting a bug against nova would also help with the backports
20:50:51 mriedem https://bugs.launchpad.net/nova/+filebug
20:52:08 Ctesias will do
21:13:23 openstackgerrit Matt Riedemann proposed openstack/nova master: Consistent policies https://review.openstack.org/479774
21:13:23 openstackgerrit Matt Riedemann proposed openstack/nova master: Update policy descriptions for base. https://review.openstack.org/472622
21:14:39 openstackgerrit Matt Riedemann proposed openstack/nova master: Update policy descriptions for base. https://review.openstack.org/472622
21:15:21 mriedem oomichi: another easy one and the final patch for the policy docs bp https://review.openstack.org/#/c/472622/
21:27:48 mriedem who here feels like adding back in the ability to load up out of tree scheduler drivers? https://bugs.launchpad.net/nova/+bug/1704788
21:27:49 openstack Launchpad bug 1704788 in OpenStack Compute (nova) "Hardcoded choices for nova scheduler driver" [Undecided,Confirmed]
21:30:03 dansmith heh
21:30:24 mriedem bauzas: since you were +W on that thing, how do you feel about ^
21:30:32 mriedem answer tomorrow when you're awake
21:30:56 mriedem because we really probably should have made that (1) a deprecation cycle and (2) ffs at least reno it
21:33:22 openstackgerrit Merged openstack/nova master: Handle Cinder 3.27 style attachments in swap_volume https://review.openstack.org/456971
21:34:11 openstackgerrit Merged openstack/nova master: [placement] Update allocation-candidates.yaml for gabbi 1.35 https://review.openstack.org/484356
21:34:23 cdent \o/
21:34:34 mriedem cdent: btw, just so you know,
21:34:49 mriedem we went hiking, toured a historic village, and went swimming yesterday
21:35:00 mriedem so it wasn't all work
21:35:04 cdent ah well, I am so relieved
21:36:36 melwitt mriedem: replied to your latest comments. the things that seem up in the air are 1) whether to add vm_states.SOFT_DELETED + task_states.RESTORING instances to the count and recheck in restore
21:36:48 melwitt 2) whether to check quota on resize confirm
21:38:20 mriedem ok
21:38:57 mriedem oh dan https://review.openstack.org/#/c/472622/ <3
21:40:13 melwitt mriedem: I'm not sure what I think other than, if I do both 1) and 2) I guess that eliminates the TODOs I had written bc checking quota at resize confirm sort of serves as a recheck for resize (as I described in the review comment)
21:40:47 melwitt so maybe that one should be guarded by "if CONF.quota.recheck_quota"
21:44:44 melwitt correction, the revert_resize TODO would remain
21:44:51 dansmith mriedem: we might want to get this in before the quota-ectomy so we can backport: https://review.openstack.org/#/c/462521/4/nova/compute/manager.py
21:45:39 mriedem dansmith: that's 3 changes in a series
21:45:42 mriedem the 2nd change has no tests
21:46:09 dansmith ah, yup
21:49:07 dansmith the bottom one doesn't either and it seems like they'd be trivial
21:58:15 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove key_manager.api_class hack https://review.openstack.org/484501
22:15:48 openstackgerrit Matt Riedemann proposed openstack/nova master: Log compute node uuid when the record is created https://review.openstack.org/484447
22:29:41 openstackgerrit Matt Riedemann proposed openstack/nova master: Convert HostState.limits['numa_topology'] to primitive https://review.openstack.org/484439
22:29:43 mriedem dansmith: ^ is that what you were looking for wrt being specific?
22:30:11 dansmith mriedem: well kinda, although I don't see why you need to check for if it's an object
22:30:24 dansmith that's just too much ambiguity unless it's really needed
22:30:30 dansmith if it's set, it's that object, right?
22:30:43 mriedem honestly i'd rather not even do this specific check at all
22:30:47 mriedem and just handle it generically
22:31:06 mriedem i don't like the tight coupling between the filters and the scheduler manager here
22:32:49 dansmith idk, I just think more magic object conversions hide where this is happening
22:33:37 mriedem true
22:33:45 mriedem i don't like any of it really so i don't care too much :)
22:35:24 dansmith they're reverting the jsonutils change, but they plan to put it back in I guess?
22:35:58 mriedem they plan to put it back in with a UserWarning that the thing passed in can't be turned into a primitive
22:36:15 mriedem and then drop that at some point with a major version bump i guess
22:36:17 dansmith okay
22:36:25 mriedem since it's an api change in the library
22:36:45 mriedem but 6 months from now who knows if anyone will remember any of this
22:36:52 dansmith well, I dunno, we shouldn't really be doing this in the first place for an unversioned return value of an rpc call, IMHO
22:37:07 dansmith but IMHO, it's best to be very explicit and targeted if we're going to convert it
22:37:28 dansmith i.e. "if there is a numa limit, it is a NumaWhateverObject and we shall always convert it to primitive"
22:38:04 mriedem ok making that change
22:48:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Convert HostState.limits['numa_topology'] to primitive https://review.openstack.org/484439
23:11:09 mriedem efried: is https://review.openstack.org/#/c/458257/ the last thing for that bp?
23:11:14 mriedem i see the dependent change is in ksa 2.20
23:12:10 efried mriedem No, that one had a couple of the clienty changes; plan was to follow up with others.
23:12:15 efried mriedem Did ksa 2.20 happen??
23:12:54 efried mriedem Or maybe 2.20 isn't the one I thought I was trying to squeeze stuff into right now.
23:13:57 mriedem https://review.openstack.org/#/c/482742/ ?
23:14:02 mriedem which change in ksa specifically do we need?
23:14:12 mriedem or all over https://review.openstack.org/#/q/topic:version-discovery ?
23:14:15 mriedem *all ov
23:14:16 mriedem *of
23:15:06 efried mriedem That was the hope. Specifically I wanted to fix the APIs in discover.py - https://review.openstack.org/#/c/483604/
23:15:38 efried ...so we didn't release them with unnecessary params and have to support those (and their [really complicated] implications) forever.
23:17:17 mriedem ok so realizing that ksa boat of changes isn't going to land by thursday probably,
23:17:34 mriedem do we have something pragmatic to land in nova to complete this for pike and then improve it later?
23:18:51 mriedem sfinucan: you took over as author on this https://review.openstack.org/#/c/428241/
23:19:06 mriedem i think that git review / rebase bug where it changes author is hitting more than just me
23:19:09 efried mriedem If you're assuming the boat won't land... I would have to work something up that's better than https://review.openstack.org/#/c/458257/ but not the whole ksa hog.
23:19:30 mriedem efried: i'm assuming it won't land by thursday, no

Earlier   Later