| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-07-17 | |||
| 14:02:28 | bauzas | edleafe: snap, caught by the police :p | |
| 14:02:53 | mordred | efried: or - we make sure that the "add microversion helper parameter" bit to the end of the stack so that if we can't all agree on the approach we don't block anything else | |
| 14:02:54 | jangutter | bauzas: https://wiki.openstack.org/wiki/SR-IOV-Passthrough-For-Networking <--- very stale. | |
| 14:03:38 | efried | mordred Probably at least that last thing. | |
| 14:03:44 | bauzas | asettle: hola, unsure if you can answer my question | |
| 14:04:02 | efried | mordred Cause I imagine it may take a little while to figure out all the special cases, whatever approach we land on. | |
| 14:04:35 | jangutter | bauzas: and the one for Ocata: https://docs.openstack.org/ocata/networking-guide/config-sriov.html <--- something like this, or do you want more low-level? | |
| 14:04:52 | bauzas | asettle: but I can see a 404 on http://docs.openstack.org/admin-guide/compute-pci-passthrough.html | |
| 14:04:58 | bauzas | jangutter: yeah, that will work out | |
| 14:05:02 | mordred | efried: yes - and I think we need to get a ksa release cut that hasall the other things this week so that it makes the cutoff and you can use it in nova | |
| 14:05:18 | bauzas | jangutter: it's not really for my knowledge, it's rather more about providing guidance to others | |
| 14:05:52 | efried | mordred Yes, and I'm a tad worried about that. Working hard on getting https://review.openstack.org/#/c/483604/ polished off, cause that affects the initial APIs of the new methods. | |
| 14:06:16 | efried | mordred Also concerned about getting that rename (min/max_version => min/max_endpoint_version) in place for same reason. | |
| 14:06:28 | mordred | efried: ++ | |
| 14:06:39 | efried | mordred Prolly should move this conversation to -dev/-sdks | |
| 14:12:33 | openstackgerrit | Jay Pipes proposed openstack/nova master: add dict of allocation requests to select_dests() https://review.openstack.org/483565 | |
| 14:12:33 | openstackgerrit | Jay Pipes proposed openstack/nova master: claim resources in placement API during schedule() https://review.openstack.org/483566 | |
| 14:12:41 | jaypipes | edleafe: done ^ | |
| 14:12:59 | edleafe | jaypipes: gracias | |
| 14:13:51 | openstackgerrit | Jan Gutter proposed openstack/nova master: Netronome SmartNIC Enablement https://review.openstack.org/483459 | |
| 14:28:51 | asettle | bauzas: uno momento, in a meeting :) will look shortly | |
| 14:29:00 | asettle | bauzas: admin guide has been migrated | |
| 14:29:06 | bauzas | k | |
| 14:29:32 | asettle | Y'all need to migrate the Comptue section of the admin guide into the nova repo | |
| 14:31:15 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Migration from 'ip' commands to pyroute2 https://review.openstack.org/484386 | |
| 14:34:02 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Migration from 'ip' commands to pyroute2 https://review.openstack.org/484386 | |
| 14:35:52 | ralonsoh | stephenfin: hi! A present: https://review.openstack.org/#/c/484386/ | |
| 14:36:28 | ralonsoh | stephenfin: BTW. I'm running out of time. Can you take a look at https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/enable-sriov-nic-features? | |
| 14:36:52 | mdrabe | dansmith: I think https://review.openstack.org/#/c/482620 should be bueno | |
| 14:37:35 | dansmith | mdrabe: indeed, thanks | |
| 14:39:18 | openstackgerrit | Artem Tiumentcev proposed openstack/nova master: Add root and ephemeral disk quota https://review.openstack.org/484390 | |
| 14:43:57 | openstackgerrit | Artem Tiumentcev proposed openstack/python-novaclient master: Add 'local_gb' disk quota support https://review.openstack.org/484391 | |
| 15:02:50 | openstackgerrit | Steve Noyes proposed openstack/nova master: update live migration to use v3 cinder api https://review.openstack.org/463987 | |
| 15:09:00 | mriedem | sdague: can you go through this new style cinder attachments swap volume change? https://review.openstack.org/#/c/456971/ - i'm good with it and jay is +2, | |
| 15:09:34 | mriedem | sdague: we really need another core to help review the new style cinder attachments stuff, so if you could help here this week it'd be really good | |
| 15:10:24 | mriedem | keep in mind, everything is keyed off the bdm.attachment_id field being set - which doesn't happen until the very last patch where we turn this all on - which only happens when (1) cinder is new enough to provide 3.27 and (2) all computes are upgraded | |
| 15:11:44 | gibi | mriedem: hi! I have a fix up for the volume_swap notification test instability https://review.openstack.org/#/c/484288/ | |
| 15:13:15 | mriedem | gibi: thanks, +2 | |
| 15:21:51 | gibi | mriedem: thanks | |
| 15:23:34 | openstackgerrit | Artem Tiumentcev proposed openstack/python-novaclient master: Add 'local_gb' disk quota support https://review.openstack.org/484391 | |
| 15:25:38 | mriedem | sfinucan: i'm debugging a fun issue with NUMATopologyLimits not getting serialized in the scheduler with a new oslo.serialization change | |
| 15:25:47 | mriedem | http://logs.openstack.org/87/482287/6/check/gate-cross-nova-func-ubuntu-xenial/a645ce8/console.html#_2017-07-16_14_02_02_649384 | |
| 15:25:59 | mriedem | that's due to this change in oslo.serialization https://review.openstack.org/#/c/327564/ | |
| 15:26:16 | mriedem | which is failing here: https://review.openstack.org/#/c/482287/ | |
| 15:27:36 | mriedem | i'm trying to sort out where this is getting serializaed | |
| 15:27:38 | mriedem | *serialized | |
| 15:27:48 | mriedem | obviously the select_destinations call | |
| 15:28:45 | mriedem | oh i think i see, | |
| 15:28:59 | mriedem | the request spec is serialized, and contains numa_topology which comes from the HostState object: | |
| 15:29:00 | mriedem | host_state.limits['numa_topology'] = limits | |
| 15:29:12 | mriedem | set via the NUMATopologyFilter | |
| 15:31:22 | mriedem | still not sure why that would fail to serialize | |
| 15:32:49 | jangutter | newbie question about the gate: is there a way to inform it that the unit tests require an updated os-vif? | |
| 15:33:06 | mriedem | jangutter: depends-on | |
| 15:33:08 | mriedem | buth, | |
| 15:33:11 | mriedem | *but, | |
| 15:33:22 | mriedem | you have to get the changes merged and released in os-vif first | |
| 15:33:46 | jangutter | mriedem: yah, thought as much. | |
| 15:33:46 | mriedem | you can't depends-on a source change in a library w/o it being released first in most jobs | |
| 15:36:22 | jangutter | mriedem: funnily enough, the non-test code seem to load the patched os-vif. | |
| 15:36:45 | jangutter | mriedem: I presume it's because tox creates a sandbox. | |
| 15:40:17 | mriedem | i'm not really understanding what you're saying | |
| 15:40:41 | mriedem | it's all going to run in a tox venv with dependencies using the versions from upper-constraints | |
| 15:40:50 | mriedem | https://github.com/openstack/requirements/blob/master/upper-constraints.txt | |
| 15:41:04 | mriedem | so until the change in os-vif is released and in upper-constraints, then the tox venv isn't using it | |
| 15:41:07 | mriedem | at least in the CI system | |
| 15:41:24 | mriedem | so either your local venv is hacked or it's not working the way you think | |
| 15:42:12 | jangutter | mriedem: Yeah, I hacked my local venv (by running install on os-vif), but only for the unit tests. | |
| 15:43:45 | mriedem | sfinucan: this is what we get right before select_destinations blows up http://paste.openstack.org/show/615631/ | |
| 15:44:10 | sdague | mriedem: will look | |
| 15:44:22 | mriedem | sdague: thanks, poke me with questions | |
| 15:46:08 | bauzas | jaypipes: dansmith: mriedem: sorry, was off last friday, but just saw https://review.openstack.org/#/c/483564/2 | |
| 15:47:10 | bauzas | jaypipes: dansmith: mriedem: so we're now passing a full list of weighed hosts to _schedule() even if don't really use those | |
| 15:47:43 | bauzas | jaypipes: dansmith: mriedem: I get of course why we need to do such in later changes but I do wonder of the performance penalty | |
| 15:48:10 | mriedem | huh? | |
| 15:48:15 | bauzas | jaypipes: dansmith: mriedem: the performance penalty being for example a list of 1000 nodes | |
| 15:48:19 | mriedem | what's getting passed to _schedule that you are worried about? | |
| 15:48:25 | bauzas | given we don't pass an iterator but a full ist | |
| 15:48:26 | bauzas | list | |
| 15:48:40 | bauzas | mriedem: https://review.openstack.org/#/c/483564/2/nova/scheduler/filter_scheduler.py@150 | |
| 15:48:59 | bauzas | that's a list, not an iterator | |
| 15:49:17 | mriedem | you mean not what's passed to _schedule, you mean what's passed from _get_sorted_hosts and used in _schedule | |
| 15:49:27 | bauzas | so we literally build in memory an object that could be large just for the purpose of selecting only the first item | |
| 15:49:34 | bauzas | yup, that | |
| 15:49:51 | bauzas | I'd frankly be more happy if that was an iterator | |
| 15:50:00 | bauzas | but I could be picky | |
| 15:50:07 | bauzas | just raising my concern out loud | |
| 15:50:16 | bauzas | not worth a revert of course | |
| 15:50:24 | mriedem | so push a change to do that | |
| 15:50:38 | mriedem | or leave a comment in the patch | |
| 15:50:51 | bauzas | mriedem: I can workout a patch | |
| 15:54:14 | bauzas | jaypipes: mriedem: oh looks like https://review.openstack.org/#/c/483564/2 will not land because of a functional test issue | |
| 15:54:17 | mriedem | i see the "# Note: remember, we are using an iterator here." on L93 but which variable is the iterator? is it 'hosts' returned from _get_all_host_states ? | |
| 15:54:30 | mriedem | because i think that returns a tuple | |
| 15:55:04 | mriedem | HostManager.get_host_states_by_uuids calls _get_host_states which returns a tuple | |
| 15:56:35 | mriedem | I think get_filtered_hosts is what converts to an iterator | |
| 15:56:41 | mriedem | hosts = six.itervalues(name_to_cls_map) | |
| 15:56:43 | bauzas | mriedem: the whole filters/weighers accepts an iterator | |
| 15:56:45 | bauzas | AFAIR | |
| 15:56:48 | mriedem | and passes that to filter_handler.get_filtered_objects | |