| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-07-13 | |||
| 18:11:22 | lbragstad | i wouldn't expect each service's default rule to be the same | |
| 18:12:19 | cdent | (I think the issue in the review is more that policy file generation was leaving the default out? https://review.openstack.org/#/c/481443/ and if you try to use that file elsewhere, things go awry?) | |
| 18:12:28 | mriedem | cdent: i left a question in there | |
| 18:12:35 | cdent | thanks | |
| 18:12:40 | mriedem | compute:get_all is an old legacy v2 API rule i think | |
| 18:13:20 | mriedem | seems like a horizon bug actually | |
| 18:13:27 | lbragstad | speaking of policy - i was thinking about organizing a session in Denver focused on next steps (much like what we did in atlanta) | |
| 18:13:33 | lbragstad | is anyone here interested in that? | |
| 18:13:36 | cdent | could very welll be | |
| 18:14:52 | mriedem | i'm not interested in thinking about denver at all right now | |
| 18:15:06 | lbragstad | :) that's fair | |
| 18:15:40 | robcresswell | Ah, we still have references to the old style policy rules | |
| 18:15:45 | robcresswell | I can fix that. | |
| 18:16:08 | mriedem | robcresswell: someone already did https://github.com/openstack/horizon/blob/master/openstack_dashboard/conf/nova_policy.json | |
| 18:16:12 | mriedem | compute:get_all isn't in there | |
| 18:16:22 | mriedem | unless it's hard-coded | |
| 18:16:47 | robcresswell | mriedem: I co-authored on that. We've left a check on the rule in our admin > instances panel | |
| 18:17:05 | robcresswell | https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/instances/panel.py#L29 | |
| 18:17:30 | robcresswell | Is there a relevant bug open in Nova I can link to? | |
| 18:17:35 | mriedem | https://bugs.launchpad.net/horizon/+bug/1703066 | |
| 18:17:36 | openstack | Launchpad bug 1703066 in OpenStack Compute (nova) " Add "default" rule when generate policy.yaml.sample" [Undecided,Incomplete] - Assigned to KaiLi (damonl1) | |
| 18:17:39 | mriedem | just added horizon to it | |
| 18:17:46 | robcresswell | Thanks | |
| 18:17:53 | mriedem | np | |
| 18:17:57 | mriedem | cdent: -1 on the nova change then | |
| 18:18:05 | cdent | thanks to all three of you | |
| 18:18:07 | cdent | yeah, totes | |
| 18:21:03 | robcresswell | Whats the equivalent of "get_all"? "os_compute_api:servers:index"? | |
| 18:21:14 | mriedem | yeah | |
| 18:21:33 | mriedem | well, | |
| 18:21:37 | mriedem | depends, do you need details? | |
| 18:21:48 | mriedem | because then it would be os_compute_api:servers:detail | |
| 18:21:51 | mriedem | "os_compute_api:servers:detail" | |
| 18:21:54 | mriedem | blast | |
| 18:22:35 | robcresswell | That particular check is just saying "can I list all instances" I believe. | |
| 18:22:43 | robcresswell | on the horizon side, I mean | |
| 18:22:48 | mriedem | i'll check some old nova code | |
| 18:23:11 | robcresswell | It looks like that last patch replaced get_all with "os_compute_api:servers:index:get_all_tenants" in a couple of places | |
| 18:23:24 | mriedem | that would be wrong | |
| 18:23:38 | mriedem | the old version of that was compute:get_all_tenants | |
| 18:23:50 | robcresswell | thanks | |
| 18:23:50 | robcresswell | gotcha | |
| 18:23:53 | mriedem | the all tenants stuff is admin only by default | |
| 18:24:04 | mriedem | since tenant A shouldn't be able to list instances from tenant B | |
| 18:24:45 | mriedem | compute:get_all was used for both index and detail in the v2 API | |
| 18:24:50 | mriedem | so you can use the index or detail one, either is fine | |
| 18:25:19 | mriedem | well, i mean it really depends on what you're going to be doing - if you're going to be getting servers with details to show details, then you want the details one | |
| 18:25:50 | robcresswell | Is that the same as viewing the details of a specific server? | |
| 18:25:56 | mriedem | nope | |
| 18:25:57 | mriedem | :) | |
| 18:26:25 | robcresswell | Whats the policy for that? | |
| 18:26:36 | mriedem | i think that's "os_compute_api:servers:show" | |
| 18:26:48 | robcresswell | Ah! Yes | |
| 18:26:53 | robcresswell | Very good | |
| 18:28:46 | robcresswell | mriedem: https://review.openstack.org/#/c/483501/ | |
| 18:29:01 | openstackgerrit | zhang zhenzhong proposed openstack/nova master: fix rp registration failed while placement endpoint created after compute start https://review.openstack.org/483460 | |
| 18:29:52 | dansmith | melwitt: agree that less behavioral change is better | |
| 18:30:41 | melwitt | cool. I think we all agree, so I'll nix the pending resizes stuff | |
| 18:30:43 | robcresswell | mriedem: Right, I'll get that merged ASAP and backport it. Thanks for the help. | |
| 18:30:53 | melwitt | and put back the current behavior | |
| 18:30:54 | mriedem | +1 | |
| 18:31:28 | mriedem | melwitt: cool, that means you can also drop the 2nd change in the series too right? | |
| 18:31:35 | dansmith | I think so | |
| 18:31:37 | mriedem | f yes | |
| 18:31:43 | mriedem | that's like 15% better | |
| 18:31:48 | dansmith | hehe | |
| 18:32:05 | melwitt | /fistpump | |
| 18:32:30 | dansmith | if we round to 20% less (code to merge) we could all take tomorrow off | |
| 18:32:44 | melwitt | haha | |
| 18:36:37 | mriedem | i have to work on my pbc tomorrow | |
| 18:36:38 | mriedem | so no dice | |
| 18:39:09 | dansmith | mriedem: oh horrors of horror | |
| 18:39:20 | dansmith | er, horror of horrors? | |
| 18:39:27 | dansmith | whatever. horror-ible. | |
| 18:39:33 | mriedem | ha | |
| 18:39:44 | mriedem | don't make me get out ralph wiggum again | |
| 18:39:48 | dansmith | hehe | |
| 18:40:32 | melwitt | what's pbc | |
| 18:40:45 | mriedem | personal business commitments | |
| 18:41:06 | mriedem | goals | |
| 18:41:28 | mriedem | like, "i'm going to synergize for cloud enterprise adoption 2.0" | |
| 18:42:15 | melwitt | hah | |
| 18:44:30 | edleafe | mriedem: don't forget the cover page for the TPS report | |
| 18:44:36 | edleafe | mriedem: you did get the memo, right? | |
| 18:44:54 | jaypipes | mriedem: don't forget to unprison your think rhino. | |
| 18:44:59 | mriedem | i did put a cover page on my expense claim and throw that in the mail today | |
| 18:45:57 | openstackgerrit | zhang zhenzhong proposed openstack/nova master: fix rp registration failed while placement endpoint created after compute start https://review.openstack.org/483460 | |
| 18:46:28 | melwitt | lol think rhino? unprison? | |
| 18:46:29 | cdent | jaypipes: you may have some opinions on that ^^ | |
| 18:50:48 | jaypipes | melwitt: https://twitter.com/e_monty/status/852540106317627392 | |
| 18:51:22 | melwitt | lol | |
| 18:51:28 | edleafe | jaypipes: ah, that totally clears everything up | |
| 18:51:35 | jaypipes | hehe | |
| 18:53:43 | openstackgerrit | zhang zhenzhong proposed openstack/nova master: remove un-necessary update() in _init_compute_node of rt https://review.openstack.org/483506 | |
| 19:04:37 | dansmith | mriedem: this event rebase is taking a long time because of your silly volume extend nonsense, but I'm about done | |
| 19:04:56 | openstackgerrit | Dan Smith proposed openstack/nova master: Fix and optimize external_events for multiple cells https://review.openstack.org/445142 | |
| 19:07:06 | mriedem | boohoo | |
| 19:07:19 | melwitt | hehehe | |
| 19:08:57 | dansmith | mriedem: you guys are only on cloud 2.0? | |
| 19:09:23 | dansmith | I think we're on 4.0 now | |