Earlier  
Posted Nick Remark
#openstack-nova - 2017-07-13
02:32:41 openstackgerrit Debo Zhang proposed openstack/nova master: Fix typo. https://review.openstack.org/483162
03:10:28 openstackgerrit Debo Zhang proposed openstack/nova master: Fix typo https://review.openstack.org/483159
03:21:38 openstackgerrit Debo Zhang proposed openstack/nova master: Fix typo https://review.openstack.org/483162
03:34:00 openstackgerrit Alex Xu proposed openstack/nova master: Fix the releasenote and api-ref for quota-class API https://review.openstack.org/483170
03:34:11 alex_xu gmann: mriedem ^
03:54:34 openstackgerrit Debo Zhang proposed openstack/nova master: Fix typo https://review.openstack.org/483159
04:09:34 openstackgerrit Merged openstack/nova master: improve notification short-circuit https://review.openstack.org/482497
06:00:23 openstackgerrit jichenjc proposed openstack/nova master: add description for supports_migrate_to_same_host https://review.openstack.org/481483
07:05:26 openstackgerrit Alex Xu proposed openstack/nova master: Fix the releasenote and api-ref for quota-class API https://review.openstack.org/483170
07:19:58 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(4/4) https://review.openstack.org/469800
07:48:50 openstackgerrit Alex Szarka proposed openstack/nova master: Raise a real Exception instead of direct Exception call https://review.openstack.org/482200
08:07:49 jangutter sean-k-mooney: would you have an example handy on that alternate way to set the bridge name in a VIF? (something about trunk ports, I think...)
08:30:29 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/nova master: Read Neutron port 'binding_profile' during boot https://review.openstack.org/449257
08:40:29 openstackgerrit LiChunlin proposed openstack/nova master: update the description of hypervisor statistics response https://review.openstack.org/462355
08:49:42 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/nova master: Add Neutron port capabilities to devspec in request https://review.openstack.org/451777
08:50:52 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add memoize function using oslo.cache https://review.openstack.org/472773
09:05:09 openstackgerrit Merged openstack/nova master: Add BDM to InstancePayload https://review.openstack.org/448779
09:30:26 openstackgerrit ChangBo Guo(gcb) proposed openstack/nova master: rbd: Remove unnecessary 'encode' calls https://review.openstack.org/412356
09:32:00 bauzas stephenfin: hola
09:32:09 stephenfin bauzas: Morning
09:32:30 bauzas stephenfin: could you please remember me if we need to add a _LW() for any warning log ?
09:32:35 bauzas I think so
09:32:42 bauzas only debug logs are not needed
09:33:01 openstackgerrit yuanyue proposed openstack/nova master: Remove ports on create_port timeout during instance build https://review.openstack.org/483280
09:33:17 stephenfin bauzas: No, IIRC we don't need any _L* translations. We only translate exceptions now
09:33:29 bauzas okay
09:33:34 stephenfin ...which use the '_' symbol
09:33:49 bauzas yeah that I know
09:34:06 bauzas I thought we said to only translate logs having no debug level
09:34:26 bauzas but I didn't remember we said to stop translating any level log
09:35:01 stephenfin Hmm, lemme go check
09:35:53 stephenfin gcb: Can you say, do we still need to translate LOG.warning logs?
09:36:49 stephenfin bauzas: https://docs.openstack.org/nova/latest/i18n.html
09:36:57 stephenfin Log messages should not be translated. Any use of _LI(), _LW(), _LE(), _LC() are vestigial and will be removed over time.
09:37:11 stephenfin gcb: It's good - we figured it out :)
09:37:26 bauzas stephenfin: cool thanks
09:37:30 gcb stephenfin: yes, look at https://docs.openstack.org/oslo.i18n/latest/user/usage.html
09:37:42 openstackgerrit Alex Szarka proposed openstack/nova master: Add method for verify multiple versioned notifications https://review.openstack.org/465526
09:37:54 gcb Starting with the Pike series, OpenStack no longer supports log translation. It is not necessary to add translation instructions to new code, and the instructions can be removed from old code. Refer to the email thread understanding log domain change on the openstack-dev mailing list for more details.
09:38:07 gcb stephenfin^^
09:38:23 stephenfin gcb: Excellent. Thank you :)
09:40:39 cdent stephenfin: I'm not wise in the ways of policy, does this change (or the linked bug) make sense: https://review.openstack.org/#/c/481443/
09:42:04 stephenfin cdent: I was purposefully leaving that until if/when johnthetubaguy was back. Apparently we were removing all default rules, so I'd imagine that will have some bearing on that
09:43:03 cdent stephenfin: ah okay, so the burden of setting the default is on the deployment?
09:44:02 stephenfin cdent: Wait, no - that was _discoverable_ policies (because they no longer make sense)
09:44:40 stephenfin Looks like claudiub added a load of those default rules. Maybe he can review https://review.openstack.org/#/c/481443/ and see if it makes sense?
09:56:36 openstackgerrit Rikimaru Honjo proposed openstack/nova master: compute: Do not create bdms before successfully reserving a volume https://review.openstack.org/290793
10:07:07 openstackgerrit Stephen Finucane proposed openstack/nova master: Always set MTU when plugging devices https://review.openstack.org/408781
10:12:10 pallavi_ Hi , I have done ubuntu manual installation for ocata release. I have launched instance. But accessing to the instance is not happening.?? Can anyone please help me out to figure it out
10:17:00 claudiub stephenfin: replied. that patch LGTM.
10:18:30 stephenfin claudiub: Thanks :) If you're happy, so am I
10:23:27 claudiub stephenfin: if you're happy and you know it, clap your hands! *clap* *clap*. :D
10:23:49 cdent thanks claudiub
10:28:11 gibi bauzas: hi! There is a small test and doc only patch that needs a second +2. Could you check it please? https://review.openstack.org/#/c/480469/
10:28:22 bauzas gibi: roger this.
10:28:43 gibi bauzas: thanks!
10:35:51 sean-k-mooney jangutter: hi the bridge name is currently set here https://github.com/openstack/neutron/blob/8326a65a5e3c70c66a5297c618d0202c9395cc3f/neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py#L94-L105
10:37:03 sean-k-mooney jangutter: so in you mech driver if you just overrided that fuction you can pass the bridge name via the vif binding details.
10:38:40 sean-k-mooney jangutter: this then get populated into the os-vif network object here https://github.com/openstack/nova/blob/d955eb1db753f191acb02eb9758080329da5b866/nova/network/os_vif_util.py#L225-L226
10:40:17 sean-k-mooney jangutter: and its used in os-vif here: https://github.com/openstack/os-vif/blob/4a8e07f6c502e5e3b99db9ba543a501fbb138596/vif_plug_ovs/ovs.py#L97 and anywayer else we need the bridge name
10:43:53 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove plug_ovs_hybrid, unplug_ovs_hybrid https://review.openstack.org/483030
10:43:54 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Remove useless test https://review.openstack.org/483031
10:44:00 bauzas stephenfin: gibi: something got messed up with our man pages
10:44:10 stephenfin ?
10:44:21 bauzas eg. <http://docs.openstack.org/developer/nova/man/nova-manage.html#nova-cells-v2 is pointing nowhere
10:44:32 stephenfin Yeah, that's a pbr bug
10:44:43 stephenfin *Oh, that's like that pbr bug
10:44:57 stephenfin *likely
10:44:58 stephenfin dammit
10:45:25 stephenfin bauzas: https://bugs.launchpad.net/pbr/+bug/1702872
10:45:26 openstack Launchpad bug 1702872 in PBR "pbr + Sphinx 1.6+ ignores the '[sphinx_build] builders' setuptools option" [Undecided,In progress] - Assigned to Stephen Finucane (stephenfinucane)
10:46:17 stephenfin I'll tack a fix onto the end of the https://review.openstack.org/#/q/topic:doc-migration+project:openstack/nova series, once pep8 fix patch goes in (it needs a rebase again)
10:46:23 bauzas stephenfin: I just +2d https://review.openstack.org/#/c/478472/7 because it workarounds the issue
10:46:47 bauzas stephenfin: I'm not sure it should be a cli/ section, but meh
10:47:10 bauzas at least it's understandable that nova-manage and nova-status are CLI tools
10:47:53 stephenfin Yeah, sdague said the same thing. However, we've no where else to put those man pages
10:48:05 stephenfin I wanted that section called 'man' instead, but didn't make my case strongly enough :(
10:55:17 openstackgerrit Alex Szarka proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660
11:13:54 openstackgerrit Chris Dent proposed openstack/nova master: Add functional test for two-cell scheduler behaviors https://review.openstack.org/452006
11:54:14 gibi cdent: thank you for your detailed answer on my placement question on the ML. It helps a lot
11:57:00 openstackgerrit Claudiu Belu proposed openstack/nova master: hyperv: Cleans up live migration Planned VM https://review.openstack.org/478943
11:57:31 jangutter sean-k-mooney: hmmm, I still get: ERROR os_vif NotImplementedError: Cannot load 'bridge' in the base class
11:58:28 sean-k-mooney jangutter: how are you accessing the bridge? via the network object?
11:59:33 jangutter sean-k-mooney: vif.network.bridge -> I think that might not be populated for vhostuser
11:59:49 sean-k-mooney jangutter: if you do a neutron port show or openstack port show do you see the bridge correctly set in the vif_binding_details
12:00:37 sean-k-mooney jangutter: it should be populated or it means that vlan aware vms dose not work for vhost-user and this is a nova bug we need to fix
12:01:55 sean-k-mooney jangutter: yep you are right.... https://github.com/openstack/nova/blob/d955eb1db753f191acb02eb9758080329da5b866/nova/network/neutronv2/api.py#L2157-L2179
12:02:17 sean-k-mooney jangutter: do you want to submit the patch or will i
12:02:27 jangutter sean-k-mooney: binding_vif_details -> ovs_hybrid_plug='False', port_filter='True'
12:03:40 jangutter sean-k-mooney: depends on what will get it merged faster :-)
12:03:40 sean-k-mooney actully no i misread that https://github.com/openstack/nova/blob/d955eb1db753f191acb02eb9758080329da5b866/nova/network/neutronv2/api.py#L2172-L2173 it is saved for vhost-user
12:04:21 sean-k-mooney jangutter: so ya the bug is in the neutron ml2 driver yuou are missing the bridge key in the vif_binding_details
12:05:21 jangutter sean-k-mooney: Aah, and the workaround is to add: elif vif_type == network_model.VIF_TYPE_AGILIO_OVS to that list.
12:05:42 sean-k-mooney jangutter: you really should not have a new vif_type
12:06:20 sean-k-mooney there will not be a new vif object in os-vif and you should not need one for nova or neutron
12:06:52 sean-k-mooney the vif type shoud just be VIF_TYPE_VHOSTUSER
12:07:14 jangutter sean-k-mooney: I am using VIF_TYPE_VHOSTUSER for the actual plugging.
12:07:28 sean-k-mooney jangutter: you should also be using it for port binding
12:08:11 sean-k-mooney we are trying to stop using vif types as a flag for how to plug interfaces and retrun them to being a statemant about what type if interface you want
12:09:03 sean-k-mooney or in otherwords the vif_type is an abstion for the hyperviser interface type and is not related to how that interface is pluged to the network backend at all

Earlier   Later