| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-07-12 | |||
| 15:01:16 | bauzas | jaypipes: dansmith: btw. sorry about me not reviewing the patches previously, I was (again) in PTO | |
| 15:01:36 | dansmith | bauzas: I just assume you're on PTO unless you say otherwise | |
| 15:01:54 | bauzas | .... and Friday is an holiday day :( | |
| 15:02:02 | bauzas | so terrible | |
| 15:02:18 | bauzas | I should be done with all my PTOs for last year FWIW | |
| 15:02:58 | bauzas | I sincerely apologize for that | |
| 15:05:02 | gibi | mriedem: added the TODO and fixed / answered the fixture comments in https://review.openstack.org/#/c/448779 | |
| 15:06:36 | ftersin | mdbooth: hi, thank you for reviewing. If you have the opportunity, pls, look at my comments there, i just asked some details for the reworking | |
| 15:07:35 | mriedem | gibi: is the indent intentional here? https://review.openstack.org/#/c/448779/39/nova/tests/fixtures.py@1270 | |
| 15:08:03 | gibi | mriedem: yes, I tried to explain the reason of that in my response to your comment | |
| 15:08:57 | gibi | mriedem: either need the explicity detach in the test or I break the swap volume tests. | |
| 15:09:14 | mriedem | ok just checking | |
| 15:09:43 | gibi | mriedem: will propose a clean up on this fixture at some point | |
| 15:10:41 | mriedem | ok, +2 | |
| 15:10:48 | mriedem | i left a comment for other reviewers too | |
| 15:10:56 | mriedem | a todo or note in there would also be good, | |
| 15:10:56 | gibi | mriedem: thanks | |
| 15:10:59 | mriedem | but only if you respin | |
| 15:11:18 | gibi | mriedem: OK | |
| 15:11:59 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955 | |
| 15:12:30 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608 | |
| 15:12:55 | bauzas | gibi: https://review.openstack.org/#/c/482497/1 is needed for what ? | |
| 15:13:16 | bauzas | just a clean-up right? | |
| 15:13:28 | gibi | bauzas: splited out from the BDM patch on top of it | |
| 15:13:48 | gibi | bauzas: it basically optimize out some data generation if the notification will not be sent out at the end | |
| 15:14:04 | bauzas | gibi: oh nevermind, it was just something missed from https://review.openstack.org/#/c/428260/ ? | |
| 15:14:32 | gibi | bauzas: yes, from that and from other patches later on | |
| 15:15:06 | bauzas | gibi: all good | |
| 15:15:16 | gibi | bauzas: thanks for the review | |
| 15:20:14 | ildikov | gibi: that fixture is a mess :( | |
| 15:22:47 | gibi | ildikov: I have my sticker to clean up it, but first I will optimize out some db query related to the instance.create | |
| 15:23:15 | gibi | ildikov: or do you have some time to work on it? ;] | |
| 15:23:23 | ildikov | gibi: I have a patch touching it with a note to figure something out there :) | |
| 15:23:42 | ildikov | gibi: well, let's see who gets there first ;) | |
| 15:24:31 | gibi | ildikov: well, that will be a real fight for that juicy commit | |
| 15:24:44 | ildikov | gibi: lol :) | |
| 15:26:37 | mriedem | gmann: i'm not sure i agree with this https://review.openstack.org/#/c/482994/ | |
| 15:26:45 | mriedem | it gets really confusing which is why i left it out of my patch | |
| 15:26:50 | mriedem | to mark 'events' as optional | |
| 15:30:46 | bauzas | gibi: may I ask a silly question about https://review.openstack.org/#/c/448779/39 ? | |
| 15:31:18 | bauzas | gibi: why some notifications samples provide an empty list for bdm notifications objects while others provide it? | |
| 15:31:20 | gibi | bauzas: sure | |
| 15:32:27 | gibi | bauzas: in some cases the bdm is overridden during the test | |
| 15:32:46 | gibi | bauzas: like test_volume_swap_server_with_error | |
| 15:33:04 | gibi | bauzas: or test_create_delete_server_with_instance_update | |
| 15:33:52 | gibi | bauzas: in test_create_delete_server_with_instance_update the bdm appears only after the instance goes through the block device mapping step during the create | |
| 15:34:20 | gibi | bauzas: so the early instance-updates has no bdm but at that point it starts appearing | |
| 15:34:33 | gibi | bauzas: and I don't want to store different sample files for each steps | |
| 15:40:21 | gibi | bauzas: specially in the instance.create case we only attach the volume after the boot not during it | |
| 15:42:19 | mriedem | Vek: can you take a look at this? https://review.openstack.org/#/c/480392/ | |
| 15:42:54 | mriedem | or andreykurilin ^ | |
| 15:43:01 | gibi | bauzas: disregard my statement about test_create_delete_server_with_instance_update | |
| 15:43:18 | gibi | bauzas: in that case the bdm is empty as there the volume also attached after the create | |
| 15:44:20 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | |
| 15:45:40 | andreykurilin | looking | |
| 15:49:39 | openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: mark instance action events parameter as optional https://review.openstack.org/480792 | |
| 15:49:40 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add ability to signal and perform online volume size change https://review.openstack.org/454322 | |
| 15:53:27 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add ability to signal and perform online volume size change https://review.openstack.org/454322 | |
| 16:00:40 | bauzas | gibi: okay, that's reasonable, those notifications mutated ? | |
| 16:01:03 | gibi | bauzas: the sample is mutated during the test | |
| 16:02:47 | gibi | bauzas: but I'm not sure this is what you are after | |
| 16:02:54 | mriedem | sean-k-mooney: ralonsoh: i wouldn't block on that out of band port update thingy, as i said, but i am not really an authority on that entire series of changes either as i haven't gone into it in detail, | |
| 16:03:01 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | |
| 16:03:04 | mriedem | and my understanding of a lot of the pci stuff in nova is very limited | |
| 16:03:09 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | |
| 16:03:10 | bauzas | gibi: it was just for my understanding | |
| 16:03:26 | bauzas | gibi: I have all I need, I was just in a short meeting beforehand | |
| 16:03:33 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | |
| 16:04:07 | ralonsoh | mriedem: thanks for your comments! | |
| 16:04:15 | gibi | bauzas: OK. I will leave soon for today but just ping me tomorrow if you have questions | |
| 16:04:57 | bauzas | gibi: that's not necessary :) | |
| 16:05:34 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add functional tests for cold migration to same host https://review.openstack.org/414926 | |
| 16:05:43 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add functional tests for cold migration to same host https://review.openstack.org/414926 | |
| 16:07:55 | gibi | bauzas: there are patches up to help keeping the style of the sample files consistent. I left the links under your comment | |
| 16:08:02 | bauzas | ++ | |
| 16:08:25 | bauzas | not really super important, but for review time, it helps | |
| 16:10:17 | gibi | bauzas: I agree | |
| 16:14:05 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483 | |
| 16:28:34 | mriedem | jaypipes: given sdague was +2 on https://review.openstack.org/#/c/454322/ and is out for the rest of this week, if you're cool with it, want to just fast approve that one? | |
| 16:28:54 | jaypipes | mriedem: done | |
| 16:28:58 | mriedem | thanks | |
| 16:32:08 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Add Neutron port capabilities to devspec in request https://review.openstack.org/451777 | |
| 16:36:10 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove plug_ovs_hybrid, unplug_ovs_hybrid https://review.openstack.org/483030 | |
| 16:36:11 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Remove useless test https://review.openstack.org/483031 | |
| 16:38:35 | edleafe | 1/away | |
| 16:38:39 | edleafe | geez | |
| 16:43:08 | bauzas | edleafe: 2/there | |
| 16:43:19 | edleafe | bauzas: :) | |
| 16:57:36 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: add claim_resources() to report client https://review.openstack.org/482382 | |
| 16:57:37 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: claim resources in filter scheduler https://review.openstack.org/482383 | |
| 16:58:29 | jaypipes | edleafe, mriedem, bauzas, dansmith: ^^ squashed the "alternate destinations" patch into the claim resources in filter scheduler patch and re-ordered the patches so the add claim_resources() to report client can be reviewed ahead of the claim in scheduler patch. | |
| 16:58:36 | jaypipes | still need to handle the cells thing. | |
| 17:01:22 | mriedem | ok | |
| 17:17:19 | mriedem | gmann: https://review.openstack.org/#/c/467999/ needs some work | |
| 17:17:23 | mriedem | it's merged but the docs are lacking | |
| 17:21:19 | edleafe | jaypipes: regarding filtering alternates by cell, feel free to take as much of this as works: https://review.openstack.org/#/c/465768/8/nova/scheduler/filter_scheduler.py@181 | |
| 17:27:24 | openstackgerrit | Merged openstack/python-novaclient master: Microversion 2.49 - Virt device tagged attach https://review.openstack.org/480392 | |
| 18:16:25 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: WIP: Microversion 2.50 - fix quota class sets resource usage https://review.openstack.org/483060 | |
| 18:36:09 | cdent | edleafe: filtering rps by traits: https://review.openstack.org/#/c/474602/ still alive? | |
| 18:39:35 | gheorghe_ | is there something wrong with migrations on ocata? my VMs are on the same host after migration...always... | |