Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-07-11
20:29:30 mriedem ok leaving comments
20:29:33 melwitt mriedem: so it's a matter of, we need to make sure the count doesn't count soft deleted instances, and I'm pretty sure it doesn't bc the {'deleted': False} filter includes soft delete IIRC
20:29:36 mriedem still chugalugging through the api
20:29:44 melwitt thanks
20:30:03 mriedem i haven't even gotten to the count_as_dict thingy yet
20:30:04 mriedem :)
20:30:26 mriedem i'd think we could also just remove the check_num_instances_quota call from restore() in the compute api
20:31:39 mriedem which now has me thinking,
20:31:45 melwitt why? to keep the behavior we would check quota since that's going to change usage
20:32:04 mriedem this is going to be an upcall from the computes
20:32:10 melwitt soft delete takes it out of usage, restore would put it back into usage
20:32:48 melwitt I thought the check for restore is in compute/api, not an upcall. *looks*
20:32:58 mriedem it is,
20:33:11 mriedem i'm talking about anything that happens in the compute manager on soft_delete_instance or reclaim_queued_deletes
20:34:20 melwitt why does it matter what happens in compute manager? if usage is decremented when the user soft deletes, it's already handled?
20:35:45 mriedem where do we actually decrement the usage in the API on soft delete though?
20:37:17 melwitt when it's marked as soft deleted, it should no longer show up in the count because of the {'deleted': False} filter in the count function
20:37:28 mriedem oh yeah, was just about to make that connection
20:39:47 melwitt this is where the logic is https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L2167-L2192
20:56:00 mriedem melwitt: dansmith: ok, i have posted comments. i have to jump on a call for a bit. i still need to go through the resize stuff to complete the api, and then everything else after that...
20:57:40 melwitt thanks mriedem
21:08:34 dansmith is the gate sick?
21:08:40 dansmith seems like the queue is barely draining
21:15:18 alaski \quit
21:15:28 alaski grr
21:16:34 melwitt o/ alaski
21:35:26 jaypipes I want to firebomb these scheduler unit tests.
21:38:10 melwitt :)
21:38:43 jaypipes melwitt: seriously. I am contemplating making napalm to douse my computer with.
21:39:59 melwitt heh. I feel you.
21:43:13 alaski o/ cdent and melwitt
21:59:06 openstackgerrit Merged openstack/nova master: Add release note for xenapi virt device tagging support https://review.openstack.org/481148
22:31:23 gheorghe_ every time i try o migrate an instance, it gets migrated to the same host
22:31:24 gheorghe_ migrations is successful but the VM stays on the same host
22:31:26 gheorghe_ i am using ocata on ubuntu 16.04
23:00:15 openstackgerrit Jay Pipes proposed openstack/nova master: placement: add claim_resources() to report client https://review.openstack.org/482382
23:00:16 openstackgerrit Jay Pipes proposed openstack/nova master: scheduler: alternates for filter scheduler https://review.openstack.org/482381
23:00:16 openstackgerrit Jay Pipes proposed openstack/nova master: placement: claim resources in filter scheduler https://review.openstack.org/482383
23:27:26 openstackgerrit Merged openstack/nova master: xenapi: avoid unnecessary BDM query when building device metadata https://review.openstack.org/481162
#openstack-nova - 2017-07-12
00:24:25 mriedem dansmith: video ram isn't tracked for placement :) it's checked on server create and decremented from ram quota on server delete, and checked in the libvirt driver, but not part of the resource claim tracking :)
00:24:28 mriedem of course
00:26:00 openstackgerrit Merged openstack/nova master: Pre-load instance.device_metadata in InstanceMetadata https://review.openstack.org/481235
00:27:22 openstackgerrit Merged openstack/nova master: hyperv: Fixes log message in livemigrationops https://review.openstack.org/479245
00:45:25 mriedem alex_xu: i replied to your comments in https://review.openstack.org/#/c/464280/ - i probably won't be able to attend the api meeting this week, so i might post some thoughts in the ML for discussion, but i'm struggling with deciding if we should allow the same behavior as before regarding trying to disable an already disabled service and failing or ignoring it, same for enabling an enabled service since that's not a failure t
00:45:53 mriedem but that's essentially how i wrote that change - it won't fail if you try to enable and enabled service and vice versa for disabled
00:46:01 mriedem *an enabled service
03:23:37 openstackgerrit zhangdaolong proposed openstack/nova master: Fix appropriate parameters name for unit test https://review.openstack.org/482782
03:55:45 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(4/4) https://review.openstack.org/469800
05:56:36 openstackgerrit Merged openstack/nova master: Fix quota class set APIs https://review.openstack.org/467999
06:34:26 openstackgerrit Béla Vancsics proposed openstack/nova master: Modify the value of instance's root_gb when flavor's root_gb is 0 https://review.openstack.org/398891
06:36:45 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(4/4) https://review.openstack.org/469800
07:38:58 openstackgerrit jichenjc proposed openstack/nova master: Enhance support matrix document https://review.openstack.org/482013
07:42:50 danpawlik Good morning
07:43:27 danpawlik Does someone know, if its possible to change keyboard layout in novnc proxy without changing instnce xml file?
07:45:52 openstackgerrit jichenjc proposed openstack/nova master: Add quiesce and unquiesce in support matrix https://review.openstack.org/482390
07:47:14 openstackgerrit zhangdaolong proposed openstack/nova master: Fix wrong log parm. https://review.openstack.org/482832
07:57:54 openstackgerrit jichenjc proposed openstack/nova master: Enhance support matrix document https://review.openstack.org/482020
08:20:23 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(4/4) https://review.openstack.org/469800
08:36:33 bauzas p!spy
08:46:10 openstackgerrit Merged openstack/os-vif master: Enable some off-by-default checks https://review.openstack.org/482384
08:49:06 ildikov bauzas: hi :)
08:49:14 bauzas ildikov: hey
08:49:15 openstackgerrit Merged openstack/os-vif master: set mtu on all code paths https://review.openstack.org/469951
08:49:27 ildikov bauzas: I have a review with one +2 on it already: https://review.openstack.org/#/c/456971/
08:49:44 ildikov bauzas: was just wondering if you could take a look when you have a little time :)
08:49:52 ildikov bauzas: pretty please :)
08:49:57 bauzas ildikov: sure, I can
08:50:07 ildikov bauzas: awesome, thank you!
08:50:38 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add BDM to InstancePayload https://review.openstack.org/448779
08:51:21 openstackgerrit sudhir agarwal proposed openstack/nova master: Replaces uuid.uuid4 with uuidutils.generate_uuid() https://review.openstack.org/481007
09:02:34 openstackgerrit Alex Szarka proposed openstack/nova master: Changed maximum code complexity to 30 https://review.openstack.org/351176
09:04:45 openstackgerrit iswarya vakati proposed openstack/nova master: Fixed wrap from taking negative values https://review.openstack.org/481465
09:15:22 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for os-baremetal-nodes endpoint instead of stevedore https://review.openstack.org/461480
09:15:23 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for os-security-group-rules instead of stevedore https://review.openstack.org/478903
09:15:23 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for os-security-groups instead of stevedore https://review.openstack.org/478901
09:15:24 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for os-networks instead of stevedore https://review.openstack.org/474463
09:15:24 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for server-security-groups instead of stevedore https://review.openstack.org/478902
09:15:25 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for os-volumes instead of stevedore https://review.openstack.org/479497
09:15:25 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for image-metadata instead of stevedore https://review.openstack.org/478499
09:15:26 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for os-security-group-default-rules instead of stevedore https://review.openstack.org/478904
09:15:26 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for images instead of stevedore https://review.openstack.org/478498
09:48:52 openstackgerrit jichenjc proposed openstack/nova master: Document device tags in support matrix https://review.openstack.org/481478
09:48:52 openstackgerrit jichenjc proposed openstack/nova master: Add description for tag support in attach https://review.openstack.org/481479
09:51:21 openstackgerrit yuanyue proposed openstack/nova master: Recreate root volume for instance rebuild https://review.openstack.org/478330
10:27:04 openstackgerrit yuanyue proposed openstack/nova master: Recreate root volume for instance rebuild https://review.openstack.org/478330
11:53:16 openstackgerrit Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for allocation_candidates https://review.openstack.org/481112
11:53:17 openstackgerrit Andrey Volkov proposed openstack/nova master: [placement] Make placement_api_docs.py failing https://review.openstack.org/480924
11:53:17 openstackgerrit Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for usages https://review.openstack.org/480563
11:53:18 openstackgerrit Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for RP allocations https://review.openstack.org/450550
11:53:18 openstackgerrit Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for RP usages https://review.openstack.org/450105
12:10:40 openstackgerrit Eric Fried proposed openstack/nova master: Document device tags in support matrix https://review.openstack.org/481478
12:11:35 openstackgerrit Eric Fried proposed openstack/nova master: Document device tags in support matrix https://review.openstack.org/481478
12:37:40 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for os-security-groups instead of stevedore https://review.openstack.org/478901
12:37:40 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for os-baremetal-nodes endpoint instead of stevedore https://review.openstack.org/461480
12:37:41 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for os-security-group-rules instead of stevedore https://review.openstack.org/478903
12:37:41 openstackgerrit Alex Xu proposed openstack/nova master: Remove the test for the route '/resources.:(format)' https://review.openstack.org/478900
12:37:42 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for image-metadata instead of stevedore https://review.openstack.org/478499
12:37:42 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for server-security-groups instead of stevedore https://review.openstack.org/478902
12:37:43 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for images instead of stevedore https://review.openstack.org/478498
12:37:43 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for os-volumes instead of stevedore https://review.openstack.org/479497

Earlier   Later