| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-07-11 | |||
| 19:39:10 | melwitt | I found that part pretty confusing | |
| 19:39:45 | mriedem | yeah, elif min_count <= allowed <= max_count: | |
| 19:39:55 | mriedem | user_id=user_id) | |
| 19:39:55 | mriedem | allowed, project_id=project_id, | |
| 19:39:55 | mriedem | return check_num_instances_quota(context, instance_type, min_count, | |
| 19:40:02 | mriedem | so allowed becomes the new max_count | |
| 19:40:20 | mriedem | so give me the min i want plus fill up the rest of my quota | |
| 19:41:19 | melwitt | right, if max was more than quota | |
| 19:48:58 | jaypipes | mriedem: answered you. ack on the reason for not adding a new policy rule. | |
| 19:49:29 | mriedem | double ack good buddy 10-4 | |
| 20:18:10 | mriedem | hmm | |
| 20:18:20 | mriedem | melwitt: we should see if tempest has a soft delete / restore test | |
| 20:19:21 | claudiub | mriedem: heya. any idea where the nova PCI passthrough / SR-IOV guide went? | |
| 20:19:32 | mriedem | melwitt: there isn't - there are only negative tests in tempest for restore | |
| 20:19:36 | mriedem | test_restore_nonexistent_server_id | |
| 20:19:40 | mriedem | test_restore_server_invalid_state | |
| 20:19:42 | claudiub | can't seem to find anymore, only some wiki since juno | |
| 20:20:26 | mriedem | claudiub: hmm, the docs are all being migrated from the openstack-manuals repo | |
| 20:20:43 | mriedem | https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:doc-migration | |
| 20:20:54 | mtreinish | mriedem: I like how you know that off the top of your head | |
| 20:21:07 | mriedem | mtreinish: know what now? | |
| 20:21:08 | melwitt | mriedem: we have functional tests for it nova/tests/functional/test_servers.py test_deferred_delete* | |
| 20:21:35 | mriedem | mtreinish: i searched through the tempest compute api tests for the 'restore' action | |
| 20:21:36 | mtreinish | there is no restore test in tempest | |
| 20:21:36 | mriedem | :) | |
| 20:21:54 | mriedem | found the client call and traced that back to the 2 negative tests | |
| 20:21:57 | mtreinish | heh, you should have just gone with it | |
| 20:22:04 | mtreinish | pretended to know :) | |
| 20:22:04 | mriedem | i mean, i know all | |
| 20:22:32 | claudiub | mriedem: cool, ty. :) | |
| 20:22:56 | mriedem | claudiub: probably this change https://review.openstack.org/#/c/477497/ | |
| 20:23:12 | mriedem | the cpu topologies stuff is in there for numa, huge pages and cpu pinning | |
| 20:23:16 | claudiub | yep, that's the one i was looking at. | |
| 20:23:44 | mriedem | ok, i know there is some stuff in the flavor extra specs doc about pci passthrough | |
| 20:23:52 | mriedem | i think the sriov stuff is in the networking guide? | |
| 20:24:06 | claudiub | i was asking because i was getting some nova-api errors when i was trying to spawn an insance with a flavor extra_spec pci_passthrough:alias | |
| 20:24:32 | claudiub | and was wondering if i missed some configuration | |
| 20:25:09 | mriedem | melwitt: so my point with restore is, | |
| 20:25:23 | mriedem | the way things used to work, when we soft deleted an instance, we would decrement usage, right? | |
| 20:25:30 | mriedem | and on restore, we'd check instance quota + 1 | |
| 20:25:54 | claudiub | as for sriov, afaik, it should be able to be used just like pci passthough. | |
| 20:26:08 | melwitt | mriedem: I think soft-deleted instances count against quota until they are deleted for real behind the scenes after the reclaim interval passes | |
| 20:27:11 | melwitt | wait hang on, maybe I'm wrong | |
| 20:27:35 | mriedem | yeah i don't think that's right | |
| 20:27:49 | mriedem | soft delete in the api would create a decrement reservation and pass that to the compute manager | |
| 20:27:50 | melwitt | yeah, sorry. quota is indeed released upon soft delete even if reclaim hasn't happened yet | |
| 20:28:02 | mriedem | the compute manager soft_delete_instance would commit the reservation when it deleted the guest | |
| 20:28:13 | melwitt | I got mixed up thinking about a patch someone has up to tie up quota until reclaim | |
| 20:28:15 | mriedem | or rollback if the soft delete fails in the manager | |
| 20:29:30 | mriedem | ok leaving comments | |
| 20:29:33 | melwitt | mriedem: so it's a matter of, we need to make sure the count doesn't count soft deleted instances, and I'm pretty sure it doesn't bc the {'deleted': False} filter includes soft delete IIRC | |
| 20:29:36 | mriedem | still chugalugging through the api | |
| 20:29:44 | melwitt | thanks | |
| 20:30:03 | mriedem | i haven't even gotten to the count_as_dict thingy yet | |
| 20:30:04 | mriedem | :) | |
| 20:30:26 | mriedem | i'd think we could also just remove the check_num_instances_quota call from restore() in the compute api | |
| 20:31:39 | mriedem | which now has me thinking, | |
| 20:31:45 | melwitt | why? to keep the behavior we would check quota since that's going to change usage | |
| 20:32:04 | mriedem | this is going to be an upcall from the computes | |
| 20:32:10 | melwitt | soft delete takes it out of usage, restore would put it back into usage | |
| 20:32:48 | melwitt | I thought the check for restore is in compute/api, not an upcall. *looks* | |
| 20:32:58 | mriedem | it is, | |
| 20:33:11 | mriedem | i'm talking about anything that happens in the compute manager on soft_delete_instance or reclaim_queued_deletes | |
| 20:34:20 | melwitt | why does it matter what happens in compute manager? if usage is decremented when the user soft deletes, it's already handled? | |
| 20:35:45 | mriedem | where do we actually decrement the usage in the API on soft delete though? | |
| 20:37:17 | melwitt | when it's marked as soft deleted, it should no longer show up in the count because of the {'deleted': False} filter in the count function | |
| 20:37:28 | mriedem | oh yeah, was just about to make that connection | |
| 20:39:47 | melwitt | this is where the logic is https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L2167-L2192 | |
| 20:56:00 | mriedem | melwitt: dansmith: ok, i have posted comments. i have to jump on a call for a bit. i still need to go through the resize stuff to complete the api, and then everything else after that... | |
| 20:57:40 | melwitt | thanks mriedem | |
| 21:08:34 | dansmith | is the gate sick? | |
| 21:08:40 | dansmith | seems like the queue is barely draining | |
| 21:15:18 | alaski | \quit | |
| 21:15:28 | alaski | grr | |
| 21:16:34 | melwitt | o/ alaski | |
| 21:35:26 | jaypipes | I want to firebomb these scheduler unit tests. | |
| 21:38:10 | melwitt | :) | |
| 21:38:43 | jaypipes | melwitt: seriously. I am contemplating making napalm to douse my computer with. | |
| 21:39:59 | melwitt | heh. I feel you. | |
| 21:43:13 | alaski | o/ cdent and melwitt | |
| 21:59:06 | openstackgerrit | Merged openstack/nova master: Add release note for xenapi virt device tagging support https://review.openstack.org/481148 | |
| 22:31:23 | gheorghe_ | every time i try o migrate an instance, it gets migrated to the same host | |
| 22:31:24 | gheorghe_ | migrations is successful but the VM stays on the same host | |
| 22:31:26 | gheorghe_ | i am using ocata on ubuntu 16.04 | |
| 23:00:15 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: add claim_resources() to report client https://review.openstack.org/482382 | |
| 23:00:16 | openstackgerrit | Jay Pipes proposed openstack/nova master: scheduler: alternates for filter scheduler https://review.openstack.org/482381 | |
| 23:00:16 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: claim resources in filter scheduler https://review.openstack.org/482383 | |
| 23:27:26 | openstackgerrit | Merged openstack/nova master: xenapi: avoid unnecessary BDM query when building device metadata https://review.openstack.org/481162 | |
| #openstack-nova - 2017-07-12 | |||
| 00:24:25 | mriedem | dansmith: video ram isn't tracked for placement :) it's checked on server create and decremented from ram quota on server delete, and checked in the libvirt driver, but not part of the resource claim tracking :) | |
| 00:24:28 | mriedem | of course | |
| 00:26:00 | openstackgerrit | Merged openstack/nova master: Pre-load instance.device_metadata in InstanceMetadata https://review.openstack.org/481235 | |
| 00:27:22 | openstackgerrit | Merged openstack/nova master: hyperv: Fixes log message in livemigrationops https://review.openstack.org/479245 | |
| 00:45:25 | mriedem | alex_xu: i replied to your comments in https://review.openstack.org/#/c/464280/ - i probably won't be able to attend the api meeting this week, so i might post some thoughts in the ML for discussion, but i'm struggling with deciding if we should allow the same behavior as before regarding trying to disable an already disabled service and failing or ignoring it, same for enabling an enabled service since that's not a failure t | |
| 00:45:53 | mriedem | but that's essentially how i wrote that change - it won't fail if you try to enable and enabled service and vice versa for disabled | |
| 00:46:01 | mriedem | *an enabled service | |
| 03:23:37 | openstackgerrit | zhangdaolong proposed openstack/nova master: Fix appropriate parameters name for unit test https://review.openstack.org/482782 | |
| 03:55:45 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(4/4) https://review.openstack.org/469800 | |
| 05:56:36 | openstackgerrit | Merged openstack/nova master: Fix quota class set APIs https://review.openstack.org/467999 | |
| 06:34:26 | openstackgerrit | Béla Vancsics proposed openstack/nova master: Modify the value of instance's root_gb when flavor's root_gb is 0 https://review.openstack.org/398891 | |
| 06:36:45 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(4/4) https://review.openstack.org/469800 | |