| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-07-06 | |||
| 21:03:00 | mriedem | oh i was looking at yours | |
| 21:13:49 | dansmith | mriedem: oh I bet you were | |
| 21:13:59 | mriedem | i was less than impressed | |
| 21:14:51 | dansmith | daaaum.. | |
| 21:15:12 | mriedem | not sure i care for claudiub's change since it's specific to the virt driver, and xenapi just added this same support | |
| 21:15:25 | mriedem | but i think xenapi will be ok because they also blindly set instance.device_metadata | |
| 21:15:35 | dansmith | mriedem: well, the deal is, we needn't load this because libvirt always has this set once it has resolved the devices | |
| 21:15:50 | dansmith | so I think the better thing is to make sure that's the assumed behavior, | |
| 21:15:51 | dansmith | otherwise we're just lazy-loading nothing | |
| 21:15:51 | mriedem | i know it's not an issue for libvirt | |
| 21:16:16 | dansmith | we can do both I guess just to make sure we don't get the 'splosion | |
| 21:16:40 | mriedem | yeah see that's the other thing, the comment in the change to pre-load those said it was doing ec2_ids and keypairs because those are known to be used in there, | |
| 21:16:46 | mriedem | device_metadata clearly is also | |
| 21:17:02 | dansmith | yeah, fair enough | |
| 21:17:59 | mriedem | i'll just move my test over to your patch and +W it | |
| 21:18:33 | dansmith | already abandoned and +2d yours | |
| 21:18:37 | mriedem | guh | |
| 21:18:54 | dansmith | you had nothing but mean things to say about mine | |
| 21:19:03 | mriedem | i'm sorry | |
| 21:19:07 | mriedem | a little | |
| 21:19:11 | dansmith | yours was a little bigger | |
| 21:20:15 | mriedem | "I think you mean "touch"" - i try to avoid getting sued | |
| 21:20:29 | dansmith | since when? | |
| 21:20:32 | dansmith | this is news to me | |
| 21:20:34 | mriedem | about 20 minutes ago | |
| 21:20:38 | dansmith | haha | |
| 21:30:40 | openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: test new style volume attach with live migration https://review.openstack.org/481290 | |
| 21:30:41 | mriedem | ildikov: stvnoyes1: ^ should test live migration with the new style volume attachments | |
| 21:30:47 | mriedem | assuming it all merges | |
| 21:31:23 | ildikov | mriedem: fingers crossed :) | |
| 21:31:37 | ildikov | mriedem: and thanks | |
| 21:41:08 | melwitt | mriedem: looks like zuul is angry with your patch | |
| 21:41:36 | mriedem | zuul be damned | |
| 21:41:42 | melwitt | heh | |
| 21:54:31 | openstackgerrit | Mike Perez proposed openstack/nova master: Replace support matrix ext with common library https://review.openstack.org/481304 | |
| 21:56:26 | openstackgerrit | Mike Perez proposed openstack/nova master: Replace support matrix ext with common library https://review.openstack.org/481304 | |
| 22:08:51 | openstackgerrit | Octave Orgeron proposed openstack/nova master: Enables MySQL Cluster Support for Nova https://review.openstack.org/446643 | |
| 22:27:30 | openstackgerrit | Merged openstack/nova master: [placement] Improve allocation_candidates coverage https://review.openstack.org/481153 | |
| 22:50:08 | dansmith | mriedem: oooh, you fail | |
| 22:50:33 | mriedem | ildikov: went through the swap volume change - https://review.openstack.org/#/c/456971/ - there are a bunch of missing tests, i can work on adding those | |
| 22:50:41 | mriedem | since i have it in my head what i'd like to see | |
| 22:51:06 | mriedem | dansmith: holy god yeah i did | |
| 22:51:22 | mriedem | gah it's that damn ec2_ids | |
| 22:51:24 | mriedem | fixing | |
| 22:51:50 | mriedem | looks like it's going to be an all nighter | |
| 22:52:25 | ildikov | mriedem: yeah, I fixed a few added just a few more and went ahead to fix the attach patch... | |
| 22:52:35 | mriedem | np | |
| 22:52:37 | mriedem | i'll add the rest | |
| 22:52:52 | ildikov | mriedem: prolly waaaay faster if you add the rest | |
| 22:53:56 | ildikov | mriedem: I owe you | |
| 22:54:09 | ildikov | mriedem: thank you! | |
| 23:00:25 | mriedem | ildikov: confirmed that the new style volume swap was tested in the change at the top of the series http://logs.openstack.org/85/330285/86/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/15d8c0f/console.html#_2017-07-05_17_04_17_100023 | |
| 23:01:43 | mriedem | that's the nova-initiated swap, not the cinder one, | |
| 23:01:49 | mriedem | we have another job that tests that in the experimental queue i htink | |
| 23:02:21 | ildikov | mriedem: I saw it failing when I messed up something earlier so I knew it's supposed to run | |
| 23:02:29 | mriedem | the tempest test is TestVolumeMigrateRetypeAttached | |
| 23:02:57 | ildikov | Hmm I don't recall that one | |
| 23:02:59 | mriedem | i think it's tested from the lvm multibackend job | |
| 23:03:19 | mriedem | that's the one that scottda added for testing volume migration/retype | |
| 23:04:02 | mriedem | i think tempest-dsvm-neutron-scenario-multinode-lvm-multibackend | |
| 23:04:09 | ildikov | Yeah, I remember that I just don't remember having any issues with it so I didn't deal with it | |
| 23:04:27 | mriedem | there is also tempest-dsvm-lvm-multibackend but that doesn't run slow tests, and this is tagged as a slow test | |
| 23:04:33 | mriedem | experimental queue jobs won't vote | |
| 23:04:39 | mriedem | so you likely wouldn't notice | |
| 23:05:31 | ildikov | I checked the non-voting jobs too when they failed | |
| 23:05:55 | mriedem | yeah but check queue non-voting != experimental queue non-voting | |
| 23:06:06 | mriedem | experimental queue jobs are all run on-demand | |
| 23:07:02 | ildikov | ok, missed the experimental part for a sec | |
| 23:11:15 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Pre-load instance.device_metadata in InstanceMetadata https://review.openstack.org/481235 | |
| 23:11:16 | mriedem | dansmith: melwitt: ^ fixed | |
| 23:13:31 | mriedem | jaypipes: i might just update this one https://review.openstack.org/#/c/476631/ | |
| 23:57:44 | jaypipes | melwitt: go for it | |
| 23:58:24 | jaypipes | lol, that should have been mriedem. | |
| 23:58:33 | jaypipes | mriedem: but I can fix those issues. sorry, was out of the hosue. | |
| #openstack-nova - 2017-07-07 | |||
| 00:06:02 | gmann | mriedem, good morning. can you check this spec, i updated the quota class APi fix spec for network quota filter out - https://review.openstack.org/#/c/480815/ | |
| 00:16:35 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: scheduler uses allocation candidates https://review.openstack.org/476631 | |
| 00:16:36 | openstackgerrit | Jay Pipes proposed openstack/nova master: WIP - placement: claim resources in scheduler https://review.openstack.org/476632 | |
| 00:16:37 | jaypipes | mriedem: ^ k, fixed up. | |
| 00:30:27 | mriedem | cool | |
| 00:35:18 | jaypipes | mriedem: sorry for the delay. was out this afternoon. | |
| 00:35:30 | mriedem | np, one teeny tiny thing https://review.openstack.org/#/c/476631/17 | |
| 00:35:36 | mriedem | and then +2 to the extreme | |
| 00:41:15 | jaypipes | mriedem: done. | |
| 00:41:21 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: scheduler uses allocation candidates https://review.openstack.org/476631 | |
| 00:41:22 | openstackgerrit | Jay Pipes proposed openstack/nova master: WIP - placement: claim resources in scheduler https://review.openstack.org/476632 | |
| 00:42:03 | alex_xu | jaypipes: easy fix for AllocationCandidates https://review.openstack.org/480379 :) | |
| 00:42:23 | alex_xu | jaypipes: sorry, that is the hard one, need your feedback, the easy one is https://review.openstack.org/480130 | |
| 00:42:53 | jaypipes | alex_xu: cool, will review both later tonight. | |
| 00:42:59 | alex_xu | jaypipes: thanks! | |
| 00:46:42 | openstackgerrit | yuanyue proposed openstack/nova master: Add log info in scheduler to mark start of scheduling https://review.openstack.org/481340 | |
| 00:47:05 | jaypipes | alex_xu: approved the one. nice catch! :) | |
| 00:47:15 | alex_xu | jaypipes: thanks \o/ | |
| 00:48:07 | jaypipes | alex_xu: would be good to add a functional test that verified that (though, I understand that all of our fixtures and the way we currently do testing would *not* have shown that issue since the usages table was appropriately filtered by resource_class_id already. | |
| 00:49:57 | alex_xu | jaypipes: you mean a functional test for usage filtered by resource_class_id? | |
| 00:51:33 | jaypipes | alex_xu: no, I mean add a functional test that showed the missing WHERE condition that was fixed in your patch. | |
| 00:52:30 | alex_xu | jaypipes: emm..I changed the function tests to expose that bug https://review.openstack.org/#/c/480130/3/nova/tests/functional/db/test_resource_provider.py | |
| 00:52:54 | mriedem | jaypipes: +2 | |
| 00:53:05 | mriedem | dansmith: for your morning, +2 on the allocation candidates in scheduler change https://review.openstack.org/#/c/476631/ | |
| 00:55:06 | jaypipes | alex_xu: understood. but those tests, while exposing the bug, didn't directly call _get_usages_by_provider_and_rc(). that's all I was saying, sorry, I wasn't being clear! | |
| 00:56:05 | alex_xu | jaypipes: ah, I see now | |