Earlier  
Posted Nick Remark
#openstack-nova - 2017-07-06
20:46:06 mriedem that spec update was last july
20:46:11 mriedem the ML thread was from jan 2016
20:46:21 dims y, chasing ghosts
20:47:02 mriedem i think it basically amounted to,
20:47:12 mriedem barbican didn't want a fake key manager b/c it's not secure, obviously,
20:47:25 mriedem but the rest of us don't want fake key managers in nova/cinder/anywhere else that's copied that pattern for testing,
20:47:30 dims right, this is castellan
20:47:32 mriedem and because barbican isn't in base devstack,
20:47:35 mriedem we can't get it from barbican
20:47:48 mriedem *we can't use barbican, or rely on it being in the dsvm env
20:47:53 dims yep
20:48:22 dims that's what i am chasing prompted by a ping from ttx about potentially making barbican a base service in the future
20:48:51 dims there are 2 ConfKeyManager(s) one in cinder and one in nova :)
20:49:25 mriedem yeah and the cinder one is a copy of the nova one
20:53:50 mriedem found it
20:53:56 mriedem you owe me $5
20:53:58 dims looks like setting the api_class is never used in any tests
20:54:07 dims http://codesearch.openstack.org/?q=BarbicanKeyManager&i=nope&files=&repos=
20:54:12 mriedem http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2016-06-13.log.html#t2016-06-13T18:44:47
20:54:23 mriedem https://review.openstack.org/#/c/273717/
20:54:30 mriedem it was prompted by that devstack change
20:55:01 dims thanks mriedem ! i still have some RMB you can have :)
20:55:16 mriedem me too
20:59:14 openstackgerrit Matt Riedemann proposed openstack/nova master: Pre-load instance.device_metadata in InstanceMetadata https://review.openstack.org/481235
20:59:15 mriedem dansmith: claudiub pointed this out the other day ^
20:59:31 dansmith mriedem: I put a patch up for it,
20:59:35 mriedem oh
20:59:43 mriedem same big
20:59:44 mriedem *bug?
20:59:49 dansmith mriedem: but I think the right approach is different, and he put one up for it
21:00:11 dansmith https://review.openstack.org/#/c/479335/
21:00:13 dansmith yeah
21:01:14 melwitt are we doing a nova meeting today?
21:01:17 mriedem yes
21:01:18 mriedem crap
21:02:24 mriedem dansmith: this is his i guess? https://review.openstack.org/#/c/479335/
21:02:39 dansmith mriedem: I just pasted that bove :)
21:03:00 mriedem oh i was looking at yours
21:13:49 dansmith mriedem: oh I bet you were
21:13:59 mriedem i was less than impressed
21:14:51 dansmith daaaum..
21:15:12 mriedem not sure i care for claudiub's change since it's specific to the virt driver, and xenapi just added this same support
21:15:25 mriedem but i think xenapi will be ok because they also blindly set instance.device_metadata
21:15:35 dansmith mriedem: well, the deal is, we needn't load this because libvirt always has this set once it has resolved the devices
21:15:50 dansmith so I think the better thing is to make sure that's the assumed behavior,
21:15:51 dansmith otherwise we're just lazy-loading nothing
21:15:51 mriedem i know it's not an issue for libvirt
21:16:16 dansmith we can do both I guess just to make sure we don't get the 'splosion
21:16:40 mriedem yeah see that's the other thing, the comment in the change to pre-load those said it was doing ec2_ids and keypairs because those are known to be used in there,
21:16:46 mriedem device_metadata clearly is also
21:17:02 dansmith yeah, fair enough
21:17:59 mriedem i'll just move my test over to your patch and +W it
21:18:33 dansmith already abandoned and +2d yours
21:18:37 mriedem guh
21:18:54 dansmith you had nothing but mean things to say about mine
21:19:03 mriedem i'm sorry
21:19:07 mriedem a little
21:19:11 dansmith yours was a little bigger
21:20:15 mriedem "I think you mean "touch"" - i try to avoid getting sued
21:20:29 dansmith since when?
21:20:32 dansmith this is news to me
21:20:34 mriedem about 20 minutes ago
21:20:38 dansmith haha
21:30:40 openstackgerrit Matt Riedemann proposed openstack/nova master: DNM: test new style volume attach with live migration https://review.openstack.org/481290
21:30:41 mriedem ildikov: stvnoyes1: ^ should test live migration with the new style volume attachments
21:30:47 mriedem assuming it all merges
21:31:23 ildikov mriedem: fingers crossed :)
21:31:37 ildikov mriedem: and thanks
21:41:08 melwitt mriedem: looks like zuul is angry with your patch
21:41:36 mriedem zuul be damned
21:41:42 melwitt heh
21:54:31 openstackgerrit Mike Perez proposed openstack/nova master: Replace support matrix ext with common library https://review.openstack.org/481304
21:56:26 openstackgerrit Mike Perez proposed openstack/nova master: Replace support matrix ext with common library https://review.openstack.org/481304
22:08:51 openstackgerrit Octave Orgeron proposed openstack/nova master: Enables MySQL Cluster Support for Nova https://review.openstack.org/446643
22:27:30 openstackgerrit Merged openstack/nova master: [placement] Improve allocation_candidates coverage https://review.openstack.org/481153
22:50:08 dansmith mriedem: oooh, you fail
22:50:33 mriedem ildikov: went through the swap volume change - https://review.openstack.org/#/c/456971/ - there are a bunch of missing tests, i can work on adding those
22:50:41 mriedem since i have it in my head what i'd like to see
22:51:06 mriedem dansmith: holy god yeah i did
22:51:22 mriedem gah it's that damn ec2_ids
22:51:24 mriedem fixing
22:51:50 mriedem looks like it's going to be an all nighter
22:52:25 ildikov mriedem: yeah, I fixed a few added just a few more and went ahead to fix the attach patch...
22:52:35 mriedem np
22:52:37 mriedem i'll add the rest
22:52:52 ildikov mriedem: prolly waaaay faster if you add the rest
22:53:56 ildikov mriedem: I owe you
22:54:09 ildikov mriedem: thank you!
23:00:25 mriedem ildikov: confirmed that the new style volume swap was tested in the change at the top of the series http://logs.openstack.org/85/330285/86/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/15d8c0f/console.html#_2017-07-05_17_04_17_100023
23:01:43 mriedem that's the nova-initiated swap, not the cinder one,
23:01:49 mriedem we have another job that tests that in the experimental queue i htink
23:02:21 ildikov mriedem: I saw it failing when I messed up something earlier so I knew it's supposed to run
23:02:29 mriedem the tempest test is TestVolumeMigrateRetypeAttached
23:02:57 ildikov Hmm I don't recall that one
23:02:59 mriedem i think it's tested from the lvm multibackend job
23:03:19 mriedem that's the one that scottda added for testing volume migration/retype
23:04:02 mriedem i think tempest-dsvm-neutron-scenario-multinode-lvm-multibackend
23:04:09 ildikov Yeah, I remember that I just don't remember having any issues with it so I didn't deal with it
23:04:27 mriedem there is also tempest-dsvm-lvm-multibackend but that doesn't run slow tests, and this is tagged as a slow test
23:04:33 mriedem experimental queue jobs won't vote

Earlier   Later