Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-07-06
01:31:18 mriedem something like that right?
01:31:26 Kevin_Zheng besides, build_request contains TagList.obj so I build taglist in API layer
01:31:27 Kevin_Zheng yes
01:32:32 mriedem i wonder if people would be ok with checking the type for the tags parameter in TagList.create
01:32:42 mriedem and if it's a TagList, convert it to a simple form
01:33:27 mriedem it's just a lot more efficient to do it that way in a single call if we have multiple tags for the server
01:34:00 mriedem because every separate tag create call does this extra _check_instance_exists_in_project db query
01:34:02 mriedem and context switch
01:34:28 Kevin_Zheng you mean do it in objects/tag.py?
01:34:53 mriedem well that would abstract the check which would be nice and clean, but people might not like that, like dansmith
01:35:25 mriedem otherwise we could just convert the TagList to a simple list in the conductor method
01:35:37 mriedem i think passing the TagList object from the compute api to conductor is still ok and what we want
01:36:24 Kevin_Zheng yeah, and we also need it in build_request
01:36:33 mriedem sure i think that's fine
01:36:50 mriedem i wish TagList just had a non-classmethod create() but that would conflict with the classmethod
01:37:13 mriedem we could add a TagList.create_all(context) or something
01:37:22 mriedem TagList.create_all(context, resource_id)
01:37:35 mriedem which would use the tags already stored in the TagList
01:37:48 mriedem create_all() is a confusing name when there is already a create() method
01:37:54 Kevin_Zheng yeah
01:38:07 mriedem i'm just kicking out ideas, i could talk to dan in the morning,
01:38:24 mriedem but i'd really like to do the create in the single call fashion rather than iterate in conductor manager
01:38:44 Kevin_Zheng OK, I will have a try and have all the other comments addressed
01:38:46 Kevin_Zheng first
01:38:53 mriedem the simplest way to do that today is just doing tags = [tag.tag for tag in tags] in conductor manager
01:39:13 mriedem we could always move ^ into TagList later if we wanted
01:39:27 Kevin_Zheng OK
01:42:51 openstackgerrit Matt Riedemann proposed openstack/nova master: api-ref: mark instance action events parameter as optional https://review.openstack.org/480792
02:03:05 openstackgerrit Merged openstack/nova master: Fix arguments in calling _delete_nic_metadata https://review.openstack.org/480369
02:08:20 openstackgerrit Merged openstack/nova master: Delete all inventory has its own method DELETE https://review.openstack.org/460147
02:10:23 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(3/4) https://review.openstack.org/459593
03:15:46 openstackgerrit Ghanshyam Mann proposed openstack/nova-specs master: Update quota class spec to filter out networks quota https://review.openstack.org/480815
03:27:21 gmann alex_xu, mriedem: updated spec for filter out network quotas in os-quota-class - https://review.openstack.org/#/c/480815/1
03:27:33 alex_xu gmann: thanks
03:45:56 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(3/4) https://review.openstack.org/459593
04:06:59 openstackgerrit zhangdaolong proposed openstack/python-novaclient master: Fix the inappropriate parameter name https://review.openstack.org/480826
04:33:35 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add 'updated_at' field to InstancePayload in notifications https://review.openstack.org/475276
05:04:52 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.49 - Virt device tagged attach https://review.openstack.org/480392
05:19:44 openstackgerrit Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955
05:20:07 openstackgerrit Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964
05:20:34 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042
05:21:07 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add functional tests for cold migration to same host https://review.openstack.org/414926
05:34:18 openstackgerrit zhangdaolong proposed openstack/nova master: Fix parameters and description for os-volume_attachments https://review.openstack.org/480832
05:35:28 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.50 - Enable cold migration with target host https://review.openstack.org/406707
05:53:17 openstackgerrit Moshe Levi proposed openstack/os-vif master: fix read the representor phys_port_name https://review.openstack.org/480213
05:54:43 reedip Hi guys, With Ceph as backend, and using cinder, when we attach a volume to an instance, the following error is visible in the compute's nova-compute.log
05:54:57 reedip libvirtError: Secret not found: rbd no secret matches uuid '------------------------------------'
05:55:07 reedip any ideas how to resolve it ?
05:55:20 reedip we have one ceph, one compute and one controller+network node
06:01:38 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Fix to return server groups quota in quota class set https://review.openstack.org/467999
06:08:32 openstackgerrit Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608
06:09:52 openstackgerrit Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483
06:41:13 openstackgerrit Béla Vancsics proposed openstack/nova master: Transform keypair.import notification https://review.openstack.org/467514
06:45:54 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.50 - List/Show all server migration types https://review.openstack.org/430839
06:50:17 gaurangt Hi, I'm facing an issue where quota is not getting updated when the failed instance is deleted. Is there any work around for setting the right values for the quotas?
06:55:39 openstackgerrit Merged openstack/nova master: Add api-ref for os-quota-class-set APIs https://review.openstack.org/467938
07:15:49 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Add X-Openstack-Request-Id description https://review.openstack.org/474847
07:37:25 openstackgerrit Takashi NATSUME proposed openstack/nova master: Use URIOpt https://review.openstack.org/479215
07:42:00 openstackgerrit Silvan Kaiser proposed openstack/nova master: [WIP] Add truncate for images if prealloc is true https://review.openstack.org/480464
07:52:24 openstackgerrit Takashi NATSUME proposed openstack/nova master: Stop using mox stubs in test_console_auth_tokens.py https://review.openstack.org/477374
08:41:01 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi: Exception Error logs shown in Citrix XenServer CI https://review.openstack.org/478437
08:50:59 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(3/4) https://review.openstack.org/459593
08:53:16 openstackgerrit Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for RP traits https://review.openstack.org/474550
08:53:17 openstackgerrit Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for usages https://review.openstack.org/480563
08:53:17 openstackgerrit Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for allocations https://review.openstack.org/470933
08:53:18 openstackgerrit Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for RP usages https://review.openstack.org/450105
08:53:18 openstackgerrit Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for RP allocations https://review.openstack.org/450550
08:59:31 openstackgerrit Takashi NATSUME proposed openstack/nova master: Stop using mox stubs in test_console_auth_tokens.py https://review.openstack.org/477374
09:12:39 openstackgerrit Andrey Volkov proposed openstack/nova master: [placement] Make placement_api_docs.py failing https://review.openstack.org/480924
09:20:04 openstackgerrit Andreas Scheuring proposed openstack/nova master: DO NOT MERGE! Dummy patch https://review.openstack.org/478186
09:38:02 bauzas sfinucan: very old bug https://review.openstack.org/#/c/391060/
09:38:41 stephenfin bauzas: I feel like I already reviewed that?
09:39:13 bauzas I know, you did +1
09:39:33 bauzas but it was a long time ago :p
09:40:20 stephenfin bauzas: Was there something similar to that a few weeks back though?
09:40:33 stephenfin with requestspec objects
09:41:28 stephenfin Oh yeah, commit e211fca55a11c80058d5d78e31dc3ad466d7edfd
09:41:55 stephenfin Cool. I'll take a look once I've finished resolving the merge conflict on https://review.openstack.org/#/c/415921/
09:45:16 openstackgerrit Alex Szarka proposed openstack/nova master: Transform instance-live_migration_post notification https://review.openstack.org/480119
09:59:44 bauzas sorry, was afk for getting my daughter at school
10:17:24 _jarvis need help in this bug
10:17:25 openstack Launchpad bug 1698253 in OpenStack Compute (nova) "InvalidInput: Invalid input received: vif type bridge not supported" [Undecided,In progress] - Assigned to PRAVIN (jarvisopenstack)
10:17:25 _jarvis https://bugs.launchpad.net/nova/+bug/1698253
10:19:06 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add sample test for instance audit https://review.openstack.org/480955
10:19:17 _jarvis these was working in liberity
10:20:29 openstackgerrit Stephen Finucane proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807
10:20:31 openstackgerrit Stephen Finucane proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215
10:20:32 openstackgerrit Stephen Finucane proposed openstack/nova master: placement: integrate ProviderTree to report client https://review.openstack.org/415921
10:20:32 openstackgerrit Stephen Finucane proposed openstack/nova master: placement: set/check if inventory change in tree https://review.openstack.org/470575
10:20:33 openstackgerrit Stephen Finucane proposed openstack/nova master: placement: add nested resource providers https://review.openstack.org/377138
10:20:33 openstackgerrit Stephen Finucane proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693
10:20:34 openstackgerrit Stephen Finucane proposed openstack/nova master: placement: add ProviderTree.is_inventory_empty https://review.openstack.org/480957
11:05:43 openstackgerrit Alex Szarka proposed openstack/nova master: Add method for verify multiple versioned notifications https://review.openstack.org/465526
11:05:53 openstackgerrit Alex Szarka proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660
11:20:38 openstackgerrit Balazs Gibizer proposed openstack/nova master: Make notification publisher_id consistent https://review.openstack.org/480984
11:30:58 openstackgerrit Arundhati Surpur proposed openstack/python-novaclient master: Removed extra 'method' from the NOTE https://review.openstack.org/480988
11:33:45 openstackgerrit Béla Vancsics proposed openstack/nova master: Transform keypair.import notification https://review.openstack.org/467514
11:41:43 alex_xu bauzas: another fix for placement https://review.openstack.org/#/c/480130/, this should be easy :)
11:51:35 openstackgerrit Balazs Gibizer proposed openstack/nova master: Use enum value instead of string service name https://review.openstack.org/476538
12:01:16 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/477091

Earlier   Later