Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-07-05
08:42:02 gibi stephenfin: the followup pep8 patch might conflict with yours but then I will push that top of your series
08:42:19 stephenfin gibi: yup - I'm referring to the follow-up
08:42:40 gibi stephenfin: cool, then we are on the same page.
08:42:49 stephenfin (y)
08:43:27 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi: Exception Error logs shown in Citrix XenServer CI https://review.openstack.org/478437
08:47:29 openstackgerrit Chason Chan proposed openstack/python-novaclient master: switch to openstackdocstheme https://review.openstack.org/477757
08:51:37 openstackgerrit Merged openstack/nova master: Reset the traits sync flag in the placement fixtures https://review.openstack.org/480198
09:16:27 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(3/4) https://review.openstack.org/459593
09:18:09 bauzas sfinucan: test courtesy ping
09:20:59 openstackgerrit Silvan Kaiser proposed openstack/nova master: [WIP] Add truncate for images if prealloc is true https://review.openstack.org/480464
09:22:31 openstackgerrit Silvan Kaiser proposed openstack/nova master: [WIP] Add truncate for images if prealloc is true https://review.openstack.org/480464
09:23:07 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/nova master: Read Neutron port 'binding_profile' during boot https://review.openstack.org/449257
09:23:28 openstackgerrit Silvan Kaiser proposed openstack/nova master: [WIP] Add truncate for images if prealloc is true https://review.openstack.org/480464
09:24:33 bauzas sfinucan: test courtesy ping2
09:25:24 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(4/4) https://review.openstack.org/469800
09:25:25 openstackgerrit Balazs Gibizer proposed openstack/nova master: Enable pep8 on doc generation code https://review.openstack.org/480469
09:25:52 gibi stephenfin, bauzas: I pushed the doc gen follow up patch ^^
09:27:14 bauzas gibi: mmm, sounds okay to me
09:27:31 openstackgerrit Silvan Kaiser proposed openstack/nova master: [WIP] Add truncate for images if prealloc is true https://review.openstack.org/480464
09:28:45 stephenfin gibi: likewise
09:29:06 stephenfin bauzas: If you were really bored today, the rest of that series sure could do with reviews ;)
09:30:10 bauzas stephenfin: https://review.openstack.org/#/q/topic:doc-migration ?
09:30:42 stephenfin Yup. There are patches up there for nova, python-novaclient, os-vif and os-traits
09:30:57 stephenfin But the nova changes are the most important ones right now, IMO
09:31:06 sanfern hi, my vm instance is not getting ip, how can I login into VM from hypervisor and check logs
09:31:49 stephenfin sanfern: See the channel message - you'd have better luck asking that on #openstack
09:33:10 openstackgerrit Matthew Booth proposed openstack/nova master: Automatically revert resize which fails on destination https://review.openstack.org/462521
09:33:11 sanfern stephenfin, thanks
09:33:11 openstackgerrit Matthew Booth proposed openstack/nova master: Ensure errors_out_migration errors out migration https://review.openstack.org/479802
09:33:38 gibi bauzas: could you put your +A on https://review.openstack.org/#/c/475349 ?
09:36:32 bauzas gibi: looks like you're gonna conflict with https://review.openstack.org/#/c/480469/1
09:36:38 bauzas gibi: ping me when you rebase
09:37:57 gibi bauzas: https://review.openstack.org/#/c/480469/ will go in later as it is top of the doc migration series
09:38:42 gibi bauzas: thanks for the +A I will handle the rebase as the conflict appears
09:39:06 bauzas gibi: sure
09:44:34 openstackgerrit Andrey Kurilin proposed openstack/python-novaclient master: [ci] Use pseudo-random names for new resources https://review.openstack.org/479777
09:48:28 openstackgerrit lan proposed openstack/nova master: Switch from oslosphinx to openstackdocstheme https://review.openstack.org/480487
10:02:49 openstackgerrit Silvan Kaiser proposed openstack/nova master: [WIP] Add truncate for images if prealloc is true https://review.openstack.org/480464
10:23:53 openstackgerrit Alex Szarka proposed openstack/nova master: Transform instance-live_migration_abort notification https://review.openstack.org/420453
10:32:50 openstackgerrit Vladyslav Drok proposed openstack/nova master: Fix incorrect docstrings in neutron network API https://review.openstack.org/480167
10:42:07 openstackgerrit Alex Szarka proposed openstack/nova master: Transform instance-live_migration_abort notification https://review.openstack.org/420453
10:42:49 openstackgerrit Alex Szarka proposed openstack/nova master: Transform instance-live_migration_post notification https://review.openstack.org/480119
10:45:41 openstackgerrit Vladyslav Drok proposed openstack/nova master: Fix incorrect docstrings in neutron network API https://review.openstack.org/480167
10:46:49 openstackgerrit Merged openstack/nova master: add missing notification samples to dev ref https://review.openstack.org/475349
10:47:09 openstackgerrit Andrey Kurilin proposed openstack/python-novaclient master: [ci] Use pseudo-random names for new resources https://review.openstack.org/479777
10:47:44 openstackgerrit Alex Xu proposed openstack/nova master: placement: ensure shared RP maps with correct root RP https://review.openstack.org/480379
11:00:41 openstackgerrit Stephen Finucane proposed openstack/nova master: policies: Fix Sphinx issues https://review.openstack.org/480516
11:00:41 openstackgerrit Stephen Finucane proposed openstack/nova master: doc: Start using oslo_policy.sphinxext https://review.openstack.org/479358
11:15:26 openstackgerrit Balazs Gibizer proposed openstack/nova master: Enable pep8 on doc generation code https://review.openstack.org/480469
11:43:06 sean-k-mooney stephenfin: dumb quest but use use git review -d to checkout your patches right? what is the correct syntax to checkout https://review.openstack.org/#/c/466132/
11:43:14 sean-k-mooney *question
11:44:01 sean-k-mooney stephenfin: should i be useing the change id?
11:45:32 sean-k-mooney stephenfin: the yes i should never mind...
11:47:52 mdbooth sfinucan: I had another look at that errors_out_migration patch. I started by writing a better commit message, and as often happens writing docs leads to better understanding :) I've made a couple of changes to affected functions, but hopefully they're now better described and justified.
11:48:50 mdbooth I was really tempted, btw, to change things around in _finish_resize, because it's weird that we do networky things before sending the start notification.
11:49:25 mdbooth I resisted the urge, though, which has resulted in a slightly untidy return value from that function.
11:51:53 efried jaypipes Why do you prefer set(1, 2, 3) over the {1, 2, 3} notation?
11:54:00 stephenfin mdbooth: Sounds good. I'll check it out after lunch :)
11:54:32 stephenfin Also, I'm using stephenfin instead of sfinucan now. You should have got an away message, but it seems some clients don't show them :(
11:54:46 stephenfin sean-k-mooney: So you're good?
11:54:58 sean-k-mooney stephenfin: i think so one question though
11:55:06 stephenfin sean-k-mooney: it's 'git review -d 466132' just in case
11:55:08 stephenfin hit me
11:55:24 sean-k-mooney stephenfin: when submiting if i use -f will it restore the original topic?
11:55:57 sean-k-mooney stephenfin: it checked it out as review/sean_mooney/kolla-build-external-dockerfiles but normally the branch would be just kolla-build-external-dockerfiles
11:56:25 stephenfin sean-k-mooney: It does some odd stuff. If any of the patches have 'blueprint' mentioned in them, the topic will be set to 'bp/{title}'. Ditto for bug ('bug/{bugID}')
11:57:02 stephenfin sean-k-mooney: In general though, if your branch is called 'review/{username}/{topic}', only the '{topic}' piece is kept (i.e. nothing changes)
11:57:19 sean-k-mooney hum ok well i can change it in the gerrit ui if id does the wronge thing might as well just see what it does.
11:57:38 stephenfin efried: I would guess it's because the set notation is not that common
11:58:15 sean-k-mooney stephenfin: i usually checkout everything manually but i think it about time i start using git review for that too
11:58:27 efried stephenfin I ask because I prefer the latter - and in fact my IDE complains if you use set() in certain circumstances where {...} will do.
11:58:27 stephenfin I would say it's very rare in the nova code base, while the 'set(1, 2, 3)' notation is very common
11:58:56 stephenfin sean-k-mooney: I've used nothing but git-review for the past two years and it's rarely, if ever, let me down
11:58:57 efried stephenfin If it's a "nova codebase consistency" thing, okay.
11:59:23 sean-k-mooney stephenfin: yep git review -f work as i wanted thanks :)
11:59:25 efried sean-k-mooney stephenfin +1 git-review
11:59:44 stephenfin sean-k-mooney: two tips for you too. #1 - if you want to download a single patch with dependencies, use '-x' instead of '-d'
12:00:16 stephenfin (very helpful when someone has uploaded a new revision of a patch in the middle of a series, are you want to rebase the successors)
12:00:54 stephenfin and #2 - use '{change},{revision}' to download a previous revision
12:01:06 stephenfin e.g. 'git review -d 466132,1'
12:03:23 openstackgerrit Andrey Kurilin proposed openstack/python-novaclient master: [ci] Use pseudo-random names for new resources https://review.openstack.org/479777
12:03:44 sean-k-mooney efried: ya i use it for upload becase "git push gerrit HEAD:refs/change/466132" is annorying but i havent been useing the other features
12:03:57 sean-k-mooney stephenfin: cool that is good to know
12:15:58 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/477091
12:23:53 openstackgerrit Vladyslav Drok proposed openstack/nova master: Implement interface attach/detach in ironic virt driver https://review.openstack.org/419975
12:26:34 openstackgerrit Vladyslav Drok proposed openstack/nova master: Implement interface attach/detach in ironic virt driver https://review.openstack.org/419975
12:39:55 jaypipes efried: because {1, 2, 3} is too easy to mistake for a dict.
12:40:23 efried jaypipes It is?
12:40:35 jaypipes cdent: I would moo back but suffering from allergies badly today :(
12:41:00 cdent bummer dood
12:41:04 jaypipes efried: perhaps not for you. for others it is :)
12:41:38 efried jaypipes Okay, good to know.
12:42:50 alex_xu jaypipes: cdent two fixes for AllocationCandidates.get_by_filters https://review.openstack.org/480379 and https://review.openstack.org/480130
12:43:05 openstackgerrit Gábor Antal proposed openstack/nova master: Transform instance.live_migration_force_complete notification https://review.openstack.org/480561
12:43:35 cdent I've been pretty good at not paying attention for a while
12:43:59 alex_xu cdent: welcome back :)
12:44:07 cdent thanks alex_xu
12:44:31 openstackgerrit Gábor Antal proposed openstack/nova master: Transform instance.live_migration_force_complete notification https://review.openstack.org/480561
12:45:06 alex_xu nova api meeting is in 15 mins at #openstack-meeting-4
12:47:31 openstackgerrit Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for allocations https://review.openstack.org/470933

Earlier   Later