Earlier  
Posted Nick Remark
#openstack-nova - 2017-06-29
10:06:32 openstackgerrit Stephen Finucane proposed openstack/nova master: doc: Populate the 'reference' section https://review.openstack.org/478484
10:06:32 openstackgerrit Stephen Finucane proposed openstack/nova master: doc: Populate the 'contributor' section https://review.openstack.org/478474
10:06:33 openstackgerrit Stephen Finucane proposed openstack/nova master: doc: Rework index page per new sections https://review.openstack.org/478485
10:06:33 openstackgerrit Stephen Finucane proposed openstack/nova master: doc: Remove dead plugin https://review.openstack.org/478469
10:06:34 openstackgerrit Stephen Finucane proposed openstack/nova master: doc: Create directory structure for docs migration https://review.openstack.org/478471
10:06:34 openstackgerrit Stephen Finucane proposed openstack/nova master: doc: Remove cruft from conf.py https://review.openstack.org/478468
10:06:35 openstackgerrit Stephen Finucane proposed openstack/nova master: doc: Remove dead files https://review.openstack.org/478470
10:07:12 sfinucan OK, I think that's it now
10:10:13 bauzas oh LOL
10:17:22 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Remove check_detach https://review.openstack.org/446671
10:17:23 openstackgerrit Ildiko Vancsa proposed openstack/nova master: WIP/POC Implement new attach Cinder flow https://review.openstack.org/330285
10:29:11 ildikov sfinucan: hi
10:29:45 ildikov sfinucan: did you get a chance to take a look at the swap and/or live_migrate patches I pinged you about earlier this week?
10:30:12 sfinucan ildikov: Yes, but I haven't been able to wrap my head around it :(
10:30:25 sfinucan I really don't know that code, so I'm having to learn it from scratch
10:30:49 ildikov sfinucan: I know that feeling pretty well :( :)
10:31:56 ildikov sfinucan: please let e know if I can help with anything
10:39:16 sfinucan gibi: Can you take a look at my comments on https://review.openstack.org/#/c/448779/30 when possible
10:39:29 sfinucan Particularly the bit about disabling API features with config
10:44:48 gaurangt Hi, I encountered a bug in nova where quota details is not updated when a failed instance is deleted. I see that there is a fix for that which is backported to ocata. https://review.openstack.org/#/c/445236/
10:45:10 gaurangt So, what should I do to update the quota to correct values now?
10:54:33 gibi sfinucan: looking...
11:06:18 gibi sfinucan: responded to your comments in https://review.openstack.org/#/c/448779/30
11:06:46 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add BDM to InstancePayload https://review.openstack.org/448779
11:46:25 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/477091
12:20:40 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for os-cells endpoint instead of stevedore https://review.openstack.org/474869
12:20:41 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for image-metadata instead of stevedore https://review.openstack.org/478499
12:20:41 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for os-networks instead of stevedore https://review.openstack.org/474463
12:20:42 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for volumes instead of stevedore https://review.openstack.org/478502
12:20:42 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for images instead of stevedore https://review.openstack.org/478498
12:20:43 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for os-security-groups instead of stevedore https://review.openstack.org/478901
12:20:43 openstackgerrit Alex Xu proposed openstack/nova master: Remove the test for the route '/resources.:(format)' https://review.openstack.org/478900
12:20:44 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for os-security-group-rules instead of stevedore https://review.openstack.org/478903
12:20:44 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for server-security-groups instead of stevedore https://review.openstack.org/478902
12:20:45 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for os-baremetal-nodes instead of stevedore https://review.openstack.org/478905
12:20:45 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for os-security-group-default-rules instead of stevedore https://review.openstack.org/478904
12:23:01 mriedem yar
12:24:21 gibi mriedem: hi! if you have some time, the next two patches of searchlight notification additions just need a second +2
12:24:35 gibi mriedem: start here /review.openstack.org/#/c/419730
12:24:59 gibi mriedem, sfinucan: and the BDM patch (the third) needs some discussion between you two guys
12:25:25 gibi mriedem ,sfinucan: about the configuration option for turning on BDM in instance.action
12:25:46 edleafe mriedem: When you have time, please re-review https://review.openstack.org/#/c/473627/ - it really doesn't seem that an extra-specs value can be None.
12:28:06 bauzas gibi: edleafe: AFAIK, mriedem is in China this week
12:29:04 edleafe bauzas: yeah, that's why I'm trying to catch him before he goes to sleep :)
12:29:54 bauzas well, UTC+8 means 10:30pm :p
12:30:15 mriedem 8:30pm right now
12:30:15 mriedem gah
12:30:16 bauzas we're not all night owls :p
12:30:41 bauzas what? did I make some wrong calculation ? /me is offended
12:30:43 bauzas fake news!
12:32:38 gibi bauzas: I don't want to keep mriedem awake, I just let him know a possibility in case of insomnia hits
12:32:58 gaoyuan I have a mox3 problem? any one can help
12:32:59 gaoyuan ?
12:33:04 bauzas so, instead of counting sheeps, counting lines ?
12:33:12 bauzas gaoyuan: sure, how can I help ?
12:33:21 gibi bauzas: yeah... maybe counting +2s :)
12:34:03 bauzas gibi: just provide a correct URL and I could help too :p
12:34:19 gaoyuan baozas: I have a mox3 mock object, let's call it a. I did something like a(1, 2, 3).AndReturn(5)
12:34:40 gaoyuan how can I see the value of 1,2,3 later in the code
12:34:54 gaoyuan bauzas: using the a object
12:35:04 bauzas gaoyuan: not sure I understand you
12:35:20 bauzas gaoyuan: you wanna check the values?
12:35:29 gaoyuan yes
12:35:54 bauzas gaoyuan: you also know that if you write a new UT, we ask developers to use mock instead of mox ?
12:36:02 gaoyuan baouzas: I was debuging
12:36:15 gaoyuan baozas: I am working on remove-mox-pike
12:36:41 bauzas gaoyuan: so, what do you want explicitely?
12:36:59 bauzas do you have some code to show up so I could understand more ?
12:37:36 gaoyuan bauzas: wait a minute
12:37:45 mriedem edleafe: that seems like a bug
12:37:57 mriedem because the object field isn't defined as nullable=True
12:38:14 bauzas because writing 'a(1, 2, 3).AndReturn(5)' means that you functionnally expect the mocked object to accept those values as inputs and once called, being always returning 5 ?
12:38:30 bauzas (without the question mark, my bad)
12:38:37 mriedem edleafe: a bug in oslo.versionedobjects i mean
12:39:14 edleafe mriedem: I thought by default nullable=True
12:39:39 mriedem no
12:39:49 mriedem i would expect that behavior to be allowed only for DictOfNullableStringsField
12:40:05 mriedem oh wait, now i'm confusing myself
12:40:16 mriedem so DictOfNullableStringsField would allow {'test': None}
12:40:39 gaoyuan bauzas: http://paste.openstack.org/show/614046/
12:40:46 mriedem nullable defaults to False though
12:41:17 gaoyuan bauzas: this is the code, I deleted something to make it clearer
12:41:47 mriedem how was i able to do this then? https://review.openstack.org/#/c/473627/8/nova/scheduler/filter_scheduler.py@197
12:42:16 gibi bauzas: ups sorry, here is the correct URL https://review.openstack.org/#/c/419730
12:42:31 gaoyuan bauzas: what I want, is to set a break point, in the actual code, to see the value of, let's say, connection_info
12:43:41 mriedem edleafe: ok removed my -1
12:43:45 mriedem edleafe: going to rebase https://review.openstack.org/#/c/473627/ ?
12:44:55 bauzas edleafe: I have a shit ton of review backlog, any urgent things I should look at for placement?
12:45:02 edleafe mriedem: maybe because of https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api_models.py#L207 ?
12:45:03 bauzas like the above ?
12:45:31 edleafe bauzas: I would focus on Jay's series on allocation candidates
12:45:45 edleafe bauzas: he's changing how scheduler drivers work
12:45:45 bauzas edleafe: that's the obvious one
12:45:53 sfinucan mriedem: Assuming gibi hasn't already asked you, could you look at the discussion here https://review.openstack.org/#/c/448779/30/nova/notifications/objects/instance.py
12:46:04 edleafe bauzas: well, you missed that discussion on Tuesday
12:46:17 mriedem edleafe: the object doesn't know anything about that
12:46:19 bauzas edleafe: tl;dr then ?
12:46:25 mriedem edleafe: plus sqla columns default to nullable=True
12:46:44 edleafe bauzas: drivers now return the entire list of HostState objects to the scheduler manager
12:46:50 sfinucan wait - I just saw the "is in China" bit. At some point, in that case

Earlier   Later