| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-06-23 | |||
| 20:16:16 | fried_rice | leakypipes https://review.openstack.org/#/c/475448/9..11/nova/api/openstack/placement/handlers/allocation_candidate.py@160 -- Is there something preventing the request containing `resources=` (i.e. an empty value)? | |
| 20:16:28 | fried_rice | leakypipes If not, ^ will still raise ValueError | |
| 20:18:01 | leakypipes | fried_rice: the JSONSChema validation. | |
| 20:18:16 | fried_rice | leakypipes Which part of that ensures it's nonempty? | |
| 20:19:19 | fried_rice | leakypipes I would have expected "required": [ "resources" ] would just ensure the `resources` key is present. | |
| 20:19:54 | fried_rice | Because an empty value could be valid. | |
| 20:22:35 | fried_rice | leakypipes Just tried it out locally: `jsonschema.validate({'resources': ''}, schema, format_checker=jsonschema.FormatChecker())` passes | |
| 20:31:37 | leakypipes | fried_rice: then we'll have to go and change all the schema validators in all the handlers in placement... | |
| 20:32:03 | fried_rice | leakypipes Or just catch ValueError and convert it to HttpBadRequest | |
| 20:32:13 | leakypipes | fried_rice: which I can try and do this weekend. but for now, I'm tired. :) | |
| 20:35:12 | leakypipes | fried_rice: hold up, pushing a new patch to add that check to normalize_resources_qs_param | |
| 20:35:37 | fried_rice | leakypipes ight. | |
| 20:36:34 | fried_rice | leakypipes Yuh, that'd do it. Since that guy's clearly allowed to raise HttpBadRequest | |
| 20:41:01 | mriedem | melwitt: do you get a 406 or a 405 from placement if requesting a microversion that doesn't exist? | |
| 20:41:19 | mriedem | your consumers/allocations code is checking for a 406 response, but i thought it would be a 405 | |
| 20:41:33 | openstackgerrit | Jay Pipes proposed openstack/nova master: move resources_from_request_spec() to utils https://review.openstack.org/476629 | |
| 20:41:34 | openstackgerrit | Jay Pipes proposed openstack/nova master: Add uuid to scheduler's HostState object https://review.openstack.org/476630 | |
| 20:41:34 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: scheduler uses allocation candidates https://review.openstack.org/476631 | |
| 20:41:35 | openstackgerrit | Jay Pipes proposed openstack/nova master: WIP - placement: claim resources in scheduler https://review.openstack.org/476632 | |
| 20:41:35 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: support GET /allocation_candidates https://review.openstack.org/475448 | |
| 20:41:36 | openstackgerrit | Jay Pipes proposed openstack/nova master: return 400 Bad Request when empty string resources https://review.openstack.org/477019 | |
| 20:41:41 | leakypipes | fried_rice: ^ | |
| 20:41:46 | leakypipes | melwitt: 406 | |
| 20:41:57 | fried_rice | leakypipes Ack. | |
| 20:43:37 | leakypipes | mriedem: https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/microversion.py#L114 | |
| 20:43:46 | leakypipes | 406 HTTP Not Acceptable | |
| 20:45:06 | mriedem | ok | |
| 20:45:19 | mriedem | https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/microversion.py#L187 being the key part | |
| 20:47:12 | leakypipes | well, line 189, but yeah | |
| 20:51:31 | mriedem | not line 188? | |
| 20:51:50 | mriedem | melwitt: some comments in https://review.openstack.org/#/c/469634/ - overall looks ok, some questions about additional testing, but that could probably be follow on too | |
| 20:52:26 | leakypipes | mriedem: :) | |
| 20:53:13 | mriedem | landing and then booking ass over to the other gate | |
| 20:53:15 | mriedem | o/ | |
| 21:26:43 | leakypipes | sean-k-mooney: did you like my "does it now?" comment? :) | |
| 21:30:02 | sean-k-mooney | leakypipes: :) yes yes i did | |
| 21:30:11 | leakypipes | hehe | |
| 21:30:22 | leakypipes | sean-k-mooney: meetings suck. | |
| 21:31:39 | sean-k-mooney | the worst part is i obviosly context switch to something else and then when i came back i finished the unit test and duplicated it to create the socond one and still didnt see it | |
| 21:34:01 | sean-k-mooney | leakypipes: by they way do you want me to open a bug for that or is it fine as is | |
| 21:34:35 | sean-k-mooney | leakypipes: e.g. the patch not the lack of the rest of the comment | |
| 21:34:57 | leakypipes | sean-k-mooney: fine as it is. | |
| 21:35:36 | sean-k-mooney | cool ill respin on monday so | |
| 21:39:09 | leakypipes | sean-k-mooney: no prob! enjoy your weekend :) | |
| 21:39:42 | sean-k-mooney | leakypipes: you too :) | |
| 21:40:19 | sean-k-mooney | leakypipes: wouldnt want to upset sfinucan by working too weekends in a row :P | |
| 21:40:44 | leakypipes | heh | |
| 21:40:47 | leakypipes | or two even. | |
| 21:40:52 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: scheduler uses allocation candidates https://review.openstack.org/476631 | |
| 21:40:53 | openstackgerrit | Jay Pipes proposed openstack/nova master: WIP - placement: claim resources in scheduler https://review.openstack.org/476632 | |
| 21:41:06 | leakypipes | fried_rice: fixed based on your (excellent, thank you!) comments ^ | |
| 21:41:20 | fried_rice | leakypipes Ack | |
| 22:02:24 | jgriffith | superdan ping | |
| 22:02:56 | superdan | jgriffith: I'm like one foot out the door... | |
| 22:03:06 | jgriffith | bummer | |
| 22:03:14 | jgriffith | alright, I'll just catch ya next week | |
| 22:03:20 | superdan | urgent? | |
| 22:03:23 | jgriffith | it's about your cells update to devstack | |
| 22:03:38 | jgriffith | nah.. I can just roll back to an older version of devstack for now and look at it again later | |
| 22:03:40 | jgriffith | no worries | |
| 22:03:43 | jgriffith | have a good week-end | |
| 22:03:47 | superdan | oh snap, did that land? | |
| 22:04:09 | superdan | jgriffith: is it blocking the gate or just something local? | |
| 22:04:11 | jgriffith | Yeah, and now I've got weirdness in my multi-node deployment | |
| 22:04:16 | jgriffith | just local AFAIK | |
| 22:04:33 | jgriffith | last look at gate seems ok, assuming it's made it's way out to everything | |
| 22:04:35 | superdan | okay, well, probably will take a bit to get into it, but I'm totally game for fixing my mess on monday | |
| 22:04:53 | jgriffith | sure.. and it may not be a mess, might just be I need some education :) | |
| 22:04:58 | jgriffith | catch ya later | |
| 22:05:14 | superdan | let's assume mess until proven otherwise :) | |
| 22:05:15 | superdan | thanks, ttyl | |
| 22:25:38 | melwitt | mrhillsman: | |
| 22:25:49 | melwitt | dangit | |
| 22:29:31 | sergmelikyan | folks, I have a quick question on instance system metadata. Is there any way to set this after VM is already spawned? | |
| 22:29:44 | sergmelikyan | I am trying to enable multi-queue on already running VM | |
| 22:30:23 | sergmelikyan | and idea is that I can mark instance with image_hw_vif_multiqueue_enabled and restart the compute node | |
| 22:30:46 | sergmelikyan | but the only way which I found on how to set this is directly through database | |
| 22:30:48 | sergmelikyan | any other way? | |
| 22:47:18 | leakypipes | sergmelikyan: yes, that's the only way to do that on a live VM | |
| 22:47:45 | sergmelikyan | Thank you! | |
| 22:48:01 | leakypipes | no prob! | |
| 23:16:16 | mriedem | in flight movie system is rebooting, running linux, tried to use mysql, not available, so running on sqlite | |
| 23:16:18 | mriedem | this is fun to watch | |
| 23:25:19 | openstackgerrit | Merged openstack/nova master: placement project_id, user_id in PUT /allocations https://review.openstack.org/469634 | |
| 23:38:25 | mriedem | melwitt: how does this not blow up if user_id wasn't a query parameter? https://review.openstack.org/#/c/469635/19/nova/api/openstack/placement/handlers/usage.py@108 | |
| 23:51:24 | openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Document Pike release review priorities https://review.openstack.org/470420 | |
| 23:54:19 | mriedem | melwitt: oh duh, nvm | |
| #openstack-nova - 2017-06-24 | |||
| 00:22:55 | openstackgerrit | Merged openstack/nova master: Plumbing for tagged volume attachment https://review.openstack.org/391941 | |
| 01:14:02 | openstackgerrit | Merged openstack/nova master: Clean up volumes on boot failure https://review.openstack.org/476078 | |
| 01:30:24 | openstackgerrit | Merged openstack/nova master: placement: Add GET /usages to placement API https://review.openstack.org/469635 | |
| 03:22:08 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(4/4) https://review.openstack.org/469800 | |
| 11:31:20 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/477091 | |
| #openstack-nova - 2017-06-25 | |||
| 06:21:37 | openstackgerrit | Moshe Levi proposed openstack/os-vif master: hardware offload support for openvswitch https://review.openstack.org/460278 | |
| 12:05:11 | oanson | Hello, is anyone in? | |
| 12:05:18 | oanson | I am getting the following errors on my gate: http://logs.openstack.org/58/475358/5/check/gate-dragonflow-dsvm-fullstack-ubuntu-xenial/bd53d9e/logs/screen-n-cpu.txt.gz?level=WARNING | |
| 12:05:24 | oanson | Does this look familiar to anyone? | |
| 13:09:44 | mriedem | o/ | |
| 13:31:20 | openstack | Launchpad bug 1700359 in python-novaclient "test_os_service_disable_enable fails with "ERROR (NotFound): Could not find binary nova-scheduler on host"" [Medium,Confirmed] | |
| 13:31:20 | mriedem | i'm surprised this doesn't fai 100% of the time https://bugs.launchpad.net/nova/+bug/1700359 | |
| 13:31:22 | mriedem | *fail | |