| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-06-22 | |||
| 14:27:13 | mriedem | alex_xu: you mean why do the instance tag db api methods call _check_instance_exists_in_project(context, instance_uuid) first? | |
| 14:27:53 | alex_xu | mriedem: no, I mean why we can't remove the mock of '_check_instance_exists_in_project' | |
| 14:28:04 | mriedem | alex_xu: that would be a question for Kevin_Zheng :) | |
| 14:29:20 | alex_xu | mriedem: yea, :) Kevin_Zheng and I talk about that, but we found if we remove that mock, that method raise NotFound. just want check with you is there any mock for the instance db call which we are really missing | |
| 14:31:11 | mriedem | alex_xu: oh, well that is checking to make sure that the instance belongs to the same project that's in the context | |
| 14:31:17 | mriedem | so maybe the test setup is missing something? | |
| 14:32:51 | alex_xu | mriedem: yea, let me check that | |
| 14:32:58 | Kevin_Zheng | but we can get instance_action and instance_tags correctly | |
| 14:33:31 | mriedem | do you have a stacktrace from when it blows up if you remove the mock? | |
| 14:33:43 | mriedem | i do'nt really have context here without actually pulling the change down and testing it out myself | |
| 14:33:54 | Kevin_Zheng | yeah I have | |
| 14:37:22 | mriedem | dansmith: btw, i think this is the extent of what's needed for paging compute nodes by uuid http://paste.openstack.org/show/613404/ | |
| 14:37:24 | Kevin_Zheng | http://paste.openstack.org/show/613405/ | |
| 14:37:24 | mriedem | seems too easy | |
| 14:37:52 | dansmith | mriedem: I'm in meetings for the next two hours | |
| 14:38:05 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Update api-ref to indicate swap param https://review.openstack.org/474517 | |
| 14:38:24 | mriedem | Kevin_Zheng: you're using nosetests? :) | |
| 14:38:44 | Kevin_Zheng | my code is a little bit wrong, the loop is for cell in cells, and first loop is cell0, so it should be not found, but I still cannot get it in cell1 | |
| 14:38:46 | Kevin_Zheng | yes | |
| 14:39:21 | Kevin_Zheng | It still happens using tox | |
| 14:40:19 | Kevin_Zheng | Alex said he used tox | |
| 14:40:33 | mriedem | yeah i don't think that's related, i just didn't know people were still using nose is all | |
| 14:41:13 | openstackgerrit | Alex Szarka proposed openstack/nova master: [WIP]Transform instance-live_migration_abort notification https://review.openstack.org/420453 | |
| 14:41:18 | Kevin_Zheng | :P | |
| 14:41:28 | Kevin_Zheng | https://www.irccloud.com/pastebin/b1GCjanL/ | |
| 14:42:20 | Kevin_Zheng | here, instanceActionList can be correctly get in cell1, but instance can't | |
| 14:42:56 | mriedem | Kevin_Zheng: InstanceActionList.get_by_instance_uuid isn't using _check_instance_exists_in_project in the db api though | |
| 14:43:07 | mriedem | so it has to be some issue with the actual project_id set on the instance in the cell db | |
| 14:43:14 | mriedem | not matching what's in the context passed to the conductor method | |
| 14:43:41 | mriedem | so before you run the code, i'd assert that the test instance.project_id is equal to the context.project_id | |
| 14:44:39 | Kevin_Zheng | hmm | |
| 14:44:56 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use enum value instead of string service name https://review.openstack.org/476538 | |
| 14:46:14 | alex_xu | mriedem: I guess you are right, I saw two varibles in the class 'self.ctxt' and 'self.context'.... | |
| 14:46:42 | alex_xu | Kevin_Zheng: ^ | |
| 14:46:56 | Kevin_Zheng | yeah, I'm also checking | |
| 14:46:56 | mriedem | bingo | |
| 14:47:04 | mriedem | someone owes me a donut | |
| 14:47:16 | mriedem | Kevin_Zheng: will there by donuts in shenzhen? | |
| 14:47:17 | mriedem | :) | |
| 14:47:54 | Kevin_Zheng | maybe, I saw some coffee shop in the campus :) | |
| 14:49:43 | alex_xu | mriedem: I think shenzhen should be have many food, a donuts is to cheap for Kevin_Zheng :) | |
| 14:50:23 | Kevin_Zheng | :P | |
| 14:50:38 | mriedem | alex_xu: what would you suggest? | |
| 14:51:54 | alex_xu | mriedem: I'm not sure, but I'm sure Kevin_Zheng and his team members should have some plan, just remember to follow them :) | |
| 14:52:15 | Kevin_Zheng | the test passed | |
| 14:52:22 | alex_xu | \o/ | |
| 14:53:30 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use enum value instead of string service name https://review.openstack.org/476538 | |
| 14:54:21 | dansmith | mriedem: working through meeting brain, but I think that paste makes sense | |
| 14:54:42 | Kevin_Zheng | mriedem: last time we had some coconut hotpot, tastes good :) | |
| 14:55:30 | mriedem | alex_xu: that's my plan | |
| 14:56:02 | mriedem | although now i'm finding out that dims and i might be in different hotels - the hotel email is all in chinese so it's hard to tell just where i'm actually staying | |
| 14:57:07 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Plumbing for tagged nic attachment https://review.openstack.org/415622 | |
| 14:57:10 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Delete nic metadata when detaching interface https://review.openstack.org/435387 | |
| 14:57:18 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Delete disk metadata when detaching volume https://review.openstack.org/435082 | |
| 14:57:22 | Kevin_Zheng | amber plaza and amber xxx ? | |
| 14:57:28 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Plumbing for tagged volume attachment https://review.openstack.org/391941 | |
| 14:57:29 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: API support for tagged device attachment https://review.openstack.org/376021 | |
| 14:58:08 | alex_xu | mriedem: put the chinese in the google maps, you may get the english name. | |
| 14:58:14 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(3/4) https://review.openstack.org/459593 | |
| 14:58:52 | openstackgerrit | Alex Szarka proposed openstack/nova master: [WIP]Transform instance-live_migration_abort notification https://review.openstack.org/420453 | |
| 15:01:12 | alex_xu | mriedem: it will be great to prepare some notes for hotel's chinese address. the taxi driver doesn't know English totally. that is the way to ensure jaypipes arrive China and back to US safely :) | |
| 15:01:48 | gibi | mriedem: hi! I cannot joint to the nova meeting today. There was no real notification subteam meeting this week as I was alone. | |
| 15:03:13 | mriedem | alex_xu: yeah i printed out the email for the hotel already | |
| 15:03:20 | mriedem | gibi: ok | |
| 15:04:05 | alex_xu | mriedem: cool :) | |
| 15:05:35 | cfriesen_ | when detaching a volume, does nova/libvirt wait for an ack from the guest the way we do for PCI devices? (If so, is it possible for the guest to do something to cause nova to wait forever?) | |
| 15:09:49 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Plumbing for tagged nic attachment https://review.openstack.org/415622 | |
| 15:09:52 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Delete nic metadata when detaching interface https://review.openstack.org/435387 | |
| 15:10:02 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Delete disk metadata when detaching volume https://review.openstack.org/435082 | |
| 15:10:52 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: API support for tagged device attachment https://review.openstack.org/376021 | |
| 15:10:52 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Plumbing for tagged volume attachment https://review.openstack.org/391941 | |
| 15:17:30 | cfriesen_ | mriedem: you've been reviewing the cinder stuff recently...is there a way to tell nova to just rudely detach a cinder volume without worrying about corrupting it (since it's going to be deleted right away, for example) | |
| 15:17:54 | cfriesen_ | mriedem: we're hitting a case where a heat stack delete is hanging because the guest is heavily using a cinder volume and so nova can't detach it | |
| 15:19:05 | mriedem | cfriesen_: not from the nova side | |
| 15:19:13 | mriedem | there is a force detach api in the cinder side i think | |
| 15:19:24 | mriedem | which is just to change the state on the volume from in-use to available so you can delete it | |
| 15:19:28 | mriedem | but, | |
| 15:19:52 | mriedem | you'll likely have issues deleting the instance then because nova will get volume not found - which may be ignored with a warning, not sure | |
| 15:20:50 | cfriesen_ | mriedem: so basically we need to quiesce the guest before detaching a cinder volume? | |
| 15:23:56 | openstackgerrit | Alex Szarka proposed openstack/nova master: Transform instance-live_migration_abort notification https://review.openstack.org/420453 | |
| 15:24:29 | mriedem | cfriesen_: i think the only time we quiece the guest when a volume is attached is when taking a snapshot | |
| 15:25:11 | cfriesen_ | mriedem: I mean that more generally, like having the end user shut things down in the guest. | |
| 15:26:08 | mriedem | oh | |
| 15:26:15 | mriedem | does nova fail or just hang? | |
| 15:26:18 | mriedem | nova/os-brick | |
| 15:27:05 | cfriesen_ | mriedem: nova tries 7 times to detach the device and then gives up | |
| 15:27:54 | cfriesen_ | mriedem: not sure if nova returns an error or if heat ignores it | |
| 15:28:44 | mriedem | oh, well, it's a cast | |
| 15:28:49 | mriedem | so it's all async from a heat pov | |
| 15:29:00 | mriedem | so heat would have to timeout waiting for the volume to be detached | |
| 15:30:40 | cfriesen_ | mriedem: it's kind of too bad we can't do an unclean teardown if we're going to be deleting everything anyway | |
| 15:32:16 | openstackgerrit | Alex Szarka proposed openstack/nova master: Transform instance.resize.error notifications https://review.openstack.org/417882 | |
| 15:39:25 | bauzas | jaypipes: just a rebase for https://review.openstack.org/#/c/469037/ given you already +2d it | |
| 15:39:44 | bauzas | mriedem: dansmith: possibly some others could look at it ^ | |
| 15:40:11 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Fix ChanceScheduler returning a wrong node https://review.openstack.org/466725 | |
| 15:41:08 | jaypipes | bauzas: done | |
| 15:41:30 | bauzas | cools | |
| 15:45:23 | openstackgerrit | Ildiko Vancsa proposed openstack/nova master: WIP/POC Implement new attach Cinder flow https://review.openstack.org/330285 | |
| 15:49:07 | mkucia | Hi! I wonder if someone know what is the story behind `PCI device pools` in nova. Were those introduced for performance reasons? Why not plain list of devices? | |
| 15:51:22 | cfriesen_ | andreykurilin: are you around? | |