Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-06-21
01:54:54 Kevin_Zheng https://github.com/openstack/nova/blob/9ed0d611453aee7a27debd773bdbe146510be0ad/nova/network/neutronv2/api.py#L1274
01:55:28 Kevin_Zheng after compute_utils.refresh_info_cache_for_instance(context, instance) instance.info_cache still have only one record
01:56:22 Kevin_Zheng and if I do instance.info_cache_refresh() again after nw_info = self._build_network_info_model(context, instance, networks,port_ids, admin_client, preexisting_port_ids)
01:56:42 Kevin_Zheng it contains the new record, and everything will be correct
01:57:17 mriedem so it starts from here correct? https://github.com/openstack/nova/blob/9ed0d611453aee7a27debd773bdbe146510be0ad/nova/network/neutronv2/api.py#L881
01:57:34 mriedem ordered_ports and preexisting_port_ids are the same there i think
01:57:46 mriedem when attaching a preexisting port to an instance
01:58:09 mriedem so that's calling this https://github.com/openstack/nova/blob/9ed0d611453aee7a27debd773bdbe146510be0ad/nova/network/base_api.py#L246
01:58:26 mriedem which calls back into the neutronv2 api code https://github.com/openstack/nova/blob/9ed0d611453aee7a27debd773bdbe146510be0ad/nova/network/base_api.py#L249
01:58:37 mriedem https://github.com/openstack/nova/blob/9ed0d611453aee7a27debd773bdbe146510be0ad/nova/network/neutronv2/api.py#L1274
01:58:57 mriedem at that point, compute_utils.refresh_info_cache_for_instance(context, instance) won't have the newly attached port in it
01:59:04 Kevin_Zheng yeah
01:59:11 Kevin_Zheng Thats what I tested
01:59:12 mriedem because _build_network_info_model is going to process it
01:59:20 Kevin_Zheng yeah
01:59:32 mriedem so we call _build_network_info_model with the port_ids and preexisting_port_ids list, which are going to have the same single entry
01:59:52 mriedem and network_info returned from that will have a single vif in it
02:00:18 mriedem which is asserted here https://github.com/openstack/nova/blob/9ed0d611453aee7a27debd773bdbe146510be0ad/nova/compute/manager.py#L5080
02:00:37 mriedem ok, so that explains it
02:00:53 mriedem that also explains a bug that vladikr is trying to fix
02:00:59 mriedem https://review.openstack.org/#/c/468758/
02:02:26 Kevin_Zheng so, should we do instance.info_cache.refresh() again after _build_network_info_model ?
02:02:54 openstackgerrit Ngo Quoc Cuong proposed openstack/nova master: Remove translation of log messages https://review.openstack.org/466957
02:02:55 openstackgerrit Li Yingjun proposed openstack/nova master: Fix duplicate Neutron ports on instance reschedule https://review.openstack.org/467509
02:06:01 mriedem Kevin_Zheng: that won't do it i don't think
02:06:11 mriedem the info cache is updated on the instance here https://github.com/openstack/nova/blob/9ed0d611453aee7a27debd773bdbe146510be0ad/nova/network/base_api.py#L255
02:06:48 Kevin_Zheng it seems it only saved info_cache to DB
02:07:05 mriedem yes this right? https://github.com/openstack/nova/blob/9ed0d611453aee7a27debd773bdbe146510be0ad/nova/network/base_api.py#L50
02:07:14 Kevin_Zheng the instance obj in memory still didn't contain new record
02:07:37 mriedem hmm, why don't we just set instance.info_cache = ic there?
02:08:03 Kevin_Zheng yeah, that will also work
02:08:34 artom mriedem, re "care about supporting attaching tagged volumes to a shelved offloaded instance" - I think it's less bad in the create BuildAbort case because the feedback the user gets is more immediate
02:09:27 artom Whereas with shelved offloaded there could be a delay between attaching a tagged volume and unshelving the instance
02:09:31 artom I dunno
02:09:47 mriedem Kevin_Zheng: can you test that out and see if it fixes the bug? because that would be much easier and convenient since we'd have the object we need right there
02:09:50 artom If we can fail fast with cellsv1 we can fail fast with shelved/offloaded
02:10:05 Kevin_Zheng yeah, I will do it now
02:10:27 mriedem artom: the feedback the user gets with server build isn't all that immediate, unless you mean it immediately goes to ERROR state :)
02:10:31 mriedem and with unshelve it doesn't
02:11:04 mriedem Kevin_Zheng: plus that trace of steps is probably needed in the commit message for people to understand how this is happening :)
02:11:20 mriedem i've looked at this at least 4 times and just now got it together in my head
02:11:35 Kevin_Zheng OK, I will try to add one
02:16:19 openstackgerrit Michael Still proposed openstack/nova master: Move the last_bytes util method to the libvirt driver. https://review.openstack.org/472228
02:16:19 openstackgerrit Michael Still proposed openstack/nova master: Avoid chowning console logs in libvirt https://review.openstack.org/472229
02:16:20 openstackgerrit Michael Still proposed openstack/nova master: Move libvirt usages of chown to privsep. https://review.openstack.org/471972
02:16:20 openstackgerrit Michael Still proposed openstack/nova master: First attempt at adding a privsep user to nova itself. https://review.openstack.org/459166
02:22:02 artom mriedem, yeah, I meant immediate ERROR state
02:22:27 mriedem artom: ok, well i put this in the api meeting agenda for tomorrow morning if you can make it
02:22:36 mriedem i might not be able to make it given morning parental duties
02:23:05 artom mriedem, I'm temporarily on GMT+3, so it's at midnight my time
02:23:05 mriedem artom: are you in toronto btw?
02:23:09 mriedem oh
02:23:10 mriedem ew
02:23:10 artom On Friday morning
02:23:22 artom Well, Thursday night, I guess
02:23:30 mriedem ok well nevermind
02:23:35 artom I could make it, I think
02:24:11 mriedem alright, well i'm going to call it a day
02:24:16 mriedem i'll circle back on that one tomorrow
02:35:48 artom No wait, API meeting
02:35:52 artom Yeah, I can totally make that
02:35:59 artom (I know Matt's gone)
03:38:36 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Don't delete neutron port when attach failed https://review.openstack.org/403568
05:58:24 openstackgerrit Hironori Shiina proposed openstack/nova master: Ironic: Check a last error of power action https://review.openstack.org/470754
06:03:19 openstackgerrit Ngo Quoc Cuong proposed openstack/nova master: Remove translation of log messages https://review.openstack.org/466957
06:32:14 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Don't delete neutron port when attach failed https://review.openstack.org/403568
06:32:34 openstackgerrit Merged openstack/nova master: XenAPI: Create linux bridge in dest host during live migration https://review.openstack.org/462017
06:43:59 ratailor jaypipes, you aroudn ?
06:44:12 ratailor jaypipes, *around
07:07:05 hardrush hello all
07:07:32 hardrush i have some issue about nova, i fail launching instances with flavors have root disk more than 45 GB
07:07:53 hardrush It errors: no valid hosts found, i have enough resource and i am suspicious about quotas
07:38:38 openstackgerrit Balazs Gibizer proposed openstack/nova master: Transform rescue/unrescue instance notifications https://review.openstack.org/385644
08:26:45 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Add X-Openstack-Request-Id description https://review.openstack.org/474847
08:26:52 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Add X-Openstack-Request-Id description https://review.openstack.org/474847
09:19:25 openstackgerrit Silvan Kaiser proposed openstack/nova master: Removes getfattr from Quobyte Nova driver https://review.openstack.org/428646
09:23:24 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Don't delete neutron port when attach failed https://review.openstack.org/403568
09:31:50 openstackgerrit Silvan Kaiser proposed openstack/nova master: Switch Nova Quobyte volume driver to mount via systemd-run https://review.openstack.org/432344
09:31:50 openstackgerrit Silvan Kaiser proposed openstack/nova master: Removes potentially bad exit value from accepted list in Quobyte volume driver https://review.openstack.org/453537
10:06:21 openstackgerrit Alex Szarka proposed openstack/nova master: [WIP]Transform instance-live_migration_abort notification https://review.openstack.org/420453
10:13:53 openstackgerrit yuanyue proposed openstack/nova master: Fix the bug on boot failure https://review.openstack.org/476078
10:19:24 openstackgerrit yuanyue proposed openstack/nova master: Fix the bug on boot failure https://review.openstack.org/476078
10:27:42 openstackgerrit yuanyue proposed openstack/nova master: Fix the bug on boot failure https://review.openstack.org/476078
10:37:58 openstackgerrit Pooja Jadhav proposed openstack/nova master: Deny volume swapping with non-bootable volume https://review.openstack.org/407346
10:51:54 openstackgerrit Alex Szarka proposed openstack/nova master: Transform instance.resize.error notifications https://review.openstack.org/417882
10:52:23 openstackgerrit yuanyue proposed openstack/nova master: Fix the bug on boot failure https://review.openstack.org/476078
11:16:05 markus_z pkoniszewski: any chance you could take https://review.openstack.org/#/c/347471/ on your backlog? (the devstack and tempest parts are merged)
11:18:57 pkoniszewski markus_z: hey, I'm still here only to answer LM questions if any, ufortunately I was moved to another project
11:19:18 pkoniszewski markus_z: probably won't have time for upstream contribution in the near future
11:19:30 markus_z pkoniszewski: Oh, sorry, I wasn't aware of that.
11:22:18 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Update the placement deployment instructions https://review.openstack.org/469048
11:33:46 openstackgerrit Hironori Shiina proposed openstack/nova master: Ironic: Support boot from Cinder volume https://review.openstack.org/215385
11:36:10 openstackgerrit Hironori Shiina proposed openstack/nova master: Ironic: Get IP address for volume connector https://review.openstack.org/468353
11:39:19 kosal openstack-nova, I have query .... What is the maximum number of host aggregate can be created in Availability Zone ?
11:39:56 openstackgerrit Maciej Kucia proposed openstack/nova master: Add JSON schema validation to PCI whitelist https://review.openstack.org/476098
11:45:04 openstackgerrit Maciej Kucia proposed openstack/nova master: Add JSON schema validation to PCI whitelist https://review.openstack.org/476098
11:48:38 openstackgerrit Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766
12:21:08 ebbex Other than max_concurrent_builds, what can I tune to speed up the scheduling/building of instances? (Stress-testing systems, by creating 3-400 instances at a time.)
12:45:17 alex_xu nova api meeting is 15 mins at #openstack-meeting-4
12:45:36 alex_xu s/is 15 mins/is in 15 mins/

Earlier   Later